ClientExceptionsTest::testGuzzleException() - Code Metrics - Inspection of "Improve coverage" - scaytrase/json-rpc-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#17)

by Pavel

created 2017-06-14 08:25 UTC

ClientExceptionsTest::testGuzzleException() A

↳ Parent: ClientExceptionsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	7
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

namespace ScayTrase\Api\JsonRpc\Tests;

use GuzzleHttp\Exception\ServerException;
use GuzzleHttp\Psr7\Request;
use GuzzleHttp\Psr7\Uri;
use ScayTrase\Api\JsonRpc\JsonRpcClient;
use ScayTrase\Api\Rpc\Exception\RemoteCallFailedException;

class ClientExceptionsTest extends AbstractJsonRpcClientTest
{
    /**
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage Request should be either array or single RpcRequestInterface instance
     */
    public function testInvalidArrayArgumentException()
    {
        $client = new JsonRpcClient($this->getClient(), new Uri());
        $client->invoke('test');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @expectedException \ScayTrase\Api\Rpc\Exception\RemoteCallFailedException
     * @expectedExceptionMessage Error completing request
     */
    public function testGuzzleException()
    {
        $client = new JsonRpcClient($this->getClient(), new Uri());
        $exception = ServerException::create(new Request('GET', new Uri()));
        $request = $this->createRequestForSingleInvocation('test', [], $exception);
        $client->invoke($request)->getResponse($request);
    }
}


1			<?php
2
3			namespace ScayTrase\Api\JsonRpc\Tests;
4
5			use GuzzleHttp\Exception\ServerException;
6			use GuzzleHttp\Psr7\Request;
7			use GuzzleHttp\Psr7\Uri;
8			use ScayTrase\Api\JsonRpc\JsonRpcClient;
9			use ScayTrase\Api\Rpc\Exception\RemoteCallFailedException;
10
11			class ClientExceptionsTest extends AbstractJsonRpcClientTest
12			{
13			/**
14			* @expectedException \InvalidArgumentException
15			* @expectedExceptionMessage Request should be either array or single RpcRequestInterface instance
16			*/
17			public function testInvalidArrayArgumentException()
18			{
19			$client = new JsonRpcClient($this->getClient(), new Uri());
20			$client->invoke('test');
			0 ignored issues – show Documentation introduced 2017-06-14 08:30 UTC by Report Bug Copy Issue Report `'test'` is of type `string`, but the function expects a `object<ScayTrase\Api\Rpc...c\RpcRequestInterface>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
21			}
22
23			/**
24			* @expectedException \ScayTrase\Api\Rpc\Exception\RemoteCallFailedException
25			* @expectedExceptionMessage Error completing request
26			*/
27			public function testGuzzleException()
28			{
29			$client = new JsonRpcClient($this->getClient(), new Uri());
30			$exception = ServerException::create(new Request('GET', new Uri()));
31			$request = $this->createRequestForSingleInvocation('test', [], $exception);
32			$client->invoke($request)->getResponse($request);
33			}
34			}
35

scaytrase / json-rpc-client

Pull Request — master (#17)

ClientExceptionsTest::testGuzzleException() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like