Conditions | 3 |
Total Lines | 92 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | # -*- coding: utf-8 -*- |
||
83 | def test_get_resources(self): |
||
84 | |||
85 | def compare_results(permissions, service=None, name=None, |
||
86 | resource=None, result=None, include_locked=False): |
||
87 | """ Resets the auth API endpoint /tokens/:id/permissions, call |
||
88 | get_resources and compare results with what is expected. |
||
89 | """ |
||
90 | if result is None: |
||
91 | result = [] |
||
92 | |||
93 | self.make_fake_perms(permissions) |
||
94 | resources = self.api.get_resources( |
||
95 | service=service, name=name, resource=resource, |
||
96 | include_locked=include_locked |
||
97 | ) |
||
98 | # XOR on two sets returns the difference between them |
||
99 | # Used because we don't know in which order api.get_resources |
||
100 | # returns the resources. |
||
101 | self.assertFalse(set(resources) ^ set(result)) |
||
102 | |||
103 | # Check the API has been requested with |
||
104 | # ?include_locked set to `include_locked` |
||
105 | self.assertEqual( |
||
106 | httpretty.last_request().querystring.get('include_locked'), |
||
107 | [str(include_locked)] |
||
108 | ) |
||
109 | |||
110 | # No permission, no resource |
||
111 | compare_results({}, result=[]) |
||
112 | |||
113 | # Simple permissions |
||
114 | compare_results(self.fake_permissions, |
||
115 | service='compute', name='can_boot', |
||
116 | result=['server1', 'server2']) |
||
117 | |||
118 | compare_results(self.fake_permissions, |
||
119 | service='compute', name='can_boot', |
||
120 | result=['server1', 'server2']) |
||
121 | |||
122 | compare_results(self.fake_permissions, |
||
123 | service='compute', name='can_boot', resource='server2', |
||
124 | result=['server2']) |
||
125 | |||
126 | compare_results(self.fake_permissions, |
||
127 | service='compute', name='can_delete', |
||
128 | result=['server1']) |
||
129 | |||
130 | compare_results( |
||
131 | self.fake_permissions, |
||
132 | service='compute', name='can_delete', resource='server1', |
||
133 | result=['server1'] |
||
134 | ) |
||
135 | |||
136 | compare_results(self.fake_permissions, |
||
137 | service='compute', name='can_write', |
||
138 | result=[]) |
||
139 | |||
140 | # Nested permissions |
||
141 | compare_results(self.fake_permissions, |
||
142 | service='account', name='token:read', |
||
143 | result=['token1', 'token2', 'token3']) |
||
144 | |||
145 | compare_results( |
||
146 | self.fake_permissions, |
||
147 | service='account', name='token:read', resource='invalid', |
||
148 | result=[] |
||
149 | ) |
||
150 | |||
151 | compare_results( |
||
152 | self.fake_permissions, |
||
153 | service='account', name='token:read', resource='token2', |
||
154 | result=['token2'] |
||
155 | ) |
||
156 | |||
157 | compare_results( |
||
158 | self.fake_permissions, |
||
159 | service='account', name='token:write', |
||
160 | result=['token1', 'token2', 'token4'] |
||
161 | ) |
||
162 | |||
163 | compare_results( |
||
164 | self.fake_permissions, |
||
165 | service='account', name='token:admin', |
||
166 | result=['token1', 'token2'] |
||
167 | ) |
||
168 | |||
169 | # Include lock set to True |
||
170 | compare_results( |
||
171 | self.fake_permissions, |
||
172 | service='account', name='token:admin', |
||
173 | result=['token1', 'token2'], |
||
174 | include_locked=True |
||
175 | ) |
||
275 |