Saxulum\RestCrud\Request\ContentToFormDataConverter

Complexity

Total Complexity

9

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	17	4
B	convert()	0	27	3
A	getConverter()	0	8	2

<?php

namespace Saxulum\RestCrud\Request;

use Saxulum\RestCrud\Request\Converter\ConverterInterface;
use Symfony\Component\HttpFoundation\Request;

class ContentToFormDataConverter
{
    /**
     * @var ConverterInterface[]
     */
    protected $converters = [];

    /**
     * @param ConverterInterface[] $converters
     */
    public function __construct(array $converters)
    {
        foreach ($converters as $i => $converter) {
            if (!$converter instanceof ConverterInterface) {
                $type = is_object($converter) ? get_class($converter) : gettype($converter);
                throw new \InvalidArgumentException(
                    sprintf(
                        'Only objects implementing "%s" are supported! "%s" given on index %s',
                        'Saxulum\RestCrud\Request\Converter\ConverterInterface',
                        $type,
                        $i
                    )
                );
            }
            $this->converters[$converter->contentType()] = $converter;
        }
    }

    /**
     * @param Request $request
     *
     * @return Request
     */
    public function convert(Request &$request)
    {
        $contentType = $request->headers->get('Content-Type');
        if (false !== $pos = strpos($contentType, ';')) {
            $contentType = substr($contentType, 0, $pos);
        }

        if (in_array($contentType, array('application/x-www-form-urlencoded', 'multipart/form-data'), true)) {
            return $request;
        }

        $formData = $this->getConverter($contentType)->convert($request->getContent());

It seems like $request->getContent() targeting Symfony\Component\HttpFoundation\Request::getContent() can also be of type resource; however, Saxulum\RestCrud\Request\Converter\ConverterInterface::convert() does only seem to accept string, maybe add an additional type check?

It seems like $contentType defined by $request->headers->get('Content-Type') on line 43 can also be of type array<integer,string>; however, Saxulum\RestCrud\Request\ContentToFormDataConverter::getConverter() does only seem to accept string, maybe add an additional type check?

        $request = new Request(
            $request->query->all(),
            $formData,
            $request->attributes->all(),
            $request->cookies->all(),
            $request->files->all(),
            array_replace($request->server->all(), array(
                'CONTENT_TYPE' => 'application/x-www-form-urlencoded',
            )),
            http_build_query($formData)
        );

        return $request;
    }

    /**
     * @param string $contentType
     *
     * @return ConverterInterface
     *
     * @throws \Exception
     */
    protected function getConverter($contentType)
    {
        if (!isset($this->converters[$contentType])) {
            throw new \Exception(sprintf('There is no converter for content type: "%s', $contentType));
        }

        return $this->converters[$contentType];
    }
}