Request::with() - Code Metrics - Inspection of "add a simple stream" - saxulum/saxulum-http-message - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d1aac8...7341fe )

by Dominik

created 2016-09-10 19:00 UTC

Request::with() A

↳ Parent: Request

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	10

Duplication

Lines	15
Ratio	100 %

Importance

Changes

Metric	Value
dl	15
loc	15
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	1

<?php

namespace Saxulum\HttpMessage;

use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\StreamInterface;
use Psr\Http\Message\UriInterface;

final class Request extends AbstractMessage implements RequestInterface
{
    /**
     * @var string|null
     */
    private $requestTarget;

    /**
     * @var string|null
     */
    private $method;

    const METHOD_OPTIONS = 'OPTIONS';
    const METHOD_GET = 'GET';
    const METHOD_HEAD = 'HEAD';
    const METHOD_POST = 'POST';
    const METHOD_PUT = 'PUT';
    const METHOD_PATCH = 'PATCH';
    const METHOD_DELETE = 'DELETE';

    /**
     * @var UriInterface
     */
    private $uri;

    /**
     * @var RequestInterface|null
     */
    protected $__previous;

    /**
     * @param UriInterface          $uri
     * @param string                $method
     * @param array                 $headers
     * @param StreamInterface|null  $body
     * @param string                $protocolVersion
     * @param string|null           $requestTarget
     * @param RequestInterface|null $__previous
     */
    public function __construct(
        UriInterface $uri,
        string $method = self::METHOD_GET,
        array $headers = [],
        StreamInterface $body = null,
        string $protocolVersion = self::PROTOCOL_VERSION_1_1,
        string $requestTarget = null,
        RequestInterface $__previous = null
    ) {
        $this->uri = $uri;
        $this->method = $method;
        $this->headers = $headers;
        $this->body = $body;
        $this->protocolVersion = $protocolVersion;
        $this->requestTarget = $requestTarget;
        $this->__previous = $__previous;
    }

    /**
     * {@inheritdoc}
     */
    public function getRequestTarget()
    {
        if (null !== $this->requestTarget) {
            return $this->requestTarget;
        }

        if ('' === $requestTarget = $this->uri->getPath()) {
            $requestTarget = '/';
        }

        if ('' !== $query = $this->uri->getQuery()) {
            $requestTarget .= '?'.$query;
        }

        return $requestTarget;
    }

    /**
     * {@inheritdoc}
     */
    public function withRequestTarget($requestTarget)
    {
        return $this->with(['requestTarget' => $requestTarget]);
    }

    /**
     * {@inheritdoc}
     */
    public function getMethod()
    {
        return null !== $this->method ? (string) $this->method : self::METHOD_GET;
    }

    /**
     * {@inheritdoc}
     */
    public function withMethod($method)
    {
        return $this->with(['method' => $method]);
    }

    /**
     * {@inheritdoc}
     */
    public function getUri(): UriInterface
    {
        return $this->uri;
    }

    public function withUri(UriInterface $uri, $preserveHost = false)
    {
        return $this->with(['uri' => $uri]);
    }

    /**
     * @param array $parameters
     *
     * @return Request
     */
    protected function with(array $parameters): self

    {
        $defaults = [
            'uri' => $this->uri,
            'method' => $this->method,
            'headers' => $this->headers,
            'body' => $this->body,
            'protocolVersion' => $this->protocolVersion,
            'requestTarget' => $this->requestTarget,
        ];

        $arguments = array_values(array_replace($defaults, $parameters, ['__previous' => $this]));

        return new static(...$arguments);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1		<?php
2
3		namespace Saxulum\HttpMessage;
4
5		use Psr\Http\Message\RequestInterface;
6		use Psr\Http\Message\StreamInterface;
7		use Psr\Http\Message\UriInterface;
8
9		final class Request extends AbstractMessage implements RequestInterface
10		{
11		/**
12		* @var string\|null
13		*/
14		private $requestTarget;
15
16		/**
17		* @var string\|null
18		*/
19		private $method;
20
21		const METHOD_OPTIONS = 'OPTIONS';
22		const METHOD_GET = 'GET';
23		const METHOD_HEAD = 'HEAD';
24		const METHOD_POST = 'POST';
25		const METHOD_PUT = 'PUT';
26		const METHOD_PATCH = 'PATCH';
27		const METHOD_DELETE = 'DELETE';
28
29		/**
30		* @var UriInterface
31		*/
32		private $uri;
33
34		/**
35		* @var RequestInterface\|null
36		*/
37		protected $__previous;
38
39		/**
40		* @param UriInterface $uri
41		* @param string $method
42		* @param array $headers
43		* @param StreamInterface\|null $body
44		* @param string $protocolVersion
45		* @param string\|null $requestTarget
46		* @param RequestInterface\|null $__previous
47		*/
48		public function __construct(
49		UriInterface $uri,
50		string $method = self::METHOD_GET,
51		array $headers = [],
52		StreamInterface $body = null,
53		string $protocolVersion = self::PROTOCOL_VERSION_1_1,
54		string $requestTarget = null,
55		RequestInterface $__previous = null
56		) {
57		$this->uri = $uri;
58		$this->method = $method;
59		$this->headers = $headers;
60		$this->body = $body;
61		$this->protocolVersion = $protocolVersion;
62		$this->requestTarget = $requestTarget;
63		$this->__previous = $__previous;
64		}
65
66		/**
67		* {@inheritdoc}
68		*/
69		public function getRequestTarget()
70		{
71		if (null !== $this->requestTarget) {
72		return $this->requestTarget;
73		}
74
75		if ('' === $requestTarget = $this->uri->getPath()) {
76		$requestTarget = '/';
77		}
78
79		if ('' !== $query = $this->uri->getQuery()) {
80		$requestTarget .= '?'.$query;
81		}
82
83		return $requestTarget;
84		}
85
86		/**
87		* {@inheritdoc}
88		*/
89		public function withRequestTarget($requestTarget)
90		{
91		return $this->with(['requestTarget' => $requestTarget]);
92		}
93
94		/**
95		* {@inheritdoc}
96		*/
97		public function getMethod()
98		{
99		return null !== $this->method ? (string) $this->method : self::METHOD_GET;
100		}
101
102		/**
103		* {@inheritdoc}
104		*/
105		public function withMethod($method)
106		{
107		return $this->with(['method' => $method]);
108		}
109
110		/**
111		* {@inheritdoc}
112		*/
113		public function getUri(): UriInterface
114		{
115		return $this->uri;
116		}
117
118		public function withUri(UriInterface $uri, $preserveHost = false)
119		{
120		return $this->with(['uri' => $uri]);
121		}
122
123		/**
124		* @param array $parameters
125		*
126		* @return Request
127		*/
128	View Code Duplication	protected function with(array $parameters): self
		0 ignored issues – show Duplication introduced 2016-09-10 19:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
129		{
130		$defaults = [
131		'uri' => $this->uri,
132		'method' => $this->method,
133		'headers' => $this->headers,
134		'body' => $this->body,
135		'protocolVersion' => $this->protocolVersion,
136		'requestTarget' => $this->requestTarget,
137		];
138
139		$arguments = array_values(array_replace($defaults, $parameters, ['__previous' => $this]));
140
141		return new static(...$arguments);
		0 ignored issues – show Documentation introduced 2016-09-10 19:03 UTC by Report Bug Copy Issue Report `$arguments` is of type `array<integer,?>`, but the function expects a `object<Psr\Http\Message\UriInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
142		}
143		}
144

saxulum / saxulum-http-message

Push — master ( d1aac8...7341fe )

Request::with() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like