Uri - Code Metrics - Inspection of "reduce duplication" - saxulum/saxulum-http-message - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (59f97a)

by Dominik

created 2016-09-10 07:42 UTC

Uri B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	383
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	43
lcom	1
cbo	0
dl	0
loc	383
rs	8.3157
c	0
b	0
f	0

24 Methods

Rating	Name	Size	Complexity
A	__construct()	21	1
A	create()	19	2
A	getScheme()	4	1
A	getAuthority()	20	4
A	getUserInfo()	12	3
A	getHost()	4	1
A	getPort()	12	3
A	getPath()	4	1
A	getQuery()	4	1
A	getFragment()	4	1
A	getPrevious()	4	1
A	withScheme()	4	1
A	withUserInfo()	4	1
A	withHost()	4	1
A	withPort()	4	1
A	withPath()	4	1
A	withQuery()	4	1
A	withFragment()	4	1
B	__toString()	26	6
A	getPortForScheme()	10	2
A	getPathForUri()	8	2
A	getPathForUriWithAuthority()	4	2
A	getPathForUriWithoutAuthority()	11	4
A	with()	18	1

How to fix Complexity

<?php

namespace Saxulum\HttpMessage;

use Psr\Http\Message\UriInterface;

final class Uri implements UriInterface
{
    /**
     * @var string|null
     */
    private $scheme;

    /**
     * @var string|null
     */
    private $host;

    /**
     * @var int|null
     */
    private $port;

    const PORT_HTTP = 80;
    const PORT_HTTPS = 443;

    /**
     * @var string|null
     */
    private $user;

    /**
     * @var string|null
     */
    private $password;

    /**
     * @var string|null
     */
    private $path;

    /**
     * @var string|null
     */
    private $query;

    /**
     * @var string|null
     */
    private $fragment;

    /**
     * @var UriInterface|null
     */
    private $previous;

    /**
     * @param string|null       $scheme
     * @param string|null       $host
     * @param int|null          $port
     * @param string|null       $user
     * @param string|null       $password
     * @param string|null       $path
     * @param string|null       $query
     * @param string|null       $fragment
     * @param UriInterface|null $previous
     */
    public function __construct(
        string $scheme = null,
        string $host = null,
        int $port = null,
        string $user = null,
        string $password = null,
        string $path = null,
        string $query = null,
        string $fragment = null,
        UriInterface $previous = null
    ) {
        $this->scheme = $scheme;
        $this->host = $host;
        $this->port = $port;
        $this->user = $user;
        $this->password = $password;
        $this->path = $path;
        $this->query = $query;
        $this->fragment = $fragment;
        $this->previous = $previous;
    }

    /**
     * @param string            $uri
     * @param UriInterface|null $previous
     *
     * @return UriInterface
     *
     * @throws \InvalidArgumentException
     */
    public static function create(string $uri, UriInterface $previous = null)
    {
        $uriParts = parse_url($uri);
        if (false === $uriParts) {
            throw new \InvalidArgumentException(sprintf('Invalid uri format for parse_url: %s', $uri));
        }

        return new self(
            $uriParts['scheme'] ?? null,
            $uriParts['host'] ?? null,
            $uriParts['port'] ?? null,
            $uriParts['user'] ?? null,
            $uriParts['pass'] ?? null,
            $uriParts['path'] ?? null,
            $uriParts['query'] ?? null,
            $uriParts['fragment'] ?? null,
            $previous
        );
    }

    /**
     * {@inheritdoc}
     */
    public function getScheme(): string
    {
        return strtolower((string) $this->scheme);
    }

    /**
     * {@inheritdoc}
     */
    public function getAuthority(): string
    {
        if ('' === $host = $this->getHost()) {
            return '';
        }

        $authority = '';

        if ('' !== $userInfo = $this->getUserInfo()) {
            $authority .= $userInfo.'@';
        }

        $authority .= $host;

        if (null !== $port = $this->getPort()) {
            $authority .= ':'.$port;
        }

        return $authority;
    }

    /**
     * {@inheritdoc}
     */
    public function getUserInfo(): string
    {
        if (null === $this->user) {
            return '';
        }

        if (null === $this->password) {
            return $this->user;
        }

        return $this->user.':'.$this->password;
    }

    /**
     * {@inheritdoc}
     */
    public function getHost(): string
    {
        return strtolower((string) $this->host);
    }

    /**
     * {@inheritdoc}
     */
    public function getPort()
    {
        if (null === $this->port) {
            return null;
        }

        if ($this->port === $this->getPortForScheme($this->getScheme())) {
            return null;
        }

        return $this->port;
    }

    /**
     * {@inheritdoc}
     */
    public function getPath(): string
    {
        return (string) $this->path;
    }

    /**
     * {@inheritdoc}
     */
    public function getQuery(): string
    {
        return (string) $this->query;
    }

    /**
     * {@inheritdoc}
     */
    public function getFragment(): string
    {
        return (string) $this->fragment;
    }

    /**
     * @return UriInterface|null
     */
    public function getPrevious()
    {
        return $this->previous;
    }

    /**
     * {@inheritdoc}
     */
    public function withScheme($scheme): self
    {
        return $this->with(['scheme' => $scheme]);
    }

    /**
     * {@inheritdoc}
     */
    public function withUserInfo($user, $password = null): self
    {
        return $this->with(['user' => $user, 'password' => $password]);
    }

    /**
     * {@inheritdoc}
     */
    public function withHost($host): self
    {
        return $this->with(['host' => $host]);
    }

    /**
     * {@inheritdoc}
     */
    public function withPort($port): self
    {
        return $this->with(['port' => $port]);
    }

    /**
     * {@inheritdoc}
     */
    public function withPath($path): self
    {
        return $this->with(['path' => $path]);
    }

    /**
     * {@inheritdoc}
     */
    public function withQuery($query): self
    {
        return $this->with(['query' => $query]);
    }

    /**
     * {@inheritdoc}
     */
    public function withFragment($fragment): self
    {
        return $this->with(['fragment' => $fragment]);
    }

    /**
     * {@inheritdoc}
     */
    public function __toString(): string
    {
        $uri = '';

        if ('' !== $scheme = $this->getScheme()) {
            $uri .= $scheme.':';
        }

        if ('' !== $authority = $this->getAuthority()) {
            $uri .= '//'.$authority;
        }

        if ('' !== $path = $this->getPath()) {
            $uri .= $this->getPathForUri($authority, $path);
        }

        if ('' !== $query = $this->getQuery()) {
            $uri .= '?'.$query;
        }

        if ('' !== $fragment = $this->getFragment()) {
            $uri .= '#'.$fragment;
        }

        return $uri;
    }

    /**
     * @param string $scheme
     *
     * @return int|null
     */
    private function getPortForScheme(string $scheme)
    {
        $constantName = 'PORT_'.strtoupper($scheme);
        $reflection = new \ReflectionObject($this);
        if ($reflection->hasConstant($constantName)) {
            return $reflection->getConstant($constantName);
        }

        return null;
    }

    /**
     * @param string $authority
     * @param string $path
     *
     * @return string
     */
    private function getPathForUri(string $authority, string $path): string
    {
        if ('' !== $authority) {
            return $this->getPathForUriWithAuthority($path);
        }

        return $this->getPathForUriWithoutAuthority($path);
    }

    /**
     * @param string $path
     *
     * @return string
     */
    private function getPathForUriWithAuthority(string $path)
    {
        return '/' === $path[0] ? $path : '/'.$path;
    }

    /**
     * @param string $path
     *
     * @return string
     */
    private function getPathForUriWithoutAuthority(string $path)
    {
        $pathLength = strlen($path);
        for ($i = 0; $i < $pathLength; ++$i) {
            if ('/' !== $path[$i]) {
                break;
            }
        }

        return 0 === $i ? $path : '/'.substr($path, $i);
    }

    /**
     * @param array $arguments
     *
     * @return Uri
     */
    public function with(array $arguments): self
    {
        $defaultArguments = [
            'scheme' => $this->scheme,
            'host' => $this->host,
            'port' => $this->port,
            'user' => $this->user,
            'password' => $this->password,
            'path' => $this->path,
            'query' => $this->query,
            'fragment' => $this->fragment,
            'previous' => $this,
        ];

        $arguments = array_replace($defaultArguments, $arguments);

        return new self(...array_merge(array_values($arguments), [$this]));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace Saxulum\HttpMessage;
4
5			use Psr\Http\Message\UriInterface;
6
7			final class Uri implements UriInterface
8			{
9			/**
10			* @var string\|null
11			*/
12			private $scheme;
13
14			/**
15			* @var string\|null
16			*/
17			private $host;
18
19			/**
20			* @var int\|null
21			*/
22			private $port;
23
24			const PORT_HTTP = 80;
25			const PORT_HTTPS = 443;
26
27			/**
28			* @var string\|null
29			*/
30			private $user;
31
32			/**
33			* @var string\|null
34			*/
35			private $password;
36
37			/**
38			* @var string\|null
39			*/
40			private $path;
41
42			/**
43			* @var string\|null
44			*/
45			private $query;
46
47			/**
48			* @var string\|null
49			*/
50			private $fragment;
51
52			/**
53			* @var UriInterface\|null
54			*/
55			private $previous;
56
57			/**
58			* @param string\|null $scheme
59			* @param string\|null $host
60			* @param int\|null $port
61			* @param string\|null $user
62			* @param string\|null $password
63			* @param string\|null $path
64			* @param string\|null $query
65			* @param string\|null $fragment
66			* @param UriInterface\|null $previous
67			*/
68			public function __construct(
69			string $scheme = null,
70			string $host = null,
71			int $port = null,
72			string $user = null,
73			string $password = null,
74			string $path = null,
75			string $query = null,
76			string $fragment = null,
77			UriInterface $previous = null
78			) {
79			$this->scheme = $scheme;
80			$this->host = $host;
81			$this->port = $port;
82			$this->user = $user;
83			$this->password = $password;
84			$this->path = $path;
85			$this->query = $query;
86			$this->fragment = $fragment;
87			$this->previous = $previous;
88			}
89
90			/**
91			* @param string $uri
92			* @param UriInterface\|null $previous
93			*
94			* @return UriInterface
95			*
96			* @throws \InvalidArgumentException
97			*/
98			public static function create(string $uri, UriInterface $previous = null)
99			{
100			$uriParts = parse_url($uri);
101			if (false === $uriParts) {
102			throw new \InvalidArgumentException(sprintf('Invalid uri format for parse_url: %s', $uri));
103			}
104
105			return new self(
106			$uriParts['scheme'] ?? null,
107			$uriParts['host'] ?? null,
108			$uriParts['port'] ?? null,
109			$uriParts['user'] ?? null,
110			$uriParts['pass'] ?? null,
111			$uriParts['path'] ?? null,
112			$uriParts['query'] ?? null,
113			$uriParts['fragment'] ?? null,
114			$previous
115			);
116			}
117
118			/**
119			* {@inheritdoc}
120			*/
121			public function getScheme(): string
122			{
123			return strtolower((string) $this->scheme);
124			}
125
126			/**
127			* {@inheritdoc}
128			*/
129			public function getAuthority(): string
130			{
131			if ('' === $host = $this->getHost()) {
132			return '';
133			}
134
135			$authority = '';
136
137			if ('' !== $userInfo = $this->getUserInfo()) {
138			$authority .= $userInfo.'@';
139			}
140
141			$authority .= $host;
142
143			if (null !== $port = $this->getPort()) {
144			$authority .= ':'.$port;
145			}
146
147			return $authority;
148			}
149
150			/**
151			* {@inheritdoc}
152			*/
153			public function getUserInfo(): string
154			{
155			if (null === $this->user) {
156			return '';
157			}
158
159			if (null === $this->password) {
160			return $this->user;
161			}
162
163			return $this->user.':'.$this->password;
164			}
165
166			/**
167			* {@inheritdoc}
168			*/
169			public function getHost(): string
170			{
171			return strtolower((string) $this->host);
172			}
173
174			/**
175			* {@inheritdoc}
176			*/
177			public function getPort()
178			{
179			if (null === $this->port) {
180			return null;
181			}
182
183			if ($this->port === $this->getPortForScheme($this->getScheme())) {
184			return null;
185			}
186
187			return $this->port;
188			}
189
190			/**
191			* {@inheritdoc}
192			*/
193			public function getPath(): string
194			{
195			return (string) $this->path;
196			}
197
198			/**
199			* {@inheritdoc}
200			*/
201			public function getQuery(): string
202			{
203			return (string) $this->query;
204			}
205
206			/**
207			* {@inheritdoc}
208			*/
209			public function getFragment(): string
210			{
211			return (string) $this->fragment;
212			}
213
214			/**
215			* @return UriInterface\|null
216			*/
217			public function getPrevious()
218			{
219			return $this->previous;
220			}
221
222			/**
223			* {@inheritdoc}
224			*/
225			public function withScheme($scheme): self
226			{
227			return $this->with(['scheme' => $scheme]);
228			}
229
230			/**
231			* {@inheritdoc}
232			*/
233			public function withUserInfo($user, $password = null): self
234			{
235			return $this->with(['user' => $user, 'password' => $password]);
236			}
237
238			/**
239			* {@inheritdoc}
240			*/
241			public function withHost($host): self
242			{
243			return $this->with(['host' => $host]);
244			}
245
246			/**
247			* {@inheritdoc}
248			*/
249			public function withPort($port): self
250			{
251			return $this->with(['port' => $port]);
252			}
253
254			/**
255			* {@inheritdoc}
256			*/
257			public function withPath($path): self
258			{
259			return $this->with(['path' => $path]);
260			}
261
262			/**
263			* {@inheritdoc}
264			*/
265			public function withQuery($query): self
266			{
267			return $this->with(['query' => $query]);
268			}
269
270			/**
271			* {@inheritdoc}
272			*/
273			public function withFragment($fragment): self
274			{
275			return $this->with(['fragment' => $fragment]);
276			}
277
278			/**
279			* {@inheritdoc}
280			*/
281			public function __toString(): string
282			{
283			$uri = '';
284
285			if ('' !== $scheme = $this->getScheme()) {
286			$uri .= $scheme.':';
287			}
288
289			if ('' !== $authority = $this->getAuthority()) {
290			$uri .= '//'.$authority;
291			}
292
293			if ('' !== $path = $this->getPath()) {
294			$uri .= $this->getPathForUri($authority, $path);
295			}
296
297			if ('' !== $query = $this->getQuery()) {
298			$uri .= '?'.$query;
299			}
300
301			if ('' !== $fragment = $this->getFragment()) {
302			$uri .= '#'.$fragment;
303			}
304
305			return $uri;
306			}
307
308			/**
309			* @param string $scheme
310			*
311			* @return int\|null
312			*/
313			private function getPortForScheme(string $scheme)
314			{
315			$constantName = 'PORT_'.strtoupper($scheme);
316			$reflection = new \ReflectionObject($this);
317			if ($reflection->hasConstant($constantName)) {
318			return $reflection->getConstant($constantName);
319			}
320
321			return null;
322			}
323
324			/**
325			* @param string $authority
326			* @param string $path
327			*
328			* @return string
329			*/
330			private function getPathForUri(string $authority, string $path): string
331			{
332			if ('' !== $authority) {
333			return $this->getPathForUriWithAuthority($path);
334			}
335
336			return $this->getPathForUriWithoutAuthority($path);
337			}
338
339			/**
340			* @param string $path
341			*
342			* @return string
343			*/
344			private function getPathForUriWithAuthority(string $path)
345			{
346			return '/' === $path[0] ? $path : '/'.$path;
347			}
348
349			/**
350			* @param string $path
351			*
352			* @return string
353			*/
354			private function getPathForUriWithoutAuthority(string $path)
355			{
356			$pathLength = strlen($path);
357			for ($i = 0; $i < $pathLength; ++$i) {
358			if ('/' !== $path[$i]) {
359			break;
360			}
361			}
362
363			return 0 === $i ? $path : '/'.substr($path, $i);
364			}
365
366			/**
367			* @param array $arguments
368			*
369			* @return Uri
370			*/
371			public function with(array $arguments): self
372			{
373			$defaultArguments = [
374			'scheme' => $this->scheme,
375			'host' => $this->host,
376			'port' => $this->port,
377			'user' => $this->user,
378			'password' => $this->password,
379			'path' => $this->path,
380			'query' => $this->query,
381			'fragment' => $this->fragment,
382			'previous' => $this,
383			];
384
385			$arguments = array_replace($defaultArguments, $arguments);
386
387			return new self(...array_merge(array_values($arguments), [$this]));
			0 ignored issues – show Documentation introduced 2016-09-10 07:43 UTC by Report Bug Copy Issue Report `array_merge(array_values...guments), array($this))` is of type `array<integer,?,{"0":"th...m\\HttpMessage\\Uri>"}>`, but the function expects a `null\|string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
388			}
389			}
390

saxulum / saxulum-http-message

Branch — master (59f97a)

Uri B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

24 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like