Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | abstract class AbstractParentNode extends AbstractNode |
||
6 | { |
||
7 | /** |
||
8 | * @var AbstractNode[]|array |
||
9 | */ |
||
10 | protected $children = []; |
||
11 | |||
12 | /** |
||
13 | * @var boolean |
||
14 | */ |
||
15 | protected $allowEmpty; |
||
16 | |||
17 | /** |
||
18 | * @var \ReflectionProperty |
||
19 | */ |
||
20 | protected $reflectionProperty; |
||
21 | |||
22 | /** |
||
23 | * @param boolean $allowEmpty |
||
24 | */ |
||
25 | public function __construct($allowEmpty = false) |
||
32 | |||
33 | /** |
||
34 | * @param AbstractNode $node |
||
35 | * @return void |
||
36 | */ |
||
37 | View Code Duplication | protected function setParent(AbstractNode $node) |
|
45 | } |
||
46 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.