Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | final class QueryBuilder implements QueryBuilderInterface |
||
17 | { |
||
18 | /** |
||
19 | * @var ObjectNode |
||
20 | */ |
||
21 | private $rootNode; |
||
22 | |||
23 | /** |
||
24 | * @var AbstractNode |
||
25 | */ |
||
26 | private $node; |
||
27 | |||
28 | 19 | public function __construct() |
|
33 | |||
34 | /** |
||
35 | * @param array ...$arguments |
||
36 | * @return QueryBuilderInterface |
||
37 | * @throws \Exception |
||
38 | */ |
||
39 | 16 | public function add(...$arguments): QueryBuilderInterface |
|
47 | |||
48 | /** |
||
49 | * @param AbstractNode $node |
||
50 | * |
||
51 | * @return QueryBuilderInterface |
||
52 | * |
||
53 | * @throws \Exception |
||
54 | */ |
||
55 | 5 | View Code Duplication | public function addToArrayNode(AbstractNode $node): QueryBuilderInterface |
66 | |||
67 | /** |
||
68 | * @param string $key |
||
69 | * @param AbstractNode $node |
||
70 | * |
||
71 | * @return QueryBuilderInterface |
||
72 | * |
||
73 | * @throws \Exception |
||
74 | */ |
||
75 | 17 | View Code Duplication | public function addToObjectNode(string $key, AbstractNode $node): QueryBuilderInterface |
86 | |||
87 | /** |
||
88 | * @param AbstractNode $node |
||
89 | */ |
||
90 | 17 | private function reassignParent(AbstractNode $node) |
|
96 | |||
97 | /** |
||
98 | * @return QueryBuilderInterface |
||
99 | * |
||
100 | * @throws \Exception |
||
101 | */ |
||
102 | 2 | public function end(): QueryBuilderInterface |
|
110 | |||
111 | /** |
||
112 | * @param bool $allowDefault |
||
113 | * @return ArrayNode |
||
114 | */ |
||
115 | 5 | public function arrayNode(bool $allowDefault = false): ArrayNode |
|
119 | |||
120 | /** |
||
121 | * @param bool|null $value |
||
122 | * @param bool $allowDefault |
||
123 | * @return BoolNode |
||
124 | */ |
||
125 | 1 | public function boolNode($value = null, bool $allowDefault = false): BoolNode |
|
129 | |||
130 | /** |
||
131 | * @param float|null $value |
||
132 | * @param bool $allowDefault |
||
133 | * @return FloatNode |
||
134 | */ |
||
135 | 1 | public function floatNode($value = null, bool $allowDefault = false): FloatNode |
|
139 | |||
140 | /** |
||
141 | * @param int|null $value |
||
142 | * @param bool $allowDefault |
||
143 | * @return IntNode |
||
144 | */ |
||
145 | 4 | public function intNode($value = null, bool $allowDefault = false): IntNode |
|
149 | |||
150 | /** |
||
151 | * @return NullNode |
||
152 | */ |
||
153 | 1 | public function nullNode(): NullNode |
|
157 | |||
158 | /** |
||
159 | * @param bool $allowDefault |
||
160 | * @return ObjectNode |
||
161 | */ |
||
162 | 16 | public function objectNode(bool $allowDefault = false): ObjectNode |
|
166 | |||
167 | /** |
||
168 | * @param string|null $value |
||
169 | * @param bool $allowDefault |
||
170 | * @return StringNode |
||
171 | */ |
||
172 | 13 | public function stringNode($value = null, bool $allowDefault = false): StringNode |
|
176 | |||
177 | /** |
||
178 | * @return \stdClass|null |
||
179 | */ |
||
180 | 16 | public function serialize() |
|
184 | |||
185 | /** |
||
186 | * @param boolean $beautify |
||
187 | * @return string |
||
188 | */ |
||
189 | 16 | public function json(bool $beautify = false): string |
|
201 | } |
||
202 |
This check looks for function calls that miss required arguments.