ObjectNode::add() - Code Metrics - Inspection of "make serialize child an own method" - saxulum/saxulum-elasticsearch-querybuilder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (343030)

by Dominik

created 2016-04-26 10:32 UTC

ObjectNode::add() A

↳ Parent: ObjectNode

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes	8
Bugs	2	Features	2

Metric	Value
c	8
b	2
f	2
dl	0
loc	13
ccs	7
cts	7
cp	1
rs	9.4285
cc	2
eloc	7
nc	2
nop	3
crap	2

<?php

namespace Saxulum\ElasticSearchQueryBuilder\Node;

class ObjectNode extends AbstractParentNode
{
    /**
     * @param string       $name
     * @param AbstractNode $node
     *
     * @return $this
     */
    public function add($name, AbstractNode $node, $allowDefault = false)
    {
        if (isset($this->children[$name])) {
            throw new \InvalidArgumentException(sprintf('There is already a node with name %s!', $name));
        }

        $node->setParent($this);

        $this->children[$name] = $node;
        $this->allowDefault[$name] = $allowDefault;

        return $this;
    }

    /**
     * @return array
     */
    public function getDefault()
    {
        return new \stdClass();
    }

    /**
     * @return \stdClass|null
     */
    public function serialize()
    {
        $serialized = new \stdClass();
        foreach ($this->children as $name => $child) {
            $this->serializeChild($serialized, $name, $child);
        }

        if ([] === (array) $serialized) {
            return;
        }

        return $serialized;
    }

    /**
     * @param \stdClass    $serialized
     * @param string       $name
     * @param AbstractNode $child
     */
    private function serializeChild(\stdClass $serialized, $name, AbstractNode $child)
    {
        if (null !== $serializedChild = $child->serialize()) {
            $serialized->$name = $serializedChild;
        } elseif ($this->allowDefault[$name]) {
            $serialized->$name = $child->getDefault();
        }
    }
}


1		<?php
2
3		namespace Saxulum\ElasticSearchQueryBuilder\Node;
4
5		class ObjectNode extends AbstractParentNode
6		{
7		/**
8		* @param string $name
9		* @param AbstractNode $node
10		*
11		* @return $this
12		*/
13	5	public function add($name, AbstractNode $node, $allowDefault = false)
14		{
15	5	if (isset($this->children[$name])) {
16	1	throw new \InvalidArgumentException(sprintf('There is already a node with name %s!', $name));
17		}
18
19	5	$node->setParent($this);
20
21	5	$this->children[$name] = $node;
22	5	$this->allowDefault[$name] = $allowDefault;
23
24	5	return $this;
25		}
26
27		/**
28		* @return array
29		*/
30	1	public function getDefault()
31		{
32	1	return new \stdClass();
33		}
34
35		/**
36		* @return \stdClass\|null
37		*/
38	4	public function serialize()
39		{
40	4	$serialized = new \stdClass();
41	4	foreach ($this->children as $name => $child) {
42	3	$this->serializeChild($serialized, $name, $child);
43	4	}
44
45	4	if ([] === (array) $serialized) {
46	2	return;
47		}
48
49	2	return $serialized;
50		}
51
52		/**
53		* @param \stdClass $serialized
54		* @param string $name
55		* @param AbstractNode $child
56		*/
57	3	private function serializeChild(\stdClass $serialized, $name, AbstractNode $child)
58		{
59	3	if (null !== $serializedChild = $child->serialize()) {
60	1	$serialized->$name = $serializedChild;
61	3	} elseif ($this->allowDefault[$name]) {
62	1	$serialized->$name = $child->getDefault();
63	1	}
64	3	}
65		}
66

saxulum / saxulum-elasticsearch-querybuilder

Branch — master (343030)

ObjectNode::add() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like