ArrayNode::serializeChild() - Code Metrics - Inspection of "make serialize child an own method" - saxulum/saxulum-elasticsearch-querybuilder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (343030)

by Dominik

created 2016-04-26 10:32 UTC

ArrayNode::serializeChild() A

↳ Parent: ArrayNode

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	7
cts	7
cp	1
rs	9.4285
cc	3
eloc	5
nc	3
nop	3
crap	3

<?php

namespace Saxulum\ElasticSearchQueryBuilder\Node;

class ArrayNode extends AbstractParentNode
{
    /**
     * @param AbstractNode $node
     * @param bool         $allowDefault
     *
     * @return $this
     */
    public function add(AbstractNode $node, $allowDefault = false)
    {
        $node->setParent($this);

        $this->children[] = $node;
        $this->allowDefault[] = $allowDefault;

        return $this;
    }

    /**
     * @return array
     */
    public function getDefault()
    {
        return [];
    }

    /**
     * @return \stdClass|null
     */
    public function serialize()
    {
        $serialized = [];
        foreach ($this->children as $i => $child) {
            $this->serializeChild($serialized, $i, $child);
        }

        if ([] === $serialized) {
            return;
        }

        return $serialized;
    }

    /**
     * @param array        $serialized
     * @param string       $name
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param AbstractNode $child
     */
    private function serializeChild(array &$serialized, $i, AbstractNode $child)
    {
        if (null !== $serializedChild = $child->serialize()) {
            $serialized[] = $serializedChild;
        } elseif ($this->allowDefault[$i]) {
            $serialized[] = $child->getDefault();
        }
    }
}


1		<?php
2
3		namespace Saxulum\ElasticSearchQueryBuilder\Node;
4
5		class ArrayNode extends AbstractParentNode
6		{
7		/**
8		* @param AbstractNode $node
9		* @param bool $allowDefault
10		*
11		* @return $this
12		*/
13	4	public function add(AbstractNode $node, $allowDefault = false)
14		{
15	4	$node->setParent($this);
16
17	4	$this->children[] = $node;
18	4	$this->allowDefault[] = $allowDefault;
19
20	4	return $this;
21		}
22
23		/**
24		* @return array
25		*/
26	1	public function getDefault()
27		{
28	1	return [];
29		}
30
31		/**
32		* @return \stdClass\|null
33		*/
34	4	public function serialize()
35		{
36	4	$serialized = [];
37	4	foreach ($this->children as $i => $child) {
38	3	$this->serializeChild($serialized, $i, $child);
39	4	}
40
41	4	if ([] === $serialized) {
42	2	return;
43		}
44
45	2	return $serialized;
46		}
47
48		/**
49		* @param array $serialized
50		* @param string $name
		0 ignored issues – show Bug introduced 2016-04-26 10:35 UTC by Report Bug Copy Issue Report There is no parameter named `$name`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
51		* @param AbstractNode $child
52		*/
53	3	private function serializeChild(array &$serialized, $i, AbstractNode $child)
54		{
55	3	if (null !== $serializedChild = $child->serialize()) {
56	1	$serialized[] = $serializedChild;
57	3	} elseif ($this->allowDefault[$i]) {
58	1	$serialized[] = $child->getDefault();
59	1	}
60	3	}
61		}
62

saxulum / saxulum-elasticsearch-querybuilder

Branch — master (343030)

ArrayNode::serializeChild() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like