QueryBuilder::add() - Code Metrics - Inspection of "simplify the usage: remove all ->end() if they are..." - saxulum/saxulum-elasticsearch-querybuilder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 88365a...ba5dfd )

by Dominik

created 2016-05-02 17:46 UTC

QueryBuilder::add() B

↳ Parent: QueryBuilder

Complexity

Conditions	5
Paths	6

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	5

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	15
ccs	11
cts	11
cp	1
rs	8.8571
cc	5
eloc	9
nc	6
nop	1
crap	5

<?php

namespace Saxulum\ElasticSearchQueryBuilder;

use Saxulum\ElasticSearchQueryBuilder\Node\AbstractNode;
use Saxulum\ElasticSearchQueryBuilder\Node\ArrayNode;
use Saxulum\ElasticSearchQueryBuilder\Node\CallbackNode;
use Saxulum\ElasticSearchQueryBuilder\Node\ObjectNode;
use Saxulum\ElasticSearchQueryBuilder\Node\ScalarNode;

class QueryBuilder
{
    /**
     * @var ObjectNode
     */
    protected $rootNode;

    /**
     * @var AbstractNode
     */
    protected $node;

    public function __construct()
    {
        $this->rootNode = new ObjectNode();
        $this->node = $this->rootNode;
    }

    /**
     * @return Expr
     */
    public function a()
    {
        return new Expr(new ArrayNode());
    }

    /**
     * @param \Closure $callback
     *
     * @return Expr
     */
    public function c(\Closure $callback)
    {
        return new Expr(new CallbackNode($callback));
    }

    /**
     * @return Expr
     */
    public function o()
    {
        return new Expr(new ObjectNode());
    }

    /**
     * @return Expr
     */
    public function s($value = null)
    {
        return new Expr(new ScalarNode($value));
    }

    /**
     * @param Expr $expr
     *
     * @return $this
     */
    public function add(Expr $expr)
    {
        $node = $expr->getNode();
        if ($this->node instanceof ArrayNode) {
            $this->node->add($node, $expr->isAllowDefault());
        } elseif ($this->node instanceof ObjectNode) {
            $this->node->add($expr->getKey(), $node, $expr->isAllowDefault());
        }

        if ($node instanceof ArrayNode || $node instanceof ObjectNode) {
            $this->node = $node;
        }

        return $this;
    }

    /**
     * @return $this
     */
    public function end()
    {
        $this->node = $this->node->getParent();

        return $this;
    }

    /**
     * @return Query
     */
    public function query()
    {
        return new Query($this->rootNode);
    }
}


1		<?php
2
3		namespace Saxulum\ElasticSearchQueryBuilder;
4
5		use Saxulum\ElasticSearchQueryBuilder\Node\AbstractNode;
6		use Saxulum\ElasticSearchQueryBuilder\Node\ArrayNode;
7		use Saxulum\ElasticSearchQueryBuilder\Node\CallbackNode;
8		use Saxulum\ElasticSearchQueryBuilder\Node\ObjectNode;
9		use Saxulum\ElasticSearchQueryBuilder\Node\ScalarNode;
10
11		class QueryBuilder
12		{
13		/**
14		* @var ObjectNode
15		*/
16		protected $rootNode;
17
18		/**
19		* @var AbstractNode
20		*/
21		protected $node;
22
23	14	public function __construct()
24		{
25	14	$this->rootNode = new ObjectNode();
26	14	$this->node = $this->rootNode;
27	14	}
28
29		/**
30		* @return Expr
31		*/
32	2	public function a()
33		{
34	2	return new Expr(new ArrayNode());
35		}
36
37		/**
38		* @param \Closure $callback
39		*
40		* @return Expr
41		*/
42	2	public function c(\Closure $callback)
43		{
44	2	return new Expr(new CallbackNode($callback));
45		}
46
47		/**
48		* @return Expr
49		*/
50	14	public function o()
51		{
52	14	return new Expr(new ObjectNode());
53		}
54
55		/**
56		* @return Expr
57		*/
58	13	public function s($value = null)
59		{
60	13	return new Expr(new ScalarNode($value));
61		}
62
63		/**
64		* @param Expr $expr
65		*
66		* @return $this
67		*/
68	14	public function add(Expr $expr)
69		{
70	14	$node = $expr->getNode();
71	14	if ($this->node instanceof ArrayNode) {
72	2	$this->node->add($node, $expr->isAllowDefault());
73	14	} elseif ($this->node instanceof ObjectNode) {
74	14	$this->node->add($expr->getKey(), $node, $expr->isAllowDefault());
75	14	}
76
77	14	if ($node instanceof ArrayNode \|\| $node instanceof ObjectNode) {
78	14	$this->node = $node;
79	14	}
80
81	14	return $this;
82		}
83
84		/**
85		* @return $this
86		*/
87	1	public function end()
88		{
89	1	$this->node = $this->node->getParent();
90
91	1	return $this;
92		}
93
94		/**
95		* @return Query
96		*/
97	14	public function query()
98		{
99	14	return new Query($this->rootNode);
100		}
101		}
102

saxulum / saxulum-elasticsearch-querybuilder

Push — master ( 88365a...ba5dfd )

QueryBuilder::add() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like