Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like CrudTrait often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CrudTrait, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
28 | trait CrudTrait |
||
29 | { |
||
30 | /** |
||
31 | * @param Request $request |
||
32 | * @param array $templateVars |
||
33 | * |
||
34 | * @return Response |
||
35 | * |
||
36 | * @throws \Exception |
||
37 | */ |
||
38 | public function crudListObjects(Request $request, array $templateVars = array()) |
||
91 | |||
92 | /** |
||
93 | * @param Request $request |
||
94 | * @param array $templateVars |
||
95 | * |
||
96 | * @return Response|RedirectResponse |
||
97 | */ |
||
98 | View Code Duplication | public function crudCreateObject(Request $request, array $templateVars = array()) |
|
158 | |||
159 | /** |
||
160 | * @param Request $request |
||
161 | * @param object|string|int $object |
||
162 | * @param array $templateVars |
||
163 | * |
||
164 | * @return Response|RedirectResponse |
||
165 | */ |
||
166 | View Code Duplication | public function crudEditObject(Request $request, $object, array $templateVars = array()) |
|
227 | |||
228 | /** |
||
229 | * @param Request $request |
||
230 | * @param object|string|int $object |
||
231 | * @param array $templateVars |
||
232 | * |
||
233 | * @return Response|RedirectResponse |
||
234 | */ |
||
235 | public function crudViewObject(Request $request, $object, array $templateVars = array()) |
||
269 | |||
270 | /** |
||
271 | * @param Request $request |
||
272 | * @param object|string|int $object |
||
273 | * |
||
274 | * @return Response|RedirectResponse |
||
275 | */ |
||
276 | public function crudDeleteObject(Request $request, $object) |
||
296 | |||
297 | /** |
||
298 | * @return int |
||
299 | */ |
||
300 | protected function crudListPerPage() |
||
304 | |||
305 | /** |
||
306 | * @return Listing |
||
307 | */ |
||
308 | protected function crudListListing() |
||
315 | |||
316 | /** |
||
317 | * @return string |
||
318 | */ |
||
319 | protected function crudListRoute() |
||
323 | |||
324 | /** |
||
325 | * @return string |
||
326 | */ |
||
327 | protected function crudListRole() |
||
331 | |||
332 | /** |
||
333 | * @param Request $request |
||
334 | * |
||
335 | * @return FormInterface|null |
||
336 | */ |
||
337 | protected function crudListForm(Request $request) |
||
345 | |||
346 | /** |
||
347 | * @param Request $request |
||
348 | * |
||
349 | * @return FormTypeInterface|null |
||
350 | */ |
||
351 | protected function crudListFormType(Request $request) |
||
355 | |||
356 | /** |
||
357 | * @param Request $request |
||
358 | * @param array $formData |
||
359 | * |
||
360 | * @return array |
||
361 | */ |
||
362 | protected function crudListFormDataEnrich(Request $request, array $formData) |
||
366 | |||
367 | /** |
||
368 | * @param Request $request |
||
369 | * @param array $baseTemplateVars |
||
370 | * @param array $templateVars |
||
371 | * |
||
372 | * @return Response |
||
373 | */ |
||
374 | protected function crudListRenderTemplateResponse(Request $request, array $baseTemplateVars, array $templateVars) |
||
381 | |||
382 | /** |
||
383 | * @return string |
||
384 | */ |
||
385 | protected function crudListTemplate() |
||
389 | |||
390 | /** |
||
391 | * @return string |
||
392 | */ |
||
393 | protected function crudCreateRoute() |
||
397 | |||
398 | /** |
||
399 | * @return string |
||
400 | */ |
||
401 | protected function crudCreateRole() |
||
405 | |||
406 | /** |
||
407 | * @param Request $request |
||
408 | * |
||
409 | * @return object |
||
410 | */ |
||
411 | protected function crudCreateFactory(Request $request) |
||
417 | |||
418 | /** |
||
419 | * @param object $object |
||
420 | * @param Request $request |
||
421 | * |
||
422 | * @return FormInterface |
||
423 | */ |
||
424 | protected function crudCreateForm($object, Request $request) |
||
428 | |||
429 | /** |
||
430 | * @param Request $request |
||
431 | * @param object $object |
||
432 | * @return FormTypeInterface |
||
433 | * |
||
434 | * @throws \Exception |
||
435 | */ |
||
436 | protected function crudCreateFormType(Request $request, $object) |
||
440 | |||
441 | /** |
||
442 | * @param object $object |
||
443 | * @param FormInterface $form |
||
444 | * @param Request $request |
||
445 | * |
||
446 | * @return bool |
||
447 | */ |
||
448 | View Code Duplication | protected function crudCreateIsSubmitted($object, FormInterface $form, Request $request) |
|
457 | |||
458 | /** |
||
459 | * @return string|null |
||
460 | */ |
||
461 | protected function crudCreateButtonName() |
||
465 | |||
466 | /** |
||
467 | * @param object $object |
||
468 | * @param FormInterface $form |
||
469 | * @param Request $request |
||
470 | */ |
||
471 | protected function crudCreateSuccessFlashMesssage($object, FormInterface $form, Request $request) |
||
475 | |||
476 | /** |
||
477 | * @param object $object |
||
478 | * @param FormInterface $form |
||
479 | * @param Request $request |
||
480 | */ |
||
481 | protected function crudCreateErrorFlashMesssage($object, FormInterface $form, Request $request) |
||
485 | |||
486 | /** |
||
487 | * @param object $object |
||
488 | * @param FormInterface $form |
||
489 | * @param Request $request |
||
490 | * |
||
491 | * @return RedirectResponse|Response |
||
492 | */ |
||
493 | View Code Duplication | protected function crudCreateSuccessResponse($object, FormInterface $form, Request $request) |
|
500 | |||
501 | /** |
||
502 | * @param object $object |
||
503 | * @param FormInterface $form |
||
504 | * @param Request $request |
||
505 | * |
||
506 | * @return RedirectResponse|Response|null |
||
507 | */ |
||
508 | protected function crudCreateErrorResponse($object, FormInterface $form, Request $request) |
||
512 | |||
513 | /** |
||
514 | * @param Request $request |
||
515 | * @param array $baseTemplateVars |
||
516 | * @param array $templateVars |
||
517 | * |
||
518 | * @return Response |
||
519 | */ |
||
520 | protected function crudCreateRenderTemplateResponse(Request $request, array $baseTemplateVars, array $templateVars) |
||
527 | |||
528 | /** |
||
529 | * @return string |
||
530 | */ |
||
531 | protected function crudCreateTemplate() |
||
535 | |||
536 | /** |
||
537 | * @param object $object |
||
538 | * @param FormInterface $form |
||
539 | * @param Request $request |
||
540 | */ |
||
541 | protected function crudCreatePrePersist($object, FormInterface $form, Request $request) |
||
544 | |||
545 | /** |
||
546 | * @param object $object |
||
547 | * @param FormInterface $form |
||
548 | * @param Request $request |
||
549 | */ |
||
550 | protected function crudCreatePostFlush($object, FormInterface $form, Request $request) |
||
553 | |||
554 | /** |
||
555 | * @return string |
||
556 | */ |
||
557 | protected function crudEditRoute() |
||
561 | |||
562 | /** |
||
563 | * @param object|string|int $object |
||
564 | * @param Request $request |
||
565 | * |
||
566 | * @return object |
||
567 | */ |
||
568 | protected function crudEditLoadObject($object, Request $request) |
||
572 | |||
573 | /** |
||
574 | * @return string |
||
575 | */ |
||
576 | protected function crudEditRole() |
||
580 | |||
581 | /** |
||
582 | * @param object $object |
||
583 | * @param Request $request |
||
584 | * |
||
585 | * @return FormInterface |
||
586 | */ |
||
587 | protected function crudEditForm($object, Request $request) |
||
591 | |||
592 | /** |
||
593 | * @param Request $request |
||
594 | * @param object $object |
||
595 | * |
||
596 | * @return FormTypeInterface |
||
597 | * |
||
598 | * @throws \Exception |
||
599 | */ |
||
600 | protected function crudEditFormType(Request $request, $object) |
||
604 | |||
605 | /** |
||
606 | * @param object $object |
||
607 | * @param FormInterface $form |
||
608 | * @param Request $request |
||
609 | * |
||
610 | * @return bool |
||
611 | */ |
||
612 | View Code Duplication | protected function crudEditIsSubmitted($object, FormInterface $form, Request $request) |
|
621 | |||
622 | /** |
||
623 | * @return string|null |
||
624 | */ |
||
625 | protected function crudEditButtonName() |
||
629 | |||
630 | /** |
||
631 | * @param object $object |
||
632 | * @param FormInterface $form |
||
633 | * @param Request $request |
||
634 | */ |
||
635 | protected function crudEditSuccessFlashMesssage($object, FormInterface $form, Request $request) |
||
639 | |||
640 | /** |
||
641 | * @param object $object |
||
642 | * @param FormInterface $form |
||
643 | * @param Request $request |
||
644 | */ |
||
645 | protected function crudEditErrorFlashMesssage($object, FormInterface $form, Request $request) |
||
649 | |||
650 | /** |
||
651 | * @param object $object |
||
652 | * @param FormInterface $form |
||
653 | * @param Request $request |
||
654 | * |
||
655 | * @return RedirectResponse|Response |
||
656 | */ |
||
657 | View Code Duplication | protected function crudEditSuccessResponse($object, FormInterface $form, Request $request) |
|
664 | |||
665 | /** |
||
666 | * @param object $object |
||
667 | * @param FormInterface $form |
||
668 | * @param Request $request |
||
669 | * |
||
670 | * @return RedirectResponse|Response|null |
||
671 | */ |
||
672 | protected function crudEditErrorResponse($object, FormInterface $form, Request $request) |
||
676 | |||
677 | /** |
||
678 | * @param Request $request |
||
679 | * @param array $baseTemplateVars |
||
680 | * @param array $templateVars |
||
681 | * |
||
682 | * @return Response |
||
683 | */ |
||
684 | protected function crudEditRenderTemplateResponse(Request $request, array $baseTemplateVars, array $templateVars) |
||
691 | |||
692 | /** |
||
693 | * @return string |
||
694 | */ |
||
695 | protected function crudEditTemplate() |
||
699 | |||
700 | /** |
||
701 | * @param object $object |
||
702 | * @param FormInterface $form |
||
703 | * @param Request $request |
||
704 | */ |
||
705 | protected function crudEditPrePersist($object, FormInterface $form, Request $request) |
||
708 | |||
709 | /** |
||
710 | * @param object $object |
||
711 | * @param FormInterface $form |
||
712 | * @param Request $request |
||
713 | */ |
||
714 | protected function crudEditPostFlush($object, FormInterface $form, Request $request) |
||
717 | |||
718 | /** |
||
719 | * @return string |
||
720 | */ |
||
721 | protected function crudViewRoute() |
||
725 | |||
726 | /** |
||
727 | * @param object|string|int $object |
||
728 | * @param Request $request |
||
729 | * |
||
730 | * @return object |
||
731 | */ |
||
732 | protected function crudViewLoadObject($object, Request $request) |
||
736 | |||
737 | /** |
||
738 | * @return string |
||
739 | */ |
||
740 | protected function crudViewRole() |
||
744 | |||
745 | /** |
||
746 | * @param Request $request |
||
747 | * @param array $baseTemplateVars |
||
748 | * @param array $templateVars |
||
749 | * |
||
750 | * @return Response |
||
751 | */ |
||
752 | protected function crudViewRenderTemplateResponse(Request $request, array $baseTemplateVars, array $templateVars) |
||
759 | |||
760 | /** |
||
761 | * @return string |
||
762 | */ |
||
763 | protected function crudViewTemplate() |
||
767 | |||
768 | /** |
||
769 | * @return string |
||
770 | */ |
||
771 | protected function crudDeleteRoute() |
||
775 | |||
776 | /** |
||
777 | * @param object|string|int $object |
||
778 | * @param Request $request |
||
779 | * |
||
780 | * @return object |
||
781 | */ |
||
782 | protected function crudDeleteLoadObject($object, Request $request) |
||
786 | |||
787 | /** |
||
788 | * @return string |
||
789 | */ |
||
790 | protected function crudDeleteRole() |
||
794 | |||
795 | /** |
||
796 | * @param object $object |
||
797 | * @param Request $request |
||
798 | */ |
||
799 | protected function crudDeleteSuccessFlashMesssage($object, Request $request) |
||
803 | |||
804 | /** |
||
805 | * @param object $object |
||
806 | * @param Request $request |
||
807 | * |
||
808 | * @return RedirectResponse|Response |
||
809 | */ |
||
810 | protected function crudDeleteSuccessResponse($object, Request $request) |
||
814 | |||
815 | /** |
||
816 | * @param object $object |
||
817 | * @param Request $request |
||
818 | */ |
||
819 | protected function crudDeletePreRemove($object, Request $request) |
||
822 | |||
823 | /** |
||
824 | * @param object $object |
||
825 | * @param Request $request |
||
826 | */ |
||
827 | protected function crudDeletePostFlush($object, Request $request) |
||
830 | |||
831 | /** |
||
832 | * @return string |
||
833 | */ |
||
834 | protected function crudRoutePattern() |
||
838 | |||
839 | /** |
||
840 | * @return string |
||
841 | */ |
||
842 | protected function crudRolePattern() |
||
846 | |||
847 | /** |
||
848 | * @return string |
||
849 | */ |
||
850 | protected function crudTransPrefix() |
||
854 | |||
855 | /** |
||
856 | * @return string |
||
857 | */ |
||
858 | protected function crudTransDomain() |
||
862 | |||
863 | /** |
||
864 | * @return string |
||
865 | * |
||
866 | * @throws \Exception |
||
867 | */ |
||
868 | protected function crudTemplatePattern() |
||
875 | |||
876 | /** |
||
877 | * @return string |
||
878 | */ |
||
879 | abstract protected function crudName(); |
||
880 | |||
881 | /** |
||
882 | * @return string |
||
883 | */ |
||
884 | abstract protected function crudObjectClass(); |
||
885 | |||
886 | /** |
||
887 | * @return AuthorizationCheckerInterface |
||
888 | * |
||
889 | * @throws ServiceNotFoundException |
||
890 | */ |
||
891 | protected function crudAuthorizationChecker() |
||
898 | |||
899 | /** |
||
900 | * @return SecurityContextInterface |
||
901 | * |
||
902 | * @throws ServiceNotFoundException |
||
903 | */ |
||
904 | protected function crudSecurity() |
||
911 | |||
912 | /** |
||
913 | * @return ManagerRegistry |
||
914 | * |
||
915 | * @throws ServiceNotFoundException |
||
916 | */ |
||
917 | protected function crudDoctrine() |
||
924 | |||
925 | /** |
||
926 | * @return FormFactoryInterface |
||
927 | * |
||
928 | * @throws ServiceNotFoundException |
||
929 | */ |
||
930 | protected function crudFormFactory() |
||
937 | |||
938 | /** |
||
939 | * @return PaginatorInterface |
||
940 | * |
||
941 | * @throws ServiceNotFoundException |
||
942 | */ |
||
943 | protected function crudPaginator() |
||
950 | |||
951 | /** |
||
952 | * @return UrlGeneratorInterface |
||
953 | * |
||
954 | * @throws ServiceNotFoundException |
||
955 | */ |
||
956 | protected function crudUrlGenerator() |
||
963 | |||
964 | /** |
||
965 | * @return \Twig_Environment |
||
966 | * |
||
967 | * @throws ServiceNotFoundException |
||
968 | */ |
||
969 | protected function crudTwig() |
||
976 | |||
977 | /** |
||
978 | * @return ListingFactory |
||
979 | * |
||
980 | * @throws ServiceNotFoundException |
||
981 | */ |
||
982 | protected function crudListingFactory() |
||
989 | |||
990 | /** |
||
991 | * @param mixed $attributes |
||
992 | * @param mixed $object |
||
993 | * |
||
994 | * @return bool |
||
995 | * |
||
996 | * @throws \Exception |
||
997 | */ |
||
998 | protected function crudIsGranted($attributes, $object = null) |
||
1006 | |||
1007 | /** |
||
1008 | * @param object|string|int $object |
||
1009 | * @param Request $request |
||
1010 | * |
||
1011 | * @return object object |
||
1012 | */ |
||
1013 | protected function crudLoadObject($object, Request $request) |
||
1029 | |||
1030 | /** |
||
1031 | * @param string $class |
||
1032 | * |
||
1033 | * @return ObjectManager |
||
1034 | * |
||
1035 | * @throws \Exception |
||
1036 | */ |
||
1037 | protected function crudManagerForClass($class) |
||
1047 | |||
1048 | /** |
||
1049 | * @param string $class |
||
1050 | * |
||
1051 | * @return ObjectRepository |
||
1052 | */ |
||
1053 | protected function crudRepositoryForClass($class) |
||
1057 | |||
1058 | /** |
||
1059 | * @return string |
||
1060 | * |
||
1061 | * @throws \Exception |
||
1062 | */ |
||
1063 | protected function crudIdentifier() |
||
1076 | |||
1077 | /** |
||
1078 | * @return string |
||
1079 | * |
||
1080 | * @throws \Exception |
||
1081 | */ |
||
1082 | protected function crudIdentifierMethod() |
||
1088 | |||
1089 | /** |
||
1090 | * @param FormTypeInterface $type |
||
1091 | * @param mixed $data |
||
1092 | * @param array $options |
||
1093 | * |
||
1094 | * @return FormInterface |
||
1095 | */ |
||
1096 | protected function crudForm(FormTypeInterface $type, $data = null, array $options = array()) |
||
1100 | |||
1101 | /** |
||
1102 | * @param object $target |
||
1103 | * @param Request $request |
||
1104 | * |
||
1105 | * @return AbstractPagination |
||
1106 | */ |
||
1107 | protected function crudPaginate($target, Request $request) |
||
1115 | |||
1116 | /** |
||
1117 | * @param string $name |
||
1118 | * @param array $parameters |
||
1119 | * |
||
1120 | * @return string |
||
1121 | */ |
||
1122 | protected function crudGenerateRoute($name, array $parameters = array()) |
||
1126 | |||
1127 | /** |
||
1128 | * @param string $view |
||
1129 | * @param array $parameters |
||
1130 | * |
||
1131 | * @return Response |
||
1132 | */ |
||
1133 | protected function crudRender($view, array $parameters = array()) |
||
1137 | |||
1138 | /** |
||
1139 | * @param Request $request |
||
1140 | * @param string $type |
||
1141 | * @param string $message |
||
1142 | */ |
||
1143 | protected function crudFlashMessage(Request $request, $type, $message) |
||
1149 | } |
||
1150 |