SignereServiceProvider::defineAssetPublishing() - Code Metrics - Inspection of "Implemented facades but commented out most for now" - sausin/signere-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 365164...87d4f7 )

by Saurabh

created 2017-08-22 19:55 UTC

SignereServiceProvider::defineAssetPublishing() A

↳ Parent: SignereServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	0
dl	0
loc	6
ccs	5
cts	5
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php

namespace Sausin\Signere;

use Illuminate\Support\Facades\Route;
use Illuminate\Support\ServiceProvider;
use Illuminate\Contracts\Events\Dispatcher;

class SignereServiceProvider extends ServiceProvider
{
    use EventMap;

    /**
     * Bootstrap the application services.
     *
     * @return void
     */
    public function boot()
    {
        // $this->registerEvents();

        $this->registerRoutes();
        $this->defineAssetPublishing();
    }

    /**
     * Register the Signere job events.
     *
     * @return void
     */
    protected function registerEvents()
    {
        $events = $this->app->make(Dispatcher::class);

        foreach ($this->events as $event => $listeners) {
            foreach ($listeners as $listener) {
                $events->listen($event, $listener);
            }
        }
    }

    /**
     * Register the Signere routes.
     *
     * @return void
     */
    protected function registerRoutes()
    {
        Route::group([
            'prefix' => 'signere',
            'namespace' => 'Sausin\Signere\Http\Controllers',
            'middleware' => 'web',
        ], function () {
            $this->loadRoutesFrom(__DIR__.'/../routes/api.php');
        });
    }

    /**
     * Define the asset publishing configuration.
     *
     * @return void
     */
    public function defineAssetPublishing()
    {
        $this->publishes([
            SIGNERE_PATH.'/public' => public_path('vendor/signere'),
        ], 'signere-assets');
    }

    /**
     * Register any application services.
     *
     * @return void
     */
    public function register()
    {
        if (! defined('SIGNERE_PATH')) {
            define('SIGNERE_PATH', realpath(__DIR__.'/../'));
        }

        $this->registerFacades();
        $this->configure();
        $this->offerPublishing();
    }

    protected function registerFacades()
    {
        $this->app->bind('signere-headers', function () {
            return new Headers(config());
        });

        // get the environment of the application
        $env = is_null(config('signere.mode')) ? $this->app->environment() : config('signere.mode');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->app->bind('signere-api-key', function ($app, $env) {
            return new ApiKey($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);
        });
        // $this->app->bind('signere-document', function ($app, $env) {

        //     return new Document($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-document-convert', function ($app, $env) {

        //     return new DocumentConvert($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-document-file', function ($app, $env) {

        //     return new DocumentFile($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-document-job', function ($app, $env) {

        //     return new DocumentJob($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-document-provider', function ($app, $env) {

        //     return new DocumentProvider($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-events', function ($app, $env) {

        //     return new Events($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-external-login', function ($app, $env) {

        //     return new ExternalLogin($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-external-sign', function ($app, $env) {

        //     return new ExternalSign($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-form', function ($app, $env) {

        //     return new Form($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-invoice', function ($app, $env) {

        //     return new Invoice($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-message', function ($app, $env) {

        //     return new Message($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-receiver', function ($app, $env) {

        //     return new Receiver($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        // $this->app->bind('signere-statistics', function ($app, $env) {

        //     return new Statistics($app->make('GuzzleHttp\Client'), $app->make(Headers::class), $env);

        // });
        $this->app->bind('signere-status', function ($app, $env) {
            return new Status($app->make('GuzzleHttp\Client'), $app->make(Headers::class), config(), $env);
        });

        $this->app->alias('signere-headers', Facades\SignereHeaders::class);
        $this->app->alias('signere-api-key', Facades\SignereApiKey::class);
        // $this->app->alias('signere-document', Facades\SignereDocument::class);

        // $this->app->alias('signere-document-convert', Facades\SignereDocumentConvert::class);

        // $this->app->alias('signere-document-file', Facades\SignereDocumentFile::class);

        // $this->app->alias('signere-document-job', Facades\SignereDocumentJob::class);

        // $this->app->alias('signere-document-provider', Facades\SignereDocumentProvider::class);

        // $this->app->alias('signere-events', Facades\SignereEvents::class);

        // $this->app->alias('signere-external-login', Facades\SignereExternalLogin::class);

        // $this->app->alias('signere-external-sign', Facades\SignereExternalSign::class);

        // $this->app->alias('signere-form', Facades\SignereForm::class);

        // $this->app->alias('signere-invoice', Facades\SignereInvoice::class);

        // $this->app->alias('signere-message', Facades\SignereMessage::class);

        // $this->app->alias('signere-receiver', Facades\SignereReceiver::class);

        // $this->app->alias('signere-statistics', Facades\SignereStatistics::class);

        $this->app->alias('signere-status', Facades\SignereStatus::class);
    }

    /**
     * Setup the configuration for Signere.
     *
     * @return void
     */
    protected function configure()
    {
        $this->mergeConfigFrom(
            __DIR__.'/../config/signere.php',
            'signere'
        );
    }

    /**
     * Setup the resource publishing groups for Signere.
     *
     * @return void
     */
    protected function offerPublishing()
    {
        if ($this->app->runningInConsole()) {
            $this->publishes([
                __DIR__.'/../config/signere.php' => config_path('signere.php'),
            ], 'signere-config');
        }
    }
}


1		<?php
2
3		namespace Sausin\Signere;
4
5		use Illuminate\Support\Facades\Route;
6		use Illuminate\Support\ServiceProvider;
7		use Illuminate\Contracts\Events\Dispatcher;
8
9		class SignereServiceProvider extends ServiceProvider
10		{
11		use EventMap;
12
13		/**
14		* Bootstrap the application services.
15		*
16		* @return void
17		*/
18	47	public function boot()
19		{
20		// $this->registerEvents();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-19 18:57 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
21	47	$this->registerRoutes();
22	47	$this->defineAssetPublishing();
23	47	}
24
25		/**
26		* Register the Signere job events.
27		*
28		* @return void
29		*/
30		protected function registerEvents()
31		{
32		$events = $this->app->make(Dispatcher::class);
33
34		foreach ($this->events as $event => $listeners) {
35		foreach ($listeners as $listener) {
36		$events->listen($event, $listener);
37		}
38		}
39		}

sausin / signere-sdk

Push — master ( 365164...87d4f7 )

SignereServiceProvider::defineAssetPublishing() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like