CsvCombine\Form\CsvImportForm

Complexity

Total Complexity

15

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	_buildValidator()	0	4	1
C	loadDataCsv()	0	51	8
B	fgetcsv_reg()	0	24	6

<?php

namespace CsvCombine\Form;

use Cake\Form\Form;
use Cake\Validation\Validator;
use Cake\Utility\Hash;

class CsvImportForm extends Form
{


    protected function _buildValidator(Validator $validator)
    {
        return $validator;
    }

    /*
     * loadDataCsv CSV読み込みアクション
     *
     * @param string $fileName 固定長テキストファイ
     * @param array $column_list 各カラム情報(name:カラム名,length:バイト数)
     * @param string $delimiter 区切り文字(デフォルトは「,」)
     * @param string $array_encoding 出力するする配列のエンコード(デフォルトはUTF-8
     * @param string $import_encoding 入力するテキストのエンコード(デフォルトはSJIS-win
     */
    public function loadDataCsv($fileName, $column_list = array(), $delimiter = ",", $array_encoding = 'utf8',$import_encoding = 'sjis-win')
    {
        //保存をするのでモデルを読み込み
        try {
            $data = array();
            $csvData = array();
            $file = fopen($fileName,"r");
            while($data = $this->fgetcsv_reg($file,65536,$delimiter)){//CSVファイルを","区切りで配列に
                mb_convert_variables($array_encoding,$import_encoding,$data);
                $csvData[] = $data;
            }

            $i = 0;
            foreach ($csvData as $line) {
                $this_data = array();
                if (empty($column_list)) {
                    $this_column_list = array();
                    $line_count = 0;
                    foreach ($line as $line_v) {
                        $this_column_list[] = $line_count;
                        $line_count++;
                    }
                } else {
                    $this_column_list = $column_list;
                }
                foreach ($this_column_list as $k => $v) {
                    if (isset($line[$k])) {
                        //先頭と末尾の"を削除
                        $b = $line[$k];
                        //カラムの数だけセット
                        $this_data = Hash::merge(
                                        $this_data,
                                        array($v => $b)
                        );
                    } else {
                        $this_data = Hash::merge(
                                        $this_data,
                                        array($v => '')
                        );
                    }
                }

                $data[$i] = $this_data;
                $i++;
            }
        } catch (\Exception $e) {
            return false;
        }

        return $data;
    }

    /**
     * fgetcsv_reg
     *
     * this is a port of the original code written by yossy.
     *
     * @author yossy
     * @author hagiwara
     *
     * @param resource $handle
     * @param integer $length
     * @param string $d
     * @param string $e
     * @see http://yossy.iimp.jp/wp/?p=56
     * @return array
     */
    private function fgetcsv_reg (&$handle, $length = null, $d = ',', $e = '"')
    {
        $d = preg_quote($d);
        $e = preg_quote($e);
        $_line = "";
        $eof = false; // Added for PHP Warning.
        while ( $eof != true ) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison !== instead.

            $_line .= (empty($length) ? fgets($handle) : fgets($handle, $length));
            $itemcnt = preg_match_all('/'.$e.'/', $_line, $dummy);
            if ($itemcnt % 2 == 0) $eof = true;
        }
        $_csv_line = preg_replace('/(?:\\r\\n|[\\r\\n])?$/', $d, trim($_line));
        $_csv_pattern = '/('.$e.'[^'.$e.']*(?:'.$e.$e.'[^'.$e.']*)*'.$e.'|[^'.$d.']*)'.$d.'/';

        preg_match_all($_csv_pattern, $_csv_line, $_csv_matches);

        $_csv_data = $_csv_matches[1];

        for ( $_csv_i=0; $_csv_i<count($_csv_data); $_csv_i++ ) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $_csv_data[$_csv_i] = preg_replace('/^'.$e.'(.*)'.$e.'$/s', '$1', $_csv_data[$_csv_i]);
            $_csv_data[$_csv_i] = str_replace($e.$e, $e, $_csv_data[$_csv_i]);
        }
        return empty($_line) ? false : $_csv_data;
    }

}