ContentsFile\Model\Behavior\Traits\NormalContentsFileBehaviorTrait

Complexity

Total Complexity

16

Size/Duplication

Total Lines	94
Duplicated Lines	7.45 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	normalParamCheck()	0	12	4
B	normalFileSave()	7	25	6
B	normalFileDelete()	0	18	5
A	normalImageResize()	0	4	1

<?php

namespace ContentsFile\Model\Behavior\Traits;

use Cake\Core\Configure;
use Cake\Filesystem\Folder;
use Cake\Network\Exception\InternalErrorException;

/**
 * NormalContentsFileBehaviorTrait
 * 通常のファイルアップ系の処理
 * メソッド名の先頭に必ずnormalを付けること
 */
trait NormalContentsFileBehaviorTrait
{

    /**
     * normalParamCheck
     * 通常の設定値チェック
     * @author hagiwara
     */
    private function normalParamCheck()

This method is not used, and could be removed.

    {
        // S3に必要な設定がそろっているかチェックする
        $normalSetting = Configure::read('ContentsFile.Setting.Normal');
        if (
            !is_array($normalSetting) ||
            !array_key_exists('tmpDir', $normalSetting) ||
            !array_key_exists('fileDir', $normalSetting)
        ) {
            throw new InternalErrorException('contentsFileNormalConfig paramater shortage');
        }
    }

    /**
     * normalFileSave
     * ファイルを保存
     * @author hagiwara
     * @param array $fileInfo
     * @param array $fieldSettings
     * @param array $attachmentSaveData
     */
    private function normalFileSave($fileInfo, $fieldSettings, $attachmentSaveData)

This method is not used, and could be removed.

    {
        $newFiledir = Configure::read('ContentsFile.Setting.Normal.fileDir') . $attachmentSaveData['model'] . '/' . $attachmentSaveData['model_id'] . '/';
        $newFilepath = $newFiledir . $fileInfo['field_name'];
        if (
            !$this->mkdir($newFiledir, 0777, true) ||

It seems like mkdir() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            !rename(Configure::read('ContentsFile.Setting.Normal.tmpDir') . $fileInfo['tmp_file_name'], $newFilepath)
        ) {
            return false;
        }

        //リサイズディレクトリはまず削除する
        $Folder = new Folder($newFilepath);
        $Folder->delete();

        //リサイズ画像作成
        if (!empty($fieldSettings['resize'])) {

This code seems to be duplicated across your project.

            foreach ($fieldSettings['resize'] as $resizeSettings) {
                if (!$this->normalImageResize($newFilepath, $resizeSettings)) {
                    return false;
                }
            }
        }
        return true;
    }

    /**
     * normalFileDelete
     * 通常のファイル削除
     * @author hagiwara
     * @param string $modelName
     * @param integer $modelId
     * @param string $field
     */
    private function normalFileDelete($modelName, $modelId, $field)

This method is not used, and could be removed.

    {
        // リサイズのディレクトリ
        $resizeDir = Configure::read('ContentsFile.Setting.Normal.fileDir') . $modelName . '/' . $modelId . '/' . 'contents_file_resize_' . $field . '/';
        if (is_dir($resizeDir)) {
            $deleteFolder = new Folder($resizeDir);
            if (!$deleteFolder->delete()) {
                return false;
            }
        }

        // 大元のファイル
        $deleteFile = Configure::read('ContentsFile.Setting.Normal.fileDir') . $modelName . '/' . $modelId . '/' . $field;
        if (file_exists($deleteFile) && !unlink($deleteFile)) {
            return false;
        }
        return true;
    }

    /**
     * normalImageResize
     * 通常のファイルのリサイズ
     * @author hagiwara
     * @param string $newFilepath
     * @param array $resizeSettings
     */
    private function normalImageResize($newFilepath, $resizeSettings)
    {
        return $this->imageResize($newFilepath, $resizeSettings);

The method imageResize() does not exist on ContentsFile\Model\Behavior\Traits\NormalContentsFileBehaviorTrait. Did you maybe mean normalImageResize()?

    }
}