S3ContentsFileBehaviorTrait::s3ParamCheck() - Code Metrics - Inspection of "Merge pull request #12 from satthi/3.0" - satthi/Contents-file - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 504b57...819fbf )

by satoru

created 2016-12-06 08:13 UTC

S3ContentsFileBehaviorTrait::s3ParamCheck() C

↳ Parent: S3ContentsFileBehaviorTrait

Complexity

Conditions	11
Paths	9

Size

Total Lines	28
Code Lines	17

Duplication

Lines	12
Ratio	42.86 %

Importance

Changes

Metric	Value
dl	12
loc	28
rs	5.2653
c	0
b	0
f	0
cc	11
eloc	17
nc	9
nop	0

How to fix Complexity

<?php

namespace ContentsFile\Model\Behavior\Traits;

use ContentsFile\Aws\S3;
use Cake\Core\Configure;
use Cake\Filesystem\Folder;
use Cake\I18n\Time;
use Cake\Network\Exception\InternalErrorException;
use Cake\Utility\Security;

/**
 * S3ContentsFileBehaviorTrait
 * 通常のファイルアップ系の処理
 * メソッド名の先頭に必ずs3を付けること
 */
trait S3ContentsFileBehaviorTrait
{

    /**
     * s3ParamCheck
     * 通常の設定値チェック
     * @author hagiwara
     */
    private function s3ParamCheck()

    {
        // S3に必要な設定がそろっているかチェックする
        $s3Setting = Configure::read('ContentsFile.Setting.S3');
        if (

            !is_array($s3Setting) ||
            !array_key_exists('key', $s3Setting) ||
            !array_key_exists('secret', $s3Setting) ||
            !array_key_exists('bucket', $s3Setting) ||
            !array_key_exists('tmpDir', $s3Setting) ||
            !array_key_exists('fileDir', $s3Setting) ||
            !array_key_exists('workingDir', $s3Setting)

        ) {
            throw new InternalErrorException('contentsFileS3Config paramater shortage');
        }

        // /が最後についていない場合はつける
        if (!preg_match('#/$#', $s3Setting['tmpDir'])) {
            Configure::write('ContentsFile.Setting.S3.tmpDir', $s3Setting['tmpDir'] . '/');
        }
        if (!preg_match('#/$#', $s3Setting['fileDir'])) {
            Configure::write('ContentsFile.Setting.S3.fileDir', $s3Setting['fileDir'] . '/');
        }
        if (!preg_match('#/$#', $s3Setting['workingDir'])) {
            Configure::write('ContentsFile.Setting.S3.workingDir', $s3Setting['workingDir'] . '/');
        }
    }

    /**
     * s3FileSave
     * ファイルをS3に保存
     * @author hagiwara
     * @param array $fileInfo
     * @param array $fieldSettings
     * @param array $attachmentSaveData
     */
    private function s3FileSave($fileInfo, $fieldSettings, $attachmentSaveData)

    {
        $S3 = new S3();
        $newFiledir = Configure::read('ContentsFile.Setting.S3.fileDir') . $attachmentSaveData['model'] . '/' . $attachmentSaveData['model_id'] . '/';
        $newFilepath = $newFiledir . $fileInfo['field_name'];
        $oldFilepath = Configure::read('ContentsFile.Setting.S3.tmpDir') . $fileInfo['tmp_file_name'];

        // tmpに挙がっているファイルを移
        if (!$S3->move($oldFilepath, $newFilepath)) {
            return false;
        }

        // リサイズディレクトリはまず削除する
        // 失敗=ディレクトリが存在しないため、成功失敗判定は行わない。
        $S3->deleteRecursive($newFilepath . '/' . 'contents_file_resize_' . $fileInfo['field_name']);

        //リサイズ画像作成
        if (!empty($fieldSettings['resize'])) {

            foreach ($fieldSettings['resize'] as $resizeSettings) {
                if (!$this->s3ImageResize($newFilepath, $resizeSettings)) {
                    return false;
                }
            }
        }
        return true;
    }

    /**
     * s3FileDelete
     * S3のファイル削除
     * @author hagiwara
     * @param string $modelName
     * @param integer $modelId
     * @param string $field
     */
    private function s3FileDelete($modelName, $modelId, $field)

    {
        $S3 = new S3();
        // リサイズのディレクトリ
        $resizeDir = Configure::read('ContentsFile.Setting.S3.fileDir') . $modelName . '/' . $modelId . '/' . 'contents_file_resize_' . $field . '/';
        if (!$S3->deleteRecursive($resizeDir)) {
            return false;
        }

        // 大元のファイル
        $deleteFile = Configure::read('ContentsFile.Setting.S3.fileDir') . $modelName . '/' . $modelId . '/' . $field;
        if (!$S3->delete($deleteFile)) {
            return false;
        }
        return true;
    }

    /**
     * s3ImageResize
     * 画像のリサイズ処理(S3用)
     * @author hagiwara
     * @param string $filepath
     * @param array $resize
     */
    public function s3ImageResize($filepath, $resize)
    {
        $imagepathinfo = $this->getPathinfo($filepath, $resize);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $S3 = new S3();
        // Exception = 存在していない場合
        $tmpFileName = Security::hash(rand() . Time::now()->i18nFormat('YYYY/MM/dd HH:ii:ss'));
        $tmpPath = Configure::read('ContentsFile.Setting.S3.workingDir') . $tmpFileName;
        // ベースのファイルを取得
        $baseObject = $S3->download($filepath);
        $fp = fopen($tmpPath, 'w');
        fwrite($fp, $baseObject['Body']);
        fclose($fp);
        if (!$this->imageResize($tmpPath, $resize)) {

            //失敗時はそのままのパスを返す(画像以外の可能性あり)
            unlink($tmpPath);
            return $filepath;
        }
        $resizeFileDir = Configure::read('ContentsFile.Setting.S3.workingDir') . 'contents_file_resize_' . $tmpFileName;
        $resizeFolder = new Folder($resizeFileDir);
        // 一つのはず
        $resizeImg = $resizeFolder->findRecursive()[0];

        // リサイズ画像をアップロード
        $S3->upload($resizeImg, $imagepathinfo['resize_filepath']);

        // tmpディレクトリの不要なディレクトリ/ファイルを削除
        $resizeFolder->delete();
        unlink($tmpPath);
        return $imagepathinfo['resize_filepath'];
    }

}


1		<?php
2
3		namespace ContentsFile\Model\Behavior\Traits;
4
5		use ContentsFile\Aws\S3;
6		use Cake\Core\Configure;
7		use Cake\Filesystem\Folder;
8		use Cake\I18n\Time;
9		use Cake\Network\Exception\InternalErrorException;
10		use Cake\Utility\Security;
11
12		/**
13		* S3ContentsFileBehaviorTrait
14		* 通常のファイルアップ系の処理
15		* メソッド名の先頭に必ずs3を付けること
16		*/
17		trait S3ContentsFileBehaviorTrait
18		{
19
20		/**
21		* s3ParamCheck
22		* 通常の設定値チェック
23		* @author hagiwara
24		*/
25		private function s3ParamCheck()
		0 ignored issues – show Unused Code introduced 2016-11-09 10:26 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
26		{
27		// S3に必要な設定がそろっているかチェックする
28		$s3Setting = Configure::read('ContentsFile.Setting.S3');
29	View Code Duplication	if (
		0 ignored issues – show Duplication introduced 2016-11-09 10:26 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		!is_array($s3Setting) \|\|
31		!array_key_exists('key', $s3Setting) \|\|
32		!array_key_exists('secret', $s3Setting) \|\|
33		!array_key_exists('bucket', $s3Setting) \|\|
34		!array_key_exists('tmpDir', $s3Setting) \|\|
35		!array_key_exists('fileDir', $s3Setting) \|\|
36		!array_key_exists('workingDir', $s3Setting)
37
38		) {
39		throw new InternalErrorException('contentsFileS3Config paramater shortage');
40		}
41
42		// /が最後についていない場合はつける
43		if (!preg_match('#/$#', $s3Setting['tmpDir'])) {
44		Configure::write('ContentsFile.Setting.S3.tmpDir', $s3Setting['tmpDir'] . '/');
45		}
46		if (!preg_match('#/$#', $s3Setting['fileDir'])) {
47		Configure::write('ContentsFile.Setting.S3.fileDir', $s3Setting['fileDir'] . '/');
48		}
49		if (!preg_match('#/$#', $s3Setting['workingDir'])) {
50		Configure::write('ContentsFile.Setting.S3.workingDir', $s3Setting['workingDir'] . '/');
51		}
52		}
53
54		/**
55		* s3FileSave
56		* ファイルをS3に保存
57		* @author hagiwara
58		* @param array $fileInfo
59		* @param array $fieldSettings
60		* @param array $attachmentSaveData
61		*/
62		private function s3FileSave($fileInfo, $fieldSettings, $attachmentSaveData)
		0 ignored issues – show Unused Code introduced 2016-11-09 10:26 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
63		{
64		$S3 = new S3();
65		$newFiledir = Configure::read('ContentsFile.Setting.S3.fileDir') . $attachmentSaveData['model'] . '/' . $attachmentSaveData['model_id'] . '/';
66		$newFilepath = $newFiledir . $fileInfo['field_name'];
67		$oldFilepath = Configure::read('ContentsFile.Setting.S3.tmpDir') . $fileInfo['tmp_file_name'];
68
69		// tmpに挙がっているファイルを移
70		if (!$S3->move($oldFilepath, $newFilepath)) {
71		return false;
72		}
73
74		// リサイズディレクトリはまず削除する
75		// 失敗=ディレクトリが存在しないため、成功失敗判定は行わない。
76		$S3->deleteRecursive($newFilepath . '/' . 'contents_file_resize_' . $fileInfo['field_name']);
77
78		//リサイズ画像作成
79	View Code Duplication	if (!empty($fieldSettings['resize'])) {
		0 ignored issues – show Duplication introduced 2016-11-09 10:26 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80		foreach ($fieldSettings['resize'] as $resizeSettings) {
81		if (!$this->s3ImageResize($newFilepath, $resizeSettings)) {
82		return false;
83		}
84		}
85		}
86		return true;
87		}
88
89		/**
90		* s3FileDelete
91		* S3のファイル削除
92		* @author hagiwara
93		* @param string $modelName
94		* @param integer $modelId
95		* @param string $field
96		*/
97		private function s3FileDelete($modelName, $modelId, $field)
		0 ignored issues – show Unused Code introduced 2016-11-09 10:26 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
98		{
99		$S3 = new S3();
100		// リサイズのディレクトリ
101		$resizeDir = Configure::read('ContentsFile.Setting.S3.fileDir') . $modelName . '/' . $modelId . '/' . 'contents_file_resize_' . $field . '/';
102		if (!$S3->deleteRecursive($resizeDir)) {
103		return false;
104		}
105
106		// 大元のファイル
107		$deleteFile = Configure::read('ContentsFile.Setting.S3.fileDir') . $modelName . '/' . $modelId . '/' . $field;
108		if (!$S3->delete($deleteFile)) {
109		return false;
110		}
111		return true;
112		}
113
114		/**
115		* s3ImageResize
116		* 画像のリサイズ処理(S3用)
117		* @author hagiwara
118		* @param string $filepath
119		* @param array $resize
120		*/
121		public function s3ImageResize($filepath, $resize)
122		{
123		$imagepathinfo = $this->getPathinfo($filepath, $resize);
		0 ignored issues – show Bug introduced 2016-11-09 10:26 UTC by Report Bug Copy Issue Report It seems like `getPathinfo()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
124		$S3 = new S3();
125		// Exception = 存在していない場合
126		$tmpFileName = Security::hash(rand() . Time::now()->i18nFormat('YYYY/MM/dd HH:ii:ss'));
127		$tmpPath = Configure::read('ContentsFile.Setting.S3.workingDir') . $tmpFileName;
128		// ベースのファイルを取得
129		$baseObject = $S3->download($filepath);
130		$fp = fopen($tmpPath, 'w');
131		fwrite($fp, $baseObject['Body']);
132		fclose($fp);
133		if (!$this->imageResize($tmpPath, $resize)) {
		0 ignored issues – show Bug introduced 2016-11-09 10:26 UTC by Report Bug Copy Issue Report The method `imageResize()` does not exist on `ContentsFile\Model\Behav...ntentsFileBehaviorTrait`. Did you maybe mean `s3ImageResize()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
134		//失敗時はそのままのパスを返す(画像以外の可能性あり)
135		unlink($tmpPath);
136		return $filepath;
137		}
138		$resizeFileDir = Configure::read('ContentsFile.Setting.S3.workingDir') . 'contents_file_resize_' . $tmpFileName;
139		$resizeFolder = new Folder($resizeFileDir);
140		// 一つのはず
141		$resizeImg = $resizeFolder->findRecursive()[0];
142
143		// リサイズ画像をアップロード
144		$S3->upload($resizeImg, $imagepathinfo['resize_filepath']);
145
146		// tmpディレクトリの不要なディレクトリ/ファイルを削除
147		$resizeFolder->delete();
148		unlink($tmpPath);
149		return $imagepathinfo['resize_filepath'];
150		}
151
152		}
153

satthi / Contents-file

Push — master ( 504b57...819fbf )

S3ContentsFileBehaviorTrait::s3ParamCheck() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like