ContentsFileHelper::makeStaticS3Url() - Code Metrics - Inspection of "Helperに静的ホスティング用のURL発行を追加" - satthi/Contents-file - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — s3_upload (82f26a)

by satoru

created 2016-11-10 02:54 UTC

ContentsFileHelper::makeStaticS3Url() B

↳ Parent: ContentsFileHelper

Complexity

Conditions	4
Paths	5

Size

Total Lines	26
Code Lines	19

Duplication

Lines	14
Ratio	53.85 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	14
loc	26
rs	8.5806
cc	4
eloc	19
nc	5
nop	1

<?php

namespace ContentsFile\View\Helper;

use Cake\Core\Configure;
use Cake\View\Helper;

class ContentsFileHelper extends Helper {

    public $helpers = ['Html', 'Url'];
    private $defaultOption = [
        'target' => '_blank',
        'escape' => false
    ];

    /**
     * link
     * @author hagiwara
     * @param array $fileInfo
     * @param array $options
     * @param string $title
     */
    public function link($fileInfo, $options = [], $title = null)
    {
        //一時パス用の設定
        if ($title === null) {
            $title = $fileInfo['file_name'];
        }
        if (isset($options['resize'])) {
            $fileInfo['resize'] = $options['resize'];
            unset($options['resize']);
        }
        $options = array_merge(
            $this->defaultOption,
            $options
        );

        return $this->Html->link(
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $title,
            $this->urlArray($fileInfo, $options),
            $options
        );
    }

    /**
     * image
     * @author hagiwara
     * @param array $fileInfo
     * @param array $options
     */
    public function image($fileInfo, $options = [])
    {
        if (!empty($fileInfo)) {
            if (isset($options['resize'])) {
                $fileInfo['resize'] = $options['resize'];
                unset($options['resize']);
            }
            return $this->Html->image($this->urlArray($fileInfo, $options), $options);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return '';
    }

    /**
     * url
     * @author hagiwara
     * @param array $fileInfo
     * @param boolean $full
     * @param array $options
     */
    public function url($fileInfo, $full = false, $options = [])
    {
        if (!isset($fileInfo['resize'])) {
            $fileInfo['resize'] = false;
        }
        return $this->Url->build($this->urlArray($fileInfo, $options), $full);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * urlArray
     * @author hagiwara
     * @param array $fileInfo
     */
    private function urlArray($fileInfo, $options)
    {
        if (!empty($fileInfo['tmp_file_name'])) {
            return [
                'controller' => 'contents_file',
                'action' => 'loader',
                'plugin' => 'ContentsFile',
                'model' => $fileInfo['model'],
                'field_name' => $fileInfo['field_name'],
                'tmp_file_name' => $fileInfo['tmp_file_name'],
            ];
        } else {
            if (!isset($fileInfo['resize'])) {
                $fileInfo['resize'] = false;
            }
            // S3のホスティングの場合
            if (
                array_key_exists('static_s3', $options) &&
                $options['static_s3'] == true &&
                Configure::read('ContentsFile.Setting.type') == 's3' &&
                !is_null(Configure::read('ContentsFile.Setting.S3.static_domain'))
            ) {
                return $this->makeStaticS3Url($fileInfo);
            } else {
                // loaderを通す場合
                return [
                    'controller' => 'contents_file',
                    'action' => 'loader',
                    'plugin' => 'ContentsFile',
                    'model' => $fileInfo['model'],
                    'field_name' => $fileInfo['field_name'],
                    'model_id' => $fileInfo['model_id'],
                    'resize' => $fileInfo['resize'],
                ];
            }
        }
    }

    /**
     * makeStaticS3Url
     * 静的ホスティング用のURL作成
     * @author hagiwara
     * @param array $fileInfo
     */
    private function makeStaticS3Url($fileInfo)
    {
        $staticS3Url = Configure::read('ContentsFile.Setting.S3.static_domain') . '/' . Configure::read('ContentsFile.Setting.S3.fileDir') . '/' . $fileInfo['model'] . '/' . $fileInfo['model_id'] . '/';
        if ($fileInfo['resize'] == false) {
            $staticS3Url .= $fileInfo['field_name'];
        } else {
            $resizeText = '';
            if (

                empty($fileInfo['resize']['width'])
            ) {
                $resizeText .= '0';
            } else {
                $resizeText .= $fileInfo['resize']['width'];
            }
            $resizeText .= '_';
            if (

                empty($fileInfo['resize']['height'])
            ) {
                $resizeText .= '0';
            } else {
                $resizeText .= $fileInfo['resize']['height'];
            }
            $staticS3Url .= 'contents_file_resize_' . $fileInfo['field_name'] . '/' . $resizeText;
        }
        return $staticS3Url;
    }
}


1		<?php
2
3		namespace ContentsFile\View\Helper;
4
5		use Cake\Core\Configure;
6		use Cake\View\Helper;
7
8		class ContentsFileHelper extends Helper {
9
10		public $helpers = ['Html', 'Url'];
11		private $defaultOption = [
12		'target' => '_blank',
13		'escape' => false
14		];
15
16		/**
17		* link
18		* @author hagiwara
19		* @param array $fileInfo
20		* @param array $options
21		* @param string $title
22		*/
23		public function link($fileInfo, $options = [], $title = null)
24		{
25		//一時パス用の設定
26		if ($title === null) {
27		$title = $fileInfo['file_name'];
28		}
29		if (isset($options['resize'])) {
30		$fileInfo['resize'] = $options['resize'];
31		unset($options['resize']);
32		}
33		$options = array_merge(
34		$this->defaultOption,
35		$options
36		);
37
38		return $this->Html->link(
		0 ignored issues – show Documentation introduced 2016-11-09 10:12 UTC by Report Bug Copy Issue Report The property `Html` does not exist on `object<ContentsFile\View...per\ContentsFileHelper>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
39		$title,
40		$this->urlArray($fileInfo, $options),
41		$options
42		);
43		}
44
45		/**
46		* image
47		* @author hagiwara
48		* @param array $fileInfo
49		* @param array $options
50		*/
51		public function image($fileInfo, $options = [])
52		{
53		if (!empty($fileInfo)) {
54		if (isset($options['resize'])) {
55		$fileInfo['resize'] = $options['resize'];
56		unset($options['resize']);
57		}
58		return $this->Html->image($this->urlArray($fileInfo, $options), $options);
		0 ignored issues – show Documentation introduced 2016-11-09 10:26 UTC by Report Bug Copy Issue Report The property `Html` does not exist on `object<ContentsFile\View...per\ContentsFileHelper>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
59		}
60		return '';
61		}
62
63		/**
64		* url
65		* @author hagiwara
66		* @param array $fileInfo
67		* @param boolean $full
68		* @param array $options
69		*/
70		public function url($fileInfo, $full = false, $options = [])
71		{
72		if (!isset($fileInfo['resize'])) {
73		$fileInfo['resize'] = false;
74		}
75		return $this->Url->build($this->urlArray($fileInfo, $options), $full);
		0 ignored issues – show Documentation introduced 2016-11-09 10:26 UTC by Report Bug Copy Issue Report The property `Url` does not exist on `object<ContentsFile\View...per\ContentsFileHelper>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
76		}
77
78		/**
79		* urlArray
80		* @author hagiwara
81		* @param array $fileInfo
82		*/
83		private function urlArray($fileInfo, $options)
84		{
85		if (!empty($fileInfo['tmp_file_name'])) {
86		return [
87		'controller' => 'contents_file',
88		'action' => 'loader',
89		'plugin' => 'ContentsFile',
90		'model' => $fileInfo['model'],
91		'field_name' => $fileInfo['field_name'],
92		'tmp_file_name' => $fileInfo['tmp_file_name'],
93		];
94		} else {
95		if (!isset($fileInfo['resize'])) {
96		$fileInfo['resize'] = false;
97		}
98		// S3のホスティングの場合
99		if (
100		array_key_exists('static_s3', $options) &&
101		$options['static_s3'] == true &&
102		Configure::read('ContentsFile.Setting.type') == 's3' &&
103		!is_null(Configure::read('ContentsFile.Setting.S3.static_domain'))
104		) {
105		return $this->makeStaticS3Url($fileInfo);
106		} else {
107		// loaderを通す場合
108		return [
109		'controller' => 'contents_file',
110		'action' => 'loader',
111		'plugin' => 'ContentsFile',
112		'model' => $fileInfo['model'],
113		'field_name' => $fileInfo['field_name'],
114		'model_id' => $fileInfo['model_id'],
115		'resize' => $fileInfo['resize'],
116		];
117		}
118		}
119		}
120
121		/**
122		* makeStaticS3Url
123		* 静的ホスティング用のURL作成
124		* @author hagiwara
125		* @param array $fileInfo
126		*/
127		private function makeStaticS3Url($fileInfo)
128		{
129		$staticS3Url = Configure::read('ContentsFile.Setting.S3.static_domain') . '/' . Configure::read('ContentsFile.Setting.S3.fileDir') . '/' . $fileInfo['model'] . '/' . $fileInfo['model_id'] . '/';
130		if ($fileInfo['resize'] == false) {
131		$staticS3Url .= $fileInfo['field_name'];
132		} else {
133		$resizeText = '';
134	View Code Duplication	if (
		0 ignored issues – show Duplication introduced 2016-11-10 02:56 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
135		empty($fileInfo['resize']['width'])
136		) {
137		$resizeText .= '0';
138		} else {
139		$resizeText .= $fileInfo['resize']['width'];
140		}
141		$resizeText .= '_';
142	View Code Duplication	if (
		0 ignored issues – show Duplication introduced 2016-11-10 02:56 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
143		empty($fileInfo['resize']['height'])
144		) {
145		$resizeText .= '0';
146		} else {
147		$resizeText .= $fileInfo['resize']['height'];
148		}
149		$staticS3Url .= 'contents_file_resize_' . $fileInfo['field_name'] . '/' . $resizeText;
150		}
151		return $staticS3Url;
152		}
153		}
154

satthi / Contents-file

Branch — s3_upload (82f26a)

ContentsFileHelper::makeStaticS3Url() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like