CrudTrait::createTagFromString() - Code Metrics - Inspection of "Change: several changes to rebuild tag implementat..." - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 46ec4b...680621 )

by Mohamed

created 2016-05-04 10:51 UTC

CrudTrait::createTagFromString() A

↳ Parent: CrudTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
ccs	0
cts	6
cp	0
rs	9.4285
cc	2
eloc	6
nc	2
nop	1
crap	6

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Model\Traits\Tag;

use Illuminate\Database\Eloquent;
use Tinyissue\Model\Tag;

/**
 * CrudTrait is trait class containing the methods for adding/editing/deleting the Tag model.
 *
 * @author Mohamed Alsharaf <[email protected]>
 *
 * @method Eloquent\Model where($column, $operator = null, $value = null, $boolean = 'and')
 */
trait CrudTrait
{
    /**
     * Create a new tag.
     *
     * @param array $input
     *
     * @return mixed
     */
    public function createTag(array $input)
    {
        return $this->fill($this->prepareTagToSave($input))->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Update the tags in the database.
     *
     * @param array $attributes
     *
     * @return bool|int
     */
    public function update(array $attributes = [])
    {
        return parent::update($this->prepareTagToSave($attributes));
    }

    /**
     * Create a new tag if valid or return existing one.
     *
     * @param string   $name
     * @param null|Tag $parent
     *
     * @return bool|$this
     */
    public function validOrCreate($name, Tag $parent = null)
    {
        $group = $parent === null ? true : false;
        $tag   = $this->where('name', '=', $name)->first();
        if ($tag && $tag->group != $group) {
            return false;
        }

        if (!$tag) {
            $tag        = new Tag();
            $tag->name  = $name;
            $tag->group = $group;
            if (!is_null($parent)) {
                $tag->parent_id = $parent->id;
                $tag->setRelation('parent', $parent);
            }
            $tag->save();
        }

        return $tag;
    }

    /**
     * Prepare tag details to save.
     *
     * @param array $input
     *
     * @return array
     */
    protected function prepareTagToSave(array $input)
    {
        $input['group'] = 0;

        return $input;
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Model\Traits\Tag;
13
14		use Illuminate\Database\Eloquent;
15		use Tinyissue\Model\Tag;
16
17		/**
18		* CrudTrait is trait class containing the methods for adding/editing/deleting the Tag model.
19		*
20		* @author Mohamed Alsharaf <[email protected]>
21		*
22		* @method Eloquent\Model where($column, $operator = null, $value = null, $boolean = 'and')
23		*/
24		trait CrudTrait
25		{
26		/**
27		* Create a new tag.
28		*
29		* @param array $input
30		*
31		* @return mixed
32		*/
33	1	public function createTag(array $input)
34		{
35	1	return $this->fill($this->prepareTagToSave($input))->save();
		0 ignored issues – show Bug introduced 2016-03-07 09:48 UTC by Report Bug Copy Issue Report It seems like `fill()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36		}
37
38		/**
39		* Update the tags in the database.
40		*
41		* @param array $attributes
42		*
43		* @return bool\|int
44		*/
45		public function update(array $attributes = [])
46		{
47		return parent::update($this->prepareTagToSave($attributes));
48		}
49
50		/**
51		* Create a new tag if valid or return existing one.
52		*
53		* @param string $name
54		* @param null\|Tag $parent
55		*
56		* @return bool\|$this
57		*/
58		public function validOrCreate($name, Tag $parent = null)
59		{
60		$group = $parent === null ? true : false;
61		$tag = $this->where('name', '=', $name)->first();
62		if ($tag && $tag->group != $group) {
63		return false;
64		}
65
66		if (!$tag) {
67		$tag = new Tag();
68		$tag->name = $name;
69		$tag->group = $group;
70		if (!is_null($parent)) {
71		$tag->parent_id = $parent->id;
72		$tag->setRelation('parent', $parent);
73		}
74		$tag->save();
75		}
76
77		return $tag;
78		}
79
80		/**
81		* Prepare tag details to save.
82		*
83		* @param array $input
84		*
85		* @return array
86		*/
87		protected function prepareTagToSave(array $input)
88		{
89		$input['group'] = 0;
90
91		return $input;
92		}
93		}
94

satrun77 / tinyissue

Push — develop ( 46ec4b...680621 )

CrudTrait::createTagFromString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like