Tag::toArray() - Code Metrics - Inspection of "Change: several changes to rebuild tag implementat..." - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 46ec4b...680621 )

by Mohamed

created 2016-05-04 10:51 UTC

Tag::toArray() A

↳ Parent: Tag

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	0
cts	2
cp	0
rs	9.4285
cc	1
eloc	5
nc	1
nop	0
crap	2

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Model;

use Illuminate\Database\Eloquent\Model;

/**
 * Tag is model class for tags.
 *
 * @author Mohamed Alsharaf <[email protected]>
 *
 * @property int     $id
 * @property int     $parent_id
 * @property string  $name
 * @property string  $fullname
 * @property string  $bgcolor
 * @property bool $group
 * @property Tag     $parent
 */
class Tag extends Model
{
    use Traits\Tag\CrudTrait,
        Traits\Tag\QueryTrait,
        Traits\Tag\RelationTrait,
        Traits\Tag\CountTrait;

    /**
     * Core tag: Open.
     *
     * @var string
     */
    const STATUS_OPEN = 'open';

    /**
     * Core tag: Closed.
     *
     * @var string
     */
    const STATUS_CLOSED = 'closed';

    /**
     * Core tag group: Status.
     *
     * @var string
     */
    const GROUP_STATUS = 'status';

    /**
     * Timestamp enabled.
     *
     * @var bool
     */
    public $timestamps = true;

    /**
     * List of allowed columns to be used in $this->fill().
     *
     * @var array
     */
    public $fillable = ['parent_id', 'name', 'bgcolor', 'group', 'role_limit'];

    /**
     * Name of database table.
     *
     * @var string
     */
    protected $table = 'tags';

    /**
     * Generate a URL for the tag.
     *
     * @param string $url
     *
     * @return mixed
     */
    public function to($url)
    {
        return \URL::to('administration/tag/' . $this->id . (($url) ? '/' . $url : ''));
    }

    /**
     * Returns tag full name with prefix group name and ":" in between.
     *
     * @return string
     */
    public function getFullNameAttribute()
    {
        return ucwords($this->attributes['name']);
    }

    /**
     * Whether or not the current user can view this tag
     *
     * @return bool
     */
    public function canView()
    {
        return auth()->user()->role_id >= $this->role_limit;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * Return an array of tag details.
     *
     * @return array
     */
    public function toArray()
    {
        return [
            'id'      => $this->id,
            'name'    => $this->fullname,
            'bgcolor' => $this->bgcolor,
        ];
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Model;
13
14		use Illuminate\Database\Eloquent\Model;
15
16		/**
17		* Tag is model class for tags.
18		*
19		* @author Mohamed Alsharaf <[email protected]>
20		*
21		* @property int $id
22		* @property int $parent_id
23		* @property string $name
24		* @property string $fullname
25		* @property string $bgcolor
26		* @property bool $group
27		* @property Tag $parent
28		*/
29		class Tag extends Model
30		{
31		use Traits\Tag\CrudTrait,
32		Traits\Tag\QueryTrait,
33		Traits\Tag\RelationTrait,
34		Traits\Tag\CountTrait;
35
36		/**
37		* Core tag: Open.
38		*
39		* @var string
40		*/
41		const STATUS_OPEN = 'open';
42
43		/**
44		* Core tag: Closed.
45		*
46		* @var string
47		*/
48		const STATUS_CLOSED = 'closed';
49
50		/**
51		* Core tag group: Status.
52		*
53		* @var string
54		*/
55		const GROUP_STATUS = 'status';
56
57		/**
58		* Timestamp enabled.
59		*
60		* @var bool
61		*/
62		public $timestamps = true;
63
64		/**
65		* List of allowed columns to be used in $this->fill().
66		*
67		* @var array
68		*/
69		public $fillable = ['parent_id', 'name', 'bgcolor', 'group', 'role_limit'];
70
71		/**
72		* Name of database table.
73		*
74		* @var string
75		*/
76		protected $table = 'tags';
77
78		/**
79		* Generate a URL for the tag.
80		*
81		* @param string $url
82		*
83		* @return mixed
84		*/
85		public function to($url)
86	2	{
87		return \URL::to('administration/tag/' . $this->id . (($url) ? '/' . $url : ''));
88	2	}
89
90		/**
91		* Returns tag full name with prefix group name and ":" in between.
92		*
93		* @return string
94		*/
95		public function getFullNameAttribute()
96	30	{
97		return ucwords($this->attributes['name']);
98	30	}
99
100		/**
101		* Whether or not the current user can view this tag
102		*
103		* @return bool
104		*/
105		public function canView()
106	7	{
107		return auth()->user()->role_id >= $this->role_limit;
		0 ignored issues – show Bug introduced 2016-05-02 10:04 UTC by Report Bug Copy Issue Report Accessing `role_id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Documentation introduced 2016-05-02 10:04 UTC by Report Bug Copy Issue Report The property `role_limit` does not exist on `object<Tinyissue\Model\Tag>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
108	7	}
109
110		/**
111		* Return an array of tag details.
112		*
113		* @return array
114		*/
115		public function toArray()
116		{
117		return [
118		'id' => $this->id,
119		'name' => $this->fullname,
120		'bgcolor' => $this->bgcolor,
121		];
122		}
123		}
124

satrun77 / tinyissue

Push — develop ( 46ec4b...680621 )

Tag::toArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like