Completed
Push — develop ( 688bc1...4964b4 )
by Mohamed
07:24
created

QueryTrait   A

Complexity

Total Complexity 15

Size/Duplication

Total Lines 186
Duplicated Lines 3.23 %

Coupling/Cohesion

Components 3
Dependencies 4

Test Coverage

Coverage 60.56%

Importance

Changes 15
Bugs 2 Features 2
Metric Value
wmc 15
c 15
b 2
f 2
lcom 3
cbo 4
dl 6
loc 186
ccs 43
cts 71
cp 0.6056
rs 10

9 Methods

Rating   Name   Duplication   Size   Complexity  
A publicProjects() 0 6 1
B projectsWidthIssues() 6 25 3
A activeProjects() 0 6 1
A usersNotIn() 0 11 2
B listIssues() 0 29 3
A listAssignedOrCreatedIssues() 0 11 2
A getKanbanTagsForUser() 0 11 1
A issuesGroupByTags() 0 15 1
A usersCanFixIssue() 0 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
/*
4
 * This file is part of the Tinyissue package.
5
 *
6
 * (c) Mohamed Alsharaf <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace Tinyissue\Model\Traits\Project;
13
14
use Illuminate\Database\Eloquent;
15
use Illuminate\Database\Eloquent\Relations;
16
use Illuminate\Database\Eloquent\Relations\Relation;
17
use Illuminate\Database\Query;
18
use Tinyissue\Model\Project;
19
use Tinyissue\Model\Role;
20
use Tinyissue\Model\User;
21
22
/**
23
 * QueryTrait is trait class containing the database queries methods for the Project model.
24
 *
25
 * @author Mohamed Alsharaf <[email protected]>
26
 *
27
 * @property int $id
28
 *
29
 * @method   Eloquent\Model      where($column, $operator = null, $value = null, $boolean = 'and')
30
 * @method   Query\Builder       join($table, $one, $operator = null, $two = null, $type = 'inner', $where = false)
31
 * @method   Relations\HasMany   users()
32
 * @method   Relations\HasMany   issues()
33
 * @method   void                filterAssignTo(Query\Builder $query, $userId)
34
 * @method   void                filterTitleOrBody(Query\Builder $query, $keyword)
35
 * @method   void                filterTags(Eloquent\Builder $query, array $tags)
36
 * @method   void                sortByUpdated(Query\Builder $query, $order = 'asc')
37
 * @method   Eloquent\Collection sortByTag(Query\Builder $query, $tagGroup, $order = 'asc')
38
 */
39
trait QueryTrait
40
{
41
    /**
42
     * Returns collection of active projects.
43
     *
44
     * @return Eloquent\Collection
45
     */
46
    public static function activeProjects()
47
    {
48
        return static::where('status', '=', Project::STATUS_OPEN)
49
            ->orderBy('name', 'ASC')
50
            ->get();
51
    }
52
53
    /**
54
     * Returns collection of public projects.
55
     *
56
     * @return Eloquent\Collection
57
     */
58
    public function publicProjects()
59
    {
60
        return $this->where('private', '=', Project::PRIVATE_NO)
61
            ->orderBy('name', 'ASC')
62
            ->get();
63
    }
64
65
    /**
66
     * Returns all users that are not assigned in the current project.
67
     *
68
     * @return array
69
     */
70 1
    public function usersNotIn()
71
    {
72 1
        if ($this->id > 0) {
73
            $userIds = $this->users()->lists('user_id')->all();
74
            $users   = User::where('deleted', '=', User::NOT_DELETED_USERS)->whereNotIn('id', $userIds)->get();
75
        } else {
76 1
            $users = User::where('deleted', '=', User::NOT_DELETED_USERS)->get();
77
        }
78
79 1
        return $users->lists('fullname', 'id')->all();
80
    }
81
82
    /**
83
     * Fetch and filter issues in the project.
84
     *
85
     * @param int   $status
86
     * @param array $filter
87
     *
88
     * @return \Illuminate\Database\Eloquent\Collection
89
     */
90 2
    public function listIssues($status = Project\Issue::STATUS_OPEN, array $filter = [])
91
    {
92 2
        $sortOrder = array_get($filter, 'sort.sortorder', 'desc');
93 2
        $sortBy    = array_get($filter, 'sort.sortby', null);
94
95 2
        $query = $this->issues()
96 2
            ->with('countComments', 'user', 'updatedBy', 'tags', 'tags.parent')
97 2
            ->with([
98
                'tags' => function (Relation $query) use ($sortOrder) {
99 2
                    $query->orderBy('name', $sortOrder);
100 2
                },
101
            ])
102 2
            ->where('status', '=', $status);
103
104
        // Filter issues
105 2
        $this->filterAssignTo($query, array_get($filter, 'assignto'));
106 2
        $this->filterTitleOrBody($query, array_get($filter, 'keyword'));
107 2
        $this->filterTags($query, array_get($filter, 'tag_status'));
108 2
        $this->filterTags($query, array_get($filter, 'tag_type'));
109
110
        // Sort
111 2
        if ($sortBy == 'updated') {
112
            $this->sortByUpdated($query, $sortOrder);
113 2
        } elseif (($tagGroup = substr($sortBy, strlen('tag:'))) > 0) {
114
            return $this->sortByTag($query, $tagGroup, $sortOrder);
115
        }
116
117 2
        return $query->get();
118
    }
119
120
    /**
121
     * Fetch issues assigned to a user.
122
     *
123
     * @param User $user
124
     *
125
     * @return \Illuminate\Database\Eloquent\Collection
126
     */
127 1
    public function listAssignedOrCreatedIssues(User $user)
128
    {
129 1
        $assignedOrCreate = $user->isUser()? 'created_by' : 'assigned_to';
130
131 1
        return $this->issues()
132 1
            ->with('countComments', 'user', 'updatedBy')
133 1
            ->where('status', '=', Project\Issue::STATUS_OPEN)
134 1
            ->where($assignedOrCreate, '=', $user->id)
135 1
            ->orderBy('updated_at', 'DESC')
136 1
            ->get();
137
    }
138
139
    /**
140
     * Returns projects with issues details eager loaded.
141
     *
142
     * @param int $status
143
     * @param int $private
144
     *
145
     * @return Relations\HasMany
146
     */
147 4
    public function projectsWidthIssues($status = Project::STATUS_OPEN, $private = Project::PRIVATE_NO)
148
    {
149
        $query = $this
150 4
            ->where('status', '=', $status)
151 4
            ->orderBy('name');
152
153 4
        if ($private !== Project::PRIVATE_ALL) {
154 4
            $query->where('private', '=', $private);
155
        }
156
157 4
        $query->with([
158 View Code Duplication
            'issues' => function (Relations\Relation $query) use ($status) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
159 3
                $query->with('updatedBy');
160 3
                if ($status === Project::STATUS_OPEN) {
161 3
                    $query->where('status', '=', Project\Issue::STATUS_OPEN);
162
                }
163 4
            },
164
            'issues.user' => function () {
165 4
            },
166
            'issues.countComments' => function () {
167 4
            },
168
        ]);
169
170 4
        return $query;
171
    }
172
173
    /**
174
     * Returns collection of tags for Kanban view.
175
     *
176
     * @param User $user
177
     *
178
     * @return mixed
179
     */
180
    public function getKanbanTagsForUser(User $user)
181
    {
182
        $tags = $this->kanbanTags()
0 ignored issues
show
Bug introduced by
The method kanbanTags() does not exist on Tinyissue\Model\Traits\Project\QueryTrait. Did you maybe mean getKanbanTagsForUser()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
183
            ->where(function (Eloquent\Builder $query) use ($user) {
184
                $query->where('role_limit', '<=', $user->role_id);
185
                $query->orWhere('role_limit', '=', null);
186
            })
187
            ->get();
188
189
        return $tags;
190
    }
191
192
    /**
193
     * Returns collection of issues grouped by tags.
194
     *
195
     * @param $tagIds
196
     *
197
     * @return mixed
198
     */
199
    public function issuesGroupByTags($tagIds)
200
    {
201
        $issues = $this->issues()
202
        ->with('user', 'tags')
203
            ->where('status', '=', Project\Issue::STATUS_OPEN)
204
            ->whereIn('projects_issues_tags.tag_id', $tagIds)
205
            ->join('projects_issues_tags', 'issue_id', '=', 'id')
206
            ->orderBy('id')
207
            ->get()
208
            ->groupBy(function (Project\Issue $issue) {
209
                return $issue->getStatusTag()->name;
210
            });
211
212
        return $issues;
213
    }
214
215
    /**
216
     * Returns users assigned to the project that can fix issues (with edit permission).
217
     *
218
     * @return Relations\BelongsToMany
219
     */
220 8
    public function usersCanFixIssue()
221
    {
222 8
        return $this->users()->where('users.role_id', '>', 1);
223
    }
224
}
225