LoggedUser::setAuth() - Code Metrics - Inspection of "In progress [skip ci]" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop-3.0 (ec383d)

by Mohamed

created 2016-10-02 10:06 UTC

LoggedUser::setAuth() A

↳ Parent: LoggedUser

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Extensions\Auth;

use Tinyissue\Model\User;
use Illuminate\Contracts\Auth\Guard;

/**
 * @author Mohamed Alsharaf <[email protected]>
 */
trait LoggedUser
{
    /**
     * @var mixed
     */
    protected $loggedUser;

    /**
     * @var Guard
     */
    protected $auth;

    protected function setAuth(Guard $auth)
    {
        $this->auth = $auth;

        return $this;
    }

    /**
     * Return instance of the logged user.
     *
     * @param mixed $user
     *
     * @return $this
     */
    public function setLoggedUser($user)
    {
        $this->loggedUser = $user;

        return $this;
    }

    protected function isLoggedIn()
    {
        $this->lazyLoadLoggedUser();

        return $this->loggedUser instanceof User;
    }

    /**
     * Is current logged in user with role User.
     *
     * @return bool
     */
    protected function isLoggedNormalUser()
    {
        return $this->isLoggedIn() && $this->getLoggedUser()->isUser();
    }

    /**
     * Inject the instance of logged user.
     *
     * @return void
     */
    protected function lazyLoadLoggedUser()
    {
        if (!$this->auth instanceof Guard) {
            $this->setAuth(auth());
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }

        if (null === $this->loggedUser) {
            $this->loggedUser = $this->auth->user();
        }
    }

    /**
     * Return instance of the logged user.
     *
     * @return User
     */
    public function getLoggedUser()
    {
        $this->lazyLoadLoggedUser();

        /* @var \Tinyissue\Services\SettingsManager $settings */
        if (!$this->isLoggedIn() && !app('tinyissue.settings')->isPublicProjectsEnabled()) {
            throw new \DomainException('Unable to find a valid instance of logged user.');
        }

        return $this->loggedUser;
    }
}


1			<?php
2
3			/*
4			* This file is part of the Tinyissue package.
5			*
6			* (c) Mohamed Alsharaf <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Tinyissue\Extensions\Auth;
13
14			use Tinyissue\Model\User;
15			use Illuminate\Contracts\Auth\Guard;
16
17			/**
18			* @author Mohamed Alsharaf <[email protected]>
19			*/
20			trait LoggedUser
21			{
22			/**
23			* @var mixed
24			*/
25			protected $loggedUser;
26
27			/**
28			* @var Guard
29			*/
30			protected $auth;
31
32			protected function setAuth(Guard $auth)
33			{
34			$this->auth = $auth;
35
36			return $this;
37			}
38
39			/**
40			* Return instance of the logged user.
41			*
42			* @param mixed $user
43			*
44			* @return $this
45			*/
46			public function setLoggedUser($user)
47			{
48			$this->loggedUser = $user;
49
50			return $this;
51			}
52
53			protected function isLoggedIn()
54			{
55			$this->lazyLoadLoggedUser();
56
57			return $this->loggedUser instanceof User;
58			}
59
60			/**
61			* Is current logged in user with role User.
62			*
63			* @return bool
64			*/
65			protected function isLoggedNormalUser()
66			{
67			return $this->isLoggedIn() && $this->getLoggedUser()->isUser();
68			}
69
70			/**
71			* Inject the instance of logged user.
72			*
73			* @return void
74			*/
75			protected function lazyLoadLoggedUser()
76			{
77			if (!$this->auth instanceof Guard) {
78			$this->setAuth(auth());
			0 ignored issues – show Bug introduced 2016-10-02 08:20 UTC by Report Bug Copy Issue Report It seems like `auth()` can also be of type `object<Illuminate\Contracts\Auth\Factory>`; however, `Tinyissue\Extensions\Auth\LoggedUser::setAuth()` does only seem to accept `object<Illuminate\Contracts\Auth\Guard>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
79			}
80
81			if (null === $this->loggedUser) {
82			$this->loggedUser = $this->auth->user();
83			}
84			}
85
86			/**
87			* Return instance of the logged user.
88			*
89			* @return User
90			*/
91			public function getLoggedUser()
92			{
93			$this->lazyLoadLoggedUser();
94
95			/* @var \Tinyissue\Services\SettingsManager $settings */
96			if (!$this->isLoggedIn() && !app('tinyissue.settings')->isPublicProjectsEnabled()) {
97			throw new \DomainException('Unable to find a valid instance of logged user.');
98			}
99
100			return $this->loggedUser;
101			}
102			}
103

satrun77 / tinyissue

Branch — develop-3.0 (ec383d)

LoggedUser::setAuth() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like