BusServiceProvider - Code Metrics - Inspection of "Test: add extra asserts to functional/OtherFunctio..." - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 8d2e7b...6184bf )

by Mohamed

created 2016-08-05 11:46 UTC

BusServiceProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	1	Features	1

Metric	Value
wmc	3
c	1
b	1
f	1
lcom	1
cbo	7
dl	0
loc	44
ccs	18
cts	18
cp	1
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	boot()	0	8	1
B	register()	0	24	2

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Providers;

use Illuminate\Bus\Dispatcher;
use Illuminate\Support\ServiceProvider;
use Tinyissue\Form\FormInterface;
use Tinyissue\Http\Requests\Request as FormRequest;
use Illuminate\Foundation\Application;

/**
 * BusServiceProvider is the request service provider for bootstrapping and registering services in current request.
 *
 * @author Mohamed Alsharaf <[email protected]>
 */
class BusServiceProvider extends ServiceProvider
{
    /**
     * Bootstrap any application services.
     *
     * @param \Illuminate\Bus\Dispatcher $dispatcher
     */
    public function boot(Dispatcher $dispatcher)
    {
        $dispatcher->mapUsing(function ($command) {
            return Dispatcher::simpleMapping(
                            $command, 'Tinyissue\Commands', 'Tinyissue\Handlers\Commands'
            );
        });
    }

    /**
     * Register any application services.
     */
    public function register()
    {
        // Resolve form object by injecting the current model being edited
        $this->app->resolving(function (FormInterface $form, Application $app) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $form->setup($app->router->getCurrentRoute()->parameters());
            $form->setLoggedUser(auth()->user());
        });

        // Resolve form request by injecting the current model being edited
        $this->app->resolving(function (FormRequest $request, Application $app) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $form = array_first($app->router->getCurrentRoute()->parameters(), function ($key, $value) {
                return $value instanceof FormInterface;
            }, function () use ($request, $app) {
                return $app->make($request->getFormClassName());
            });
            if ($form) {
                $form->setup($app->router->getCurrentRoute()->parameters());
                $form->setLoggedUser(auth()->user());
                $request->setForm($form);
            }

            return $request;
        });
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Providers;
13
14		use Illuminate\Bus\Dispatcher;
15		use Illuminate\Support\ServiceProvider;
16		use Tinyissue\Form\FormInterface;
17		use Tinyissue\Http\Requests\Request as FormRequest;
18		use Illuminate\Foundation\Application;
19
20		/**
21		* BusServiceProvider is the request service provider for bootstrapping and registering services in current request.
22		*
23		* @author Mohamed Alsharaf <[email protected]>
24		*/
25		class BusServiceProvider extends ServiceProvider
26		{
27		/**
28		* Bootstrap any application services.
29		*
30		* @param \Illuminate\Bus\Dispatcher $dispatcher
31		*/
32	62	public function boot(Dispatcher $dispatcher)
33		{
34		$dispatcher->mapUsing(function ($command) {
35		return Dispatcher::simpleMapping(
36		$command, 'Tinyissue\Commands', 'Tinyissue\Handlers\Commands'
37		);
38	62	});
39	62	}
40
41		/**
42		* Register any application services.
43		*/
44	62	public function register()
45		{
46		// Resolve form object by injecting the current model being edited
47		$this->app->resolving(function (FormInterface $form, Application $app) {
		0 ignored issues – show Documentation introduced 2016-07-29 13:40 UTC by Report Bug Copy Issue Report `function (\Tinyissue\For...User(auth()->user()); }` is of type `object<Closure>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48	49	$form->setup($app->router->getCurrentRoute()->parameters());
49	49	$form->setLoggedUser(auth()->user());
50	62	});
51
52		// Resolve form request by injecting the current model being edited
53		$this->app->resolving(function (FormRequest $request, Application $app) {
		0 ignored issues – show Documentation introduced 2016-07-29 10:03 UTC by Report Bug Copy Issue Report `function (\Tinyissue\Htt... return $request; }` is of type `object<Closure>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54		$form = array_first($app->router->getCurrentRoute()->parameters(), function ($key, $value) {
55	14	return $value instanceof FormInterface;
56	27	}, function () use ($request, $app) {
57	27	return $app->make($request->getFormClassName());
58	27	});
59	27	if ($form) {
60	27	$form->setup($app->router->getCurrentRoute()->parameters());
61	27	$form->setLoggedUser(auth()->user());
62	27	$request->setForm($form);
63		}
64
65	27	return $request;
66	62	});
67	62	}
68		}
69

satrun77 / tinyissue

Push — develop ( 8d2e7b...6184bf )

BusServiceProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like