Tag::canView() - Code Metrics - Inspection of "Feature: init code to limit tags by user role" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( a46361...3940dc )

by Mohamed

created 2016-05-02 09:56 UTC

Tag::canView() A

↳ Parent: Tag

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Model;

use Illuminate\Database\Eloquent\Model;

/**
 * Tag is model class for tags.
 *
 * @author Mohamed Alsharaf <[email protected]>
 *
 * @property int     $id
 * @property int     $parent_id
 * @property string  $name
 * @property string  $fullname
 * @property string  $bgcolor
 * @property bool $group
 * @property Tag     $parent
 */
class Tag extends Model
{
    use Traits\Tag\CrudTrait,
        Traits\Tag\QueryTrait,
        Traits\Tag\RelationTrait,
        Traits\Tag\CountTrait,
        Traits\Tag\DataMappingTrait;

    /**
     * Core tag: Open.
     *
     * @var string
     */
    const STATUS_OPEN = 'open';

    /**
     * Core tag: Closed.
     *
     * @var string
     */
    const STATUS_CLOSED = 'closed';

    /**
     * Core tag group: Status.
     *
     * @var string
     */
    const GROUP_STATUS = 'status';

    /**
     * Timestamp enabled.
     *
     * @var bool
     */
    public $timestamps = true;

    /**
     * List of allowed columns to be used in $this->fill().
     *
     * @var array
     */
    public $fillable = ['parent_id', 'name', 'bgcolor', 'group', 'role_limit'];

    /**
     * Name of database table.
     *
     * @var string
     */
    protected $table = 'tags';

    /**
     * Generate a URL for the tag.
     *
     * @param string $url
     *
     * @return mixed
     */
    public function to($url)
    {
        return \URL::to('administration/tag/' . $this->id . (($url) ? '/' . $url : ''));
    }

    /**
     * Returns tag full name with prefix group name and ":" in between.
     *
     * @return string
     */
    public function getFullNameAttribute()
    {
        return ucwords($this->attributes['name']);
    }

    /**
     * Whether or not the current user can view this tag
     *
     * @return bool
     */
    public function canView()
    {
        return auth()->user()->role_id >= $this->role_limit;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * Whether or not the tag is core tag
     *
     * @return bool
     */
    public function isCore()
    {
        return $this->name == static::STATUS_OPEN || $this->name == static::STATUS_CLOSED;
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Model;
13
14		use Illuminate\Database\Eloquent\Model;
15
16		/**
17		* Tag is model class for tags.
18		*
19		* @author Mohamed Alsharaf <[email protected]>
20		*
21		* @property int $id
22		* @property int $parent_id
23		* @property string $name
24		* @property string $fullname
25		* @property string $bgcolor
26		* @property bool $group
27		* @property Tag $parent
28		*/
29		class Tag extends Model
30		{
31		use Traits\Tag\CrudTrait,
32		Traits\Tag\QueryTrait,
33		Traits\Tag\RelationTrait,
34		Traits\Tag\CountTrait,
35		Traits\Tag\DataMappingTrait;
36
37		/**
38		* Core tag: Open.
39		*
40		* @var string
41		*/
42		const STATUS_OPEN = 'open';
43
44		/**
45		* Core tag: Closed.
46		*
47		* @var string
48		*/
49		const STATUS_CLOSED = 'closed';
50
51		/**
52		* Core tag group: Status.
53		*
54		* @var string
55		*/
56		const GROUP_STATUS = 'status';
57
58		/**
59		* Timestamp enabled.
60		*
61		* @var bool
62		*/
63		public $timestamps = true;
64
65		/**
66		* List of allowed columns to be used in $this->fill().
67		*
68		* @var array
69		*/
70		public $fillable = ['parent_id', 'name', 'bgcolor', 'group', 'role_limit'];
71
72		/**
73		* Name of database table.
74		*
75		* @var string
76		*/
77		protected $table = 'tags';
78
79		/**
80		* Generate a URL for the tag.
81		*
82		* @param string $url
83		*
84		* @return mixed
85		*/
86	2	public function to($url)
87		{
88	2	return \URL::to('administration/tag/' . $this->id . (($url) ? '/' . $url : ''));
89		}
90
91		/**
92		* Returns tag full name with prefix group name and ":" in between.
93		*
94		* @return string
95		*/
96	30	public function getFullNameAttribute()
97		{
98	30	return ucwords($this->attributes['name']);
99		}
100
101		/**
102		* Whether or not the current user can view this tag
103		*
104		* @return bool
105		*/
106	7	public function canView()
107		{
108	7	return auth()->user()->role_id >= $this->role_limit;
		0 ignored issues – show Bug introduced 2016-05-02 10:04 UTC by Report Bug Copy Issue Report Accessing `role_id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Documentation introduced 2016-05-02 10:04 UTC by Report Bug Copy Issue Report The property `role_limit` does not exist on `object<Tinyissue\Model\Tag>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
109		}
110
111		/**
112		* Whether or not the tag is core tag
113		*
114		* @return bool
115		*/
116	1	public function isCore()
117		{
118	1	return $this->name == static::STATUS_OPEN \|\| $this->name == static::STATUS_CLOSED;
119		}
120		}
121

satrun77 / tinyissue

Push — develop ( a46361...3940dc )

Tag::canView() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like