SettingsManager::load() - Code Metrics - Inspection of "Feature: Set a project as private or not" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 78dac2...5cd299 )

by Mohamed

created 2016-01-11 07:42 UTC

SettingsManager::load() A

↳ Parent: SettingsManager

Complexity

Conditions	4
Paths	5

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	4.3731

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
ccs	5
cts	7
cp	0.7143
rs	9.2
cc	4
eloc	8
nc	5
nop	0
crap	4.3731

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Services;

use Illuminate\Database\Eloquent;
use Illuminate\Support\Collection;
use Tinyissue\Model\Setting;

/**
 * SettingsManager singleton class to maintain a collection of all settings
 *
 * @author Mohamed Alsharaf <[email protected]>
 *
 * @property int $id
 * @property string $name
 * @property string $value
 * @property string $key
 */
class SettingsManager extends Collection
{
    public function __construct($items = [])
    {
        parent::__construct($items);
        $this->load();
    }

    /**
     * Load all settings
     *
     * @return \Illuminate\Database\Eloquent\Collection|boolean
     */
    protected function load()
    {
        if ($this->count() === 0) {
            // Skip exception if table does not exists
            // This method called from RouteServiceProvider, which is called within command line 'artisan migrate'
            // before the table exists.
            try {
                $items = Setting::all();
                $this->items = is_array($items) ? $items : $this->getArrayableItems($items);
            } catch (\Exception $e) {
                return false;
            }
        }

        return $this;
    }

    /**
     * Returns a setting value
     *
     * @param $name
     * @param mixed|null $default
     * @return mixed
     */
    public function get($name, $default = null)
    {
        if ($this->load()) {
            foreach ($this->all() as $setting) {
                if ($setting->key === $name) {
                    return $setting->value;
                }
            }
        }

        return $default;
    }

    /**
     * Whether or not the public projects enabled
     *
     * @return bool
     */
    public function isPublicProjectsEnabled()
    {
        return (boolean)$this->get('enable_public_projects') === true;
    }

    /**
     * Save a collection of settings
     *
     * @param $values
     * @return boolean
     */
    public function save($values)
    {
        foreach ($values as $name => $value) {
            $settings = new Setting();
            $setting = $settings->where('key', '=', $name)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($setting) {
                $setting->value = $value;
                $setting->save();
            }
            unset($settings, $setting);
        }

        // Reload items
        $this->items = [];
        $this->load();

        return true;
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Services;
13
14		use Illuminate\Database\Eloquent;
15		use Illuminate\Support\Collection;
16		use Tinyissue\Model\Setting;
17
18		/**
19		* SettingsManager singleton class to maintain a collection of all settings
20		*
21		* @author Mohamed Alsharaf <[email protected]>
22		*
23		* @property int $id
24		* @property string $name
25		* @property string $value
26		* @property string $key
27		*/
28		class SettingsManager extends Collection
29		{
30	56	public function __construct($items = [])
31		{
32	56	parent::__construct($items);
33	56	$this->load();
34	56	}
35
36		/**
37		* Load all settings
38		*
39		* @return \Illuminate\Database\Eloquent\Collection\|boolean
40		*/
41	56	protected function load()
42		{
43	56	if ($this->count() === 0) {
44		// Skip exception if table does not exists
45		// This method called from RouteServiceProvider, which is called within command line 'artisan migrate'
46		// before the table exists.
47		try {
48	56	$items = Setting::all();
49	56	$this->items = is_array($items) ? $items : $this->getArrayableItems($items);
50		} catch (\Exception $e) {
51		return false;
52		}
53		}
54
55	56	return $this;
56		}
57
58		/**
59		* Returns a setting value
60		*
61		* @param $name
62		* @param mixed\|null $default
63		* @return mixed
64		*/
65	56	public function get($name, $default = null)
66		{
67	56	if ($this->load()) {
68	56	foreach ($this->all() as $setting) {
69	56	if ($setting->key === $name) {
70	56	return $setting->value;
71		}
72		}
73		}
74
75		return $default;
76		}
77
78		/**
79		* Whether or not the public projects enabled
80		*
81		* @return bool
82		*/
83	56	public function isPublicProjectsEnabled()
84		{
85	56	return (boolean)$this->get('enable_public_projects') === true;
86		}
87
88		/**
89		* Save a collection of settings
90		*
91		* @param $values
92		* @return boolean
93		*/
94	3	public function save($values)
95		{
96	3	foreach ($values as $name => $value) {
97	3	$settings = new Setting();
98	3	$setting = $settings->where('key', '=', $name)->first();
		0 ignored issues – show Documentation Bug introduced 2016-01-11 07:49 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<Tinyissue\Model\Setting>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
99	3	if ($setting) {
100	3	$setting->value = $value;
101	3	$setting->save();
102		}
103	3	unset($settings, $setting);
104		}
105
106		// Reload items
107	3	$this->items = [];
108	3	$this->load();
109
110	3	return true;
111		}
112		}
113

satrun77 / tinyissue

Push — develop ( 78dac2...5cd299 )

SettingsManager::load() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like