Tinyissue\Repository\User\Updater

Complexity

Total Complexity

7

Size/Duplication

Total Lines	84
Duplicated Lines	55.95 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	create()	15	15	1
A	delete()	11	11	1
A	update()	10	10	3
A	updateMessagesSettings()	11	11	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Repository\User;

use Hash;
use Tinyissue\Contracts\Model\UserInterface;
use Tinyissue\Model\Project\User as ProjectUser;
use Tinyissue\Model\User;
use Tinyissue\Repository\RepositoryUpdater;

/**
 * Class Updater.
 *
 * @package Tinyissue\\User
 */
class Updater extends RepositoryUpdater
{
    protected $model;

    public function __construct(UserInterface $model)
    {
        $this->model = $model;
    }

    /**
     * Add a new user.
     *
     * @param array $info
     *
     * @return bool
     */
    public function create(array $info)

This method seems to be duplicated in your project.

    {
        $insert = [
            'email'     => $info['email'],
            'firstname' => $info['firstname'],
            'lastname'  => $info['lastname'],
            'role_id'   => $info['role_id'],
            'private'   => (boolean) $info['private'],
            'password'  => Hash::make($info['password']),
            'status'    => $info['status'],
            'language'  => app('tinyissue.settings')->getLanguage(),
        ];

        return $this->model->fill($insert)->save();
    }

    /**
     * Soft deletes a user and empties the email.
     *
     * @return bool
     */
    public function delete()

This method seems to be duplicated in your project.

    {
        $this->model->update([
            'email'   => $this->model->email . '_deleted',

Accessing email on the interface Tinyissue\Contracts\Model\UserInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            'deleted' => User::DELETED_USERS,
        ]);

        ProjectUser::where('user_id', '=', $this->model->id)->delete();

Accessing id on the interface Tinyissue\Contracts\Model\UserInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        return true;
    }

    /**
     * Updates the users settings, validates the fields.
     *
     * @param array $info

There is no parameter named $info. Was it maybe removed?

     *
     * @return Eloquent\Model
     */
    public function update(array $attributes = [])

This method seems to be duplicated in your project.

    {
        if ($attributes['password']) {
            $attributes['password'] = Hash::make($attributes['password']);
        } elseif (empty($attributes['password'])) {
            unset($attributes['password']);
        }

        return $this->model->update($attributes);
    }

    /**
     * Update user messages setting.
     *
     * @param array $input
     */
    public function updateMessagesSettings(array $input)

This method seems to be duplicated in your project.

    {
        return (new ProjectUser())

The method where does not exist on object<Tinyissue\Model\Project\User>? Since you implemented __call, maybe consider adding a @method annotation.

            ->where('user_id', '=', $this->model->id)

Accessing id on the interface Tinyissue\Contracts\Model\UserInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            ->whereIn('project_id', array_keys($input))
            ->get()
            ->each(function (ProjectUser $project) use ($input) {
                $project->message_id = $input[$project->project_id];
                $project->save();
            });
    }
}