Tinyissue\Repository\User\Fetcher

Complexity

Total Complexity

12

Size/Duplication

Total Lines	108
Duplicated Lines	2.78 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getProjects()	0	4	1
A	getProjectsWithSettings()	0	4	1
A	getActiveUsers()	0	4	1
A	getProjectsWithRecentActivities()	0	4	1
A	getProjectsWithRecentIssues()	0	14	2
A	getIssuesGroupByTags()	0	21	2
A	getProjectsWithOpenIssuesCount()	3	8	3

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Repository\User;

use Illuminate\Database\Eloquent;
use Illuminate\Database\Eloquent\Relations;
use Tinyissue\Contracts\Model\UserInterface;
use Tinyissue\Model\Permission;
use Tinyissue\Model\Project;
use Tinyissue\Model\User;
use Tinyissue\Repository\Repository;

class Fetcher extends Repository
{
    /**
     * @var User
     */
    protected $model;

    public function __construct(UserInterface $model)
    {
        $this->model = $model;

$model is of type object<Tinyissue\Contracts\Model\UserInterface>, but the property $model was declared to be of type object<Tinyissue\Model\User>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * Returns projects the user member of.
     *
     * @return Eloquent\Collection
     */
    public function getProjects()
    {
        return $this->model->projects()->get();
    }

    public function getProjectsWithSettings()
    {
        return $this->model->projects()->with('projectUsers')->get();
    }

    /**
     * Returns public users.
     *
     * @return Eloquent\Collection
     */
    public function getActiveUsers()
    {
        return $this->model->with('role')->private()->orderBy('firstname')->get();
    }

    /**
     * Returns user projects with activities details eager loaded.
     *
     * @param int $status
     * @done
     *
     * @return Relations\HasMany
     */
    public function getProjectsWithRecentActivities($status = Project::STATUS_OPEN)
    {
        return $this->model->projects($status)->with('recentActivities')->get();

The call to User::projects() has too many arguments starting with $status.

    }

    /**
     * Returns projects with issues details eager loaded.
     *
     * @return Relations\HasMany
     */
    public function getProjectsWithRecentIssues()
    {
        return $this->model

The method active() does not exist on Tinyissue\Model\User. Did you maybe mean isActive()?

            ->active()
            ->with('issues.user', 'issues.countComments')
            ->with([
                'openIssuesWithUpdater' => function (Relations\Relation $query) {
                    $assignedOrCreate = $this->model->isUser() ? 'createdBy' : 'assignedTo';
                    $query->$assignedOrCreate($this->id);

The property id does not exist. Did you maybe forget to declare it?

                },
            ])
            ->orderBy('name')
            ->get();
    }

    public function getIssuesGroupByTags(Eloquent\Collection $tagIds, $projectId = null)
    {
        $tagIds = $tagIds->pluck('id')->all();

        $assignedOrCreate = $this->model->isUser() ? 'issuesCreatedBy' : 'issues';
        $issues           = $this->model->$assignedOrCreate()
            ->with('user', 'tags')
            ->open()
            ->forProject($projectId)
            ->join('projects_issues_tags', 'issue_id', '=', 'id')
            ->whereIn('projects_issues_tags.tag_id', $tagIds)
            ->orderBy('id')
            ->get()
            ->groupBy(function (Project\Issue $issue) {
                return $issue->getStatusTag()->name;

The method getStatusTag does not exist on object<Tinyissue\Model\Project\Issue>? Since you implemented __call, maybe consider adding a @method annotation.

            })
//            ->get()
        ;

        return $issues;
    }

    /**
     * Returns all projects with open issue count.
     *
     * @param int $status
     *
     * @return Builder|Relations\BelongsToMany
     */
    public function getProjectsWithOpenIssuesCount($status = Project::STATUS_OPEN)
    {
        if ($this->model->isManager() || $this->model->isAdmin()) {

This code seems to be duplicated across your project.

            return app()->make(Project::class)->getProjectsWithOpenIssuesCount($status, Project::PRIVATE_ALL);
        }

        return $this->model->projects()->status($status)->with('openIssuesCount')->get();
    }
}