Tinyissue\Repository\Project\Issue\Attachment\Updater

Complexity

Total Complexity

9

Size/Duplication

Total Lines	91
Duplicated Lines	12.09 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	delete()	0	7	1
A	upload()	0	17	1
A	remove()	0	7	1
A	deleteFile()	11	12	3
A	updateIssueToken()	0	4	1
A	updateCommentToken()	0	7	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Repository\Project\Issue\Attachment;

use Tinyissue\Contracts\Model\UserInterface;
use Tinyissue\Model\Project;
use Tinyissue\Repository\RepositoryUpdater;

class Updater extends RepositoryUpdater
{
    public function __construct(Project\Issue\Attachment $model)
    {
        $this->model = $model;
    }

    public function delete()
    {
        $path = $this->getUploadStorage($this->model->issue->project, $this->model->upload_token);
        $this->deleteFile($path, $this->model->filename);

        return parent::delete();
    }

    /**
     * Upload the attachment.
     *
     * @param array         $input
     * @param Project       $project
     * @param UserInterface $user
     *
     * @return Eloquent\Model
     */
    public function upload(array $input, Project $project, UserInterface $user)
    {
        // Upload path
        $path = $this->getUploadStorage($project, $input['upload_token']);

        /* @var $uploadedFile \Symfony\Component\HttpFoundation\File\UploadedFile */
        $uploadedFile = $input['upload'];
        $file = $uploadedFile->move($path, $uploadedFile->getClientOriginalName());

        $this->model->uploaded_by = $user->id;

Accessing id on the interface Tinyissue\Contracts\Model\UserInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->model->filename = $file->getFilename();
        $this->model->fileextension = $file->getExtension();
        $this->model->filesize = $file->getSize();
        $this->model->upload_token = $input['upload_token'];

        return $this->save();
    }

    /**
     * Remove a attachment that is pending from a issue/comment.
     *
     * @param array         $input
     * @param Project       $project
     * @param UserInterface $user
     *
     * @return void
     */
    public function remove(array $input, Project $project, UserInterface $user)
    {
        $this->model->byUser($user)->forToken($input['upload_token'])->filename($input['filename'])->delete();

        $path = $this->getUploadStorage($project, $input['upload_token']);
        $this->deleteFile($path, $input['filename']);
    }

    /**
     * Delete the physical file of an attachment.
     *
     * @param string $path
     * @param string $filename
     */
    public function deleteFile($path, $filename)

This method seems to be duplicated in your project.

    {
        $file = $path . '/' . $filename;

        if (file_exists($file)) {
            unlink($file);
        }

        if (is_dir($path)) {
            rmdir($path);
        }
    }

    public function updateIssueToken($token, $uploadBy, $issueId)
    {
        return $this->model->forToken($token)->byUser($uploadBy)->update(['issue_id' => $issueId]);
    }

    public function updateCommentToken($token, $uploadBy, $issueId, $commentId)
    {
        return $this->model->forToken($token)->byUser($uploadBy)->update([
            'issue_id'   => $issueId,
            'comment_id' => $commentId,
        ]);
    }
}