satrun77 /
tinyissue
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 31 | class TagPolicy |
||
| 32 | { |
||
| 33 | use HandlesAuthorization; |
||
| 34 | |||
| 35 | View Code Duplication | public function before(UserInterface $user) |
|
| 42 | |||
| 43 | /** |
||
| 44 | * Determine whether the user can view the project. |
||
| 45 | * |
||
| 46 | * @param User $user |
||
| 47 | * @param Project $project |
||
| 48 | * @return mixed |
||
| 49 | */ |
||
| 50 | public function view(User $user, Tag $tag) |
||
| 55 | // |
||
| 56 | // |
||
| 57 | // /** |
||
| 58 | // * Whether or not the current user can view this tag. |
||
| 59 | // * |
||
| 60 | // * @return bool |
||
| 61 | // */ |
||
| 62 | // public function canView() |
||
| 63 | // { |
||
| 64 | // return $this->getLoggedUser()->role_id >= $this->role_limit; |
||
| 65 | // } |
||
| 66 | // |
||
| 67 | // /** |
||
| 68 | // * Determine whether the user can create projects. |
||
| 69 | // * |
||
| 70 | // * @param User $user |
||
| 71 | // * @return mixed |
||
| 72 | // */ |
||
| 73 | // public function create(User $user) |
||
| 74 | // { |
||
| 75 | // $this->dd(__METHOD__); |
||
| 76 | // return $user->isAdmin(); |
||
| 77 | // } |
||
| 78 | // |
||
| 79 | // /** |
||
| 80 | // * Determine whether the user can update the project. |
||
| 81 | // * |
||
| 82 | // * @param User $user |
||
| 83 | // * @return mixed |
||
| 84 | // */ |
||
| 85 | // public function update(User $user) |
||
| 86 | // { |
||
| 87 | // $this->dd(__METHOD__); |
||
| 88 | // return $this->create($user); |
||
| 89 | // } |
||
| 90 | // |
||
| 91 | // /** |
||
| 92 | // * Determine whether the user can delete the project. |
||
| 93 | // * |
||
| 94 | // * @param User $user |
||
| 95 | // * @return mixed |
||
| 96 | // */ |
||
| 97 | // public function delete(User $user) |
||
| 98 | // { |
||
| 99 | // $this->dd(__METHOD__); |
||
| 100 | // return $this->create($user); |
||
| 101 | // } |
||
| 102 | // |
||
| 103 | // public function export(User $user) |
||
| 104 | // { |
||
| 105 | // $this->dd(__METHOD__); |
||
| 106 | // return $user->isAdmin() || $user->isManager(); |
||
| 107 | // } |
||
| 108 | // |
||
| 109 | // public function viewInactiveUsers(User $user, Project $project = null) |
||
| 110 | // { |
||
| 111 | // $this->dd(__METHOD__); |
||
| 112 | // |
||
| 113 | // return $user->isUser(); // TODO check this!!!! |
||
| 114 | // $this->dd(__METHOD__); |
||
| 115 | // if ($this->isPublicProject($project) || $project->isMember($user->id)) { |
||
| 116 | // return true; |
||
| 117 | // } |
||
| 118 | // |
||
| 119 | // return false; |
||
| 120 | // } |
||
| 121 | //inactiveUsers |
||
| 122 | } |
||
| 123 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.