ProjectPolicy - Code Metrics - Inspection of "In progress" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop-3.0 ( 4fe777...24fc5d )

by Mohamed

created 2016-09-23 07:52 UTC

ProjectPolicy A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	85
Duplicated Lines	17.65 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

Metric	Value
wmc	15
lcom	0
cbo	5
dl	15
loc	85
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	before()	7	7	4
A	view()	8	8	3
A	create()	0	5	1
A	update()	0	5	1
A	delete()	0	5	1
A	export()	0	5	2
A	viewInactiveUsers()	0	12	3

How to fix Duplicated Code

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Policies;

use Tinyissue\Contracts\Model\UserInterface;
use Tinyissue\Extensions\Policies\ProjectAccess;
use Tinyissue\Model\Project;
use Tinyissue\Model\User;
use Illuminate\Auth\Access\HandlesAuthorization;

/**
 * Class ProjectPolicy.
 * View:   member of the project and manager role.
 * Create: admin role.
 * Update: admin role.
 * Delete: admin role.
 *
 * @author Mohamed Alsharaf <[email protected]>
 */
class ProjectPolicy
{
    use HandlesAuthorization, ProjectAccess;

    public function before(UserInterface $user)

    {
        $this->dd(__METHOD__);

        if ($user instanceof UserInterface && ($user->isAdmin() || $user->isManager())) {
            return true;
        }
    }

    /**
     * Determine whether the user can view the project.
     *
     * @param  User  $user
     * @param  Project  $project
     * @return mixed
     */
    public function view(User $user, Project $project)

    {
        if ($this->isPublicProject($project) || $project->isMember($user->id)) {
            return true;
        }

        return false;
    }


    /**
     * Determine whether the user can create projects.
     *
     * @param  User  $user
     * @return mixed
     */
    public function create(User $user)
    {
        $this->dd(__METHOD__);

        return $user->isAdmin();
    }

    /**
     * Determine whether the user can update the project.
     *
     * @param  User  $user
     * @return mixed
     */
    public function update(User $user)
    {
        $this->dd(__METHOD__);

        return $this->create($user);
    }

    /**
     * Determine whether the user can delete the project.
     *
     * @param  User  $user
     * @return mixed
     */
    public function delete(User $user)
    {
        $this->dd(__METHOD__);

        return $this->create($user);
    }

    public function export(User $user)
    {
        $this->dd(__METHOD__);

        return $user->isAdmin() || $user->isManager();
    }

    public function viewInactiveUsers(User $user, Project $project = null)

    {
        $this->dd(__METHOD__);


        return $user->isUser(); // TODO check this!!!!
        $this->dd(__METHOD__);
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        if ($this->isPublicProject($project) || $project->isMember($user->id)) {
            return true;
        }

        return false;
    }
    //inactiveUsers
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Policies;
13
14		use Tinyissue\Contracts\Model\UserInterface;
15		use Tinyissue\Extensions\Policies\ProjectAccess;
16		use Tinyissue\Model\Project;
17		use Tinyissue\Model\User;
18		use Illuminate\Auth\Access\HandlesAuthorization;
19
20		/**
21		* Class ProjectPolicy.
22		* View: member of the project and manager role.
23		* Create: admin role.
24		* Update: admin role.
25		* Delete: admin role.
26		*
27		* @author Mohamed Alsharaf <[email protected]>
28		*/
29		class ProjectPolicy
30		{
31		use HandlesAuthorization, ProjectAccess;
32
33	View Code Duplication	public function before(UserInterface $user)
		0 ignored issues – show Duplication introduced 2016-09-23 08:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		$this->dd(__METHOD__);
		0 ignored issues – show Bug introduced 2016-09-23 08:01 UTC by Report Bug Copy Issue Report The method `dd()` does not seem to exist on `object<Tinyissue\Policies\ProjectPolicy>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
36		if ($user instanceof UserInterface && ($user->isAdmin() \|\| $user->isManager())) {
37		return true;
38		}
39		}
40
41		/**
42		* Determine whether the user can view the project.
43		*
44		* @param User $user
45		* @param Project $project
46		* @return mixed
47		*/
48	View Code Duplication	public function view(User $user, Project $project)
		0 ignored issues – show Duplication introduced 2016-09-23 08:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		{
50		if ($this->isPublicProject($project) \|\| $project->isMember($user->id)) {
51		return true;
52		}
53
54		return false;
55		}
56
57
58		/**
59		* Determine whether the user can create projects.
60		*
61		* @param User $user
62		* @return mixed
63		*/
64		public function create(User $user)
65		{
66		$this->dd(__METHOD__);
		0 ignored issues – show Bug introduced 2016-09-23 08:01 UTC by Report Bug Copy Issue Report The method `dd()` does not seem to exist on `object<Tinyissue\Policies\ProjectPolicy>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
67		return $user->isAdmin();
68		}
69
70		/**
71		* Determine whether the user can update the project.
72		*
73		* @param User $user
74		* @return mixed
75		*/
76		public function update(User $user)
77		{
78		$this->dd(__METHOD__);
		0 ignored issues – show Bug introduced 2016-09-23 08:01 UTC by Report Bug Copy Issue Report The method `dd()` does not seem to exist on `object<Tinyissue\Policies\ProjectPolicy>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
79		return $this->create($user);
80		}
81
82		/**
83		* Determine whether the user can delete the project.
84		*
85		* @param User $user
86		* @return mixed
87		*/
88		public function delete(User $user)
89		{
90		$this->dd(__METHOD__);
		0 ignored issues – show Bug introduced 2016-09-23 08:01 UTC by Report Bug Copy Issue Report The method `dd()` does not seem to exist on `object<Tinyissue\Policies\ProjectPolicy>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
91		return $this->create($user);
92		}
93
94		public function export(User $user)
95		{
96		$this->dd(__METHOD__);
		0 ignored issues – show Bug introduced 2016-09-23 08:01 UTC by Report Bug Copy Issue Report The method `dd()` does not seem to exist on `object<Tinyissue\Policies\ProjectPolicy>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
97		return $user->isAdmin() \|\| $user->isManager();
98		}
99
100		public function viewInactiveUsers(User $user, Project $project = null)
		0 ignored issues – show Unused Code introduced 2016-09-23 08:01 UTC by Report Bug Copy Issue Report The parameter `$project` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
101		{
102		$this->dd(__METHOD__);
		0 ignored issues – show Bug introduced 2016-09-23 08:01 UTC by Report Bug Copy Issue Report The method `dd()` does not seem to exist on `object<Tinyissue\Policies\ProjectPolicy>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
103
104		return $user->isUser(); // TODO check this!!!!
105		$this->dd(__METHOD__);
		0 ignored issues – show Unused Code introduced 2016-09-23 08:01 UTC by Report Bug Copy Issue Report `// TODO check this!!!! $this->dd(__METHOD__);` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
106		if ($this->isPublicProject($project) \|\| $project->isMember($user->id)) {
107		return true;
108		}
109
110		return false;
111		}
112		//inactiveUsers
113		}
114

satrun77 / tinyissue

Push — develop-3.0 ( 4fe777...24fc5d )

ProjectPolicy A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like