Tinyissue\Form\GlobalIssue

Complexity

Total Complexity

7

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	6
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setup()	0	4	1
A	getRedirectUrl()	0	4	1
A	getProjects()	0	8	2
A	actions()	0	6	1
A	rules()	0	7	1
A	fields()	0	19	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Form;

use Tinyissue\Model;

/**
 * GlobalIssue is a class to defines fields & rules for adding an issue form.
 *
 * @author Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 */
class GlobalIssue extends Issue
{
    /**
     * List of projects.
     *
     * @var array
     */
    protected $projects = [];

    /**
     * Returns list of logged in user projects.
     *
     * @return array
     */
    protected function getProjects()
    {
        if (!$this->projects) {

The expression $this->projects of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->projects = \Auth::user()->projects()->get()->lists('name', 'id');
        }

        return $this->projects;
    }

    /**
     * @param array $params
     *
     * @return void
     */
    public function setup(array $params)
    {
        $this->project = new Model\Project();
    }

    /**
     * @return array
     */
    public function actions()
    {
        return [
            'submit' => 'create_issue',
        ];
    }

    /**
     * @return array
     */
    public function fields()
    {
        $fields = $this->fieldTitle();

        $fields['project'] = [
            'type'    => 'select',
            'label'   => 'project',
            'options' => $this->getProjects()->all(),

The method all cannot be called on $this->getProjects() (of type array).

        ];

        $fields += $this->fieldBody();

        $fields += $this->fieldTypeTags();

        // Only on creating new issue
        $fields += $this->fieldUpload();

        return $fields;
    }

    /**
     * @return array
     */
    public function rules()
    {
        $rules            = parent::rules();
        $rules['project'] = 'required|in:' . $this->getProjects()->keys()->implode(',');

The method keys cannot be called on $this->getProjects() (of type array).

        return $rules;
    }

    /**
     * @return string
     */
    public function getRedirectUrl()
    {
        return 'projects/new-issue';
    }
}