Tinyissue\Extensions\Auth\LoggedUser

Complexity

Total Complexity

4

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	2
Bugs	2	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setLoggedUser()	0	6	1
A	getLoggedUser()	0	12	3

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Extensions\Auth;

use Tinyissue\Model\User;

/**
 * @author Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 */
trait LoggedUser
{
    /**
     * @var User
     */
    protected $loggedUser;

    /**
     * Return instance of the logged user.
     *
     * @param static $user

The type LoggedUser for parameter $user is a trait, and thus cannot be used for type-hinting in PHP. Maybe consider adding an interface and use that for type-hinting?

     *
     * @return $this
     */
    public function setLoggedUser($user)
    {
        $this->loggedUser = $user;

It seems like $user of type object<Tinyissue\Extensions\Auth\LoggedUser> is incompatible with the declared type object<Tinyissue\Model\User> of property $loggedUser.

        return $this;
    }

    /**
     * Return instance of the logged user.
     *
     * @return User
     */
    public function getLoggedUser()
    {
        if (null === $this->loggedUser) {
            $this->loggedUser = auth()->user();

It seems like auth()->user() can also be of type object<Illuminate\Contracts\Auth\Authenticatable>. However, the property $loggedUser is declared as type object<Tinyissue\Model\User>. Maybe add an additional type check?

        }

        if (!$this->loggedUser instanceof User) {
            throw new \DomainException('Unable to find a valid instance of logged user.');
        }

        return $this->loggedUser;
    }
}