ActivityScopes::scopeLoadRelatedDetails() - Code Metrics - Inspection of "In progress" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop-3.0 (4fe777)

by Mohamed

created 2016-09-11 10:54 UTC

ActivityScopes::scopeLoadRelatedDetails() A

↳ Parent: ActivityScopes

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	5
Ratio	100 %

Importance

Changes

Metric	Value
dl	5
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Model\User;

use Illuminate\Database\Eloquent\Builder;
use Tinyissue\Model\Project;

/**
 * RelationTrait is trait class containing the relationship method for the User\Activity model.
 *
 * @author Mohamed Alsharaf <[email protected]>
 *
 * @property static $this
 */
trait ActivityScopes

{
    public function scopeLoadRelatedDetails(Builder $query)
    {
        return $query->with('activity', 'issue', 'user', 'assignTo', 'comment', 'note')
            ->orderBy('users_activity.created_at', 'DESC');
    }

    public function scopeLimitResultForUserRole(Builder $query)
    {
        // For logged users with role User, show issues that are created by them in internal projects
        // of issue create by any for other project statuses
        $user = $this->getLoggedUser();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        if (!is_null($user) && !$user->isUser()) {
            $query->join('projects_issues', 'projects_issues.id', '=', 'item_id');
            $query->join('projects', 'projects.id', '=', 'parent_id');
            $query->where(function (Builder $query) use ($user) {
                $query->where(function (Builder $query) use ($user) {
                    $query->where('created_by', '=', $user->id);
                    $query->where('private', '=', Project::INTERNAL_YES);
                });
                $query->orWhere('private', '<>', Project::INTERNAL_YES);
            });
        }

        return $query;
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Model\User;
13
14		use Illuminate\Database\Eloquent\Builder;
15		use Tinyissue\Model\Project;
16
17		/**
18		* RelationTrait is trait class containing the relationship method for the User\Activity model.
19		*
20		* @author Mohamed Alsharaf <[email protected]>
21		*
22		* @property static $this
23		*/
24	View Code Duplication	trait ActivityScopes
		0 ignored issues – show Duplication introduced 2016-09-11 11:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		public function scopeLoadRelatedDetails(Builder $query)
27		{
28		return $query->with('activity', 'issue', 'user', 'assignTo', 'comment', 'note')
29		->orderBy('users_activity.created_at', 'DESC');
30		}
31
32		public function scopeLimitResultForUserRole(Builder $query)
33		{
34		// For logged users with role User, show issues that are created by them in internal projects
35		// of issue create by any for other project statuses
36		$user = $this->getLoggedUser();
		0 ignored issues – show Bug introduced 2016-09-11 11:05 UTC by Report Bug Copy Issue Report It seems like `getLoggedUser()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37		if (!is_null($user) && !$user->isUser()) {
38		$query->join('projects_issues', 'projects_issues.id', '=', 'item_id');
39		$query->join('projects', 'projects.id', '=', 'parent_id');
40		$query->where(function (Builder $query) use ($user) {
41		$query->where(function (Builder $query) use ($user) {
42		$query->where('created_by', '=', $user->id);
43		$query->where('private', '=', Project::INTERNAL_YES);
44		});
45		$query->orWhere('private', '<>', Project::INTERNAL_YES);
46		});
47		}
48
49		return $query;
50		}
51		}
52

satrun77 / tinyissue

Branch — develop-3.0 (4fe777)

ActivityScopes::scopeLoadRelatedDetails() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like