Tinyissue\Model\TagRelations

Complexity

Total Complexity

7

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	parent()	0	4	1
A	tags()	0	4	1
A	userAccessibleTags()	0	4	1
A	scopeAccessibleToUser()	0	7	1
A	scopeAccessibleToLoggedUser()	0	4	1
A	issues()	0	4	1
A	projects()	0	4	1
	belongsTo()	0	1	?
	hasMany()	0	1	?
	belongsToMany()	0	1	?

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Model;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Relations;
use Tinyissue\Contracts\Model\UserInterface;

/**
 * RelationTrait is trait class containing the relationship methods for the Tag model.
 *
 * @author Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * @property static $this
 */
trait TagRelations
{
    /**
     * Returns the parent/group for the tag.
     *
     * @return Relations\BelongsTo
     */
    public function parent()
    {
        return $this->belongsTo('Tinyissue\Model\Tag', 'parent_id');
    }

    /**
     * Parent tag/group have many tags.
     *
     * @return Relations\HasMany
     */
    public function tags()
    {
        return $this->hasMany('Tinyissue\Model\Tag', 'parent_id');
    }

    public function userAccessibleTags()
    {
        return $this->tags()->accessibleToLoggedUser();
    }

    public function scopeAccessibleToUser(Builder $query, UserInterface $user)
    {
        return $query->where(function (Builder $query) use ($user) {
            $query->where('role_limit', '<=', $user->role_id);

Accessing role_id on the interface Tinyissue\Contracts\Model\UserInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            $query->orWhere('role_limit', '=', null);
        });
    }

    public function scopeAccessibleToLoggedUser(Builder $query)
    {
        return $this->scopeAccessibleToUser($query, $this->getLoggedUser());

It seems like getLoggedUser() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Returns issues for the Tag. Tag can belong to many issues & issue can have many tags.
     *
     * @return Relations\BelongsToMany
     */
    public function issues()
    {
        return $this->belongsToMany('Tinyissue\Model\Project\Issue', 'projects_issues_tags', 'issue_id', 'tag_id');
    }

    /**
     * Returns projects for the Tag. Tag can belong to many projects & project can have many tags.
     *
     * @return Relations\BelongsToMany
     */
    public function projects()
    {
        return $this->belongsToMany('Tinyissue\Model\Project', 'projects_kanban_tags', 'project_id', 'tag_id');
    }

    abstract public function belongsTo($related, $foreignKey = null, $otherKey = null, $relation = null);

    abstract public function hasMany($related, $foreignKey = null, $localKey = null);

    abstract public function belongsToMany($related, $table = null, $foreignKey = null, $otherKey = null, $relation = null);
}