ProjectController - Code Metrics - Inspection of "Bug: issues limited by create_by for user (interna..." - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( dd34aa...9f6d05 )

by Mohamed

created 2016-08-06 09:20 UTC

ProjectController B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	386
Duplicated Lines	11.4 %

Coupling/Cohesion

Components	1
Dependencies	11

Test Coverage

Coverage

98.59%

Importance

Changes	9
Bugs	3	Features	0

Metric	Value
wmc	37
c	9
b	3
f	0
lcom	1
cbo	11
dl	44
loc	386
ccs	140
cts	142
cp	0.9859
rs	8.6

16 Methods

Rating	Name	Duplication	Size	Complexity
A	getIndex()	0	21	3
A	getIssues()	0	17	4
A	getAssigned()	12	12	1
A	getCreated()	12	12	1
A	getNotes()	0	13	1
C	projectMainViewTabs()	0	58	13
A	getEdit()	0	8	1
A	postEdit()	0	15	2
A	getInactiveUsers()	0	6	1
A	postAssign()	10	10	2
A	postUnassign()	10	10	2
A	postAddNote()	0	8	1
A	postEditNote()	0	12	2
A	getDeleteNote()	0	6	1
A	postExportIssues()	0	23	1
A	getDownloadExport()	0	8	1

How to fix Duplicated Code

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Http\Controllers;

use Illuminate\Database\Eloquent\Relations\Relation;
use Illuminate\Http\Request;
use Tinyissue\Form\FilterIssue as FilterForm;
use Tinyissue\Form\Note as NoteForm;
use Tinyissue\Form\Project as Form;
use Tinyissue\Http\Requests\FormRequest;
use Tinyissue\Model\Project;
use Tinyissue\Model\Project\Issue;
use Tinyissue\Model\Project\Note;
use Tinyissue\Services\Exporter;

/**
 * ProjectController is the controller class for managing request related to a project.
 *
 * @author Mohamed Alsharaf <[email protected]>
 */
class ProjectController extends Controller
{
    /**
     * Display activity for a project.
     *
     * @param Project $project
     *
     * @return \Illuminate\View\View
     */
    public function getIndex(Project $project)
    {
        $activities = $project->activities()
            ->with('activity', 'issue', 'user', 'assignTo', 'comment', 'note')
            ->orderBy('users_activity.created_at', 'DESC')
            ->take(10);

        // Internal project and logged user can see created only
        if ($project->isPrivateInternal() && $this->auth->user()->isUser()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $activities->join('projects_issues', 'projects_issues.id', '=', 'item_id');
            $activities->where('created_by', '=', $this->auth->user()->id);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        }

        return view('project.index', [

            'tabs'       => $this->projectMainViewTabs($project, 'index'),
            'project'    => $project,
            'active'     => 'activity',
            'activities' => $activities->get(),
            'sidebar'    => 'project',
        ]);
    }

    /**
     * Display issues for a project.
     *
     * @param FilterForm $filterForm
     * @param Request    $request
     * @param Project    $project
     * @param int        $status
     *
     * @return \Illuminate\View\View
     */
    public function getIssues(FilterForm $filterForm, Request $request, Project $project, $status = Issue::STATUS_OPEN)
    {
        if ($project->isPrivateInternal() && $this->auth->user()->isUser()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $request['created_by'] = $this->auth->user()->id;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        }
        $active                = $status == Issue::STATUS_OPEN ? 'open_issue' : 'closed_issue';
        $issues                = $project->listIssues($status, $request->all());

        return view('project.index', [

            'tabs'       => $this->projectMainViewTabs($project, 'issues', $issues, $status),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'project'    => $project,
            'active'     => $active,
            'issues'     => $issues,
            'sidebar'    => 'project',
            'filterForm' => $filterForm,
        ]);
    }

    /**
     * Display issues assigned to current user for a project.
     *
     * @param Project $project
     *
     * @return \Illuminate\View\View
     */
    public function getAssigned(Project $project)

    {
        $issues = $project->listAssignedOrCreatedIssues($this->auth->user());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return view('project.index', [

            'tabs'    => $this->projectMainViewTabs($project, 'assigned', $issues),
            'project' => $project,
            'active'  => 'issue_assigned_to_you',
            'issues'  => $issues,
            'sidebar' => 'project',
        ]);
    }

    /**
     * Display issues created to current user for a project.
     *
     * @param Project $project
     *
     * @return \Illuminate\View\View
     */
    public function getCreated(Project $project)

    {
        $issues = $project->listAssignedOrCreatedIssues($this->auth->user());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return view('project.index', [

            'tabs'    => $this->projectMainViewTabs($project, 'created', $issues),
            'project' => $project,
            'active'  => 'issue_created_by_you',
            'issues'  => $issues,
            'sidebar' => 'project',
        ]);
    }

    /**
     * Display notes for a project.
     *
     * @param Project  $project
     * @param NoteForm $form
     *
     * @return \Illuminate\View\View
     */
    public function getNotes(Project $project, NoteForm $form)
    {
        $notes = $project->notes()->with('createdBy')->get();

        return view('project.index', [

            'tabs'     => $this->projectMainViewTabs($project, 'notes', $notes),
            'project'  => $project,
            'active'   => 'notes',
            'notes'    => $notes,
            'sidebar'  => 'project',
            'noteForm' => $form,
        ]);
    }

    /**
     * @param Project $project
     * @param string  $view
     * @param null    $data
     * @param bool    $status
     *
     * @return array
     */
    protected function projectMainViewTabs(Project $project, $view, $data = null, $status = false)
    {
        $notesCount        = $view === 'note' ? $data->count() : $project->notes()->count();

        $user              = $this->auth->user();
        $isLoggedIn        = !$this->auth->guest();
        $isUser            = $isLoggedIn && $user->isUser();
        $isInternalProject = $project->isPrivateInternal();

        if ($view === 'issues') {
            if ($status == Issue::STATUS_OPEN) {
                $closedIssuesCount = $project->closedIssuesCount($user)->count();
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                $openIssuesCount   = $data->count();

            } else {
                $closedIssuesCount = $data->count();

                $openIssuesCount   = $project->openIssuesCount($user)->count();
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            }
        } else {
            $openIssuesCount   = $project->openIssuesCount($user)->count();
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $closedIssuesCount = $project->closedIssuesCount($user)->count();
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }

        $tabs   = [];
        $tabs[] = [
            'url'  => $project->to(),
            'page' => 'activity',
        ];
        $tabs[] = [
            'url'    => $project->to('issues'),
            'page'   => 'open_issue',
            'prefix' => $openIssuesCount,
        ];
        $tabs[] = [
            'url'    => $project->to('issues') . '/0',
            'page'   => 'closed_issue',
            'prefix' => $closedIssuesCount,
        ];
        if ($isLoggedIn && (!$isInternalProject || (!$isUser && $isInternalProject))) {
            if ($view !== 'assigned') {
                $method              = $isUser ? 'createdIssuesCount' : 'assignedIssuesCount';
                $assignedIssuesCount = $this->auth->user()->$method($project->id);
            } else {
                $assignedIssuesCount = $data->count();

            }

            $tabs[] = [
                'url'    => $project->to($isUser ? 'created' : 'assigned'),
                'page'   => ($isUser ? 'issue_created_by_you' : 'issue_assigned_to_you'),
                'prefix' => $assignedIssuesCount,
            ];
        }
        $tabs[] = [
            'url'    => $project->to('notes'),
            'page'   => 'notes',
            'prefix' => $notesCount,
        ];

        return $tabs;
    }

    /**
     * Edit the project.
     *
     * @param Project $project
     * @param Form    $form
     *
     * @return \Illuminate\View\View
     */
    public function getEdit(Project $project, Form $form)
    {
        return view('project.edit', [

            'form'    => $form,
            'project' => $project,
            'sidebar' => 'project',
        ]);
    }

    /**
     * To update project details.
     *
     * @param Project             $project
     * @param FormRequest\Project $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function postEdit(Project $project, FormRequest\Project $request)
    {
        // Delete the project
        if ($request->has('delete-project')) {
            $project->delete();

            return redirect('projects')
                ->with('notice', trans('tinyissue.project_has_been_deleted'));
        }

        $project->update($request->all());

        return redirect($project->to())
            ->with('notice', trans('tinyissue.project_has_been_updated'));
    }

    /**
     * Ajax: returns list of users that are not in the project.
     *
     * @param Project $project
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function getInactiveUsers(Project $project = null)
    {
        $users = $project->usersNotIn();
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}

        return response()->json($users);
    }

    /**
     * Ajax: add user to the project.
     *
     * @param Project $project
     * @param Request $request
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function postAssign(Project $project, Request $request)

    {
        $status = false;
        if ($request->has('user_id')) {
            $project->assignUser((int) $request->input('user_id'));
            $status = true;
        }

        return response()->json(['status' => $status]);
    }

    /**
     * Ajax: remove user from the project.
     *
     * @param Project $project
     * @param Request $request
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function postUnassign(Project $project, Request $request)

    {
        $status = false;
        if ($request->has('user_id')) {
            $project->unassignUser((int) $request->input('user_id'));
            $status = true;
        }

        return response()->json(['status' => $status]);
    }

    /**
     * To add a new note to the project.
     *
     * @param Project          $project
     * @param Note             $note
     * @param FormRequest\Note $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function postAddNote(Project $project, Note $note, FormRequest\Note $request)
    {
        $note->setRelation('project', $project);
        $note->setRelation('createdBy', $this->auth->user());
        $note->createNote($request->all());

        return redirect($note->to())->with('notice', trans('tinyissue.your_note_added'));
    }

    /**
     * Ajax: To update project note.
     *
     * @param Project $project
     * @param Note    $note
     * @param Request $request
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function postEditNote(Project $project, Project\Note $note, Request $request)
    {
        $body = '';
        if ($request->has('body')) {
            $note->setRelation('project', $project);
            $note->updateBody($request->input('body'), $this->auth->user());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $body = \Html::format($note->body);
        }

        return response()->json(['status' => true, 'text' => $body]);
    }

    /**
     * Ajax: to delete a project note.
     *
     * @param Project $project
     * @param Note    $note
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function getDeleteNote(Project $project, Project\Note $note)

    {
        $note->deleteNote($this->auth->user());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return response()->json(['status' => true]);
    }

    /**
     * Ajax: generate the issues export file.
     *
     * @param Project  $project
     * @param Exporter $exporter
     * @param Request  $request
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function postExportIssues(Project $project, Exporter $exporter, Request $request)
    {
        // Generate export file
        $info = $exporter->exportFile(
            'Project\Issue',
            $request->input('format', Exporter::TYPE_CSV),

            $request->all()
        );

        // Download link
        $link = link_to(
            $project->to('download_export/' . $info['file']),
            trans('tinyissue.download_export'),
            ['class' => 'btn btn-link']
        );

        return response()->json([
            'link'  => $link,
            'title' => $info['title'],
            'file'  => $info['file'],
            'ext'   => $info['ext'],
        ]);
    }

    /**
     * Download and then delete an export file.
     *
     * @param Project $project
     * @param string  $file
     *
     * @return \Symfony\Component\HttpFoundation\BinaryFileResponse
     */
    public function getDownloadExport(Project $project, $file)

    {
        // Filter out any characters that are not in pattern
        $file = preg_replace('/[^a-z0-9\_\.]/mi', '', $file);

        // Download export
        return response()->download(storage_path('exports/' . $file), $file)->deleteFileAfterSend(true);
    }
}


Push — develop ( dd34aa...9f6d05 )

ProjectController B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

16 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Http\Controllers;
13
14		use Illuminate\Database\Eloquent\Relations\Relation;
15		use Illuminate\Http\Request;
16		use Tinyissue\Form\FilterIssue as FilterForm;
17		use Tinyissue\Form\Note as NoteForm;
18		use Tinyissue\Form\Project as Form;
19		use Tinyissue\Http\Requests\FormRequest;
20		use Tinyissue\Model\Project;
21		use Tinyissue\Model\Project\Issue;
22		use Tinyissue\Model\Project\Note;
23		use Tinyissue\Services\Exporter;
24
25		/**
26		* ProjectController is the controller class for managing request related to a project.
27		*
28		* @author Mohamed Alsharaf <[email protected]>
29		*/
30		class ProjectController extends Controller
31		{
32		/**
33		* Display activity for a project.
34		*
35		* @param Project $project
36		*
37		* @return \Illuminate\View\View
38		*/
39	12	public function getIndex(Project $project)
40		{

satrun77 / tinyissue

Push — develop ( dd34aa...9f6d05 )

ProjectController B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

16 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like