Issue - Code Metrics - Inspection of "Misc: increment version & update changes doc" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dec0dd...e17ce1 )

by Mohamed

created 2016-04-22 09:27 UTC

Issue A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	361
Duplicated Lines	12.19 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

99.18%

Importance

Changes	19
Bugs	7	Features	4

Metric	Value
wmc	33
lcom	1
cbo	7
dl	44
loc	361
c	19
b	7
f	4
ccs	121
cts	122
cp	0.9918
rs	9.3999

17 Methods

Rating	Name	Duplication	Size	Complexity
A	fieldBody()	0	9	1
A	getRedirectUrl()	0	8	2
A	getTags()	0	12	3
A	getIssueTagId()	0	15	3
A	issueModifyFields()	0	22	1
A	fieldTitle()	0	9	1
A	fieldStatusTags()	22	22	2
A	fieldTypeTags()	22	22	2
B	fieldResolutionTags()	0	29	2
A	fieldAssignedTo()	0	11	1
A	fieldUpload()	0	8	2
B	fieldTimeQuote()	0	24	1
A	extractQuoteValue()	0	15	4
A	setup()	0	7	2
A	actions()	0	6	2
A	fields()	0	20	3
A	rules()	0	9	1

How to fix Duplicated Code

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Form;

use Tinyissue\Model;

/**
 * Issue is a class to defines fields & rules for add/edit issue form.
 *
 * @author Mohamed Alsharaf <[email protected]>
 */
class Issue extends FormAbstract
{
    /**
     * An instance of project model.
     *
     * @var Model\Project
     */
    protected $project;

    /**
     * Collection of all tags.
     *
     * @var \Illuminate\Database\Eloquent\Collection
     */
    protected $tags = null;

    /**
     * @param string $type
     *
     * @return \Illuminate\Database\Eloquent\Collection|null
     */
    protected function getTags($type = null)
    {
        if ($this->tags === null) {
            $this->tags = (new Model\Tag())->getGroupTags();
        }

        if ($type) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->tags->where('name', $type)->first()->tags;
        }

        return $this->tags;
    }

    /**
     * Get issue tag for specific type/group.
     *
     * @param string $type
     *
     * @return int
     */
    protected function getIssueTagId($type)
    {
        if (!$this->isEditing()) {
            return 0;
        }

        $groupId     = $this->getTags($type)->first()->parent_id;
        $selectedTag = $this->getModel()->tags->where('parent_id', $groupId);

        if ($selectedTag->count() === 0) {
            return 0;
        }

        return $selectedTag->last()->id;
    }

    /**
     * @param array $params
     *
     * @return void
     */
    public function setup(array $params)
    {
        $this->project = $params['project'];
        if (!empty($params['issue'])) {
            $this->editingModel($params['issue']);
        }
    }

    /**
     * @return array
     */
    public function actions()
    {
        return [
            'submit' => $this->isEditing() ? 'update_issue' : 'create_issue',
        ];
    }

    /**
     * @return array
     */
    public function fields()
    {
        $issueModify = \Auth::user()->permission('issue-modify');

        $fields = $this->fieldTitle();
        $fields += $this->fieldBody();
        $fields += $this->fieldTypeTags();

        // Only on creating new issue
        if (!$this->isEditing()) {
            $fields += $this->fieldUpload();
        }

        // Show fields for users with issue modify permission
        if ($issueModify) {
            $fields += $this->issueModifyFields();
        }

        return $fields;
    }

    /**
     * Return a list of fields for users with issue modify permission.
     *
     * @return array
     */
    protected function issueModifyFields()
    {
        $fields = [];

        $fields['internal_status'] = [
            'type' => 'legend',
        ];

        // Status tags
        $fields += $this->fieldStatusTags();

        // Assign users
        $fields += $this->fieldAssignedTo();

        // Quotes
        $fields += $this->fieldTimeQuote();

        // Resolution tags
        $fields += $this->fieldResolutionTags();

        return $fields;
    }

    /**
     * Returns title field.
     *
     * @return array
     */
    protected function fieldTitle()
    {
        return [
            'title' => [
                'type'  => 'text',
                'label' => 'title',
            ],
        ];
    }

    /**
     * Returns body field.
     *
     * @return array
     */
    protected function fieldBody()
    {
        return [
            'body' => [
                'type'  => 'textarea',
                'label' => 'issue',
            ],
        ];
    }

    /**
     * Returns status tag field.
     *
     * @return array
     */
    protected function fieldStatusTags()

    {
        $tags    = $this->getTags('status');
        $options = [];
        foreach ($tags as $tag) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $options[ucwords($tag->name)] = [
                'name'      => 'tag_status',
                'value'     => $tag->id,
                'data-tags' => $tag->id,
                'color'     => $tag->bgcolor,
            ];
        }

        $fields['tag_status'] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            'label'  => 'status',
            'type'   => 'radioButton',
            'radios' => $options,
            'check'  => $this->getIssueTagId('status'),
        ];

        return $fields;
    }
    /**
     * Returns tags field.
     *
     * @return array
     */
    protected function fieldTypeTags()

    {
        $tags    = $this->getTags('type');
        $options = [];
        foreach ($tags as $tag) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $options[ucwords($tag->name)] = [
                'name'      => 'tag_type',
                'value'     => $tag->id,
                'data-tags' => $tag->id,
                'color'     => $tag->bgcolor,
            ];
        }

        $fields['tag_type'] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            'label'  => 'type',
            'type'   => 'radioButton',
            'radios' => $options,
            'check'  => $this->getIssueTagId('type'),
        ];

        return $fields;
    }

    /**
     * Returns tags field.
     *
     * @return array
     */
    protected function fieldResolutionTags()
    {
        $tags    = $this->getTags('resolution');
        $options = [
            trans('tinyissue.none') => [
                'name'      => 'tag_resolution',
                'value'     => 0,
                'data-tags' => 0,
                'color'     => '#62CFFC',
            ],
        ];
        foreach ($tags as $tag) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $options[ucwords($tag->name)] = [
                'name'      => 'tag_resolution',
                'value'     => $tag->id,
                'data-tags' => $tag->id,
                'color'     => $tag->bgcolor,
            ];
        }

        $fields['tag_resolution'] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            'label'  => 'resolution',
            'type'   => 'radioButton',
            'radios' => $options,
            'check'  => $this->getIssueTagId('resolution'),
        ];

        return $fields;
    }

    /**
     * Returns assigned to field.
     *
     * @return array
     */
    protected function fieldAssignedTo()
    {
        return [
            'assigned_to' => [
                'type'    => 'select',
                'label'   => 'assigned_to',
                'options' => [0 => ''] + $this->project->usersCanFixIssue()->get()->lists('fullname', 'id')->all(),
                'value'   => (int) $this->project->default_assignee,
            ],
        ];
    }

    /**
     * Returns upload field.
     *
     * @return array
     */
    protected function fieldUpload()
    {
        $user                      = \Auth::guest() ? new Model\User() : \Auth::user();
        $fields                    = $this->projectUploadFields('upload', $this->project, $user);
        $fields['upload']['label'] = 'attachments';

        return $fields;
    }

    /**
     * Returns time quote field.
     *
     * @return array
     */
    protected function fieldTimeQuote()
    {
        return [
            'time_quote' => [
                'type'   => 'groupField',
                'label'  => 'quote',
                'fields' => [
                    'h' => [
                        'type'          => 'number',
                        'append'        => trans('tinyissue.hours'),
                        'value'         => $this->extractQuoteValue('h'),
                        'addGroupClass' => 'col-sm-12 col-md-12 col-lg-4',
                    ],
                    'm' => [
                        'type'          => 'number',
                        'append'        => trans('tinyissue.minutes'),
                        'value'         => $this->extractQuoteValue('m'),
                        'addGroupClass' => 'col-sm-12 col-md-12 col-lg-4',
                    ],
                ],
                'addClass' => 'row issue-quote',
            ],
        ];
    }

    /**
     * @return array
     */
    public function rules()
    {
        $rules = [
            'title' => 'required|max:200',
            'body'  => 'required',
        ];

        return $rules;
    }

    /**
     * @return string
     */
    public function getRedirectUrl()
    {
        if ($this->isEditing()) {
            return $this->getModel()->to('edit');
        }

        return 'project/' . $this->project->id . '/issue/new';
    }

    /**
     * Extract number of hours, or minutes, or seconds from a quote.
     *
     * @param string $part
     *
     * @return float|int
     */
    protected function extractQuoteValue($part)
    {
        if ($this->getModel() instanceof Model\Project\Issue) {
            $seconds = $this->getModel()->time_quote;
            if ($part === 'h') {
                return floor($seconds / 3600);
            }

            if ($part === 'm') {
                return ($seconds / 60) % 60;
            }
        }

        return 0;
    }
}


1			<?php
2
3			/*
4			* This file is part of the Tinyissue package.
5			*
6			* (c) Mohamed Alsharaf <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Tinyissue\Form;
13
14			use Tinyissue\Model;
15
16			/**
17			* Issue is a class to defines fields & rules for add/edit issue form.
18			*
19			* @author Mohamed Alsharaf <[email protected]>
20			*/
21			class Issue extends FormAbstract
22			{
23			/**
24			* An instance of project model.
25			*
26			* @var Model\Project
27			*/
28			protected $project;
29
30			/**
31			* Collection of all tags.
32			*
33			* @var \Illuminate\Database\Eloquent\Collection
34			*/
35			protected $tags = null;
36
37			/**
38			* @param string $type
39			*
40			* @return \Illuminate\Database\Eloquent\Collection\|null
41			*/
42	7		protected function getTags($type = null)
43			{
44	7		if ($this->tags === null) {
45	7		$this->tags = (new Model\Tag())->getGroupTags();
46			}
47
48	7		if ($type) {
			0 ignored issues – show Bug Best Practice introduced 2016-04-19 08:26 UTC by Report Bug Copy Issue Report The expression `$type` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
49	7		return $this->tags->where('name', $type)->first()->tags;
50			}
51
52			return $this->tags;
53			}
54
55			/**
56			* Get issue tag for specific type/group.
57			*
58			* @param string $type
59			*
60			* @return int
61			*/
62	7		protected function getIssueTagId($type)
63			{
64	7		if (!$this->isEditing()) {
65	6		return 0;
66			}
67
68	2		$groupId = $this->getTags($type)->first()->parent_id;
69	2		$selectedTag = $this->getModel()->tags->where('parent_id', $groupId);
70
71	2		if ($selectedTag->count() === 0) {
72	2		return 0;
73			}
74
75	2		return $selectedTag->last()->id;
76			}
77
78			/**
79			* @param array $params
80			*
81			* @return void
82			*/
83	6		public function setup(array $params)
84			{
85	6		$this->project = $params['project'];
86	6		if (!empty($params['issue'])) {
87	2		$this->editingModel($params['issue']);
88			}
89	6		}
90
91			/**
92			* @return array
93			*/
94	6		public function actions()
95			{
96			return [
97	6		'submit' => $this->isEditing() ? 'update_issue' : 'create_issue',
98			];
99			}
100
101			/**
102			* @return array
103			*/
104	6		public function fields()
105			{
106	6		$issueModify = \Auth::user()->permission('issue-modify');
107
108	6		$fields = $this->fieldTitle();
109	6		$fields += $this->fieldBody();
110	6		$fields += $this->fieldTypeTags();
111
112			// Only on creating new issue
113	6		if (!$this->isEditing()) {
114	5		$fields += $this->fieldUpload();
115			}
116
117			// Show fields for users with issue modify permission
118	6		if ($issueModify) {
119	6		$fields += $this->issueModifyFields();
120			}
121
122	6		return $fields;
123			}
124
125			/**
126			* Return a list of fields for users with issue modify permission.
127			*
128			* @return array
129			*/
130	6		protected function issueModifyFields()
131			{
132	6		$fields = [];
133
134	6		$fields['internal_status'] = [
135			'type' => 'legend',
136			];
137
138			// Status tags
139	6		$fields += $this->fieldStatusTags();
140
141			// Assign users
142	6		$fields += $this->fieldAssignedTo();
143
144			// Quotes
145	6		$fields += $this->fieldTimeQuote();
146
147			// Resolution tags
148	6		$fields += $this->fieldResolutionTags();
149
150	6		return $fields;
151			}
152
153			/**
154			* Returns title field.
155			*
156			* @return array
157			*/
158	7		protected function fieldTitle()
159			{
160			return [
161			'title' => [
162			'type' => 'text',
163			'label' => 'title',
164	7		],
165			];
166			}
167
168			/**
169			* Returns body field.
170			*
171			* @return array
172			*/
173	7		protected function fieldBody()
174			{
175			return [
176			'body' => [
177			'type' => 'textarea',
178			'label' => 'issue',
179	7		],
180			];
181			}
182
183			/**
184			* Returns status tag field.
185			*
186			* @return array
187			*/
188	6	View Code Duplication	protected function fieldStatusTags()
			0 ignored issues – show Duplication introduced 2016-04-19 08:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
189			{
190	6		$tags = $this->getTags('status');
191	6		$options = [];
192	6		foreach ($tags as $tag) {
			0 ignored issues – show Bug introduced 2016-04-19 08:26 UTC by Report Bug Copy Issue Report The expression `$tags` of type `object<Illuminate\Databa...oquent\Collection>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
193	6		$options[ucwords($tag->name)] = [
194	6		'name' => 'tag_status',
195	6		'value' => $tag->id,
196	6		'data-tags' => $tag->id,
197	6		'color' => $tag->bgcolor,
198			];
199			}
200
201	6		$fields['tag_status'] = [
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-19 08:26 UTC by Report Bug Copy Issue Report `$fields` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$fields = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
202	6		'label' => 'status',
203	6		'type' => 'radioButton',
204	6		'radios' => $options,
205	6		'check' => $this->getIssueTagId('status'),
206			];
207
208	6		return $fields;
209			}
210			/**
211			* Returns tags field.
212			*
213			* @return array
214			*/
215	7	View Code Duplication	protected function fieldTypeTags()
			0 ignored issues – show Duplication introduced 2016-04-19 08:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
216			{
217	7		$tags = $this->getTags('type');
218	7		$options = [];
219	7		foreach ($tags as $tag) {
			0 ignored issues – show Bug introduced 2016-04-19 08:26 UTC by Report Bug Copy Issue Report The expression `$tags` of type `object<Illuminate\Databa...oquent\Collection>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
220	7		$options[ucwords($tag->name)] = [
221	7		'name' => 'tag_type',
222	7		'value' => $tag->id,
223	7		'data-tags' => $tag->id,
224	7		'color' => $tag->bgcolor,
225			];
226			}
227
228	7		$fields['tag_type'] = [
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-19 08:26 UTC by Report Bug Copy Issue Report `$fields` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$fields = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
229	7		'label' => 'type',
230	7		'type' => 'radioButton',
231	7		'radios' => $options,
232	7		'check' => $this->getIssueTagId('type'),
233			];
234
235	7		return $fields;
236			}
237
238			/**
239			* Returns tags field.
240			*
241			* @return array
242			*/
243	6		protected function fieldResolutionTags()
244			{
245	6		$tags = $this->getTags('resolution');
246			$options = [
247	6		trans('tinyissue.none') => [
248			'name' => 'tag_resolution',
249			'value' => 0,
250			'data-tags' => 0,
251			'color' => '#62CFFC',
252	6		],
253			];
254	6		foreach ($tags as $tag) {
			0 ignored issues – show Bug introduced 2016-04-19 08:26 UTC by Report Bug Copy Issue Report The expression `$tags` of type `object<Illuminate\Databa...oquent\Collection>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
255	6		$options[ucwords($tag->name)] = [
256	6		'name' => 'tag_resolution',
257	6		'value' => $tag->id,
258	6		'data-tags' => $tag->id,
259	6		'color' => $tag->bgcolor,
260			];
261			}
262
263	6		$fields['tag_resolution'] = [
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-19 08:26 UTC by Report Bug Copy Issue Report `$fields` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$fields = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
264	6		'label' => 'resolution',
265	6		'type' => 'radioButton',
266	6		'radios' => $options,
267	6		'check' => $this->getIssueTagId('resolution'),
268			];
269
270	6		return $fields;
271			}
272
273			/**
274			* Returns assigned to field.
275			*
276			* @return array
277			*/
278	6		protected function fieldAssignedTo()
279			{
280			return [
281			'assigned_to' => [
282	6		'type' => 'select',
283	6		'label' => 'assigned_to',
284	6		'options' => [0 => ''] + $this->project->usersCanFixIssue()->get()->lists('fullname', 'id')->all(),
285	6		'value' => (int) $this->project->default_assignee,
286			],
287			];
288			}
289
290			/**
291			* Returns upload field.
292			*
293			* @return array
294			*/
295	6		protected function fieldUpload()
296			{
297	6		$user = \Auth::guest() ? new Model\User() : \Auth::user();
298	6		$fields = $this->projectUploadFields('upload', $this->project, $user);
299	6		$fields['upload']['label'] = 'attachments';
300
301	6		return $fields;
302			}
303
304			/**
305			* Returns time quote field.
306			*
307			* @return array
308			*/
309	6		protected function fieldTimeQuote()
310			{
311			return [
312			'time_quote' => [
313	6		'type' => 'groupField',
314	6		'label' => 'quote',
315			'fields' => [
316			'h' => [
317	6		'type' => 'number',
318	6		'append' => trans('tinyissue.hours'),
319	6		'value' => $this->extractQuoteValue('h'),
320	6		'addGroupClass' => 'col-sm-12 col-md-12 col-lg-4',
321			],
322			'm' => [
323	6		'type' => 'number',
324	6		'append' => trans('tinyissue.minutes'),
325	6		'value' => $this->extractQuoteValue('m'),
326	6		'addGroupClass' => 'col-sm-12 col-md-12 col-lg-4',
327			],
328			],
329	6		'addClass' => 'row issue-quote',
330			],
331			];
332			}
333
334			/**
335			* @return array
336			*/
337	7		public function rules()
338			{
339			$rules = [
340	7		'title' => 'required\|max:200',
341			'body' => 'required',
342			];
343
344	7		return $rules;
345			}
346
347			/**
348			* @return string
349			*/
350			public function getRedirectUrl()
351			{
352			if ($this->isEditing()) {
353			return $this->getModel()->to('edit');
354			}
355
356			return 'project/' . $this->project->id . '/issue/new';
357			}
358
359			/**
360			* Extract number of hours, or minutes, or seconds from a quote.
361			*
362			* @param string $part
363			*
364			* @return float\|int
365			*/
366	6		protected function extractQuoteValue($part)
367			{
368	6		if ($this->getModel() instanceof Model\Project\Issue) {
369	2		$seconds = $this->getModel()->time_quote;
370	2		if ($part === 'h') {
371	2		return floor($seconds / 3600);
372			}
373
374	2		if ($part === 'm') {
375	2		return ($seconds / 60) % 60;
376			}
377			}
378
379	5		return 0;
380			}
381			}
382

satrun77 / tinyissue

Push — master ( dec0dd...e17ce1 )

Issue A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

17 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like