Tinyissue\Model\Project\UserScopes

Complexity

Total Complexity

2

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	scopeForUser()	0	4	1
A	scopeInProjects()	0	4	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Model\Project;

use Illuminate\Database\Eloquent\Builder;
use Tinyissue\Contracts\Model\UserInterface;

/**
 * UserScopes is trait class containing the model scope methods.
 *
 * @author Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * @property static $this
 */
trait UserScopes
{
    /**
     * Filter for project user by user id.
     *
     * @param Builder       $query
     * @param UserInterface $user
     *
     * @return Builder
     */
    public function scopeForUser(Builder $query, UserInterface $user)
    {
        return $query->where('user_id', '=', $user->id);

Accessing id on the interface Tinyissue\Contracts\Model\UserInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    /**
     * Filter for project users in list or project ids.
     *
     * @param Builder $query
     * @param array   $projectIds
     *
     * @return Builder
     */
    public function scopeInProjects(Builder $query, array $projectIds)
    {
        return $query->whereIn('project_id', $projectIds);
    }
}