CrudTrait - Code Metrics - Inspection of "Misc: build CS & JS" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 680621...53566b )

by Mohamed

created 2016-05-05 09:35 UTC

CrudTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

15.38%

Importance

Changes	9
Bugs	2	Features	2

Metric	Value
wmc	10
c	9
b	2
f	2
lcom	1
cbo	1
dl	0
loc	88
ccs	4
cts	26
cp	0.1538
rs	10

5 Methods

Rating	Name	Size	Complexity
A	createTag()	4	1
A	update()	4	1
B	validOrCreate()	21	6
A	delete()	10	1
A	prepareTagToSave()	6	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Model\Traits\Tag;

use Illuminate\Database\Eloquent;
use Tinyissue\Model\Project;
use Tinyissue\Model\Tag;

/**
 * CrudTrait is trait class containing the methods for adding/editing/deleting the Tag model.
 *
 * @author Mohamed Alsharaf <[email protected]>
 *
 * @method Eloquent\Model where($column, $operator = null, $value = null, $boolean = 'and')
 */
trait CrudTrait
{
    /**
     * Create a new tag.
     *
     * @param array $input
     *
     * @return mixed
     */
    public function createTag(array $input)
    {
        return $this->fill($this->prepareTagToSave($input))->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Update the tags in the database.
     *
     * @param array $attributes
     *
     * @return bool|int
     */
    public function update(array $attributes = [])
    {
        return parent::update($this->prepareTagToSave($attributes));
    }

    /**
     * Create a new tag if valid or return existing one.
     *
     * @param string   $name
     * @param null|Tag $parent
     *
     * @return bool|$this
     */
    public function validOrCreate($name, Tag $parent = null)
    {
        $group = $parent === null ? true : false;
        $tag   = $this->where('name', '=', $name)->first();
        if ($tag && $tag->group != $group) {
            return false;
        }

        if (!$tag) {
            $tag        = new Tag();
            $tag->name  = $name;
            $tag->group = $group;
            if (!is_null($parent)) {
                $tag->parent_id = $parent->id;
                $tag->setRelation('parent', $parent);
            }
            $tag->save();
        }

        return $tag;
    }

    /**
     * Delete tag.
     *
     * @return bool|null
     *
     * @throws \Exception
     */
    public function delete()
    {
        // Remove kanban tags
        \DB::table('projects_kanban_tags')->where('tag_id', '=', $this->id)->delete();
class MyClass { }

$x = new MyClass();
$x->foo = true;

        // Remove relation to issues
        \DB::table('projects_issues_tags')->where('tag_id', '=', $this->id)->delete();

        return parent::delete();
    }

    /**
     * Prepare tag details to save.
     *
     * @param array $input
     *
     * @return array
     */
    protected function prepareTagToSave(array $input)
    {
        $input['group'] = 0;

        return $input;
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Model\Traits\Tag;
13
14		use Illuminate\Database\Eloquent;
15		use Tinyissue\Model\Project;
16		use Tinyissue\Model\Tag;
17
18		/**
19		* CrudTrait is trait class containing the methods for adding/editing/deleting the Tag model.
20		*
21		* @author Mohamed Alsharaf <[email protected]>
22		*
23		* @method Eloquent\Model where($column, $operator = null, $value = null, $boolean = 'and')
24		*/
25		trait CrudTrait
26		{
27		/**
28		* Create a new tag.
29		*
30		* @param array $input
31		*
32		* @return mixed
33	1	*/
34		public function createTag(array $input)
35	1	{
36		return $this->fill($this->prepareTagToSave($input))->save();
		0 ignored issues – show Bug introduced 2016-03-07 09:48 UTC by Report Bug Copy Issue Report It seems like `fill()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37		}
38
39		/**
40		* Update the tags in the database.
41		*
42		* @param array $attributes
43		*
44		* @return bool\|int
45		*/
46		public function update(array $attributes = [])
47		{
48		return parent::update($this->prepareTagToSave($attributes));
49		}
50
51		/**
52		* Create a new tag if valid or return existing one.
53		*
54		* @param string $name
55		* @param null\|Tag $parent
56		*
57		* @return bool\|$this
58		*/
59		public function validOrCreate($name, Tag $parent = null)
60		{
61		$group = $parent === null ? true : false;
62		$tag = $this->where('name', '=', $name)->first();
63		if ($tag && $tag->group != $group) {
64		return false;
65		}
66
67		if (!$tag) {
68		$tag = new Tag();
69		$tag->name = $name;
70		$tag->group = $group;
71		if (!is_null($parent)) {
72		$tag->parent_id = $parent->id;
73		$tag->setRelation('parent', $parent);
74		}
75		$tag->save();
76		}
77
78		return $tag;
79		}
80
81		/**
82		* Delete tag.
83		*
84		* @return bool\|null
85		*
86		* @throws \Exception
87		*/
88		public function delete()
89		{
90		// Remove kanban tags
91		\DB::table('projects_kanban_tags')->where('tag_id', '=', $this->id)->delete();
		0 ignored issues – show Bug introduced 2016-05-05 09:38 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
92
93		// Remove relation to issues
94		\DB::table('projects_issues_tags')->where('tag_id', '=', $this->id)->delete();
95
96		return parent::delete();
97		}
98
99		/**
100		* Prepare tag details to save.
101		*
102		* @param array $input
103		*
104		* @return array
105		*/
106		protected function prepareTagToSave(array $input)
107		{
108		$input['group'] = 0;
109	1
110		return $input;
111	1	}
112		}
113

satrun77 / tinyissue

Push — develop ( 680621...53566b )

CrudTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like