RelationTrait - Code Metrics - Inspection of "Feature: Messaging system" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 64265e...12ceca )

by Mohamed

created 2016-06-05 23:55 UTC

RelationTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
c	1
b	0
f	0
lcom	0
cbo	0
dl	0
loc	18
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	changeBy()	0	4	1
A	model()	0	4	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Model\Traits\Message\Queue;

use Illuminate\Database\Eloquent\Relations;

/**
 * RelationTrait is trait class containing the relationship methods for the message queue model.
 *
 * @author Mohamed Alsharaf <[email protected]>
 */
trait RelationTrait
{
    /**
     * @return mixed
     */
    public function changeBy()
    {
        return $this->belongsTo('\Tinyissue\Model\User', 'change_by_id');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @return mixed
     */
    public function model()
    {
        return $this->morphTo();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			/*
4			* This file is part of the Tinyissue package.
5			*
6			* (c) Mohamed Alsharaf <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Tinyissue\Model\Traits\Message\Queue;
13
14			use Illuminate\Database\Eloquent\Relations;
15
16			/**
17			* RelationTrait is trait class containing the relationship methods for the message queue model.
18			*
19			* @author Mohamed Alsharaf <[email protected]>
20			*/
21			trait RelationTrait
22			{
23			/**
24			* @return mixed
25			*/
26			public function changeBy()
27			{
28			return $this->belongsTo('\Tinyissue\Model\User', 'change_by_id');
			0 ignored issues – show Bug introduced 2016-06-06 00:05 UTC by Report Bug Copy Issue Report It seems like `belongsTo()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29			}
30
31			/**
32			* @return mixed
33			*/
34			public function model()
35			{
36			return $this->morphTo();
			0 ignored issues – show Bug introduced 2016-06-06 00:05 UTC by Report Bug Copy Issue Report It seems like `morphTo()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37			}
38			}
39

satrun77 / tinyissue

Push — develop ( 64265e...12ceca )

RelationTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like