Authenticate::handle() - Code Metrics - Inspection of "Test: removed tags related tests (temp)" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( a45eac...0b88af )

by Mohamed

created 2016-04-21 09:29 UTC

Authenticate::handle() A

↳ Parent: Authenticate

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3.0175

Importance

Changes	7
Bugs	3	Features	1

Metric	Value
c	7
b	3
f	1
dl	0
loc	14
ccs	7
cts	8
cp	0.875
rs	9.4285
cc	3
eloc	7
nc	3
nop	2
crap	3.0175

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Http\Middleware;

use Closure;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Http\Request;

/**
 * Authenticate is a Middleware class to for checking if current user is logged in.
 *
 * @author Mohamed Alsharaf <[email protected]>
 */
class Authenticate
{
    /**
     * The Guard implementation.
     *
     * @var Guard
     */
    protected $auth;

    /**
     * Create a new filter instance.
     *
     * @param Guard $auth
     */
    public function __construct(Guard $auth)
    {
        $this->auth = $auth;
    }

    /**
     * Handle an incoming request.
     *
     * @param Request  $request
     * @param \Closure $next
     *
     * @return mixed
     */
    public function handle(Request $request, Closure $next)
    {
        if ($this->auth->guest()) {
            if ($request->ajax()) {
                abort(401);
            }

            return redirect()->guest('/');
        }

        app()->setLocale($this->auth->user()->language);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        return $next($request);
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Http\Middleware;
13
14		use Closure;
15		use Illuminate\Contracts\Auth\Guard;
16		use Illuminate\Http\Request;
17
18		/**
19		* Authenticate is a Middleware class to for checking if current user is logged in.
20		*
21		* @author Mohamed Alsharaf <[email protected]>
22		*/
23		class Authenticate
24		{
25		/**
26		* The Guard implementation.
27		*
28		* @var Guard
29		*/
30		protected $auth;
31
32		/**
33		* Create a new filter instance.
34		*
35		* @param Guard $auth
36		*/
37	54	public function __construct(Guard $auth)
38		{
39	54	$this->auth = $auth;
40	54	}
41
42		/**
43		* Handle an incoming request.
44		*
45		* @param Request $request
46		* @param \Closure $next
47		*
48		* @return mixed
49		*/
50	54	public function handle(Request $request, Closure $next)
51		{
52	54	if ($this->auth->guest()) {
53	2	if ($request->ajax()) {
54	1	abort(401);
55		}
56
57	1	return redirect()->guest('/');
58		}
59
60	52	app()->setLocale($this->auth->user()->language);
		0 ignored issues – show Bug introduced 2016-03-16 08:02 UTC by Report Bug Copy Issue Report Accessing `language` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
61
62	52	return $next($request);
63		}
64		}
65

satrun77 / tinyissue

Push — develop ( a45eac...0b88af )

Authenticate::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like