QueryTrait::isModelCreatedByUser() - Code Metrics - Inspection of "Test: added test cases for messaging system" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 1c3d8e...dc7d05 )

by Mohamed

created 2016-06-18 09:50 UTC

QueryTrait::isModelCreatedByUser() A

↳ Parent: QueryTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	0
cts	6
cp	0
rs	9.4285
cc	1
eloc	6
nc	1
nop	2
crap	2

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Model\Traits\Message\Queue;

use Illuminate\Database\Eloquent\Eloquent;
use Illuminate\Database\Eloquent\Relations;
use Tinyissue\Model\Message;
use Tinyissue\Model\Project\Issue;
use Tinyissue\Model\Tag;
use Tinyissue\Model\User;
use Tinyissue\Model\Message\Queue;

/**
 * QueryTrait is trait class containing the database queries methods for the message queue model.
 *
 * @author Mohamed Alsharaf <[email protected]>
 *
 * @method Relations\BelongsToMany tags()
 */
trait QueryTrait
{
    /**
     * Check whether an issue has registered add new issue in the queue.
     *
     * @param Model $model
     * @param User  $user
     *
     * @return bool
     */
    public function isModelCreatedByUser(Model $model, User $user)
    {
        return $this->where('event', '=', $this->getAddEventNameFromModel($model))
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->where('model_id', '=', $model->id)
            ->where('model_type', '=', get_class($model))
            ->where('change_by_id', '=', $user->id)
            ->first();
    }

    /**
     * Get the latest messages queue.
     * 
     * @return mixed
     */
    public function latestMessages()
    {
        return $this->with('changeBy', 'model')->orderBy('created_at', 'DESC')->orderBy('id', 'DESC');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Model\Traits\Message\Queue;
13
14		use Illuminate\Database\Eloquent\Eloquent;
15		use Illuminate\Database\Eloquent\Relations;
16		use Tinyissue\Model\Message;
17		use Tinyissue\Model\Project\Issue;
18		use Tinyissue\Model\Tag;
19		use Tinyissue\Model\User;
20		use Tinyissue\Model\Message\Queue;
21
22		/**
23		* QueryTrait is trait class containing the database queries methods for the message queue model.
24		*
25		* @author Mohamed Alsharaf <[email protected]>
26		*
27		* @method Relations\BelongsToMany tags()
28		*/
29		trait QueryTrait
30		{
31		/**
32		* Check whether an issue has registered add new issue in the queue.
33		*
34		* @param Model $model
35		* @param User $user
36		*
37		* @return bool
38		*/
39		public function isModelCreatedByUser(Model $model, User $user)
40		{
41		return $this->where('event', '=', $this->getAddEventNameFromModel($model))
		0 ignored issues – show Bug introduced 2016-06-06 00:05 UTC by Report Bug Copy Issue Report It seems like `getAddEventNameFromModel()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2016-06-06 00:05 UTC by Report Bug Copy Issue Report It seems like `where()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42		->where('model_id', '=', $model->id)
43		->where('model_type', '=', get_class($model))
44		->where('change_by_id', '=', $user->id)
45		->first();
46		}
47
48		/**
49		* Get the latest messages queue.
50		*
51		* @return mixed
52		*/
53	4	public function latestMessages()
54		{
55	4	return $this->with('changeBy', 'model')->orderBy('created_at', 'DESC')->orderBy('id', 'DESC');
		0 ignored issues – show Bug introduced 2016-06-06 00:05 UTC by Report Bug Copy Issue Report It seems like `with()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
56		}
57		}
58

satrun77 / tinyissue

Push — develop ( 1c3d8e...dc7d05 )

QueryTrait::isModelCreatedByUser() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like