HomeController::getIssues() - Code Metrics - Inspection of "Revert "Misc: added .DS_Store to .gitignore"" - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (a31570)

by Mohamed

created 2016-01-10 07:04 UTC

HomeController::getIssues() A

↳ Parent: HomeController

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	0
cts	0
cp	0
rs	9.4286
cc	1
eloc	5
nc	1
nop	2
crap	2

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Http\Controllers;

use Tinyissue\Form\Login as LoginForm;
use Tinyissue\Http\Requests\FormRequest;
use Tinyissue\Model\Project;
use Tinyissue\Model\User;

/**
 * HomeController is the controller class for login, logout, dashboard pages
 *
 * @author Mohamed Alsharaf <[email protected]>
 */
class HomeController extends Controller
{
    /**
     * Public issues view
     *
     * @param User $user
     * @param Project $project
     * @return \Illuminate\View\View
     */
    public function getIssues(User $user, Project $project)
    {
        return view('index.issues', [
            'activeUsers' => $user->activeUsers(),
            'projects'    => $project->projectsWidthIssues(Project::STATUS_OPEN, Project::PRIVATE_NO)->get(),
            'sidebar'     => 'public',
        ]);
    }

    /**
     * User dashboard
     *
     * @return \Illuminate\View\View
     */
    public function getDashboard()
    {
        return view('index.dashboard', [
            'projects' => $this->auth->user()->projectsWidthActivities(Project::STATUS_OPEN)->get(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        ]);
    }

    /**
     * Logout user and redirect to login page
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function getLogout()
    {
        $this->auth->logout();

        return redirect('/')->with('message', trans('tinyissue.loggedout'));
    }

    /**
     * Login page
     *
     * @param LoginForm $form
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|\Illuminate\View\View
     */
    public function getIndex(LoginForm $form)
    {
        if ($this->auth->user()) {
            return redirect('dashboard');
        }

        return view('user.login', ['form' => $form]);
    }

    /**
     * Attempt to log user in or redirect to login page with error
     *
     * @param FormRequest\Login $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function postSignin(FormRequest\Login $request)
    {
        $credentials = $request->only('email', 'password');

        if ($this->auth->attempt($credentials, $request->has('remember'))) {
            return redirect()->to('/dashboard');
        }

        return redirect('/')
                        ->withInput($request->only('email'))
                        ->with('notice-error', trans('tinyissue.password_incorrect'));
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Http\Controllers;
13
14		use Tinyissue\Form\Login as LoginForm;
15		use Tinyissue\Http\Requests\FormRequest;
16		use Tinyissue\Model\Project;
17		use Tinyissue\Model\User;
18
19		/**
20		* HomeController is the controller class for login, logout, dashboard pages
21		*
22		* @author Mohamed Alsharaf <[email protected]>
23		*/
24		class HomeController extends Controller
25		{
26		/**
27		* Public issues view
28		*
29		* @param User $user
30		* @param Project $project
31		* @return \Illuminate\View\View
32		*/
33		public function getIssues(User $user, Project $project)
34		{
35		return view('index.issues', [
36		'activeUsers' => $user->activeUsers(),
37		'projects' => $project->projectsWidthIssues(Project::STATUS_OPEN, Project::PRIVATE_NO)->get(),
38		'sidebar' => 'public',
39		]);
40		}
41
42		/**
43		* User dashboard
44		*
45		* @return \Illuminate\View\View
46		*/
47	10	public function getDashboard()
48		{
49	10	return view('index.dashboard', [
50	10	'projects' => $this->auth->user()->projectsWidthActivities(Project::STATUS_OPEN)->get(),
		0 ignored issues – show Bug introduced 2015-12-15 16:27 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Authenticatable` as the method `projectsWidthActivities()` does only exist in the following implementations of said interface: `Tinyissue\Model\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
51		]);
52		}
53
54		/**
55		* Logout user and redirect to login page
56		*
57		* @return \Illuminate\Http\RedirectResponse
58		*/
59	1	public function getLogout()
60		{
61	1	$this->auth->logout();
62
63	1	return redirect('/')->with('message', trans('tinyissue.loggedout'));
64		}
65
66		/**
67		* Login page
68		*
69		* @param LoginForm $form
70		*
71		* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Routing\Redirector\|\Illuminate\View\View
72		*/
73	12	public function getIndex(LoginForm $form)
74		{
75	12	if ($this->auth->user()) {
76	3	return redirect('dashboard');
77		}
78
79	9	return view('user.login', ['form' => $form]);
80		}
81
82		/**
83		* Attempt to log user in or redirect to login page with error
84		*
85		* @param FormRequest\Login $request
86		*
87		* @return \Illuminate\Http\RedirectResponse
88		*/
89	8	public function postSignin(FormRequest\Login $request)
90		{
91	8	$credentials = $request->only('email', 'password');
92
93	8	if ($this->auth->attempt($credentials, $request->has('remember'))) {
94	7	return redirect()->to('/dashboard');
95		}
96
97	1	return redirect('/')
98	1	->withInput($request->only('email'))
99	1	->with('notice-error', trans('tinyissue.password_incorrect'));
100		}
101		}
102

satrun77 / tinyissue

Branch — develop (a31570)

HomeController::getIssues() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like