Tinyissue\Http\Middleware\Permission

Complexity

Total Complexity

10

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes	6
Bugs	2	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	handle()	0	20	8
A	getPermission()	0	6	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Http\Middleware;

use Closure;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Http\Request;
use Tinyissue\Model\Project as ProjectModel;

/**
 * Permission is a Middleware class to for checking if current user has the permission to access the request
 *
 * @author Mohamed Alsharaf <mohamed.alsharaf@gmail.com>
 */
class Permission
{
    /**
     * The Guard implementation.
     *
     * @var Guard
     */
    protected $auth;

    /**
     * List of permissions that can be accessed by public users
     *
     * @var array
     */
    protected $publicAccess = [
        'issue-view'
    ];

    /**
     * Create a new filter instance.
     *
     * @param Guard $auth
     */
    public function __construct(Guard $auth)
    {
        $this->auth = $auth;
    }

    /**
     * Handle an incoming request.
     *
     * @param Request  $request
     * @param \Closure $next
     *
     * @return mixed
     */
    public function handle(Request $request, Closure $next)
    {
        $permission = $this->getPermission($request);
        $user = $this->auth->user();
        /** @var ProjectModel|null $project */
        $project = $request->route()->getParameter('project');

        // Check if user has the permission
        // & if the user can access the current context (e.g. is one of the project users)
        if (app('tinyissue.settings')->isPublicProjectsEnabled()

This if statement is empty and can be removed.

            && in_array($permission, $this->publicAccess)
            && $project instanceof ProjectModel && !$project->isPrivate()) {
            // Ignore we are ok to view issues in public project
        } else if (!$this->auth->guest()
            && (!$user->permission($permission) || !$user->permissionInContext($request->route()->parameters()))) {
            abort(401);
        }

        return $next($request);
    }

    /**
     * Returns the permission defined in route action
     *
     * @param Request $request
     *
     * @return mixed
     */
    protected function getPermission(Request $request)
    {
        $actions = $request->route()->getAction();

        return $actions['permission'];
    }
}