QueryTrait::rolesWithUsers() - Code Metrics - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

QueryTrait::rolesWithUsers() A
last analyzed 2016-08-19 12:52 UTC

↳ Parent: QueryTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Model\Traits\Role;

use Illuminate\Database\Eloquent;
use Tinyissue\Model\Role;

/**
 * QueryTrait is trait class containing the database queries methods for the Role model.
 *
 * @author Mohamed Alsharaf <[email protected]>
 *
 * @property static $this
 *
 * @method $this with($relations);
 */
trait QueryTrait
{
    /**
     * Drop down of all roles.
     *
     * @return Eloquent\Collection
     */
    public static function dropdown()
    {
        return Role::lists('name', 'id');
    }

    /**
     * Returns all roles with users of each role.
     *
     * @return Eloquent\Collection
     */
    public function rolesWithUsers()
    {
        return $this->with('users')->orderBy('id', 'DESC')->get();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Model\Traits\Role;
13
14		use Illuminate\Database\Eloquent;
15		use Tinyissue\Model\Role;
16
17		/**
18		* QueryTrait is trait class containing the database queries methods for the Role model.
19		*
20		* @author Mohamed Alsharaf <[email protected]>
21		*
22		* @property static $this
23		*
24		* @method $this with($relations);
25		*/
26		trait QueryTrait
27		{
28		/**
29		* Drop down of all roles.
30		*
31		* @return Eloquent\Collection
32		*/
33	4	public static function dropdown()
34		{
35	4	return Role::lists('name', 'id');
36		}
37
38		/**
39		* Returns all roles with users of each role.
40		*
41		* @return Eloquent\Collection
42		*/
43	3	public function rolesWithUsers()
44		{
45	3	return $this->with('users')->orderBy('id', 'DESC')->get();
		0 ignored issues – show Bug introduced 2016-08-11 03:06 UTC by Report Bug Copy Issue Report It seems like `orderBy()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
46		}
47		}
48

satrun77 / tinyissue

QueryTrait::rolesWithUsers() A last analyzed 2016-08-19 12:52 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

QueryTrait::rolesWithUsers() A
last analyzed 2016-08-19 12:52 UTC