UserSetting::innerFields() - Code Metrics - satrun77/tinyissue - Measure and Improve Code Quality continuously with Scrutinizer

UserSetting::innerFields() A
last analyzed 2016-08-19 12:52 UTC

↳ Parent: UserSetting

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	14
ccs	7
cts	7
cp	1
rs	9.4285
cc	1
eloc	9
nc	1
nop	0
crap	1

<?php

/*
 * This file is part of the Tinyissue package.
 *
 * (c) Mohamed Alsharaf <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tinyissue\Form;

use Illuminate\Contracts\Auth\Guard;

/**
 * UserSetting is a class to defines fields & rules for add/edit user settings form.
 *
 * @author Mohamed Alsharaf <[email protected]>
 */
class UserSetting extends User
{
    /**
     * @param Guard $model
     */
    public function __construct(Guard $model)
    {
        $this->editingModel($model->user());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @return array
     */
    public function actions()
    {
        return [
            'submit' => 'update',
        ];
    }

    /**
     * @return array
     */
    protected function innerFields()
    {
        $fields = [
            'language' => [
                'type'    => 'select',
                'label'   => 'language',
                'options' => $this->getModel()->getLanguages(),
                'value'   => app('tinyissue.settings')->getLanguage(),
            ],
        ];
        $fields += $this->passwordFields();

        return $fields;
    }

    /**
     * @return array
     */
    public function rules()
    {
        $rules             = parent::rules();
        $rules['password'] = 'confirmed';
        $rules['language'] = 'required';

        return $rules;
    }
}


1		<?php
2
3		/*
4		* This file is part of the Tinyissue package.
5		*
6		* (c) Mohamed Alsharaf <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Tinyissue\Form;
13
14		use Illuminate\Contracts\Auth\Guard;
15
16		/**
17		* UserSetting is a class to defines fields & rules for add/edit user settings form.
18		*
19		* @author Mohamed Alsharaf <[email protected]>
20		*/
21		class UserSetting extends User
22		{
23		/**
24		* @param Guard $model
25		*/
26	4	public function __construct(Guard $model)
27		{
28	4	$this->editingModel($model->user());
		0 ignored issues – show Documentation introduced 2015-12-15 16:27 UTC by Report Bug Copy Issue Report `$model->user()` is of type `object<Illuminate\Contra...h\Authenticatable>\|null`, but the function expects a `object<Illuminate\Database\Eloquent\Model>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29	4	}
30
31		/**
32		* @return array
33		*/
34	4	public function actions()
35		{
36		return [
37	4	'submit' => 'update',
38		];
39		}
40
41		/**
42		* @return array
43		*/
44	4	protected function innerFields()
45		{
46		$fields = [
47		'language' => [
48	4	'type' => 'select',
49	4	'label' => 'language',
50	4	'options' => $this->getModel()->getLanguages(),
51	4	'value' => app('tinyissue.settings')->getLanguage(),
52		],
53		];
54	4	$fields += $this->passwordFields();
55
56	4	return $fields;
57		}
58
59		/**
60		* @return array
61		*/
62	4	public function rules()
63		{
64	4	$rules = parent::rules();
65	4	$rules['password'] = 'confirmed';
66	4	$rules['language'] = 'required';
67
68	4	return $rules;
69		}
70		}
71

satrun77 / tinyissue

UserSetting::innerFields() A last analyzed 2016-08-19 12:52 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

UserSetting::innerFields() A
last analyzed 2016-08-19 12:52 UTC