ViewTemplate - Code Metrics - satrun77/silverstripe-viewtemplate - Measure and Improve Code Quality continuously with Scrutinizer

ViewTemplate A
last analyzed 2016-10-28 09:37 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	1
dl	0
loc	33
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getPlaceHolder()	0	4	1

<?php

/**
 * ViewTemplate is the database model class for the view template table.
 *
 * @author  Mohamed Alsharaf <[email protected]>
 *
 * @package viewtemplate
 */
class ViewTemplate extends DataObject
{
    private static $db = [
        'Title'        => 'Varchar(127)',
        'ViewTemplate' => 'Text',
    ];

    /**
     * Human-readable singular name.
     *
     * @var string
     * @config
     */
    private static $singular_name = 'View Template';

    /**
     * Human-readable plural name.
     *
     * @var string
     * @config
     */
    private static $plural_name = 'View Templates';

    /**
     * Return template placeholder.
     *
     * @return string
     */
    public function getPlaceHolder()
    {
        return '{{' . $this->Title . '}}';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1		<?php
2
3		/**
4		* ViewTemplate is the database model class for the view template table.
5		*
6		* @author Mohamed Alsharaf <[email protected]>
7		*
8		* @package viewtemplate
9		*/
10		class ViewTemplate extends DataObject
11		{
12		private static $db = [
13		'Title' => 'Varchar(127)',
14		'ViewTemplate' => 'Text',
15		];
16
17		/**
18		* Human-readable singular name.
19		*
20		* @var string
21		* @config
22		*/
23		private static $singular_name = 'View Template';
24
25		/**
26		* Human-readable plural name.
27		*
28		* @var string
29		* @config
30		*/
31		private static $plural_name = 'View Templates';
32
33		/**
34		* Return template placeholder.
35		*
36		* @return string
37		*/
38	2	public function getPlaceHolder()
39		{
40	2	return '{{' . $this->Title . '}}';
		0 ignored issues – show Documentation introduced 2016-10-26 22:06 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<ViewTemplate>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41		}
42		}
43

satrun77 / silverstripe-viewtemplate

ViewTemplate A last analyzed 2016-10-28 09:37 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like

ViewTemplate A
last analyzed 2016-10-28 09:37 UTC