Moo\FlashCard\Traits\AskAndValidate

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

63.64%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
	getEntity()	0	1	?
B	askWithValidation()	0	25	3

<?php

namespace Moo\FlashCard\Traits;

use Illuminate\Database\Eloquent\Model;

/**
 * Trait AskAndValidate provide command user input for ask and validate the user input
 */
trait AskAndValidate
{
    /**
     * @param  string $question
     * @param  string $field
     * @return string
     */
    protected function askWithValidation(string $question, string $field): string
    {
        // Ask the question and get the answer
        $input = $this->ask($question);

It seems like ask() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // Populate the model
        $this->getEntity()->fill([
            $field => $input,
        ]);

        // Validate the model data
        $validator = $this->getEntity()->getValidator();
        if ($validator->fails()) {
            // Get error message for the field
            $message = (string) $validator->errors()->first($field);
            // Display warning message if exists
            if (!empty($message)) {
                $this->warn($message);

It seems like warn() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                // Ask the question again
                return $this->askWithValidation($question, $field);
            }
        }

        return (string) $input;
    }

    /**
     * Required method to return the entity/model that contains the validation rules
     *
     * @return Model
     */
    abstract protected function getEntity(): Model;
}