satanasov / phpbbgallery

core/ucp/main_module.php

Indentation +11 added lines, -11 removed lines

@@ -389,10 +389,10 @@ 
 			generate_text_for_storage($album_data['album_desc'], $album_data['album_desc_uid'], $album_data['album_desc_bitfield'], $album_data['album_desc_options'], $request->variable('desc_parse_bbcode', false), $request->variable('desc_parse_urls', false), $request->variable('desc_parse_smilies', false));
 
 			/**
-			* borrowed from phpBB3
-			* @author: phpBB Group
-			* @location: acp_forums->manage_forums
-			*/
+			 * borrowed from phpBB3
+			 * @author: phpBB Group
+			 * @location: acp_forums->manage_forums
+			 */
 			// Parent should always be filled otherwise we use initialise_album()
 			if ($album_data['parent_id'])
 			{
@@ -833,13 +833,13 @@ 
 			}
 
 			/**
-			* Event delete user albums
-			*
-			* @event phpbbgallery.core.ucp.delete_album
-			* @var	int		album_id			Album ID
-			* @var	array	deleted_albums		Deleted album IDs
-			* @since 1.2.0
-			*/
+			 * Event delete user albums
+			 *
+			 * @event phpbbgallery.core.ucp.delete_album
+			 * @var	int		album_id			Album ID
+			 * @var	array	deleted_albums		Deleted album IDs
+			 * @since 1.2.0
+			 */
 			$vars = array('album_id', 'deleted_albums');
 			extract($phpbb_dispatcher->trigger_event('phpbbgallery.core.ucp.delete_album', compact($vars)));
 

Braces +13 added lines, -26 removed lines

@@ -108,8 +108,7 @@ 
 						if (!$phpbb_ext_gallery_user->get_data('personal_album_id'))
 						{
 							$this->info();
-						}
-						else
+						} else
 						{
 							$this->manage_albums();
 						}
@@ -142,8 +141,7 @@ 
 				'L_TITLE'			=> $this->language->lang('UCP_GALLERY_PERSONAL_ALBUMS'),
 				'L_TITLE_EXPLAIN'	=> $this->language->lang('NO_PERSONAL_ALBUM'),
 			));
-		}
-		else
+		} else
 		{
 			$phpbb_gallery_url->redirect('phpbb', 'ucp', 'i=-phpbbgallery-core-ucp-main_module&mode=manage_albums&action=manage');
 		}
@@ -230,8 +228,7 @@ 
 		if (!$parent_id)
 		{
 			$navigation = $this->language->lang('PERSONAL_ALBUM');
-		}
-		else
+		} else
 		{
 			$navigation = $this->language->lang('PERSONAL_ALBUM');
 
@@ -241,8 +238,7 @@ 
 				if ($row['album_id'] == $parent_id)
 				{
 					$navigation .= ' » ' . $row['album_name'];
-				}
-				else
+				} else
 				{
 					$navigation .= ' &raquo; <a href="' . $this->u_action . '&amp;action=manage&amp;parent_id=' . $row['album_id'] . '">' . $row['album_name'] . '</a>';
 				}
@@ -357,8 +353,7 @@ 
 				'S_AUTH_ACCESS_OPTIONS'		=> $s_access_options,
 				'L_ALBUM_ACCESS_EXPLAIN'	=> $this->language->lang('ALBUM_ACCESS_EXPLAIN', '<a href="' . $phpbb_gallery_url->append_sid('phpbb', 'faq') . '#f6r0">', '</a>'),
 			));
-		}
-		else
+		} else
 		{
 			if (!check_form_key('ucp_gallery'))
 			{
@@ -506,8 +501,7 @@ 
 
 				'S_MODE' 					=> 'edit',
 			));
-		}
-		else
+		} else
 		{
 			// Is it salty ?
 			if (!check_form_key('ucp_gallery'))
@@ -591,8 +585,7 @@ 
 						WHERE album_user_id = ' . (int) $row['album_user_id'] . '
 							AND right_id >= ' . (int) $row['left_id'];
 					$db->sql_query($sql);
-				}
-				else
+				} else
 				{
 					$sql = 'UPDATE ' . $albums_table . '
 						SET left_id = left_id - ' . $moving_ids . '
@@ -638,8 +631,7 @@ 
 			if ($album_data['album_name'] == '')
 			{
 				$album_data['album_name'] = $row['album_name'];
-			}
-			else if ($row['album_name'] != $album_data['album_name'])
+			} else if ($row['album_name'] != $album_data['album_name'])
 			{
 				$sql = 'UPDATE ' . $albums_table . "
 					SET album_parents = ''";
@@ -650,8 +642,7 @@ 
 			if (isset($config['zebra_enhance_version']))
 			{
 				$album_data['album_auth_access'] = min(4, max(0, $album_data['album_auth_access']));
-			}
-			else
+			} else
 			{
 				$album_data['album_auth_access'] = min(3, max(0, $album_data['album_auth_access']));
 			}
@@ -804,8 +795,7 @@ 
 						$phpbb_ext_gallery_config->set('newest_pega_username', $newest_pgallery['username']);
 						$phpbb_ext_gallery_config->set('newest_pega_user_colour', $newest_pgallery['user_colour']);
 						$phpbb_ext_gallery_config->set('newest_pega_album_id', $newest_pgallery['album_id']);
-					}
-					else
+					} else
 					{
 						$phpbb_ext_gallery_config->set('newest_pega_user_id', 0);
 						$phpbb_ext_gallery_config->set('newest_pega_username', '');
@@ -813,8 +803,7 @@ 
 						$phpbb_ext_gallery_config->set('newest_pega_album_id', 0);
 					}
 				}
-			}
-			else
+			} else
 			{
 				// Solve the left_id right_id problem
 				$delete_id = $right_id - ($left_id - 1);
@@ -855,8 +844,7 @@ 
 
 			trigger_error($this->language->lang('DELETED_ALBUMS') . '<br /><br />
 				<a href="' . (($parent_id) ? $phpbb_gallery_url->append_sid('phpbb', 'ucp', 'i=-phpbbgallery-core-ucp-main_module&amp;mode=manage_albums&amp;action=manage&amp;parent_id=' . $parent_id) : $phpbb_gallery_url->append_sid('phpbb', 'ucp', 'i=-phpbbgallery-core-ucp-main_module&amp;mode=manage_albums')) . '">' . $this->language->lang('BACK_TO_PREV') . '</a>');
-		}
-		else
+		} else
 		{
 			$album_id = $request->variable('album_id', 0);
 			$phpbb_ext_gallery_core_album->check_user($album_id);
@@ -899,8 +887,7 @@ 
 
 			$move_up_left = $moving['left_id'];
 			$move_up_right = $moving['right_id'];
-		}
-		else
+		} else
 		{
 			$left_id = $moving['left_id'];
 			$right_id = $target['right_id'];

Spacing +7 added lines, -7 removed lines

@@ -30,7 +30,7 @@ 
 		$phpbb_gallery_url = $phpbb_container->get('phpbbgallery.core.url');
 		$phpbb_gallery_url->_include('functions_display', 'phpbb');
 
-		$phpbb_ext_gallery_core_album =$phpbb_container->get('phpbbgallery.core.album');
+		$phpbb_ext_gallery_core_album = $phpbb_container->get('phpbbgallery.core.album');
 
 		$phpbb_ext_gallery_core_auth = $phpbb_container->get('phpbbgallery.core.auth');
 
@@ -154,7 +154,7 @@ 
 
 	function initialise_album()
 	{
-		global $cache, $db,  $user, $phpbb_ext_gallery_core_auth, $phpbb_ext_gallery_core_album, $phpbb_ext_gallery_config, $albums_table, $phpbb_ext_gallery_user;
+		global $cache, $db, $user, $phpbb_ext_gallery_core_auth, $phpbb_ext_gallery_core_album, $phpbb_ext_gallery_config, $albums_table, $phpbb_ext_gallery_user;
 		global $request, $users_table, $phpbb_container;
 
 		// we will have to initialise $phpbb_ext_gallery_user
@@ -448,7 +448,7 @@ 
 
 		$this->language = $phpbb_container->get('language');
 
-		$phpbb_gallery_url->_include(array('bbcode','message_parser'), 'phpbb');
+		$phpbb_gallery_url->_include(array('bbcode', 'message_parser'), 'phpbb');
 
 		$album_id = $request->variable('album_id', 0);
 		$phpbb_ext_gallery_core_album->check_user($album_id);
@@ -837,7 +837,7 @@ 
 				$sql = 'UPDATE ' . $albums_table . "
 					SET right_id = right_id - $delete_id
 					WHERE right_id > $right_id
-						AND album_user_id = ". (int) $user->data['user_id'];
+						AND album_user_id = " . (int) $user->data['user_id'];
 				$db->sql_query($sql);
 			}
 
@@ -1021,9 +1021,9 @@ 
 		$db->sql_freeresult($result);
 
 		// Subscribed images
-		$start				= $request->variable('start', 0);
-		$images_per_page	= $phpbb_ext_gallery_config->get('items_per_page');
-		$total_images		= 0;
+		$start = $request->variable('start', 0);
+		$images_per_page = $phpbb_ext_gallery_config->get('items_per_page');
+		$total_images = 0;
 
 		$sql = 'SELECT COUNT(image_id) as images
 			FROM ' . $watch_table . '

core/url.php

Spacing +2 added lines, -2 removed lines

@@ -129,12 +129,12 @@
 
 		if (isset($args[1]))
 		{
-			$args[1] .= '';//@todo: phpbb_gallery::$display_popup;
+			$args[1] .= ''; //@todo: phpbb_gallery::$display_popup;
 		}
 
 		$params = $args + array(
 			0	=> '',
-			1	=> '',//@todo: phpbb_gallery::$display_popup,
+			1	=> '', //@todo: phpbb_gallery::$display_popup,
 			2	=> true,
 			3	=> false,
 		);

Braces +5 added lines, -10 removed lines

@@ -121,8 +121,7 @@ 
 		{
 			$mode = array_shift($args);
 			$args[0] = $this->path($mode) . $this->phpEx_file($args[0]);
-		}
-		else
+		} else
 		{
 			$args[0] = $this->path() . $this->phpEx_file($args[0]);
 		}
@@ -197,8 +196,7 @@ 
 		if (!is_array($file))
 		{
 			include($this->path($path) . $sub_directory . $this->phpEx_file($file));
-		}
-		else
+		} else
 		{
 			foreach ($file as $real_file)
 			{
@@ -244,8 +242,7 @@ 
 			if (strpos($path, 'https:/') === 0)
 			{
 				$path = 'https://' . substr($path, 7);
-			}
-			else if (strpos($path, 'http:/') === 0)
+			} else if (strpos($path, 'http:/') === 0)
 			{
 				$path = 'http://' . substr($path, 6);
 			}
@@ -300,15 +297,13 @@ 
 		if ($this->config['force_server_vars'] == 1)
 		{
 			$url = $this->config['server_protocol'] . $url;
-		}
-		else
+		} else
 		{
 			$is_secure = $this->request->server('HTTPS', '');
 			if ($is_secure == 'on')
 			{
 				$url = 'https://' . $url;
-			}
-			else
+			} else
 			{
 				$url = 'http://' . $url;
 			}

Indentation +24 added lines, -24 removed lines

@@ -22,28 +22,28 @@ 
 	private $config;
 
 	/**
-	* Path from the gallery root, back to phpbb's root
-	*/
+	 * Path from the gallery root, back to phpbb's root
+	 */
 	private $phpbb_root_path = '../';
 
 	/**
-	* Path from the phpbb root, into admin's root
-	*/
+	 * Path from the phpbb root, into admin's root
+	 */
 	private $phpbb_admin_path = 'adm/';
 
 	/**
-	* Path from the phpbb root, into gallery's file root
-	*/
+	 * Path from the phpbb root, into gallery's file root
+	 */
 	private $phpbb_gallery_file_path = 'files/phpbbgallery/';
 
 	/**
-	* Path from the phpbb root, into gallery's root
-	*/
+	 * Path from the phpbb root, into gallery's root
+	 */
 	private $phpbb_gallery_path = 'gallery/';
 
 	/**
-	* PHP file extension (e.g. .php)
-	*/
+	 * PHP file extension (e.g. .php)
+	 */
 	private $php_ext;
 
 	const IMAGE_PATH = 'images/';
@@ -237,16 +237,16 @@ 
 	}
 
 	/**
-	* Creates beautiful relative path from ugly relative path
-	* Resolves .. (up directory)
-	*
-	* @author	bantu		based on phpbb_own_realpath() by Chris Smith
-	* @license	http://opensource.org/licenses/gpl-license.php GNU Public License
-	*
-	* @param	string		ugly path e.g. "../community/../gallery/"
-	* @param	bool		is it a full url, so we need to fix teh http:// at the beginning?
-	* @return	string		beautiful path e.g. "../gallery/"
-	*/
+	 * Creates beautiful relative path from ugly relative path
+	 * Resolves .. (up directory)
+	 *
+	 * @author	bantu		based on phpbb_own_realpath() by Chris Smith
+	 * @license	http://opensource.org/licenses/gpl-license.php GNU Public License
+	 *
+	 * @param	string		ugly path e.g. "../community/../gallery/"
+	 * @param	bool		is it a full url, so we need to fix teh http:// at the beginning?
+	 * @return	string		beautiful path e.g. "../gallery/"
+	 */
 	static public function beautiful_path($path, $is_full_url = false)
 	{
 		// Remove any repeated slashes
@@ -288,10 +288,10 @@ 
 	}
 
 	/**
-	* Custom meta_refresh implementation
-	* @param	int		$time	Time in seconds.
-	* @param	string	$route	Route generated by $helper->route
-	*/
+	 * Custom meta_refresh implementation
+	 * @param	int		$time	Time in seconds.
+	 * @param	string	$route	Route generated by $helper->route
+	 */
 	public function meta_refresh($time, $route)
 	{
 		// For XHTML compatibility we change back & to &

acpimport/acp/main_module.php

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
 
 	function import()
 	{
-		global $db, $template, $user, $phpbb_dispatcher, $phpbb_container, $gallery_url, $request, $table_prefix ,$gallery_config, $gallery_album, $request;
+		global $db, $template, $user, $phpbb_dispatcher, $phpbb_container, $gallery_url, $request, $table_prefix, $gallery_config, $gallery_album, $request;
 
 		$import_schema = $request->variable('import_schema', '');
 		$images = $request->variable('images', array(''), true);
@@ -302,7 +302,7 @@ 
 			$album_id = $request->variable('album_id', 0);
 			if (isset($_POST['users_pega']))
 			{
-				$image_user =  $phpbb_container->get('phpbbgallery.core.user');
+				$image_user = $phpbb_container->get('phpbbgallery.core.user');
 				$image_user->set_user_id($user_row['user_id']);
 				if ($user->data['user_id'] != $user_row['user_id'])
 				{

Braces +6 added lines, -12 removed lines

@@ -47,8 +47,7 @@ 
 				// Replace the md5 with the ' again and remove the space at the end to prevent \' troubles
 				$user_data['username'] = utf8_substr(str_replace("{{$import_schema}}", "'", $user_data['username']), 0, -1);
 				$image_name = utf8_substr(str_replace("{{$import_schema}}", "'", $image_name), 0, -1);
-			}
-			else
+			} else
 			{
 				global $phpEx;
 				trigger_error($user->lang('MISSING_IMPORT_SCHEMA', ($import_schema . '.' . $phpEx)), E_USER_WARNING);
@@ -198,8 +197,7 @@ 
 						if ($filename || ($image_name == ''))
 						{
 							$sql_ary['image_name'] = str_replace("_", " ", utf8_substr($image_src, 0, utf8_strrpos($image_src, '.')));
-						}
-						else
+						} else
 						{
 							$sql_ary['image_name'] = str_replace('{NUM}', $num_offset + $done_images, $image_name);
 						}
@@ -239,14 +237,12 @@ 
 				if (!$errors)
 				{
 					trigger_error(sprintf($user->lang['IMPORT_FINISHED'], $done_images) . adm_back_link($this->u_action));
-				}
-				else
+				} else
 				{
 					$errors = explode("\n", $errors);
 					trigger_error(sprintf($user->lang['IMPORT_FINISHED_ERRORS'], $done_images - sizeof($errors)) . implode('<br />', $errors) . adm_back_link($this->u_action), E_USER_WARNING);
 				}
-			}
-			else
+			} else
 			{
 				// Write the new list
 				$this->create_import_schema($import_schema, $album_id, $user_data, $start_time, $num_offset, $done_images, $todo_images, $image_name, $filename, $images);
@@ -256,8 +252,7 @@ 
 				meta_refresh(1, $forward_url);
 				trigger_error(sprintf($user->lang['IMPORT_DEBUG_MES'], $done_images, $todo_images));
 			}
-		}
-		else if ($submit)
+		} else if ($submit)
 		{
 			if (!check_form_key('acp_gallery'))
 			{
@@ -313,8 +308,7 @@ 
 						$album_id = $gallery_album->generate_personal_album($user_row['username'], $user_row['user_id'], $user_row['user_colour'], $image_user);
 					}
 					unset($image_user);
-				}
-				else
+				} else
 				{
 					$album_id = $image_user->get_data('personal_album_id');
 					if (!$album_id)

Indentation +18 added lines, -18 removed lines

@@ -58,8 +58,8 @@ 
 			foreach ($images as $image_src)
 			{
 				/**
-				* Import the images
-				*/
+				 * Import the images
+				 */
 
 				$image_src = str_replace("{{$import_schema}}", "'", $image_src);
 				$image_src_full = $gallery_url->path('import') . utf8_decode($image_src);
@@ -160,21 +160,21 @@ 
 						$additional_sql_data = [];
 
 						/**
-						* Event to trigger before mass update
-						*
-						* @event phpbbgallery.acpimport.update_image_before
-						* @var	array	additional_sql_data		array of additional sql_data
-						* @var	string	file_link				String with real file link
-						* @since 1.2.0
-						*/
+						 * Event to trigger before mass update
+						 *
+						 * @event phpbbgallery.acpimport.update_image_before
+						 * @var	array	additional_sql_data		array of additional sql_data
+						 * @var	string	file_link				String with real file link
+						 * @since 1.2.0
+						 */
 						$vars = array('additional_sql_data', 'file_link');
 						extract($phpbb_dispatcher->trigger_event('phpbbgallery.acpimport.update_image_before', compact($vars)));
 
 						if (($filetype[0] > $gallery_config->get('max_width')) || ($filetype[1] > $gallery_config->get('max_height')))
 						{
 							/**
-							* Resize oversize images
-							*/
+							 * Resize oversize images
+							 */
 							if ($gallery_config->get('allow_resize'))
 							{
 								$image_tools->resize_image($gallery_config->get('max_width'), $gallery_config->get('max_height'));
@@ -187,13 +187,13 @@ 
 						$file_updated = (bool) $image_tools->resized;
 
 						/**
-						* Event to trigger before mass update
-						*
-						* @event phpbbgallery.acpimport.update_image
-						* @var	array	additional_sql_data		array of additional sql_data
-						* @var	bool	file_updated			is file resized
-						* @since 1.2.0
-						*/
+						 * Event to trigger before mass update
+						 *
+						 * @event phpbbgallery.acpimport.update_image
+						 * @var	array	additional_sql_data		array of additional sql_data
+						 * @var	bool	file_updated			is file resized
+						 * @since 1.2.0
+						 */
 						$vars = array('additional_sql_data', 'file_updated');
 						extract($phpbb_dispatcher->trigger_event('phpbbgallery.acpimport.update_image', compact($vars)));
 

acpcleanup/cleanup.php

Braces +2 added lines, -4 removed lines

@@ -196,8 +196,7 @@ 
 			if (isset($user_image_count[(int) $row['image_user_id']]))
 			{
 				$user_image_count[(int) $row['image_user_id']]++;
-			}
-			else
+			} else
 			{
 				$user_image_count[(int) $row['image_user_id']] = 1;
 			}
@@ -246,8 +245,7 @@ 
 				$this->gallery_config->set('newest_pega_username', $newest_pega['username']);
 				$this->gallery_config->set('newest_pega_user_colour', $newest_pega['user_colour']);
 				$this->gallery_config->set('newest_pega_album_id', $newest_pega['album_id']);
-			}
-			else
+			} else
 			{
 				$this->gallery_config->set('newest_pega_user_id', 0);
 				$this->gallery_config->set('newest_pega_username', '');

Indentation +30 added lines, -30 removed lines

@@ -85,11 +85,11 @@ 
 	}
 
 	/**
-	* Delete source files without a database entry.
-	*
-	* @param	array	$filenames		An array of filenames
-	* @return	string	Language key for the success message.
-	*/
+	 * Delete source files without a database entry.
+	 *
+	 * @param	array	$filenames		An array of filenames
+	 * @return	string	Language key for the success message.
+	 */
 	public function delete_files($filenames)
 	{
 		foreach ($filenames as $file)
@@ -102,11 +102,11 @@ 
 	}
 
 	/**
-	* Delete images, where the source file is missing.
-	*
-	* @param	mixed	$image_ids		Either an array of integers or an integer.
-	* @return	string	Language key for the success message.
-	*/
+	 * Delete images, where the source file is missing.
+	 *
+	 * @param	mixed	$image_ids		Either an array of integers or an integer.
+	 * @return	string	Language key for the success message.
+	 */
 	public function delete_images($image_ids)
 	{
 		$this->log->add_log('admin', 'clean_deleteentries', 0, 0, array('LOG_CLEANUP_DELETE_ENTRIES', count($image_ids)));
@@ -116,11 +116,11 @@ 
 	}
 
 	/**
-	* Delete images, where the author is missing.
-	*
-	* @param	mixed	$image_ids		Either an array of integers or an integer.
-	* @return	string	Language key for the success message.
-	*/
+	 * Delete images, where the author is missing.
+	 *
+	 * @param	mixed	$image_ids		Either an array of integers or an integer.
+	 * @return	string	Language key for the success message.
+	 */
 	public function delete_author_images($image_ids)
 	{
 		$this->log->add_log('admin', 'clean_deletenoauthors', 0, 0, array('LOG_CLEANUP_DELETE_NO_AUTHOR', count($image_ids)));
@@ -130,11 +130,11 @@ 
 	}
 
 	/**
-	* Delete comments, where the author is missing.
-	*
-	* @param	mixed	$comment_ids	Either an array of integers or an integer.
-	* @return	string	Language key for the success message.
-	*/
+	 * Delete comments, where the author is missing.
+	 *
+	 * @param	mixed	$comment_ids	Either an array of integers or an integer.
+	 * @return	string	Language key for the success message.
+	 */
 	public function delete_author_comments($comment_ids)
 	{
 		$this->log->add_log('admin', 'clean_deletecna', 0, 0, array('LOG_CLEANUP_COMMENT_DELETE_NO_AUTHOR', count($comment_ids)));
@@ -144,12 +144,12 @@ 
 	}
 
 	/**
-	* Delete unwanted and obsolete personal galleries.
-	*
-	* @param	array	$unwanted_pegas		User IDs we want to delete the pegas.
-	* @param	array	$obsolete_pegas		User IDs we want to delete the pegas.
-	* @return	array	Language keys for the success messages.
-	*/
+	 * Delete unwanted and obsolete personal galleries.
+	 *
+	 * @param	array	$unwanted_pegas		User IDs we want to delete the pegas.
+	 * @param	array	$obsolete_pegas		User IDs we want to delete the pegas.
+	 * @return	array	Language keys for the success messages.
+	 */
 	public function delete_pegas($unwanted_pegas, $obsolete_pegas)
 	{
 
@@ -280,8 +280,8 @@ 
 	}
 
 	/**
-	*
-	*/
+	 *
+	 */
 	public function prune($pattern)
 	{
 		$sql_where = '';
@@ -325,8 +325,8 @@ 
 	}
 
 	/**
-	*
-	*/
+	 *
+	 */
 	public function lang_prune_pattern($pattern)
 	{
 		if (isset($pattern['image_album_id']))

core/moderate.php

Braces +2 added lines, -4 removed lines

@@ -85,8 +85,7 @@ 
 			{
 				$mod_array[] = 0;
 			}
-		}
-		else
+		} else
 		{
 			$mod_array = array($album);
 		}
@@ -162,8 +161,7 @@ 
 			$this->template->assign_vars(array(
 				'TOTAL_PAGES' => $this->lang->lang('PAGE_TITLE_NUMBER', $page + 1),
 			));
-		}
-		else
+		} else
 		{
 			$this->pagination->generate_template_pagination(array(
 				'routes' => array(

core/controller/moderate.php

Spacing +7 added lines, -7 removed lines

@@ -260,7 +260,7 @@ 
 			}
 			else
 			{
-				$s_hidden_fields = '<input type="hidden" name="action['.$action.']" value="' . $action . '" />';
+				$s_hidden_fields = '<input type="hidden" name="action[' . $action . ']" value="' . $action . '" />';
 				$s_hidden_fields .= '<input type="hidden" name="back_link" value="' . $back_link . '" />';
 				foreach ($approve_ary as $id => $var)
 				{
@@ -361,7 +361,7 @@ 
 			}
 			else
 			{
-				$s_hidden_fields = '<input type="hidden" name="action['.$action.']" value="' . $action . '" />';
+				$s_hidden_fields = '<input type="hidden" name="action[' . $action . ']" value="' . $action . '" />';
 				$s_hidden_fields .= '<input type="hidden" name="back_link" value="' . $back_link . '" />';
 				foreach ($report_ary as $var)
 				{
@@ -583,7 +583,7 @@ 
 			case 'reports_close':
 				if (confirm_box(true))
 				{
-					$back_link =  $this->helper->route('phpbbgallery_core_moderate_image', array('image_id' => $image_id));
+					$back_link = $this->helper->route('phpbbgallery_core_moderate_image', array('image_id' => $image_id));
 					$this->report->close_reports_by_image($image_id);
 					$message = $this->language->lang('WAITING_REPORTED_DONE', 1);
 					$this->url->meta_refresh(3, $back_link);
@@ -679,7 +679,7 @@ 
 				'REPORT_TIME'	=> $this->user->format_date($var['report_time']),
 				'REPORT_NOTE'	=> $var['report_note'],
 				'STATUS'		=> $var['report_status'],
-				'MANAGER'		=> $var['report_manager'] != 0 ?  $this->user_loader->get_username($var['report_manager'], 'full') : false,
+				'MANAGER'		=> $var['report_manager'] != 0 ? $this->user_loader->get_username($var['report_manager'], 'full') : false,
 			));
 		}
 		return $this->helper->render('gallery/moderate_image_overview.html', $this->language->lang('GALLERY'));
@@ -804,7 +804,7 @@ 
 		$image_data = $this->image->get_image_data($image_id);
 		$album_id = $image_data['image_album_id'];
 		//$user_id = $image_data['image_user_id'];
-		$album_data =  $this->album->get_info($album_id);
+		$album_data = $this->album->get_info($album_id);
 		$album_backlink = $this->helper->route('phpbbgallery_core_album', array('album_id' => $album_id));
 		$image_backlink = $this->helper->route('phpbbgallery_core_image', array('image_id' => $image_id));
 		$album_loginlink = append_sid($this->root_path . 'ucp.' . $this->php_ext . '?mode=login');
@@ -852,7 +852,7 @@ 
 		$image_data = $this->image->get_image_data($image_id);
 		$album_id = $image_data['image_album_id'];
 		//$user_id = $image_data['image_user_id'];
-		$album_data =  $this->album->get_info($album_id);
+		$album_data = $this->album->get_info($album_id);
 		$album_backlink = $this->helper->route('phpbbgallery_core_album', array('album_id' => $album_id));
 		$image_backlink = $this->helper->route('phpbbgallery_core_image', array('image_id' => $image_id));
 		$album_loginlink = append_sid($this->root_path . 'ucp.' . $this->php_ext . '?mode=login');
@@ -868,7 +868,7 @@ 
 			$image_id_ary = array($image_id);
 			$this->image->lock_images($image_id_ary, $album_data['album_id']);
 			// To DO - add notification
-			$message = sprintf($this->language->lang('WAITING_LOCKED_IMAGE',1));
+			$message = sprintf($this->language->lang('WAITING_LOCKED_IMAGE', 1));
 			meta_refresh($meta_refresh_time, $image_backlink);
 			trigger_error($message);
 		}

Braces +17 added lines, -34 removed lines

@@ -149,8 +149,7 @@ 
 			{
 				$this->misc->not_authorised($album_backlink, $album_loginlink, 'LOGIN_EXPLAIN_UPLOAD');
 			}
-		}
-		else
+		} else
 		{
 			$album = $this->album->get_info($album_id);
 			if (!$this->gallery_auth->acl_check('m_', $album['album_id'], $album['album_user_id']))
@@ -211,8 +210,7 @@ 
 			{
 				$this->misc->not_authorised($album_backlink, $album_loginlink, 'LOGIN_EXPLAIN_UPLOAD');
 			}
-		}
-		else
+		} else
 		{
 			$album = $this->album->get_info($album_id);
 			if (!$this->gallery_auth->acl_check('m_status', $album['album_id'], $album['album_user_id']))
@@ -257,8 +255,7 @@ 
 					$this->url->meta_refresh(3, $back_link);
 					trigger_error($message);
 				}
-			}
-			else
+			} else
 			{
 				$s_hidden_fields = '<input type="hidden" name="action['.$action.']" value="' . $action . '" />';
 				$s_hidden_fields .= '<input type="hidden" name="back_link" value="' . $back_link . '" />';
@@ -307,8 +304,7 @@ 
 			{
 				$this->misc->not_authorised($album_backlink, $album_loginlink, 'LOGIN_EXPLAIN_UPLOAD');
 			}
-		}
-		else
+		} else
 		{
 			$album = $this->album->get_info($album_id);
 			if (!$this->gallery_auth->acl_check('m_', $album['album_id'], $album['album_user_id']))
@@ -358,8 +354,7 @@ 
 				$message = $this->language->lang('WAITING_REPORTED_DONE', count($report_ary));
 				$this->url->meta_refresh(3, $back_link);
 				trigger_error($message);
-			}
-			else
+			} else
 			{
 				$s_hidden_fields = '<input type="hidden" name="action['.$action.']" value="' . $action . '" />';
 				$s_hidden_fields .= '<input type="hidden" name="back_link" value="' . $back_link . '" />';
@@ -379,8 +374,7 @@ 
 			{
 				$this->misc->not_authorised($album_backlink, $album_loginlink, 'LOGIN_EXPLAIN_UPLOAD');
 			}
-		}
-		else
+		} else
 		{
 			$album = $this->album->get_info($album_id);
 			if (!$this->gallery_auth->acl_check('m_report', $album['album_id'], $album['album_user_id']))
@@ -470,8 +464,7 @@ 
 					$this->url->meta_refresh(3, $back_link);
 					trigger_error($message);
 				}
-			}
-			else
+			} else
 			{
 				$s_hidden_fields = '<input type="hidden" name="select_action" value="' . $action . '" />';
 				$s_hidden_fields .= '<input type="hidden" name="back_link" value="' . $back_link . '" />';
@@ -492,8 +485,7 @@ 
 						'S_HIDDEN_FIELDS'	=> $s_hidden_fields,
 					));
 					return $this->helper->render('gallery/mcp_body.html', $this->language->lang('GALLERY'));
-				}
-				else
+				} else
 				{
 					confirm_box(false, $this->language->lang('QUEUES_A_' . strtoupper($action) . '2_CONFIRM'), $s_hidden_fields);
 				}
@@ -508,8 +500,7 @@ 
 			{
 				$this->misc->not_authorised($album_backlink, $album_loginlink, 'LOGIN_EXPLAIN_UPLOAD');
 			}
-		}
-		else
+		} else
 		{
 			$album = $this->album->get_info($album_id);
 			if (!$this->gallery_auth->acl_check('m_', $album['album_id'], $album['album_user_id']))
@@ -583,8 +574,7 @@ 
 					$message = $this->language->lang('WAITING_REPORTED_DONE', 1);
 					$this->url->meta_refresh(3, $back_link);
 					trigger_error($message);
-				}
-				else
+				} else
 				{
 					$s_hidden_fields = '<input type="hidden" name="action" value="reports_close" />';
 					confirm_box(false, $this->language->lang('REPORT_A_CLOSE2_CONFIRM'), $s_hidden_fields);
@@ -621,13 +611,11 @@ 
 			{
 				$select_select .= '<option value="images_approve">' . $this->language->lang('QUEUE_A_APPROVE') . '</option>';
 				$select_select .= '<option value="images_lock">' . $this->language->lang('QUEUE_A_LOCK') . '</option>';
-			}
-			else if ($image_data['image_status'] == 1)
+			} else if ($image_data['image_status'] == 1)
 			{
 				$select_select .= '<option value="images_unapprove">' . $this->language->lang('QUEUE_A_UNAPPROVE') . '</option>';
 				$select_select .= '<option value="images_lock">' . $this->language->lang('QUEUE_A_LOCK') . '</option>';
-			}
-			else
+			} else
 			{
 				$select_select .= '<option value="images_approve">' . $this->language->lang('QUEUE_A_APPROVE') . '</option>';
 				$select_select .= '<option value="images_unapprove">' . $this->language->lang('QUEUE_A_UNAPPROVE') . '</option>';
@@ -646,8 +634,7 @@ 
 			if ($open_report)
 			{
 				$select_select .= '<option value="reports_close">' . $this->language->lang('REPORT_A_CLOSE') . '</option>';
-			}
-			else
+			} else
 			{
 				$select_select .= '<option value="reports_open">' . $this->language->lang('REPORT_A_OPEN') . '</option>';
 			}
@@ -725,8 +712,7 @@ 
 			$message = $this->language->lang('WAITING_APPROVED_IMAGE', 1);
 			meta_refresh($meta_refresh_time, $image_backlink);
 			trigger_error($message);
-		}
-		else
+		} else
 		{
 			$this->template->assign_vars(array(
 				'S_NOTIFY_POSTER'			=> $show_notify,
@@ -775,8 +761,7 @@ 
 			$message = sprintf($this->language->lang('WAITING_UNAPPROVED_IMAGE', 1));
 			meta_refresh($meta_refresh_time, $image_backlink);
 			trigger_error($message);
-		}
-		else
+		} else
 		{
 			$s_hidden_fields = '';
 			confirm_box(false, 'QUEUE_A_UNAPPROVE2', $s_hidden_fields);
@@ -817,8 +802,7 @@ 
 			$this->album->update_info($moving_target);
 			meta_refresh($meta_refresh_time, $image_backlink);
 			trigger_error($message);
-		}
-		else
+		} else
 		{
 			$category_select = $this->album->get_albumbox(false, 'moving_target', $album_id, 'm_move', $album_id);
 			$this->template->assign_vars(array(
@@ -862,8 +846,7 @@ 
 			$message = sprintf($this->language->lang('WAITING_LOCKED_IMAGE',1));
 			meta_refresh($meta_refresh_time, $image_backlink);
 			trigger_error($message);
-		}
-		else
+		} else
 		{
 			$s_hidden_fields = '';
 			confirm_box(false, 'QUEUE_A_LOCK2', $s_hidden_fields);

core/image/image.php

Braces +2 added lines, -4 removed lines

@@ -363,8 +363,7 @@ 
 				{
 					$url = $this->url->append_sid('image_page', "album_id=$album_id&image_id=$next_image{$additional_parameters}");
 					$tpl = '<a href="{IMAGE_URL}" title="{IMAGE_NAME}">{CONTENT}</a>';
-				}
-				else
+				} else
 				{
 					$tpl = '{CONTENT}';
 				}
@@ -440,8 +439,7 @@ 
 		{
 			$this->gallery_config->inc('num_images', (int) $num_images);
 			$this->gallery_config->inc('num_comments', (int) $num_comments);
-		}
-		else
+		} else
 		{
 			$this->gallery_config->dec('num_images', (int) $num_images);
 			$this->gallery_config->dec('num_comments', (int) $num_comments);

Indentation +41 added lines, -41 removed lines

@@ -190,13 +190,13 @@ 
 		}
 
 		/**
-		* Event delete images
-		*
-		* @event phpbbgallery.core.image.delete_images
-		* @var	array	images			array of the image ids we are deleting
-		* @var	array	filenames		array of the image filenames
-		* @since 1.2.0
-		*/
+		 * Event delete images
+		 *
+		 * @event phpbbgallery.core.image.delete_images
+		 * @var	array	images			array of the image ids we are deleting
+		 * @var	array	filenames		array of the image filenames
+		 * @since 1.2.0
+		 */
 		$vars = array('images', 'filenames');
 		extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.image.delete_images', compact($vars)));
 
@@ -256,11 +256,11 @@ 
 	}
 
 	/**
-	* Get the real filenames, so we can load/delete/edit the image-file.
-	*
-	* @param	mixed		$images		Array or integer with the image_id(s)
-	* @return	array		Format: $image_id => $filename
-	*/
+	 * Get the real filenames, so we can load/delete/edit the image-file.
+	 *
+	 * @param	mixed		$images		Array or integer with the image_id(s)
+	 * @return	array		Format: $image_id => $filename
+	 */
 	public function get_filenames($images)
 	{
 		if (empty($images))
@@ -375,13 +375,13 @@ 
 				$tpl = '{CONTENT}';
 
 				/**
-				* Event generate link
-				*
-				* @event phpbbgallery.core.image.generate_link
-				* @var	string	mode	type of link
-				* @var	string	tpl		html to be outputted
-				* @since 1.2.0
-				*/
+				 * Event generate link
+				 *
+				 * @event phpbbgallery.core.image.generate_link
+				 * @var	string	mode	type of link
+				 * @var	string	tpl		html to be outputted
+				 * @since 1.2.0
+				 */
 				$vars = array('mode', 'tpl');
 				extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.image.generate_link', compact($vars)));//@todo: Correctly identify the event
 			break;
@@ -391,12 +391,12 @@ 
 	}
 
 	/**
-	* Handle user- & total image_counter
-	*
-	* @param	array	$image_id_ary	array with the image_ids which changed their status
-	* @param	bool	$add			are we adding or removing the images
-	* @param	bool	$readd			is it possible that there are images which aren't really changed
-	*/
+	 * Handle user- & total image_counter
+	 *
+	 * @param	array	$image_id_ary	array with the image_ids which changed their status
+	 * @param	bool	$add			are we adding or removing the images
+	 * @param	bool	$readd			is it possible that there are images which aren't really changed
+	 */
 	public function handle_counter($image_id_ary, $add, $readd = false)
 	{
 		if (empty($image_id_ary))
@@ -467,11 +467,11 @@ 
 	}
 
 	/**
-	* Approve image
-	* @param (array)	$image_id_ary	The image ID array to be approved
-	* @param (int)		$album_id	The album image is approved to (just save some queries for log)
-	* return 0 on success
-	*/
+	 * Approve image
+	 * @param (array)	$image_id_ary	The image ID array to be approved
+	 * @param (int)		$album_id	The album image is approved to (just save some queries for log)
+	 * return 0 on success
+	 */
 	public function approve_images($image_id_ary, $album_id)
 	{
 		$sql = 'SELECT image_id, image_name, image_user_id
@@ -507,10 +507,10 @@ 
 	}
 
 	/**
-	* UnApprove image
-	* @param (array)	$image_id_ary	The image ID array to be unapproved
-	* @param (int)		$album_id	The album image is approved to (just save some queries for log)
-	*/
+	 * UnApprove image
+	 * @param (array)	$image_id_ary	The image ID array to be unapproved
+	 * @param (int)		$album_id	The album image is approved to (just save some queries for log)
+	 */
 	public function unapprove_images($image_id_ary, $album_id)
 	{
 		self::handle_counter($image_id_ary, false);
@@ -563,10 +563,10 @@ 
 	}
 
 	/**
-	* Lock images
-	* @param (array)	$image_id_ary	Array of images we want to lock
-	* @param (int)		$album_id		Album id, so we can log the action
-	*/
+	 * Lock images
+	 * @param (array)	$image_id_ary	Array of images we want to lock
+	 * @param (int)		$album_id		Album id, so we can log the action
+	 */
 	public function lock_images($image_id_ary, $album_id)
 	{
 		self::handle_counter($image_id_ary, false);
@@ -590,9 +590,9 @@ 
 	}
 
 	/**
-	* Get last image id
-	* Return (int) image_id
-	**/
+	 * Get last image id
+	 * Return (int) image_id
+	 **/
 	public function get_last_image()
 	{
 		$this->gallery_auth->load_user_permissions($this->user->data['user_id']);

Spacing +8 added lines, -8 removed lines

@@ -383,7 +383,7 @@ 
 				* @since 1.2.0
 				*/
 				$vars = array('mode', 'tpl');
-				extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.image.generate_link', compact($vars)));//@todo: Correctly identify the event
+				extract($this->phpbb_dispatcher->trigger_event('phpbbgallery.core.image.generate_link', compact($vars))); //@todo: Correctly identify the event
 			break;
 		}
 
@@ -406,7 +406,7 @@ 
 
 		$num_images = $num_comments = 0;
 		$sql = 'SELECT SUM(image_comments) as comments
-			FROM ' . $this->table_images .'
+			FROM ' . $this->table_images . '
 			WHERE image_status ' . (($readd) ? '=' : '<>') . ' ' . (int) \phpbbgallery\core\block::STATUS_UNAPPROVED . '
 				AND ' . $this->db->sql_in_set('image_id', $image_id_ary) . '
 			GROUP BY image_user_id';
@@ -415,7 +415,7 @@ 
 		$this->db->sql_freeresult($result);
 
 		$sql = 'SELECT COUNT(image_id) images, image_user_id
-			FROM ' . $this->table_images .' 
+			FROM ' . $this->table_images . ' 
 			WHERE image_status ' . (($readd) ? '=' : '<>') . ' ' . (int) \phpbbgallery\core\block::STATUS_UNAPPROVED . '
 				AND ' . $this->db->sql_in_set('image_id', $image_id_ary) . '
 			GROUP BY image_user_id';
@@ -455,7 +455,7 @@ 
 			return;
 		}
 
-		$sql = 'SELECT * FROM ' . $this->table_images .' WHERE image_id = ' . (int) $image_id;
+		$sql = 'SELECT * FROM ' . $this->table_images . ' WHERE image_id = ' . (int) $image_id;
 		$result = $this->db->sql_query($sql);
 		$row = $this->db->sql_fetchrow($result);
 		$this->db->sql_freeresult($result);
@@ -515,14 +515,14 @@ 
 	{
 		self::handle_counter($image_id_ary, false);
 
-		$sql = 'UPDATE ' . $this->table_images .' 
+		$sql = 'UPDATE ' . $this->table_images . ' 
 			SET image_status = ' . (int) \phpbbgallery\core\block::STATUS_UNAPPROVED . '
 			WHERE image_status <> ' . (int) \phpbbgallery\core\block::STATUS_ORPHAN . '
 				AND ' . $this->db->sql_in_set('image_id', $image_id_ary);
 		$this->db->sql_query($sql);
 
 		$sql = 'SELECT image_id, image_name
-			FROM ' . $this->table_images .' 
+			FROM ' . $this->table_images . ' 
 			WHERE image_status <> ' . (int) \phpbbgallery\core\block::STATUS_ORPHAN . '
 				AND ' . $this->db->sql_in_set('image_id', $image_id_ary);
 		$result = $this->db->sql_query($sql);
@@ -684,14 +684,14 @@ 
 			'U_USER_IP'		=> $show_ip && $this->gallery_auth->acl_check('m_status', $image_data['image_album_id'], $image_data['album_user_id']) ? $image_data['image_user_ip'] : false,
 
 			'S_IMAGE_REPORTED'		=> $image_data['image_reported'],
-			'U_IMAGE_REPORTED'		=> '',//($image_data['image_reported']) ? $phpbb_ext_gallery->url->append_sid('mcp', "mode=report_details&amp;album_id={$image_data['image_album_id']}&amp;option_id=" . $image_data['image_reported']) : '',
+			'U_IMAGE_REPORTED'		=> '', //($image_data['image_reported']) ? $phpbb_ext_gallery->url->append_sid('mcp', "mode=report_details&amp;album_id={$image_data['image_album_id']}&amp;option_id=" . $image_data['image_reported']) : '',
 			'S_STATUS_APPROVED'		=> ($image_data['image_status'] == (int) \phpbbgallery\core\block::STATUS_APPROVED) ? true : false,
 			'S_STATUS_UNAPPROVED'	=> ($image_data['image_status'] == (int) \phpbbgallery\core\block::STATUS_UNAPPROVED) ? true : false,
 			'S_STATUS_UNAPPROVED_ACTION'	=> ($this->gallery_auth->acl_check('m_status', $image_data['image_album_id'], $image_data['album_user_id']) && $image_data['image_status'] == (int) \phpbbgallery\core\block::STATUS_UNAPPROVED) ? $this->helper->route('phpbbgallery_core_moderate_image_approve', array('image_id' => (int) $image_data['image_id'])) : '',
 			'S_STATUS_LOCKED'		=> ($image_data['image_status'] == (int) \phpbbgallery\core\block::STATUS_LOCKED) ? true : false,
 
 			'U_REPORT'	=> ($this->gallery_auth->acl_check('m_report', $image_data['image_album_id'], $image_data['album_user_id']) && $image_data['image_reported']) ? '123'/*$this->url->append_sid('mcp', "mode=report_details&amp;album_id={$image_data['image_album_id']}&amp;option_id=" . $image_data['image_reported'])*/ : '',
-			'U_STATUS'	=> '',//($this->auth->acl_check('m_status', $image_data['image_album_id'], $album_user_id)) ? $phpbb_ext_gallery->url->append_sid('mcp', "mode=queue_details&amp;album_id={$image_data['image_album_id']}&amp;option_id=" . $image_data['image_id']) : '',
+			'U_STATUS'	=> '', //($this->auth->acl_check('m_status', $image_data['image_album_id'], $album_user_id)) ? $phpbb_ext_gallery->url->append_sid('mcp', "mode=queue_details&amp;album_id={$image_data['image_album_id']}&amp;option_id=" . $image_data['image_id']) : '',
 			'L_STATUS'	=> ($image_data['image_status'] == (int) \phpbbgallery\core\block::STATUS_UNAPPROVED) ? $this->language->lang('APPROVE_IMAGE') : (($image_data['image_status'] == (int) \phpbbgallery\core\block::STATUS_APPROVED) ? $this->language->lang('CHANGE_IMAGE_STATUS') : $this->language->lang('UNLOCK_IMAGE')),
 		));
 	}

exif/exif.php

Spacing +14 added lines, -14 removed lines

@@ -17,7 +17,7 @@ 
 	/**
 	* Default value for new users
 	*/
-	const DEFAULT_DISPLAY	= true;
+	const DEFAULT_DISPLAY = true;
 
 	/**
 	* phpBB will treat the time from the Exif data like UTC.
@@ -26,13 +26,13 @@ 
 	*
 	* Offset must be set in seconds.
 	*/
-	const TIME_OFFSET	= 0;
+	const TIME_OFFSET = 0;
 
 	/**
 	* Constants for the status of the Exif data.
 	*/
-	const UNAVAILABLE	= 0;
-	const AVAILABLE		= 1;
+	const UNAVAILABLE = 0;
+	const AVAILABLE = 1;
 	const UNKNOWN		= 2;
 	const DBSAVED		= 3;
 
@@ -44,28 +44,28 @@ 
 	/**
 	* Exif data array with all allowed groups and keys.
 	*/
-	public $data		= array();
+	public $data = array();
 
 	/**
 	* Filtered data array. We don't have empty or invalid values here.
 	*/
-	public $prepared_data	= array();
+	public $prepared_data = array();
 
 	/**
 	* Does the image have exif data?
 	* Values see constant declaration at the beginning of the class.
 	*/
-	public $status		= 2;
+	public $status = 2;
 
 	/**
 	* Full data array, but serialized to a string
 	*/
-	public $serialized	= '';
+	public $serialized = '';
 
 	/**
 	* Full link to the image-file
 	*/
-	public $file		= '';
+	public $file = '';
 
 	/**
 	* Original status of the Exif data.
@@ -75,7 +75,7 @@ 
 	/**
 	* Image-ID, just needed to update the Exif status
 	*/
-	public $image_id	= false;
+	public $image_id = false;
 
 	/**
 	* Constructor
@@ -206,7 +206,7 @@ 
 			}
 			else if ($num)
 			{
-				$exif_exposure = ' 1/' . $den / $num ;
+				$exif_exposure = ' 1/' . $den / $num;
 			}
 			if ($exif_exposure)
 			{
@@ -249,7 +249,7 @@ 
 		}
 		if (isset($this->data["EXIF"]["ExposureBiasValue"]))
 		{
-			list($num,$den) = explode("/", $this->data["EXIF"]["ExposureBiasValue"]);
+			list($num, $den) = explode("/", $this->data["EXIF"]["ExposureBiasValue"]);
 			if ($den)
 			{
 				if (($num / $den) == 0)
@@ -323,12 +323,12 @@ 
 	* There are lots of possible Exif Groups and Values.
 	* But you will never heard of the missing ones. so we just allow the most common ones.
 	*/
-	static private $allowed_groups		= array(
+	static private $allowed_groups = array(
 		'EXIF',
 		'IFD0',
 	);
 
-	static private $allowed_keys		= array(
+	static private $allowed_keys = array(
 		'DateTimeOriginal',
 		'FocalLength',
 		'ExposureTime',

Braces +5 added lines, -10 removed lines

@@ -110,8 +110,7 @@ 
 		if ($this->status == self::DBSAVED)
 		{
 			$this->data = @unserialize($data);
-		}
-		else if (($this->status == self::AVAILABLE) || ($this->status == self::UNKNOWN))
+		} else if (($this->status == self::AVAILABLE) || ($this->status == self::UNKNOWN))
 		{
 			$this->read();
 		}
@@ -137,8 +136,7 @@ 
 				if (!in_array($key, self::$allowed_groups))
 				{
 					unset($this->data[$key]);
-				}
-				else
+				} else
 				{
 					foreach ($this->data[$key] as $subkey => $array)
 					{
@@ -152,8 +150,7 @@ 
 
 			$this->serialized = serialize($this->data);
 			$this->status = self::DBSAVED;
-		}
-		else
+		} else
 		{
 			$this->status = self::UNAVAILABLE;
 		}
@@ -203,8 +200,7 @@ 
 			if (($num > $den) && $den)
 			{
 				$exif_exposure = $num / $den;
-			}
-			else if ($num)
+			} else if ($num)
 			{
 				$exif_exposure = ' 1/' . $den / $num ;
 			}
@@ -255,8 +251,7 @@ 
 				if (($num / $den) == 0)
 				{
 					$exif_exposure_bias = 0;
-				}
-				else
+				} else
 				{
 					$exif_exposure_bias = $this->data["EXIF"]["ExposureBiasValue"];
 				}

Indentation +51 added lines, -51 removed lines

@@ -15,74 +15,74 @@ 
 class exif
 {
 	/**
-	* Default value for new users
-	*/
+	 * Default value for new users
+	 */
 	const DEFAULT_DISPLAY	= true;
 
 	/**
-	* phpBB will treat the time from the Exif data like UTC.
-	* If your images were taken with an other timezone, you can insert an offset here.
-	* The offset is than added to the timestamp before it is converted into the users time.
-	*
-	* Offset must be set in seconds.
-	*/
+	 * phpBB will treat the time from the Exif data like UTC.
+	 * If your images were taken with an other timezone, you can insert an offset here.
+	 * The offset is than added to the timestamp before it is converted into the users time.
+	 *
+	 * Offset must be set in seconds.
+	 */
 	const TIME_OFFSET	= 0;
 
 	/**
-	* Constants for the status of the Exif data.
-	*/
+	 * Constants for the status of the Exif data.
+	 */
 	const UNAVAILABLE	= 0;
 	const AVAILABLE		= 1;
 	const UNKNOWN		= 2;
 	const DBSAVED		= 3;
 
 	/**
-	* Is the function available?
-	*/
+	 * Is the function available?
+	 */
 	static public $function_exists = null;
 
 	/**
-	* Exif data array with all allowed groups and keys.
-	*/
+	 * Exif data array with all allowed groups and keys.
+	 */
 	public $data		= array();
 
 	/**
-	* Filtered data array. We don't have empty or invalid values here.
-	*/
+	 * Filtered data array. We don't have empty or invalid values here.
+	 */
 	public $prepared_data	= array();
 
 	/**
-	* Does the image have exif data?
-	* Values see constant declaration at the beginning of the class.
-	*/
+	 * Does the image have exif data?
+	 * Values see constant declaration at the beginning of the class.
+	 */
 	public $status		= 2;
 
 	/**
-	* Full data array, but serialized to a string
-	*/
+	 * Full data array, but serialized to a string
+	 */
 	public $serialized	= '';
 
 	/**
-	* Full link to the image-file
-	*/
+	 * Full link to the image-file
+	 */
 	public $file		= '';
 
 	/**
-	* Original status of the Exif data.
-	*/
+	 * Original status of the Exif data.
+	 */
 	public $orig_status = null;
 
 	/**
-	* Image-ID, just needed to update the Exif status
-	*/
+	 * Image-ID, just needed to update the Exif status
+	 */
 	public $image_id	= false;
 
 	/**
-	* Constructor
-	*
-	* @param	string	$file		Full link to the image-file
-	* @param	mixed	$image_id	False or integer
-	*/
+	 * Constructor
+	 *
+	 * @param	string	$file		Full link to the image-file
+	 * @param	mixed	$image_id	False or integer
+	 */
 	public function __construct($file, $image_id = false)
 	{
 		if (self::$function_exists === null)
@@ -98,11 +98,11 @@ 
 	}
 
 	/**
-	* Interpret the values from the database, and read the data if we don't have it.
-	*
-	* @param	int		$status		Value of a status constant (see beginning of the class)
-	* @param	mixed	$data		Either an empty string or the serialized array of the Exif from the database
-	*/
+	 * Interpret the values from the database, and read the data if we don't have it.
+	 *
+	 * @param	int		$status		Value of a status constant (see beginning of the class)
+	 * @param	mixed	$data		Either an empty string or the serialized array of the Exif from the database
+	 */
 	public function interpret($status, $data)
 	{
 		$this->orig_status = $status;
@@ -118,8 +118,8 @@ 
 	}
 
 	/**
-	* Read Exif data from the image
-	*/
+	 * Read Exif data from the image
+	 */
 	public function read()
 	{
 		if (!self::$function_exists || !$this->file || !file_exists($this->file))
@@ -165,8 +165,8 @@ 
 	}
 
 	/**
-	* Validate and prepare the data, so we can send it into the template.
-	*/
+	 * Validate and prepare the data, so we can send it into the template.
+	 */
 	private function prepare_data()
 	{
 		global $user;
@@ -273,11 +273,11 @@ 
 	}
 
 	/**
-	* Sends the Exif into the template
-	*
-	* @param	bool	$expand_view	Shall we expand the Exif data on page view or collapse?
-	* @param	string	$block			Name of the template loop the Exif's are displayed in.
-	*/
+	 * Sends the Exif into the template
+	 *
+	 * @param	bool	$expand_view	Shall we expand the Exif data on page view or collapse?
+	 * @param	string	$block			Name of the template loop the Exif's are displayed in.
+	 */
 	public function send_to_template($expand_view = true, $block = 'exif_value')
 	{
 		$this->prepare_data();
@@ -301,8 +301,8 @@ 
 	}
 
 	/**
-	* Save the new Exif status in the database
-	*/
+	 * Save the new Exif status in the database
+	 */
 	public function set_status()
 	{
 		if (!$this->image_id || ($this->orig_status == $this->status))
@@ -320,9 +320,9 @@ 
 	}
 
 	/**
-	* There are lots of possible Exif Groups and Values.
-	* But you will never heard of the missing ones. so we just allow the most common ones.
-	*/
+	 * There are lots of possible Exif Groups and Values.
+	 * But you will never heard of the missing ones. so we just allow the most common ones.
+	 */
 	static private $allowed_groups		= array(
 		'EXIF',
 		'IFD0',

acpcleanup/acp/main_module.php

Braces +4 added lines, -8 removed lines

@@ -223,14 +223,12 @@ 
 			}
 
 			trigger_error($message_string . adm_back_link($this->u_action));
-		}
-		else if ($delete || $prune || (isset($_POST['cancel'])))
+		} else if ($delete || $prune || (isset($_POST['cancel'])))
 		{
 			if (isset($_POST['cancel']))
 			{
 				trigger_error($user->lang['CLEAN_GALLERY_ABORT'] . adm_back_link($this->u_action), E_USER_WARNING);
-			}
-			else
+			} else
 			{
 				$clean_gallery_confirm = $user->lang['CONFIRM_CLEAN'];
 				if ($missing_sources)
@@ -261,8 +259,7 @@ 
 						if (in_array($row['album_user_id'], $personals_bad))
 						{
 							$personals_bad_names[] = $row['album_name'];
-						}
-						else
+						} else
 						{
 							$missing_personals_names[] = $row['album_name'];
 						}
@@ -280,8 +277,7 @@ 
 				if ($prune && empty($prune_pattern))
 				{
 					trigger_error($user->lang['CLEAN_PRUNE_NO_PATTERN'] . adm_back_link($this->u_action), E_USER_WARNING);
-				}
-				else if ($prune && $prune_pattern)
+				} else if ($prune && $prune_pattern)
 				{
 					$clean_gallery_confirm = $user->lang('CONFIRM_PRUNE', $core_cleanup->lang_prune_pattern($prune_pattern)) . '<br />' . $clean_gallery_confirm;
 				}