Inspection of "Refactor Enabling/Disabling/Purging Logic + Update..." - satanasov/phpbbgallery - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#340)

unknown

created 2025-08-10 13:36 UTC

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -8,7 +8,7 @@
 block discarded – undo
  * @author    Leinad4Mind
  * @copyright 2007-2012 nickvergessen, 2014- satanasov, 2018- Leinad4Mind
  * @license   GPL-2.0-only
-  */
+ */
 
 /**
 * DO NOT CHANGE

Please login to merge, or discard this patch.

exif/language/bg/info_exif.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -30,9 +30,9 @@  discard block
 block discarded – undo
 	'EXIF_CAM_MODEL'			=> 'Camera-model',
 	'EXIF_DATE'					=> 'Image taken on',
 	'EXIF_EXPOSURE'				=> 'Shutter speed',
-	'EXIF_EXPOSURE_EXP'			=> '%s Sec',// 'EXIF_EXPOSURE' unit
+	'EXIF_EXPOSURE_EXP'			=> '%s Sec', // 'EXIF_EXPOSURE' unit
 	'EXIF_EXPOSURE_BIAS'		=> 'Exposure bias',
-	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV',// 'EXIF_EXPOSURE_BIAS' unit
+	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV', // 'EXIF_EXPOSURE_BIAS' unit
 	'EXIF_EXPOSURE_PROG'		=> 'Exposure program',
 	'EXIF_EXPOSURE_PROG_0'		=> 'Not defined',
 	'EXIF_EXPOSURE_PROG_1'		=> 'Manual',
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 	'EXIF_FLASH_CASE_93'		=> 'Flash fired, auto mode, return light not detected, red-eye reduction mode',
 	'EXIF_FLASH_CASE_95'		=> 'Flash fired, auto mode, return light detected, red-eye reduction mode',
 	'EXIF_FOCAL'				=> 'Focus length',
-	'EXIF_FOCAL_EXP'			=> '%s mm',// 'EXIF_FOCAL' unit
+	'EXIF_FOCAL_EXP'			=> '%s mm', // 'EXIF_FOCAL' unit
 	'EXIF_ISO'					=> 'ISO speed rating',
 	'EXIF_METERING_MODE'		=> 'Metering mode',
 	'EXIF_METERING_MODE_0'		=> 'Unknown',

Please login to merge, or discard this patch.

exif/language/en/info_exif.php 2 patches

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -8,7 +8,7 @@
 block discarded – undo
  * @author    Leinad4Mind
  * @copyright 2007-2012 nickvergessen, 2014- satanasov, 2018- Leinad4Mind
  * @license   GPL-2.0-only
-  */
+ */
 
 /**
 * @ignore

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -30,9 +30,9 @@  discard block
 block discarded – undo
 	'EXIF_CAM_MODEL'			=> 'Camera-model',
 	'EXIF_DATE'					=> 'Image taken on',
 	'EXIF_EXPOSURE'				=> 'Shutter speed',
-	'EXIF_EXPOSURE_EXP'			=> '%s Sec',// 'EXIF_EXPOSURE' unit
+	'EXIF_EXPOSURE_EXP'			=> '%s Sec', // 'EXIF_EXPOSURE' unit
 	'EXIF_EXPOSURE_BIAS'		=> 'Exposure bias',
-	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV',// 'EXIF_EXPOSURE_BIAS' unit
+	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV', // 'EXIF_EXPOSURE_BIAS' unit
 	'EXIF_EXPOSURE_PROG'		=> 'Exposure program',
 	'EXIF_EXPOSURE_PROG_0'		=> 'Not defined',
 	'EXIF_EXPOSURE_PROG_1'		=> 'Manual',
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 	'EXIF_FLASH_CASE_93'		=> 'Flash fired, auto mode, return light not detected, red-eye reduction mode',
 	'EXIF_FLASH_CASE_95'		=> 'Flash fired, auto mode, return light detected, red-eye reduction mode',
 	'EXIF_FOCAL'				=> 'Focus length',
-	'EXIF_FOCAL_EXP'			=> '%s mm',// 'EXIF_FOCAL' unit
+	'EXIF_FOCAL_EXP'			=> '%s mm', // 'EXIF_FOCAL' unit
 	'EXIF_ISO'					=> 'ISO speed rating',
 	'EXIF_METERING_MODE'		=> 'Metering mode',
 	'EXIF_METERING_MODE_0'		=> 'Unknown',

Please login to merge, or discard this patch.

exif/language/fr/info_exif.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,9 +31,9 @@  discard block
 block discarded – undo
 	'EXIF_CAM_MODEL'			=> 'Modèle d’appareil photo',
 	'EXIF_DATE'					=> 'Image prise le',
 	'EXIF_EXPOSURE'				=> 'Vitesse d’obturation',
-	'EXIF_EXPOSURE_EXP'			=> '%s Sec',// 'EXIF_EXPOSURE' unit
+	'EXIF_EXPOSURE_EXP'			=> '%s Sec', // 'EXIF_EXPOSURE' unit
 	'EXIF_EXPOSURE_BIAS'		=> 'Angle d’exposition',
-	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV',// 'EXIF_EXPOSURE_BIAS' unit
+	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s EV', // 'EXIF_EXPOSURE_BIAS' unit
 	'EXIF_EXPOSURE_PROG'		=> 'Programme d’exposition',
 	'EXIF_EXPOSURE_PROG_0'		=> 'Non défini',
 	'EXIF_EXPOSURE_PROG_1'		=> 'Manuel',
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
 	'EXIF_FLASH_CASE_93'		=> 'Flash déclenché, mode automatique, avec retour de lumière non détecté, yeux rouges réduits',
 	'EXIF_FLASH_CASE_95'		=> 'Flash déclenché, mode automatique, avec retour de lumière détecté, yeux rouges réduits',
 	'EXIF_FOCAL'				=> 'Longueur de focale',
-	'EXIF_FOCAL_EXP'			=> '%s mm',// 'EXIF_FOCAL' unit
+	'EXIF_FOCAL_EXP'			=> '%s mm', // 'EXIF_FOCAL' unit
 	'EXIF_ISO'					=> 'Sensibilité ISO',
 	'EXIF_METERING_MODE'		=> 'Mode de mesure',
 	'EXIF_METERING_MODE_0'		=> 'Inconnu',

Please login to merge, or discard this patch.

exif/language/ru/info_exif.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

		@@ -31,9 +31,9 @@ discard block
		block discarded – undo
31	31	'EXIF_CAM_MODEL' => 'Модель камеры',
32	32	'EXIF_DATE' => 'Изображение заснято',
33	33	'EXIF_EXPOSURE' => 'Выдержка',
34		- 'EXIF_EXPOSURE_EXP' => '%s сек',// 'EXIF_EXPOSURE' unit
	34	+ 'EXIF_EXPOSURE_EXP' => '%s сек', // 'EXIF_EXPOSURE' unit
35	35	'EXIF_EXPOSURE_BIAS' => 'Корректировка выдержки',
36		- 'EXIF_EXPOSURE_BIAS_EXP' => '%s LW',// 'EXIF_EXPOSURE_BIAS' unit
	36	+ 'EXIF_EXPOSURE_BIAS_EXP' => '%s LW', // 'EXIF_EXPOSURE_BIAS' unit
37	37	'EXIF_EXPOSURE_PROG' => 'Программа экспозиции',
38	38	'EXIF_EXPOSURE_PROG_0' => 'Неопределенно',
39	39	'EXIF_EXPOSURE_PROG_1' => 'Вручную',
		@@ -73,7 +73,7 @@ discard block
		block discarded – undo
73	73	'EXIF_FLASH_CASE_93' => 'Вспышка сработала, авторежим, нет отражателя вспышки, подавление эффекта красных глаз',
74	74	'EXIF_FLASH_CASE_95' => 'Вспышка сработала, авторежим, отражатель вспышки сработал, подавление эффекта красных глаз',
75	75	'EXIF_FOCAL' => 'Фокусное расстояние',
76		- 'EXIF_FOCAL_EXP' => '%s mm',// 'EXIF_FOCAL' unit
	76	+ 'EXIF_FOCAL_EXP' => '%s mm', // 'EXIF_FOCAL' unit
77	77	'EXIF_ISO' => 'ISO-чувствительность',
78	78	'EXIF_METERING_MODE' => 'Метод выдержки и измерения',
79	79	'EXIF_METERING_MODE_0' => 'Неизвестно',

Please login to merge, or discard this patch.

exif/language/de/info_exif.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,9 +31,9 @@  discard block
 block discarded – undo
 	'EXIF_CAM_MODEL'			=> 'Kamera-Modell',
 	'EXIF_DATE'					=> 'Bild aufgenommen am',
 	'EXIF_EXPOSURE'				=> 'Belichtungszeit',
-	'EXIF_EXPOSURE_EXP'			=> '%s Sek',// 'EXIF_EXPOSURE' unit
+	'EXIF_EXPOSURE_EXP'			=> '%s Sek', // 'EXIF_EXPOSURE' unit
 	'EXIF_EXPOSURE_BIAS'		=> 'Belichtungskorrektur',
-	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s LW',// 'EXIF_EXPOSURE_BIAS' unit
+	'EXIF_EXPOSURE_BIAS_EXP'	=> '%s LW', // 'EXIF_EXPOSURE_BIAS' unit
 	'EXIF_EXPOSURE_PROG'		=> 'Belichtungsprogramm',
 	'EXIF_EXPOSURE_PROG_0'		=> 'Nicht definiert',
 	'EXIF_EXPOSURE_PROG_1'		=> 'Manuell',
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
 	'EXIF_FLASH_CASE_93'		=> 'Blitz wurde ausgelöst, Automodus, kein Messblitz-Licht zurückgeworfen, Rote-Augen-Reduzierung',
 	'EXIF_FLASH_CASE_95'		=> 'Blitz wurde ausgelöst, Automodus, Messblitz-Licht zurückgeworfen, Rote-Augen-Reduzierung',
 	'EXIF_FOCAL'				=> 'Brennweite',
-	'EXIF_FOCAL_EXP'			=> '%s mm',// 'EXIF_FOCAL' unit
+	'EXIF_FOCAL_EXP'			=> '%s mm', // 'EXIF_FOCAL' unit
 	'EXIF_ISO'					=> 'ISO-Empfindlichkeit',
 	'EXIF_METERING_MODE'		=> 'Belichtungs- Messmethode',
 	'EXIF_METERING_MODE_0'		=> 'Unbekannt',

Please login to merge, or discard this patch.

exif/ext.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -48,11 +48,11 @@
 block discarded – undo
 	}
 
 	/**
-	* Perform additional tasks on extension enable
-	*
-	* @param mixed $old_state State returned by previous call of this method
-	* @return mixed Returns false after last step, otherwise temporary state
-	*/
+	 * Perform additional tasks on extension enable
+	 *
+	 * @param mixed $old_state State returned by previous call of this method
+	 * @return mixed Returns false after last step, otherwise temporary state
+	 */
 	public function enable_step($old_state)
 	{
 		if (empty($old_state))

Please login to merge, or discard this patch.

exif/migrations/m2_fix_exif_field.php 1 patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -13,32 +13,32 @@
 block discarded – undo
 
 class m2_fix_exif_field extends migration
 {
-    public static function depends_on(): array
-    {
-        return [
-            '\phpbbgallery\exif\migrations\m1_init',
-        ];
-    }
+	public static function depends_on(): array
+	{
+		return [
+			'\phpbbgallery\exif\migrations\m1_init',
+		];
+	}
 
-    public function update_schema(): array
-    {
-        return [
-            'change_columns' => [
-                $this->table_prefix . 'gallery_images' => [
-                    'image_exif_data' => ['TEXT', null],
-                ],
-            ],
-        ];
-    }
+	public function update_schema(): array
+	{
+		return [
+			'change_columns' => [
+				$this->table_prefix . 'gallery_images' => [
+					'image_exif_data' => ['TEXT', null],
+				],
+			],
+		];
+	}
 
-    public function revert_schema(): array
-    {
-        return [
-            'change_columns' => [
-                $this->table_prefix . 'gallery_images' => [
-                    'image_exif_data' => ['TEXT', ''],
-                ],
-            ],
-        ];
-    }
+	public function revert_schema(): array
+	{
+		return [
+			'change_columns' => [
+				$this->table_prefix . 'gallery_images' => [
+					'image_exif_data' => ['TEXT', ''],
+				],
+			],
+		];
+	}
 }

Please login to merge, or discard this patch.

		@@ -48,11 +48,11 @@
		block discarded – undo
48	48	}
49	49
50	50	/**
51		- * Perform additional tasks on extension enable
52		- *
53		- * @param mixed $old_state State returned by previous call of this method
54		- * @return mixed Returns false after last step, otherwise temporary state
55		- */
	51	+ * Perform additional tasks on extension enable
	52	+ *
	53	+ * @param mixed $old_state State returned by previous call of this method
	54	+ * @return mixed Returns false after last step, otherwise temporary state
	55	+ */
56	56	public function enable_step($old_state)
57	57	{
58	58	if (empty($old_state))

		@@ -8,7 +8,7 @@
		block discarded – undo
8	8	* @author Leinad4Mind
9	9	* @copyright 2007-2012 nickvergessen, 2014- satanasov, 2018- Leinad4Mind
10	10	* @license GPL-2.0-only
11		- */
	11	+ */
12	12
13	13	/**
14	14	* DO NOT CHANGE

		@@ -30,9 +30,9 @@ discard block
		block discarded – undo
30	30	'EXIF_CAM_MODEL' => 'Camera-model',
31	31	'EXIF_DATE' => 'Image taken on',
32	32	'EXIF_EXPOSURE' => 'Shutter speed',
33		- 'EXIF_EXPOSURE_EXP' => '%s Sec',// 'EXIF_EXPOSURE' unit
	33	+ 'EXIF_EXPOSURE_EXP' => '%s Sec', // 'EXIF_EXPOSURE' unit
34	34	'EXIF_EXPOSURE_BIAS' => 'Exposure bias',
35		- 'EXIF_EXPOSURE_BIAS_EXP' => '%s EV',// 'EXIF_EXPOSURE_BIAS' unit
	35	+ 'EXIF_EXPOSURE_BIAS_EXP' => '%s EV', // 'EXIF_EXPOSURE_BIAS' unit
36	36	'EXIF_EXPOSURE_PROG' => 'Exposure program',
37	37	'EXIF_EXPOSURE_PROG_0' => 'Not defined',
38	38	'EXIF_EXPOSURE_PROG_1' => 'Manual',
		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	'EXIF_FLASH_CASE_93' => 'Flash fired, auto mode, return light not detected, red-eye reduction mode',
73	73	'EXIF_FLASH_CASE_95' => 'Flash fired, auto mode, return light detected, red-eye reduction mode',
74	74	'EXIF_FOCAL' => 'Focus length',
75		- 'EXIF_FOCAL_EXP' => '%s mm',// 'EXIF_FOCAL' unit
	75	+ 'EXIF_FOCAL_EXP' => '%s mm', // 'EXIF_FOCAL' unit
76	76	'EXIF_ISO' => 'ISO speed rating',
77	77	'EXIF_METERING_MODE' => 'Metering mode',
78	78	'EXIF_METERING_MODE_0' => 'Unknown',

		@@ -31,9 +31,9 @@ discard block
		block discarded – undo
31	31	'EXIF_CAM_MODEL' => 'Modèle d’appareil photo',
32	32	'EXIF_DATE' => 'Image prise le',
33	33	'EXIF_EXPOSURE' => 'Vitesse d’obturation',
34		- 'EXIF_EXPOSURE_EXP' => '%s Sec',// 'EXIF_EXPOSURE' unit
	34	+ 'EXIF_EXPOSURE_EXP' => '%s Sec', // 'EXIF_EXPOSURE' unit
35	35	'EXIF_EXPOSURE_BIAS' => 'Angle d’exposition',
36		- 'EXIF_EXPOSURE_BIAS_EXP' => '%s EV',// 'EXIF_EXPOSURE_BIAS' unit
	36	+ 'EXIF_EXPOSURE_BIAS_EXP' => '%s EV', // 'EXIF_EXPOSURE_BIAS' unit
37	37	'EXIF_EXPOSURE_PROG' => 'Programme d’exposition',
38	38	'EXIF_EXPOSURE_PROG_0' => 'Non défini',
39	39	'EXIF_EXPOSURE_PROG_1' => 'Manuel',
		@@ -73,7 +73,7 @@ discard block
		block discarded – undo
73	73	'EXIF_FLASH_CASE_93' => 'Flash déclenché, mode automatique, avec retour de lumière non détecté, yeux rouges réduits',
74	74	'EXIF_FLASH_CASE_95' => 'Flash déclenché, mode automatique, avec retour de lumière détecté, yeux rouges réduits',
75	75	'EXIF_FOCAL' => 'Longueur de focale',
76		- 'EXIF_FOCAL_EXP' => '%s mm',// 'EXIF_FOCAL' unit
	76	+ 'EXIF_FOCAL_EXP' => '%s mm', // 'EXIF_FOCAL' unit
77	77	'EXIF_ISO' => 'Sensibilité ISO',
78	78	'EXIF_METERING_MODE' => 'Mode de mesure',
79	79	'EXIF_METERING_MODE_0' => 'Inconnu',

		@@ -31,9 +31,9 @@ discard block
		block discarded – undo
31	31	'EXIF_CAM_MODEL' => 'Kamera-Modell',
32	32	'EXIF_DATE' => 'Bild aufgenommen am',
33	33	'EXIF_EXPOSURE' => 'Belichtungszeit',
34		- 'EXIF_EXPOSURE_EXP' => '%s Sek',// 'EXIF_EXPOSURE' unit
	34	+ 'EXIF_EXPOSURE_EXP' => '%s Sek', // 'EXIF_EXPOSURE' unit
35	35	'EXIF_EXPOSURE_BIAS' => 'Belichtungskorrektur',
36		- 'EXIF_EXPOSURE_BIAS_EXP' => '%s LW',// 'EXIF_EXPOSURE_BIAS' unit
	36	+ 'EXIF_EXPOSURE_BIAS_EXP' => '%s LW', // 'EXIF_EXPOSURE_BIAS' unit
37	37	'EXIF_EXPOSURE_PROG' => 'Belichtungsprogramm',
38	38	'EXIF_EXPOSURE_PROG_0' => 'Nicht definiert',
39	39	'EXIF_EXPOSURE_PROG_1' => 'Manuell',
		@@ -73,7 +73,7 @@ discard block
		block discarded – undo
73	73	'EXIF_FLASH_CASE_93' => 'Blitz wurde ausgelöst, Automodus, kein Messblitz-Licht zurückgeworfen, Rote-Augen-Reduzierung',
74	74	'EXIF_FLASH_CASE_95' => 'Blitz wurde ausgelöst, Automodus, Messblitz-Licht zurückgeworfen, Rote-Augen-Reduzierung',
75	75	'EXIF_FOCAL' => 'Brennweite',
76		- 'EXIF_FOCAL_EXP' => '%s mm',// 'EXIF_FOCAL' unit
	76	+ 'EXIF_FOCAL_EXP' => '%s mm', // 'EXIF_FOCAL' unit
77	77	'EXIF_ISO' => 'ISO-Empfindlichkeit',
78	78	'EXIF_METERING_MODE' => 'Belichtungs- Messmethode',
79	79	'EXIF_METERING_MODE_0' => 'Unbekannt',

		@@ -13,32 +13,32 @@
		block discarded – undo
13	13
14	14	class m2_fix_exif_field extends migration
15	15	{
16		- public static function depends_on(): array
17		- {
18		- return [
19		- '\phpbbgallery\exif\migrations\m1_init',
20		- ];
21		- }
	16	+ public static function depends_on(): array
	17	+ {
	18	+ return [
	19	+ '\phpbbgallery\exif\migrations\m1_init',
	20	+ ];
	21	+ }
22	22
23		- public function update_schema(): array
24		- {
25		- return [
26		- 'change_columns' => [
27		- $this->table_prefix . 'gallery_images' => [
28		- 'image_exif_data' => ['TEXT', null],
29		- ],
30		- ],
31		- ];
32		- }
	23	+ public function update_schema(): array
	24	+ {
	25	+ return [
	26	+ 'change_columns' => [
	27	+ $this->table_prefix . 'gallery_images' => [
	28	+ 'image_exif_data' => ['TEXT', null],
	29	+ ],
	30	+ ],
	31	+ ];
	32	+ }
33	33
34		- public function revert_schema(): array
35		- {
36		- return [
37		- 'change_columns' => [
38		- $this->table_prefix . 'gallery_images' => [
39		- 'image_exif_data' => ['TEXT', ''],
40		- ],
41		- ],
42		- ];
43		- }
	34	+ public function revert_schema(): array
	35	+ {
	36	+ return [
	37	+ 'change_columns' => [
	38	+ $this->table_prefix . 'gallery_images' => [
	39	+ 'image_exif_data' => ['TEXT', ''],
	40	+ ],
	41	+ ],
	42	+ ];
	43	+ }
44	44	}

satanasov / phpbbgallery

Pull Request — master (#340)

Category

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch