phpbbgallery\core\controller\album::base()

Complexity

Conditions	20
Paths	385

Size

Total Lines	101
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	44
CRAP Score	21.9582

Importance

Changes	3
Bugs	0	Features	0

<?php
	public function base($album_id, $page = 0)
	{
		$album_id = (int) $album_id;
		$this->language->add_lang(array('gallery'), 'phpbbgallery/core');

		try
		{
			$this->loader->load($album_id);
		}
		catch (\Exception $e)
		{
			throw new \phpbb\exception\http_exception(404, 'ALBUM_NOT_EXIST');

The type phpbb\exception\http_exception was not found. Maybe you did not declare it correctly or list all dependencies?

		}

		$album_data = $this->loader->get($album_id);

		if ($album_data['album_type'] == \phpbbgallery\core\block::TYPE_CONTEST)
		{
			if ($album_data['contest_id'] && $album_data['contest_marked'] && (($album_data['contest_start'] + $album_data['contest_end']) < time()))
			{
				$contest_end_time = $album_data['contest_start'] + $album_data['contest_end'];
				$this->contest->end($album_id, $album_data['contest_id'], $contest_end_time);

				$album_contest_data['contest_marked'] = \phpbbgallery\core\block::NO_CONTEST;

$album_contest_data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $album_contest_data = array(); before regardless.

			}
		}
		$this->check_permissions($album_id, $album_data['album_user_id'], $album_data['album_auth_access']);
		$this->auth_level->display($album_id, $album_data['album_status'], $album_data['album_user_id']);

		$this->display->generate_navigation($album_data);
		$this->display->display_albums($album_data, $this->config['load_moderators']);

		$page_title = $album_data['album_name'];
		if ($page > 1)
		{
			$page_title .= ' - ' . $this->language->lang('PAGE_TITLE_NUMBER', $page);
		}

		if ($this->config['load_moderators'])
		{
			$moderators = $this->display->get_moderators($album_id);

$album_id of type integer is incompatible with the type boolean expected by parameter $album_id of phpbbgallery\core\album\display::get_moderators().

			if (!empty($moderators[$album_id]))
			{
				$moderators = $moderators[$album_id];
				$l_moderator = (sizeof($moderators) == 1) ? $this->language->lang('MODERATOR') : $this->language->lang('MODERATORS');
				$this->template->assign_vars(array(
					'L_MODERATORS' => $l_moderator,
					'MODERATORS'   => implode($this->language->lang('COMMA_SEPARATOR'), $moderators),
				));
			}
		}

		if ($this->auth->acl_check('m_', $album_id, $album_data['album_user_id']))
		{
			$this->template->assign_var('U_MCP', $this->helper->route(
				'phpbbgallery_core_moderate_album',
				array('album_id' => (int) $album_id)
			));
		}
		if ((!$album_data['album_user_id'] || $album_data['album_user_id'] == $this->user->data['user_id'])
			&& ($this->user->data['user_id'] == ANONYMOUS || $this->auth->acl_check('i_upload', $album_id, $album_data['album_user_id'])))

The constant phpbbgallery\core\controller\ANONYMOUS was not found. Maybe you did not declare it correctly or list all dependencies?

		{
			if (!array_key_exists('contest_start', $album_data))
			{
				$this->template->assign_var('U_UPLOAD_IMAGE', $this->helper->route(
					'phpbbgallery_core_album_upload',
					array('album_id' => (int) $album_id)
				));
			}
			else
			{
				if ($album_data['contest_start'] + $album_data['contest_rating'] > time())
				{
					$this->template->assign_var('U_UPLOAD_IMAGE', $this->helper->route(
						'phpbbgallery_core_album_upload',
						array('album_id' => (int) $album_id)
					));
				}
			}
		}

		$this->template->assign_vars(array(
			'S_IS_POSTABLE' => $album_data['album_type'] != \phpbbgallery\core\block::TYPE_CAT,
			'S_IS_LOCKED'   => $album_data['album_status'] == \phpbbgallery\core\block::ALBUM_LOCKED,

			'U_RETURN_LINK'  => $this->helper->route('phpbbgallery_core_index'),
			'L_RETURN_LINK'  => $this->language->lang('RETURN_TO_GALLERY'),
			'S_ALBUM_ACTION' => $this->helper->route('phpbbgallery_core_album', array('album_id' => (int) $album_id)),
			'S_IS_WATCHED'   => $this->notifications_helper->get_watched_album($album_id) ? true : false,
			'U_WATCH_TOGLE'  => $this->helper->route('phpbbgallery_core_album_watch', array('album_id' => (int) $album_id)),
		));

		if ($album_data['album_type'] != \phpbbgallery\core\block::TYPE_CAT
			&& $album_data['album_images_real'] > 0)
		{
			$this->display_images($album_id, $album_data, ($page - 1) * (int) $this->config['phpbb_gallery_items_per_page'], (int) $this->config['phpbb_gallery_items_per_page']);
		}

//		phpbb_ext_gallery_core_misc::markread('album', $album_id);

		return $this->helper->render('gallery/album_body.html', $page_title);
	}