@@ -232,8 +232,7 @@ discard block |
||
232 | 232 | if ($search_terms == 'all') |
233 | 233 | { |
234 | 234 | $keywords .= ' ' . $add_keywords; |
235 | - } |
|
236 | - else |
|
235 | + } else |
|
237 | 236 | { |
238 | 237 | $search_terms = 'all'; |
239 | 238 | $keywords = preg_replace('#\s+#u', ' |', $keywords) . ' ' .$add_keywords; |
@@ -271,8 +270,7 @@ discard block |
||
271 | 270 | if (empty($search_album)) |
272 | 271 | { |
273 | 272 | $sql_where[] = $this->db->sql_in_set('i.image_album_id', $this->gallery_auth->acl_album_ids('i_view')); |
274 | - } |
|
275 | - else |
|
273 | + } else |
|
276 | 274 | { |
277 | 275 | $sql_where[] = $this->db->sql_in_set('i.image_album_id', $search_album); |
278 | 276 | } |
@@ -131,8 +131,7 @@ discard block |
||
131 | 131 | if ($this->gallery_config->get('pegas_index_album')) |
132 | 132 | { |
133 | 133 | $this->display->display_albums('personal', $this->config['load_moderators']); |
134 | - } |
|
135 | - else |
|
134 | + } else |
|
136 | 135 | { |
137 | 136 | $last_image = $this->image->get_last_image(); |
138 | 137 | if (empty($last_image)) |
@@ -347,8 +346,7 @@ discard block |
||
347 | 346 | FROM ' . GROUPS_TABLE . ' |
348 | 347 | WHERE group_legend > 0 |
349 | 348 | ORDER BY ' . $order_legend . ' ASC'; |
350 | - } |
|
351 | - else |
|
349 | + } else |
|
352 | 350 | { |
353 | 351 | $sql = 'SELECT g.group_id, g.group_name, g.group_colour, g.group_type, g.group_legend |
354 | 352 | FROM ' . GROUPS_TABLE . ' g |
@@ -373,8 +371,7 @@ discard block |
||
373 | 371 | if ($row['group_name'] == 'BOTS' || ($this->user->data['user_id'] != ANONYMOUS && !$this->auth->acl_get('u_viewprofile'))) |
374 | 372 | { |
375 | 373 | $legend[] = '<span' . $colour_text . '>' . $group_name . '</span>'; |
376 | - } |
|
377 | - else |
|
374 | + } else |
|
378 | 375 | { |
379 | 376 | $legend[] = '<a' . $colour_text . ' href="' . append_sid($this->root_path . 'memberlist.' . $this->php_ext, 'mode=group&g=' . $row['group_id']) . '">' . $group_name . '</a>'; |
380 | 377 | } |
@@ -213,8 +213,7 @@ discard block |
||
213 | 213 | if (isset($album_data['contest_start'])) |
214 | 214 | { |
215 | 215 | $s_hide_comment_input = (time() < ($album_data['contest_start'] + $album_data['contest_end'])) ? true : false; |
216 | - } |
|
217 | - else |
|
216 | + } else |
|
218 | 217 | { |
219 | 218 | $s_hide_comment_input = false; |
220 | 219 | } |
@@ -338,14 +337,12 @@ discard block |
||
338 | 337 | $this->notification_helper->notify('new_comment', $data); |
339 | 338 | //$phpbb_gallery_notification->send_notification('image', $image_id, $image_data['image_name']); |
340 | 339 | $message .= $this->language->lang('COMMENT_STORED') . '<br />'; |
341 | - } |
|
342 | - else if ($this->misc->display_captcha('comment')) |
|
340 | + } else if ($this->misc->display_captcha('comment')) |
|
343 | 341 | { |
344 | 342 | $s_captcha_hidden_fields = ($captcha->is_solved()) ? build_hidden_fields($captcha->get_hidden_fields()) : ''; |
345 | 343 | } |
346 | 344 | $sig_checked = ($this->auth->acl_get('u_sig') && isset($_POST['attach_sig'])); |
347 | - } |
|
348 | - else |
|
345 | + } else |
|
349 | 346 | { |
350 | 347 | if ($comment_id != 0) |
351 | 348 | { |
@@ -439,8 +436,7 @@ discard block |
||
439 | 436 | $comment_data = $this->db->sql_fetchrow($result); |
440 | 437 | $this->db->sql_freeresult($result); |
441 | 438 | $image_id = (int) $comment_data['comment_image_id']; |
442 | - } |
|
443 | - else |
|
439 | + } else |
|
444 | 440 | { |
445 | 441 | $this->misc->not_authorised($image_backlink, $image_loginlink); |
446 | 442 | } |
@@ -451,8 +447,7 @@ discard block |
||
451 | 447 | { |
452 | 448 | $this->misc->not_authorised($album_backlink, $album_loginlink, 'LOGIN_EXPLAIN_UPLOAD'); |
453 | 449 | } |
454 | - } |
|
455 | - else if (($comment_data['comment_user_id'] != $this->user->data['user_id']) && !$this->gallery_auth->acl_check('m_comments', $album_id, $album_data['album_user_id'])) |
|
450 | + } else if (($comment_data['comment_user_id'] != $this->user->data['user_id']) && !$this->gallery_auth->acl_check('m_comments', $album_id, $album_data['album_user_id'])) |
|
456 | 451 | { |
457 | 452 | $this->misc->not_authorised($image_backlink, $image_loginlink); |
458 | 453 | } |
@@ -485,8 +480,7 @@ discard block |
||
485 | 480 | if (isset($album_data['contest_start'])) |
486 | 481 | { |
487 | 482 | $s_hide_comment_input = (time() < ($album_data['contest_start'] + $album_data['contest_end'])) ? true : false; |
488 | - } |
|
489 | - else |
|
483 | + } else |
|
490 | 484 | { |
491 | 485 | $s_hide_comment_input = false; |
492 | 486 | } |
@@ -578,8 +572,7 @@ discard block |
||
578 | 572 | $this->gallery_log->add_log('moderator', 'c_edit', $image_data['image_album_id'], $image_data['image_id'], array('LOG_GALLERY_COMMENT_EDITED', $image_data['image_name'])); |
579 | 573 | } |
580 | 574 | } |
581 | - } |
|
582 | - else |
|
575 | + } else |
|
583 | 576 | { |
584 | 577 | $sig_checked = (bool) $comment_data['comment_signature']; |
585 | 578 | |
@@ -653,8 +646,7 @@ discard block |
||
653 | 646 | $comment_data = $this->db->sql_fetchrow($result); |
654 | 647 | $this->db->sql_freeresult($result); |
655 | 648 | $image_id = (int) $comment_data['comment_image_id']; |
656 | - } |
|
657 | - else |
|
649 | + } else |
|
658 | 650 | { |
659 | 651 | $this->misc->not_authorised($image_backlink, $image_loginlink); |
660 | 652 | } |
@@ -665,8 +657,7 @@ discard block |
||
665 | 657 | { |
666 | 658 | $this->misc->not_authorised($album_backlink, $album_loginlink, 'LOGIN_EXPLAIN_UPLOAD'); |
667 | 659 | } |
668 | - } |
|
669 | - else if (($comment_data['comment_user_id'] != $this->user->data['user_id']) && !$this->gallery_auth->acl_check('m_comments', $album_id, $album_data['album_user_id'])) |
|
660 | + } else if (($comment_data['comment_user_id'] != $this->user->data['user_id']) && !$this->gallery_auth->acl_check('m_comments', $album_id, $album_data['album_user_id'])) |
|
670 | 661 | { |
671 | 662 | $this->misc->not_authorised($image_backlink, $image_loginlink); |
672 | 663 | } |
@@ -731,15 +722,13 @@ discard block |
||
731 | 722 | |
732 | 723 | $message = $this->language->lang('DELETED_COMMENT') . '<br />'; |
733 | 724 | $submit = true; |
734 | - } |
|
735 | - else |
|
725 | + } else |
|
736 | 726 | { |
737 | 727 | if (isset($_POST['cancel'])) |
738 | 728 | { |
739 | 729 | $message = $this->language->lang('DELETED_COMMENT_NOT') . '<br />'; |
740 | 730 | $submit = true; |
741 | - } |
|
742 | - else |
|
731 | + } else |
|
743 | 732 | { |
744 | 733 | confirm_box(false, 'DELETE_COMMENT2', $s_hidden_fields); |
745 | 734 | } |
@@ -53,8 +53,7 @@ discard block |
||
53 | 53 | { |
54 | 54 | $bbcode_id = NUM_CORE_BBCODES + 1; |
55 | 55 | } |
56 | - } |
|
57 | - else |
|
56 | + } else |
|
58 | 57 | { |
59 | 58 | $bbcode_id = NUM_CORE_BBCODES + 1; |
60 | 59 | } |
@@ -63,8 +62,7 @@ discard block |
||
63 | 62 | if ($this->config['enable_mod_rewrite']) |
64 | 63 | { |
65 | 64 | $url .= 'gallery/image/'; |
66 | - } |
|
67 | - else |
|
65 | + } else |
|
68 | 66 | { |
69 | 67 | $url .= 'app.php/gallery/image/'; |
70 | 68 | } |
@@ -118,8 +118,7 @@ |
||
118 | 118 | if (isset(self::$is_dynamic[$name])) |
119 | 119 | { |
120 | 120 | $config->set('phpbb_gallery_' . $name, $value, true); |
121 | - } |
|
122 | - else |
|
121 | + } else |
|
123 | 122 | { |
124 | 123 | $config->set('phpbb_gallery_' . $name, $value); |
125 | 124 | } |
@@ -89,8 +89,7 @@ |
||
89 | 89 | if (is_dir($file)) |
90 | 90 | { |
91 | 91 | $this->recursiveRemoveDirectory($file); |
92 | - } |
|
93 | - else |
|
92 | + } else |
|
94 | 93 | { |
95 | 94 | unlink($file); |
96 | 95 | } |
@@ -111,8 +111,7 @@ |
||
111 | 111 | $phpbb_notifications->purge_notifications('phpbbgallery.core.notification.new_image'); |
112 | 112 | $phpbb_notifications->purge_notifications('phpbbgallery.core.notification.new_comment'); |
113 | 113 | $phpbb_notifications->purge_notifications('phpbbgallery.core.notification.new_report'); |
114 | - } |
|
115 | - catch (\phpbb\notification\exception $e) |
|
114 | + } catch (\phpbb\notification\exception $e) |
|
116 | 115 | { |
117 | 116 | // continue |
118 | 117 | } |
@@ -147,8 +147,7 @@ discard block |
||
147 | 147 | if (isset($this->config['phpbb_gallery_' . $option])) |
148 | 148 | { |
149 | 149 | $config_ary[$option] = $this->config['phpbb_gallery_' . $option]; |
150 | - } |
|
151 | - else |
|
150 | + } else |
|
152 | 151 | { |
153 | 152 | $config_ary[$option] = $default; |
154 | 153 | } |
@@ -161,8 +160,7 @@ discard block |
||
161 | 160 | if (isset($this->config['phpbb_gallery_' . $key])) |
162 | 161 | { |
163 | 162 | return $this->config['phpbb_gallery_' . $key]; |
164 | - } |
|
165 | - else |
|
163 | + } else |
|
166 | 164 | { |
167 | 165 | return $this->configs_array[$key]; |
168 | 166 | } |
@@ -222,8 +222,7 @@ discard block |
||
222 | 222 | SET album_parents = '" . $this->db->sql_escape($album_data['album_parents']) . "' |
223 | 223 | WHERE parent_id = " . (int) $album_data['parent_id']; |
224 | 224 | $this->db->sql_query($sql); |
225 | - } |
|
226 | - else |
|
225 | + } else |
|
227 | 226 | { |
228 | 227 | $album_parents = unserialize($album_data['album_parents']); |
229 | 228 | } |
@@ -291,16 +290,14 @@ discard block |
||
291 | 290 | if (!empty($row['user_id'])) |
292 | 291 | { |
293 | 292 | $album_moderators[$a_id][] = get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']); |
294 | - } |
|
295 | - else |
|
293 | + } else |
|
296 | 294 | { |
297 | 295 | $group_name = (($row['group_type'] == GROUP_SPECIAL) ? $this->language->lang('G_' . $row['group_name']) : $row['group_name']); |
298 | 296 | |
299 | 297 | if ($this->user->data['user_id'] != ANONYMOUS && !$this->auth->acl_get('u_viewprofile')) |
300 | 298 | { |
301 | 299 | $album_moderators[$a_id][] = '<span' . (($row['group_colour']) ? ' style="color:#' . $row['group_colour'] . ';"' : '') . '>' . $group_name . '</span>'; |
302 | - } |
|
303 | - else |
|
300 | + } else |
|
304 | 301 | { |
305 | 302 | $album_moderators[$a_id][] = '<a' . (($row['group_colour']) ? ' style="color:#' . $row['group_colour'] . ';"' : '') . ' href="' . append_sid($this->root_path . 'memberlist.' . $this->php_ext, 'mode=group&g=' . $row['group_id']) . '">' . $group_name . '</a>'; |
306 | 303 | } |
@@ -344,8 +341,7 @@ discard block |
||
344 | 341 | } |
345 | 342 | $root_data = array('album_id' => \phpbbgallery\core\block::PUBLIC_ALBUM); |
346 | 343 | $sql_where = 'a.album_user_id = ' . \phpbbgallery\core\block::PUBLIC_ALBUM; |
347 | - } |
|
348 | - else if ($root_data == 'personal') |
|
344 | + } else if ($root_data == 'personal') |
|
349 | 345 | { |
350 | 346 | if ($mark_read == 'albums') |
351 | 347 | { |
@@ -362,8 +358,7 @@ discard block |
||
362 | 358 | { |
363 | 359 | $sql_where .= ' AND u.username_clean NOT ' . $this->db->sql_like_expression(chr($i) . $this->db->any_char); |
364 | 360 | } |
365 | - } |
|
366 | - else if ($first_char) |
|
361 | + } else if ($first_char) |
|
367 | 362 | { |
368 | 363 | $sql_where .= ' AND u.username_clean ' . $this->db->sql_like_expression(substr($first_char, 0, 1) . $this->db->any_char); |
369 | 364 | } |
@@ -407,8 +402,7 @@ discard block |
||
407 | 402 | 'phpbbgallery_core_search_recent_page',), |
408 | 403 | 'params' => array()), 'pagination', 'page', $num_pegas, $limit, $start |
409 | 404 | );*/ |
410 | - } |
|
411 | - else |
|
405 | + } else |
|
412 | 406 | { |
413 | 407 | $sql_where = 'a.left_id > ' . $root_data['left_id'] . ' AND a.left_id < ' . $root_data['right_id'] . ' AND a.album_user_id = ' . $root_data['album_user_id']; |
414 | 408 | } |
@@ -496,10 +490,12 @@ discard block |
||
496 | 490 | continue; |
497 | 491 | } |
498 | 492 | |
499 | - if (false)//@todo !$this->gallery_auth->acl_check('a_list', $album_id, $row['album_user_id'])) |
|
493 | + if (false) { |
|
494 | + //@todo !$this->gallery_auth->acl_check('a_list', $album_id, $row['album_user_id'])) |
|
500 | 495 | { |
501 | 496 | // if the user does not have permissions to list this album, skip everything until next branch |
502 | 497 | $right_id = $row['right_id']; |
498 | + } |
|
503 | 499 | continue; |
504 | 500 | } |
505 | 501 | |
@@ -524,8 +520,7 @@ discard block |
||
524 | 520 | $album_rows[$parent_id]['album_type_last_image'] = $row['album_type']; |
525 | 521 | $album_rows[$parent_id]['album_contest_marked'] = $row['contest_marked']; |
526 | 522 | $album_rows[$parent_id]['orig_album_last_image_time'] = $row['album_last_image_time']; |
527 | - } |
|
528 | - else if ($row['album_type']) |
|
523 | + } else if ($row['album_type']) |
|
529 | 524 | { |
530 | 525 | $subalbums[$parent_id][$album_id]['display'] = ($row['display_on_index']) ? true : false; |
531 | 526 | $subalbums[$parent_id][$album_id]['name'] = $row['album_name']; |
@@ -567,16 +562,14 @@ discard block |
||
567 | 562 | { |
568 | 563 | $this->misc->markread('all'); |
569 | 564 | $message = $this->language->lang('RETURN_INDEX', '<a href="' . $redirect . '">', '</a>'); |
570 | - } |
|
571 | - else |
|
565 | + } else |
|
572 | 566 | { |
573 | 567 | $this->misc->markread('albums', $album_ids); |
574 | 568 | $message = $this->language->lang('RETURN_ALBUM', '<a href="' . $redirect . '">', '</a>'); |
575 | 569 | } |
576 | 570 | meta_refresh(3, $redirect); |
577 | 571 | trigger_error($this->language->lang('ALBUMS_MARKED') . '<br /><br />' . $message); |
578 | - } |
|
579 | - else |
|
572 | + } else |
|
580 | 573 | { |
581 | 574 | $message = $this->language->lang('RETURN_PAGE', '<a href="' . $redirect . '">', '</a>'); |
582 | 575 | meta_refresh(3, $redirect); |
@@ -654,8 +647,7 @@ discard block |
||
654 | 647 | 'name' => $subalbum_row['name'], |
655 | 648 | 'unread' => $subalbum_unread, |
656 | 649 | ); |
657 | - } |
|
658 | - else |
|
650 | + } else |
|
659 | 651 | { |
660 | 652 | unset($subalbums[$album_id][$subalbum_id]); |
661 | 653 | } |
@@ -668,8 +660,7 @@ discard block |
||
668 | 660 | |
669 | 661 | $l_subalbums = (sizeof($subalbums[$album_id]) == 1) ? $this->language->lang('SUBALBUM') : $this->language->lang('SUBALBUMS'); |
670 | 662 | $folder_image = ($album_unread) ? 'forum_unread_subforum' : 'forum_read_subforum'; |
671 | - } |
|
672 | - else |
|
663 | + } else |
|
673 | 664 | { |
674 | 665 | $folder_alt = ($album_unread) ? 'NEW_IMAGES' : 'NO_NEW_IMAGES'; |
675 | 666 | $folder_image = ($album_unread) ? 'forum_unread' : 'forum_read'; |
@@ -694,8 +685,7 @@ discard block |
||
694 | 685 | $lastimage_uc_name = '';//@todo phpbb_ext_gallery_core_image::generate_link('image_name', $phpbb_ext_gallery->config->get('link_image_name'), $lastimage_image_id, $lastimage_name, $lastimage_album_id); |
695 | 686 | // phpbb_ext_gallery_core_image::generate_link('lastimage_icon', $phpbb_ext_gallery->config->get('link_image_icon'), $lastimage_image_id, $lastimage_name, $lastimage_album_id); |
696 | 687 | $lastimage_uc_icon = '';//@todo phpbb_ext_gallery_core_image::generate_link('lastimage_icon', $phpbb_ext_gallery->config->get('link_image_icon'), $lastimage_image_id, $lastimage_name, $lastimage_album_id); |
697 | - } |
|
698 | - else |
|
688 | + } else |
|
699 | 689 | { |
700 | 690 | $lastimage_time = $lastimage_album_type = $lastimage_contest_marked = 0; |
701 | 691 | $lastimage_uc_fake_thumbnail = $lastimage_uc_thumbnail = $lastimage_uc_name = $lastimage_uc_icon = ''; |