Completed
Push — master ( 13cf44...c90ced )
by Stanislav
22s queued 16s
created
core/auth/auth.php 3 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -12,21 +12,21 @@  discard block
 block discarded – undo
12 12
 
13 13
 class auth
14 14
 {
15
-	const SETTING_PERMISSIONS	= -39839;
16
-	const PERSONAL_ALBUM		= -3;
15
+	const SETTING_PERMISSIONS = -39839;
16
+	const PERSONAL_ALBUM = -3;
17 17
 	const OWN_ALBUM				= -2;
18
-	const PUBLIC_ALBUM			= 0;
18
+	const PUBLIC_ALBUM = 0;
19 19
 
20 20
 	const ACCESS_ALL			= 0;
21
-	const ACCESS_REGISTERED		= 1;
22
-	const ACCESS_NOT_FOES		= 2;
23
-	const ACCESS_FRIENDS		= 3;
24
-	const ACCESS_SPECIAL_FRIENDS	= 4;
21
+	const ACCESS_REGISTERED = 1;
22
+	const ACCESS_NOT_FOES = 2;
23
+	const ACCESS_FRIENDS = 3;
24
+	const ACCESS_SPECIAL_FRIENDS = 4;
25 25
 
26 26
 	// ACL - slightly different
27
-	const ACL_NO		= 0;
28
-	const ACL_YES		= 1;
29
-	const ACL_NEVER		= 2;
27
+	const ACL_NO = 0;
28
+	const ACL_YES = 1;
29
+	const ACL_NEVER = 2;
30 30
 
31 31
 	static protected $_permission_i = array('i_view', 'i_watermark', 'i_upload', 'i_approve', 'i_edit', 'i_delete', 'i_report', 'i_rate');
32 32
 	static protected $_permission_c = array('c_read', 'c_post', 'c_edit', 'c_delete');
@@ -167,17 +167,17 @@  discard block
 block discarded – undo
167 167
 			$sql_select .= " MAX($permission) as $permission,";
168 168
 		}
169 169
 
170
-		$this->_auth_data[self::OWN_ALBUM]				= new \phpbbgallery\core\auth\set();
170
+		$this->_auth_data[self::OWN_ALBUM] = new \phpbbgallery\core\auth\set();
171 171
 		$this->_auth_data_never[self::OWN_ALBUM]		= new \phpbbgallery\core\auth\set();
172 172
 		$this->_auth_data[self::PERSONAL_ALBUM]			= new \phpbbgallery\core\auth\set();
173
-		$this->_auth_data_never[self::PERSONAL_ALBUM]	= new \phpbbgallery\core\auth\set();
173
+		$this->_auth_data_never[self::PERSONAL_ALBUM] = new \phpbbgallery\core\auth\set();
174 174
 
175 175
 		foreach ($albums as $album)
176 176
 		{
177 177
 			if ($album['album_user_id'] == self::PUBLIC_ALBUM)
178 178
 			{
179
-				$this->_auth_data[$album['album_id']]		= new \phpbbgallery\core\auth\set();
180
-				$this->_auth_data_never[$album['album_id']]	= new \phpbbgallery\core\auth\set();
179
+				$this->_auth_data[$album['album_id']] = new \phpbbgallery\core\auth\set();
180
+				$this->_auth_data_never[$album['album_id']] = new \phpbbgallery\core\auth\set();
181 181
 			}
182 182
 		}
183 183
 
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
 
356 356
 		$zebra = null;
357 357
 
358
-		$albums = array();//@todo $this->cache->obtain_album_list();
358
+		$albums = array(); //@todo $this->cache->obtain_album_list();
359 359
 		foreach ($albums as $album)
360 360
 		{
361 361
 			if (!$album['album_auth_access'] || ($album['album_user_id'] == self::PUBLIC_ALBUM))# || ($album['album_user_id'] == $user_id))
Please login to merge, or discard this patch.
Braces   +22 added lines, -41 removed lines patch added patch discarded remove patch
@@ -130,9 +130,7 @@  discard block
 block discarded – undo
130 130
 		{
131 131
 			$this->unserialize_auth_data($cached_permissions);
132 132
 			return;
133
-		}
134
-
135
-		else if ($user_id != $this->user->user_id)
133
+		} else if ($user_id != $this->user->user_id)
136 134
 		{
137 135
 			$this->user->set_user_id($user_id);
138 136
 			$cached_permissions = $this->user->get_data('user_permissions');
@@ -252,8 +250,7 @@  discard block
 block discarded – undo
252 250
 			if (!isset($acl_array[$key]))
253 251
 			{
254 252
 				$acl_array[$key] = $key . '::' . $a_id;
255
-			}
256
-			else
253
+			} else
257 254
 			{
258 255
 				$acl_array[$key] .= ':' . $a_id;
259 256
 			}
@@ -302,8 +299,7 @@  discard block
 block discarded – undo
302 299
 				if ($data[$permission] == self::ACL_NEVER)
303 300
 				{
304 301
 					$this->_auth_data_never[$album_id]->set_bit(self::$_permissions_flipped[$permission], true);
305
-				}
306
-				else if ($data[$permission] == self::ACL_YES)
302
+				} else if ($data[$permission] == self::ACL_YES)
307 303
 				{
308 304
 					$this->_auth_data[$album_id]->set_bit(self::$_permissions_flipped[$permission], true);
309 305
 					if (substr($permission, 0, 2) == 'm_')
@@ -311,8 +307,7 @@  discard block
 block discarded – undo
311 307
 						$this->_auth_data[$album_id]->set_bit(self::$_permissions_flipped['m_'], true);
312 308
 					}
313 309
 				}
314
-			}
315
-			else
310
+			} else
316 311
 			{
317 312
 				$this->_auth_data[$album_id]->set_count($permission, $data[$permission]);
318 313
 			}
@@ -358,17 +353,17 @@  discard block
 block discarded – undo
358 353
 		$albums = array();//@todo $this->cache->obtain_album_list();
359 354
 		foreach ($albums as $album)
360 355
 		{
361
-			if (!$album['album_auth_access'] || ($album['album_user_id'] == self::PUBLIC_ALBUM))# || ($album['album_user_id'] == $user_id))
356
+			if (!$album['album_auth_access'] || ($album['album_user_id'] == self::PUBLIC_ALBUM)) {
357
+				# || ($album['album_user_id'] == $user_id))
362 358
 			{
363 359
 				continue;
364 360
 			}
365
-			else if ($user_id == ANONYMOUS)
361
+			} else if ($user_id == ANONYMOUS)
366 362
 			{
367 363
 				// Level 1: No guests
368 364
 				$this->_auth_data[$album['album_id']] = new \phpbbgallery\core\auth\set();
369 365
 				continue;
370
-			}
371
-			else if ($album['album_auth_access'] == self::ACCESS_NOT_FOES)
366
+			} else if ($album['album_auth_access'] == self::ACCESS_NOT_FOES)
372 367
 			{
373 368
 				if ($zebra == null)
374 369
 				{
@@ -380,8 +375,7 @@  discard block
 block discarded – undo
380 375
 					$this->_auth_data[$album['album_id']] = new \phpbbgallery\core\auth\set();
381 376
 					continue;
382 377
 				}
383
-			}
384
-			else if ($album['album_auth_access'] == self::ACCESS_SPECIAL_FRIENDS)
378
+			} else if ($album['album_auth_access'] == self::ACCESS_SPECIAL_FRIENDS)
385 379
 			{
386 380
 				if ($zebra == null)
387 381
 				{
@@ -393,8 +387,7 @@  discard block
 block discarded – undo
393 387
 					$this->_auth_data[$album['album_id']] = new \phpbbgallery\core\auth\set();
394 388
 					continue;
395 389
 				}
396
-			}
397
-			else if ($album['album_auth_access'] == self::ACCESS_FRIENDS)
390
+			} else if ($album['album_auth_access'] == self::ACCESS_FRIENDS)
398 391
 			{
399 392
 				if ($zebra == null)
400 393
 				{
@@ -428,21 +421,18 @@  discard block
 block discarded – undo
428 421
 			if ($row['foe'])
429 422
 			{
430 423
 				$zebra['foe'][] = (int) $row['user_id'];
431
-			}
432
-			else
424
+			} else
433 425
 			{
434 426
 				if (isset($row['bff']))
435 427
 				{
436 428
 					if ($row['bff'])
437 429
 					{
438 430
 						$zebra['bff'][] = (int) $row['user_id'];
439
-					}
440
-					else
431
+					} else
441 432
 					{
442 433
 						$zebra['friend'][] = (int) $row['user_id'];
443 434
 					}
444
-				}
445
-				else
435
+				} else
446 436
 				{
447 437
 					$zebra['friend'][] = (int) $row['user_id'];
448 438
 				}
@@ -487,16 +477,13 @@  discard block
 block discarded – undo
487 477
 			if (in_array($album_author, $zebra_array['foe']))
488 478
 			{
489 479
 				$state = 1;
490
-			}
491
-			else if (in_array($album_author, $zebra_array['friend']))
480
+			} else if (in_array($album_author, $zebra_array['friend']))
492 481
 			{
493 482
 				$state = 3;
494
-			}
495
-			else if (in_array($album_author, $zebra_array['bff']))
483
+			} else if (in_array($album_author, $zebra_array['bff']))
496 484
 			{
497 485
 				$state = 4;
498
-			}
499
-			else
486
+			} else
500 487
 			{
501 488
 				$state = 2;
502 489
 			}
@@ -543,12 +530,10 @@  discard block
 block discarded – undo
543 530
 		if (is_array($user_ids))
544 531
 		{
545 532
 			$sql_where = 'WHERE ' . $this->db->sql_in_set('user_id', array_map('intval', $user_ids));
546
-		}
547
-		else if ($user_ids == 'all')
533
+		} else if ($user_ids == 'all')
548 534
 		{
549 535
 			$sql_where = '';
550
-		}
551
-		else
536
+		} else
552 537
 		{
553 538
 			$sql_where = 'WHERE user_id = ' . (int) $user_ids;
554 539
 		}
@@ -617,8 +602,7 @@  discard block
 block discarded – undo
617 602
 			if ($this->user->is_user($u_id))
618 603
 			{
619 604
 				$p_id = self::OWN_ALBUM;
620
-			}
621
-			else
605
+			} else
622 606
 			{
623 607
 				if (!isset($this->_auth_data[$a_id]))
624 608
 				{
@@ -700,12 +684,10 @@  discard block
 block discarded – undo
700 684
 			if ($this->user->is_user($album['album_user_id']))
701 685
 			{
702 686
 				$a_id = self::OWN_ALBUM;
703
-			}
704
-			else if ($album['album_user_id'] > self::PUBLIC_ALBUM)
687
+			} else if ($album['album_user_id'] > self::PUBLIC_ALBUM)
705 688
 			{
706 689
 				$a_id = self::PERSONAL_ALBUM;
707
-			}
708
-			else
690
+			} else
709 691
 			{
710 692
 				$a_id = $album['album_id'];
711 693
 			}
@@ -755,8 +737,7 @@  discard block
 block discarded – undo
755 737
 		if ($album_data['album_user_id'] != 0)
756 738
 		{
757 739
 			$sql = 'SELECT * FROM ' . $this->table_permissions . ' WHERE ' . $this->db->sql_in_set('perm_system', array(-2, -3));
758
-		}
759
-		else
740
+		} else
760 741
 		{
761 742
 			$sql = 'SELECT * FROM ' . $this->table_permissions . ' WHERE perm_album_id = ' . (int) $album_id;
762 743
 		}
Please login to merge, or discard this patch.
Indentation   +53 added lines, -53 removed lines patch added patch discarded remove patch
@@ -41,57 +41,57 @@  discard block
 block discarded – undo
41 41
 	protected $acl_cache = array();
42 42
 
43 43
 	/**
44
-	* Cache object
45
-	* @var \phpbbgallery\core\cache
46
-	*/
44
+	 * Cache object
45
+	 * @var \phpbbgallery\core\cache
46
+	 */
47 47
 	protected $cache;
48 48
 
49 49
 	/**
50
-	* Database object
51
-	* @var \phpbb\db\driver\driver
52
-	*/
50
+	 * Database object
51
+	 * @var \phpbb\db\driver\driver
52
+	 */
53 53
 	protected $db;
54 54
 
55 55
 	/**
56
-	* Gallery user object
57
-	* @var \phpbbgallery\core\user
58
-	*/
56
+	 * Gallery user object
57
+	 * @var \phpbbgallery\core\user
58
+	 */
59 59
 	protected $user;
60 60
 
61 61
 	/**
62
-	* phpBB user object
63
-	* @var \phpbb\user
64
-	*/
62
+	 * phpBB user object
63
+	 * @var \phpbb\user
64
+	 */
65 65
 	protected $phpbb_user;
66 66
 
67 67
 	/**
68
-	* phpBB auth object
69
-	* @var \phpbb\auth\auth
70
-	*/
68
+	 * phpBB auth object
69
+	 * @var \phpbb\auth\auth
70
+	 */
71 71
 	protected $auth;
72 72
 
73 73
 	/**
74
-	* Gallery permissions table
75
-	* @var string
76
-	*/
74
+	 * Gallery permissions table
75
+	 * @var string
76
+	 */
77 77
 	protected $table_permissions;
78 78
 
79 79
 	/**
80
-	* Gallery permission roles table
81
-	* @var string
82
-	*/
80
+	 * Gallery permission roles table
81
+	 * @var string
82
+	 */
83 83
 	protected $table_roles;
84 84
 
85 85
 	/**
86
-	* Gallery users table
87
-	* @var string
88
-	*/
86
+	 * Gallery users table
87
+	 * @var string
88
+	 */
89 89
 	protected $table_users;
90 90
 
91 91
 	/**
92
-	* Gallery albums table
93
-	* @var string
94
-	*/
92
+	 * Gallery albums table
93
+	 * @var string
94
+	 */
95 95
 	protected $table_albums;
96 96
 
97 97
 	/**
@@ -339,8 +339,8 @@  discard block
 block discarded – undo
339 339
 	}
340 340
 
341 341
 	/**
342
-	* Merge the NEVER-options into the YES-options by removing the YES, if it is set.
343
-	*/
342
+	 * Merge the NEVER-options into the YES-options by removing the YES, if it is set.
343
+	 */
344 344
 	protected function merge_acl_row()
345 345
 	{
346 346
 		foreach ($this->_auth_data as $album_id => $obj)
@@ -585,14 +585,14 @@  discard block
 block discarded – undo
585 585
 	}
586 586
 
587 587
 	/**
588
-	* Get permission
589
-	*
590
-	* @param	string	$acl	One of the permissions, Exp: i_view
591
-	* @param	int		$a_id	The album_id, from which we want to have the permissions
592
-	* @param	int		$u_id	The user_id from the album-owner. If not specified we need to get it from the cache.
593
-	*
594
-	* @return	bool			Is the user allowed to do the $acl?
595
-	*/
588
+	 * Get permission
589
+	 *
590
+	 * @param	string	$acl	One of the permissions, Exp: i_view
591
+	 * @param	int		$a_id	The album_id, from which we want to have the permissions
592
+	 * @param	int		$u_id	The user_id from the album-owner. If not specified we need to get it from the cache.
593
+	 *
594
+	 * @return	bool			Is the user allowed to do the $acl?
595
+	 */
596 596
 	public function acl_check($acl, $a_id, $u_id = -1)
597 597
 	{
598 598
 		$bit = self::$_permissions_flipped[$acl];
@@ -655,12 +655,12 @@  discard block
 block discarded – undo
655 655
 	}
656 656
 
657 657
 	/**
658
-	* Does the user have the permission for any album?
659
-	*
660
-	* @param	string	$acl			One of the permissions, Exp: i_view; *_count permissions are not allowed!
661
-	*
662
-	* @return	bool			Is the user allowed to do the $acl?
663
-	*/
658
+	 * Does the user have the permission for any album?
659
+	 *
660
+	 * @param	string	$acl			One of the permissions, Exp: i_view; *_count permissions are not allowed!
661
+	 *
662
+	 * @return	bool			Is the user allowed to do the $acl?
663
+	 */
664 664
 	public function acl_check_global($acl)
665 665
 	{
666 666
 		$bit = self::$_permissions_flipped[$acl];
@@ -692,16 +692,16 @@  discard block
 block discarded – undo
692 692
 	}
693 693
 
694 694
 	/**
695
-	* Get albums by permission
696
-	*
697
-	* @param	string	$acl			One of the permissions, Exp: i_view; *_count permissions are not allowed!
698
-	* @param	string	$return			Type of the return value. array returns an array, else it's a string.
699
-	*									bool means it only checks whether the user has the permission anywhere.
700
-	* @param	bool	$display_in_rrc	Only return albums, that have the display_in_rrc-flag set.
701
-	* @param	bool	$display_pegas	Include personal galleries in the list.
702
-	*
703
-	* @return	mixed					$album_ids, either as list or array.
704
-	*/
695
+	 * Get albums by permission
696
+	 *
697
+	 * @param	string	$acl			One of the permissions, Exp: i_view; *_count permissions are not allowed!
698
+	 * @param	string	$return			Type of the return value. array returns an array, else it's a string.
699
+	 *									bool means it only checks whether the user has the permission anywhere.
700
+	 * @param	bool	$display_in_rrc	Only return albums, that have the display_in_rrc-flag set.
701
+	 * @param	bool	$display_pegas	Include personal galleries in the list.
702
+	 *
703
+	 * @return	mixed					$album_ids, either as list or array.
704
+	 */
705 705
 	public function acl_album_ids($acl, $return = 'array', $display_in_rrc = false, $display_pegas = true)
706 706
 	{
707 707
 		$bit = self::$_permissions_flipped[$acl];
Please login to merge, or discard this patch.
core/acp/albums_module.php 3 patches
Indentation   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -135,13 +135,13 @@  discard block
 block discarded – undo
135 135
 					);
136 136
 
137 137
 					/**
138
-					* Event to send requested data
139
-					* @event phpbbgallery.core.acp.albums.request_data
140
-					* @var	string	action		Action we are taking
141
-					* @var	int		album_id	Album we are doing it to
142
-					* @var	array	album_data	Album data for the album
143
-					* @since 1.2.0
144
-					*/
138
+					 * Event to send requested data
139
+					 * @event phpbbgallery.core.acp.albums.request_data
140
+					 * @var	string	action		Action we are taking
141
+					 * @var	int		album_id	Album we are doing it to
142
+					 * @var	array	album_data	Album data for the album
143
+					 * @since 1.2.0
144
+					 */
145 145
 					$vars = array('action', 'album_id', 'album_data');
146 146
 					extract($phpbb_dispatcher->trigger_event('phpbbgallery.core.acp.albums.request_data', compact($vars)));
147 147
 
@@ -384,13 +384,13 @@  discard block
 block discarded – undo
384 384
 						);
385 385
 
386 386
 						/**
387
-						* Event to send default data
388
-						*
389
-						* @event phpbbgallery.core.acp.albums.default_data
390
-						* @var	action	action		Action taken
391
-						* @var	array	album_data	Album data array
392
-						* @since 1.2.0
393
-						*/
387
+						 * Event to send default data
388
+						 *
389
+						 * @event phpbbgallery.core.acp.albums.default_data
390
+						 * @var	action	action		Action taken
391
+						 * @var	array	album_data	Album data array
392
+						 * @since 1.2.0
393
+						 */
394 394
 						$vars = array('action', 'album_data');
395 395
 						extract($phpbb_dispatcher->trigger_event('phpbbgallery.core.acp.albums.default_data', compact($vars)));
396 396
 
@@ -561,13 +561,13 @@  discard block
 block discarded – undo
561 561
 				));
562 562
 
563 563
 				/**
564
-				* Event after assigning data to templete
565
-				*
566
-				* @event phpbbgallery.core.acp.albums.send_to_template
567
-				* @var	action	action		Action taken
568
-				* @var	array	album_data	Album data array
569
-				* @since 1.2.0
570
-				*/
564
+				 * Event after assigning data to templete
565
+				 *
566
+				 * @event phpbbgallery.core.acp.albums.send_to_template
567
+				 * @var	action	action		Action taken
568
+				 * @var	array	album_data	Album data array
569
+				 * @since 1.2.0
570
+				 */
571 571
 				$vars = array('action', 'album_data');
572 572
 				extract($phpbb_dispatcher->trigger_event('phpbbgallery.core.acp.albums.send_to_template', compact($vars)));
573 573
 
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -65,9 +65,9 @@  discard block
 block discarded – undo
65 65
 
66 66
 		$action		= $request->variable('action', '');
67 67
 		$update		= (isset($_POST['update'])) ? true : false;
68
-		$album_id	= $request->variable('a', 0);
68
+		$album_id = $request->variable('a', 0);
69 69
 
70
-		$this->parent_id	= $request->variable('parent_id', 0);
70
+		$this->parent_id = $request->variable('parent_id', 0);
71 71
 		$album_data = $errors = array();
72 72
 		if ($update && !check_form_key($form_key))
73 73
 		{
@@ -81,10 +81,10 @@  discard block
 block discarded – undo
81 81
 			switch ($action)
82 82
 			{
83 83
 				case 'delete':
84
-					$action_subalbums	= $request->variable('action_subalbums', '');
85
-					$subalbums_to_id	= $request->variable('subalbums_to_id', 0);
86
-					$action_images		= $request->variable('action_images', '');
87
-					$images_to_id		= $request->variable('images_to_id', 0);
84
+					$action_subalbums = $request->variable('action_subalbums', '');
85
+					$subalbums_to_id = $request->variable('subalbums_to_id', 0);
86
+					$action_images = $request->variable('action_images', '');
87
+					$images_to_id = $request->variable('images_to_id', 0);
88 88
 
89 89
 					$errors = $manage_albums->delete_album($album_id, $action_images, $action_subalbums, $images_to_id, $subalbums_to_id);
90 90
 
@@ -232,12 +232,12 @@  discard block
 block discarded – undo
232 232
 						$acl_url = '&mode=manage&action=v_mask&album_id[]=' . $album_data['album_id'];
233 233
 
234 234
 						$message = ($action == 'add') ? $this->language->lang('ALBUM_CREATED') : $this->language->lang('ALBUM_UPDATED');
235
-						$message .= '<br /><br />' . sprintf($this->language->lang('REDIRECT_ACL'), '<a href="' . $phpbb_ext_gallery_core_url->append_sid('admin' , 'index', 'i=-phpbbgallery-core-acp-permissions_module' . $acl_url) . '">', '</a>');
235
+						$message .= '<br /><br />' . sprintf($this->language->lang('REDIRECT_ACL'), '<a href="' . $phpbb_ext_gallery_core_url->append_sid('admin', 'index', 'i=-phpbbgallery-core-acp-permissions_module' . $acl_url) . '">', '</a>');
236 236
 
237 237
 						// Redirect directly to permission settings screen
238 238
 						if ($action == 'add' && !$album_perm_from)
239 239
 						{
240
-							meta_refresh(5, $phpbb_ext_gallery_core_url->append_sid('admin' , 'index', 'i=-phpbbgallery-core-acp-permissions_module' . $acl_url));
240
+							meta_refresh(5, $phpbb_ext_gallery_core_url->append_sid('admin', 'index', 'i=-phpbbgallery-core-acp-permissions_module' . $acl_url));
241 241
 						}
242 242
 
243 243
 						trigger_error($message . adm_back_link($this->u_action . '&amp;parent_id=' . $this->parent_id));
Please login to merge, or discard this patch.
Braces   +8 added lines, -16 removed lines patch added patch discarded remove patch
@@ -321,8 +321,7 @@  discard block
 block discarded – undo
321 321
 					if (!$update)
322 322
 					{
323 323
 						$album_data = $row;
324
-					}
325
-					else
324
+					} else
326 325
 					{
327 326
 						$album_data['left_id'] = $row['left_id'];
328 327
 						$album_data['right_id'] = $row['right_id'];
@@ -330,8 +329,7 @@  discard block
 block discarded – undo
330 329
 					if ($row['album_type'] == \phpbbgallery\core\block::TYPE_CONTEST)
331 330
 					{
332 331
 						$contest_data = $phpbb_gallery_contest->get_contest($album_id, 'album');
333
-					}
334
-					else
332
+					} else
335 333
 					{
336 334
 						// Default values, 3 days later rate and 7 for the end of the contest
337 335
 						$contest_data = array(
@@ -353,8 +351,7 @@  discard block
 block discarded – undo
353 351
 					/*
354 352
 					$album_data['album_password_confirm'] = $album_data['album_password'];
355 353
 					*/
356
-				}
357
-				else
354
+				} else
358 355
 				{
359 356
 					$this->page_title = 'CREATE_ALBUM';
360 357
 
@@ -491,8 +488,7 @@  discard block
 block discarded – undo
491 488
 						'S_HAS_SUBALBUMS'		=> ($album_data['right_id'] - $album_data['left_id'] > 1) ? true : false,
492 489
 						'S_ALBUMS_LIST'			=> $albums_list,
493 490
 					));
494
-				}
495
-				else if ($uploadable_album_exists)
491
+				} else if ($uploadable_album_exists)
496 492
 				{
497 493
 					$template->assign_vars(array(
498 494
 						'S_MOVE_ALBUM_OPTIONS'		=> $phpbb_ext_gallery_core_album->get_albumbox(true, '', $album_data['parent_id'], false, $album_id, 0, \phpbbgallery\core\block::TYPE_UPLOAD),
@@ -632,8 +628,7 @@  discard block
 block discarded – undo
632 628
 		if (!$this->parent_id)
633 629
 		{
634 630
 			$navigation = $user->lang['GALLERY_INDEX'];
635
-		}
636
-		else
631
+		} else
637 632
 		{
638 633
 			$navigation = '<a href="' . $this->u_action . '">' . $user->lang['GALLERY_INDEX'] . '</a>';
639 634
 
@@ -643,8 +638,7 @@  discard block
 block discarded – undo
643 638
 				if ($row['album_id'] == $this->parent_id)
644 639
 				{
645 640
 					$navigation .= ' -&gt; ' . $row['album_name'];
646
-				}
647
-				else
641
+				} else
648 642
 				{
649 643
 					$navigation .= ' -&gt; <a href="' . $this->u_action . '&amp;parent_id=' . $row['album_id'] . '">' . $row['album_name'] . '</a>';
650 644
 				}
@@ -675,8 +669,7 @@  discard block
 block discarded – undo
675 669
 				if ($row['album_status'] == \phpbbgallery\core\block::ALBUM_LOCKED)
676 670
 				{
677 671
 					$folder_image = '<img src="images/icon_folder_lock.gif" alt="' . $user->lang['LOCKED'] . '" />';
678
-				}
679
-				else
672
+				} else
680 673
 				{
681 674
 					$folder_image = ($row['left_id'] + 1 != $row['right_id']) ? '<img src="images/icon_subfolder.gif" alt="' . $user->lang['SUBALBUM'] . '" />' : '<img src="images/icon_folder.gif" alt="' . $user->lang['FOLDER'] . '" />';
682 675
 				}
@@ -702,8 +695,7 @@  discard block
 block discarded – undo
702 695
 				);
703 696
 			}
704 697
 			while ($row = $db->sql_fetchrow($result));
705
-		}
706
-		else if ($this->parent_id)
698
+		} else if ($this->parent_id)
707 699
 		{
708 700
 			$row = $phpbb_ext_gallery_core_album->get_info($this->parent_id);
709 701
 
Please login to merge, or discard this patch.
core/acp/config_module.php 3 patches
Indentation   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -12,13 +12,13 @@  discard block
 block discarded – undo
12 12
 class config_module
13 13
 {
14 14
 	/**
15
-	* This function is called, when the main() function is called.
16
-	* You can use this function to add your language files, check for a valid mode, unset config options and more.
17
-	*
18
-	* @param	int		$id		The ID of the module
19
-	* @param	string	$mode	The name of the mode we want to display
20
-	* @return	void
21
-	*/
15
+	 * This function is called, when the main() function is called.
16
+	 * You can use this function to add your language files, check for a valid mode, unset config options and more.
17
+	 *
18
+	 * @param	int		$id		The ID of the module
19
+	 * @param	string	$mode	The name of the mode we want to display
20
+	 * @return	void
21
+	 */
22 22
 	public function main($id, $mode)
23 23
 	{
24 24
 		// Check whether the mode is allowed.
@@ -263,33 +263,33 @@  discard block
 block discarded – undo
263 263
 	}
264 264
 
265 265
 	/**
266
-	* Returns an array with the display_var array for the given mode
267
-	* The returned display must have the two keys title and vars
268
-	*		@key	string	title		The page title or lang key for the page title
269
-	*		@key	array	vars		An array of tupels, one foreach config option we display:
270
-	*					@key		The name of the config in the get_config_array() array.
271
-	*								If the key starts with 'legend' a new box is opened with the value being the title of this box.
272
-	*					@value		An array with several options:
273
-	*						@key lang		Description for the config value (can be a language key)
274
-	*						@key explain	Boolean whether the config has an explanation of not.
275
-	*										If true, <lang>_EXP (and <lang>_EXPLAIN) is displayed as explanation
276
-	*						@key validate	The config value can be validated as bool, int or string.
277
-	*										Additional a min and max value can be specified for integers
278
-	*										On strings the min and max value are the length of the string
279
-	*										If your config value shall not be casted, remove the validate-key.
280
-	*						@key type		The type of the config option:
281
-	*										- Radio buttons:		Either with "Yes and No" (radio:yes_no) or "Enabled and Disabled" (radio:enabled_disabled) as description
282
-	*										- Text/password field:	"text:<field-size>:<text-max-length>" and "password:<field-size>:<text-max-length>"
283
-	*										- Select:				"select" requires the key "function" or "method" to be set which provides the html code for the options
284
-	*										- Custom template:		"custom" requires the key "function" or "method" to be set which provides the html code
285
-	*						@key function/method	Required when using type select and custom
286
-	*						@key append		A language string that is appended after the config type (e.g. You can append 'px' to a pixel size field)
287
-	* This last parameter is optional
288
-	*		@key	string	tpl			Name of the template file we use to display the configs
289
-	*
290
-	* @param	string	$mode	The name of the mode we want to display
291
-	* @return	array		See description above
292
-	*/
266
+	 * Returns an array with the display_var array for the given mode
267
+	 * The returned display must have the two keys title and vars
268
+	 *		@key	string	title		The page title or lang key for the page title
269
+	 *		@key	array	vars		An array of tupels, one foreach config option we display:
270
+	 *					@key		The name of the config in the get_config_array() array.
271
+	 *								If the key starts with 'legend' a new box is opened with the value being the title of this box.
272
+	 *					@value		An array with several options:
273
+	 *						@key lang		Description for the config value (can be a language key)
274
+	 *						@key explain	Boolean whether the config has an explanation of not.
275
+	 *										If true, <lang>_EXP (and <lang>_EXPLAIN) is displayed as explanation
276
+	 *						@key validate	The config value can be validated as bool, int or string.
277
+	 *										Additional a min and max value can be specified for integers
278
+	 *										On strings the min and max value are the length of the string
279
+	 *										If your config value shall not be casted, remove the validate-key.
280
+	 *						@key type		The type of the config option:
281
+	 *										- Radio buttons:		Either with "Yes and No" (radio:yes_no) or "Enabled and Disabled" (radio:enabled_disabled) as description
282
+	 *										- Text/password field:	"text:<field-size>:<text-max-length>" and "password:<field-size>:<text-max-length>"
283
+	 *										- Select:				"select" requires the key "function" or "method" to be set which provides the html code for the options
284
+	 *										- Custom template:		"custom" requires the key "function" or "method" to be set which provides the html code
285
+	 *						@key function/method	Required when using type select and custom
286
+	 *						@key append		A language string that is appended after the config type (e.g. You can append 'px' to a pixel size field)
287
+	 * This last parameter is optional
288
+	 *		@key	string	tpl			Name of the template file we use to display the configs
289
+	 *
290
+	 * @param	string	$mode	The name of the mode we want to display
291
+	 * @return	array		See description above
292
+	 */
293 293
 	public function get_display_vars($mode)
294 294
 	{
295 295
 		global $phpbb_dispatcher;
@@ -297,12 +297,12 @@  discard block
 block discarded – undo
297 297
 		$return_ary = $this->display_vars[$mode];
298 298
 
299 299
 		/**
300
-		* Event to send the display vars
301
-		* @event phpbbgallery.core.acp.config.get_display_vars
302
-		* @var	string	mode		Mode we are requesting for
303
-		* @var	array	return_ary	Array we are sending back
304
-		* @since 1.2.0
305
-		*/
300
+		 * Event to send the display vars
301
+		 * @event phpbbgallery.core.acp.config.get_display_vars
302
+		 * @var	string	mode		Mode we are requesting for
303
+		 * @var	array	return_ary	Array we are sending back
304
+		 * @since 1.2.0
305
+		 */
306 306
 		$vars = array('mode', 'return_ary');
307 307
 		extract($phpbb_dispatcher->trigger_event('phpbbgallery.core.acp.config.get_display_vars', compact($vars)));
308 308
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -226,8 +226,7 @@  discard block
 block discarded – undo
226 226
 				if (is_array($langs_var))
227 227
 				{
228 228
 					$vars['append'] = ' ' . substr($this->language->lang($vars['append'], 0), 1);
229
-				}
230
-				else
229
+				} else
231 230
 				{
232 231
 					$vars['append'] = ' ' . $this->language->lang($vars['append']);
233 232
 				}
@@ -577,8 +576,7 @@  discard block
 block discarded – undo
577 576
 		if ($key != 'link_imagepage')
578 577
 		{
579 578
 			$sort_order_options .= '<option' . (($value == 'image_page') ? ' selected="selected"' : '') . " value='image_page'>" . $this->language->lang('UC_LINK_IMAGE_PAGE') . '</option>';
580
-		}
581
-		else
579
+		} else
582 580
 		{
583 581
 			$sort_order_options .= '<option' . (($value == 'next') ? ' selected="selected"' : '') . " value='next'>" . $this->language->lang('UC_LINK_NEXT') . '</option>';
584 582
 		}
@@ -658,12 +656,10 @@  discard block
 block discarded – undo
658 656
 		if ($value == 'image_page')
659 657
 		{
660 658
 			$bbcode_tpl = '<a href="' . $gallery_url . 'image/{NUMBER}"><img src="' . $gallery_url . 'image/{NUMBER}/mini" alt="{NUMBER}" /></a>';
661
-		}
662
-		else if ($value == 'image')
659
+		} else if ($value == 'image')
663 660
 		{
664 661
 			$bbcode_tpl = '<a href="' . $gallery_url . 'image/{NUMBER}/source"><img src="' . $gallery_url . 'image/{NUMBER}/mini" alt="{NUMBER}" /></a>';
665
-		}
666
-		else
662
+		} else
667 663
 		{
668 664
 			$bbcode_tpl = '<img src="' . $gallery_url . 'image/{NUMBER}/mini" alt="{NUMBER}" />';
669 665
 		}
Please login to merge, or discard this patch.
Spacing   +65 added lines, -65 removed lines patch added patch discarded remove patch
@@ -331,90 +331,90 @@  discard block
 block discarded – undo
331 331
 			'vars'	=> array(
332 332
 				'' => array(),
333 333
 				'GALLERY_CONFIG'	=> array(
334
-					'items_per_page'		=> array('lang' => 'ITEMS_PER_PAGE',		'validate' => 'int',	'type' => 'text:7:3',		'explain' => true),
335
-					'allow_comments'		=> array('lang' => 'COMMENT_SYSTEM',		'validate' => 'bool',	'type' => 'radio:yes_no'),
336
-					'comment_user_control'	=> array('lang' => 'COMMENT_USER_CONTROL',	'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
337
-					'comment_length'		=> array('lang' => 'COMMENT_MAX_LENGTH',	'validate' => 'int',	'type' => 'text:7:5',		'append' => 'CHARACTERS'),
338
-					'allow_rates'			=> array('lang' => 'RATE_SYSTEM',			'validate' => 'bool',	'type' => 'radio:yes_no'),
339
-					'max_rating'			=> array('lang' => 'RATE_SCALE',			'validate' => 'int',	'type' => 'text:7:2'),
340
-					'allow_hotlinking'		=> array('lang' => 'HOTLINK_PREVENT',		'validate' => 'bool',	'type' => 'radio:yes_no'),
341
-					'hotlinking_domains'	=> array('lang' => 'HOTLINK_ALLOWED',		'validate' => 'string',	'type' => 'text:40:255',	'explain' => true),
334
+					'items_per_page'		=> array('lang' => 'ITEMS_PER_PAGE', 'validate' => 'int', 'type' => 'text:7:3', 'explain' => true),
335
+					'allow_comments'		=> array('lang' => 'COMMENT_SYSTEM', 'validate' => 'bool', 'type' => 'radio:yes_no'),
336
+					'comment_user_control'	=> array('lang' => 'COMMENT_USER_CONTROL', 'validate' => 'bool', 'type' => 'radio:yes_no', 'explain' => true),
337
+					'comment_length'		=> array('lang' => 'COMMENT_MAX_LENGTH', 'validate' => 'int', 'type' => 'text:7:5', 'append' => 'CHARACTERS'),
338
+					'allow_rates'			=> array('lang' => 'RATE_SYSTEM', 'validate' => 'bool', 'type' => 'radio:yes_no'),
339
+					'max_rating'			=> array('lang' => 'RATE_SCALE', 'validate' => 'int', 'type' => 'text:7:2'),
340
+					'allow_hotlinking'		=> array('lang' => 'HOTLINK_PREVENT', 'validate' => 'bool', 'type' => 'radio:yes_no'),
341
+					'hotlinking_domains'	=> array('lang' => 'HOTLINK_ALLOWED', 'validate' => 'string', 'type' => 'text:40:255', 'explain' => true),
342 342
 				),
343 343
 
344 344
 				'ALBUM_SETTINGS'	=> array(
345
-					'album_display'			=> array('lang' => 'RRC_DISPLAY_OPTIONS',	'validate' => 'int',	'type' => 'custom',			'method' => 'rrc_display'),
346
-					'default_sort_key'		=> array('lang' => 'DEFAULT_SORT_METHOD',	'validate' => 'string',	'type' => 'custom',			'method' => 'sort_method_select'),
347
-					'default_sort_dir'		=> array('lang' => 'DEFAULT_SORT_ORDER',	'validate' => 'string',	'type' => 'custom',			'method' => 'sort_order_select'),
348
-					'album_images'			=> array('lang' => 'MAX_IMAGES_PER_ALBUM',	'validate' => 'int',	'type' => 'text:7:7',		'explain' => true),
349
-					'mini_thumbnail_disp'	=> array('lang' => 'DISP_FAKE_THUMB',		'validate' => 'bool',	'type' => 'radio:yes_no'),
350
-					'mini_thumbnail_size'	=> array('lang' => 'FAKE_THUMB_SIZE',		'validate' => 'int',	'type' => 'text:7:4',		'explain' => true,	'append' => 'PIXELS'),
345
+					'album_display'			=> array('lang' => 'RRC_DISPLAY_OPTIONS', 'validate' => 'int', 'type' => 'custom', 'method' => 'rrc_display'),
346
+					'default_sort_key'		=> array('lang' => 'DEFAULT_SORT_METHOD', 'validate' => 'string', 'type' => 'custom', 'method' => 'sort_method_select'),
347
+					'default_sort_dir'		=> array('lang' => 'DEFAULT_SORT_ORDER', 'validate' => 'string', 'type' => 'custom', 'method' => 'sort_order_select'),
348
+					'album_images'			=> array('lang' => 'MAX_IMAGES_PER_ALBUM', 'validate' => 'int', 'type' => 'text:7:7', 'explain' => true),
349
+					'mini_thumbnail_disp'	=> array('lang' => 'DISP_FAKE_THUMB', 'validate' => 'bool', 'type' => 'radio:yes_no'),
350
+					'mini_thumbnail_size'	=> array('lang' => 'FAKE_THUMB_SIZE', 'validate' => 'int', 'type' => 'text:7:4', 'explain' => true, 'append' => 'PIXELS'),
351 351
 				),
352 352
 
353 353
 				'SEARCH_SETTINGS'	=> array(
354
-					'search_display'		=> array('lang' => 'RRC_DISPLAY_OPTIONS',	'validate' => 'int',	'type' => 'custom',			'method' => 'rrc_display'),
354
+					'search_display'		=> array('lang' => 'RRC_DISPLAY_OPTIONS', 'validate' => 'int', 'type' => 'custom', 'method' => 'rrc_display'),
355 355
 				),
356 356
 
357 357
 				'IMAGE_SETTINGS'	=> array(
358
-					'num_uploads'			=> array('lang' => 'UPLOAD_IMAGES',			'validate' => 'int',	'type' => 'text:7:2'),
359
-					'max_filesize'			=> array('lang' => 'MAX_FILE_SIZE',			'validate' => 'int',	'type' => 'text:12:9',		'append' => 'BYTES'),
360
-					'max_width'				=> array('lang' => 'MAX_WIDTH',				'validate' => 'int',	'type' => 'text:7:5',		'append' => 'PIXELS'),
361
-					'max_height'			=> array('lang' => 'MAX_HEIGHT',			'validate' => 'int',	'type' => 'text:7:5',		'append' => 'PIXELS'),
362
-					'allow_resize'			=> array('lang' => 'RESIZE_IMAGES',			'validate' => 'bool',	'type' => 'radio:yes_no'),
363
-					'allow_rotate'			=> array('lang' => 'ROTATE_IMAGES',			'validate' => 'bool',	'type' => 'radio:yes_no'),
364
-					'jpg_quality'			=> array('lang' => 'JPG_QUALITY',			'validate' => 'int',	'type' => 'text:7:5',		'explain' => true),
358
+					'num_uploads'			=> array('lang' => 'UPLOAD_IMAGES', 'validate' => 'int', 'type' => 'text:7:2'),
359
+					'max_filesize'			=> array('lang' => 'MAX_FILE_SIZE', 'validate' => 'int', 'type' => 'text:12:9', 'append' => 'BYTES'),
360
+					'max_width'				=> array('lang' => 'MAX_WIDTH', 'validate' => 'int', 'type' => 'text:7:5', 'append' => 'PIXELS'),
361
+					'max_height'			=> array('lang' => 'MAX_HEIGHT', 'validate' => 'int', 'type' => 'text:7:5', 'append' => 'PIXELS'),
362
+					'allow_resize'			=> array('lang' => 'RESIZE_IMAGES', 'validate' => 'bool', 'type' => 'radio:yes_no'),
363
+					'allow_rotate'			=> array('lang' => 'ROTATE_IMAGES', 'validate' => 'bool', 'type' => 'radio:yes_no'),
364
+					'jpg_quality'			=> array('lang' => 'JPG_QUALITY', 'validate' => 'int', 'type' => 'text:7:5', 'explain' => true),
365 365
 					//'medium_cache'			=> array('lang' => 'MEDIUM_CACHE',			'validate' => 'bool',	'type' => 'radio:yes_no'),
366
-					'medium_width'			=> array('lang' => 'RSZ_WIDTH',				'validate' => 'int',	'type' => 'text:7:4',		'append' => 'PIXELS'),
367
-					'medium_height'			=> array('lang' => 'RSZ_HEIGHT',			'validate' => 'int',	'type' => 'text:7:4',		'append' => 'PIXELS'),
368
-					'allow_gif'				=> array('lang' => 'GIF_ALLOWED',			'validate' => 'bool',	'type' => 'radio:yes_no'),
369
-					'allow_jpg'				=> array('lang' => 'JPG_ALLOWED',			'validate' => 'bool',	'type' => 'radio:yes_no'),
370
-					'allow_png'				=> array('lang' => 'PNG_ALLOWED',			'validate' => 'bool',	'type' => 'radio:yes_no'),
371
-					'allow_webp'				=> array('lang' => 'WEBP_ALLOWED',			'validate' => 'bool',	'type' => 'radio:yes_no'),
372
-					'allow_zip'				=> array('lang' => 'ZIP_ALLOWED',			'validate' => 'bool',	'type' => 'radio:yes_no'),
373
-					'description_length'	=> array('lang' => 'IMAGE_DESC_MAX_LENGTH',	'validate' => 'int',	'type' => 'text:7:5',		'append' => 'CHARACTERS'),
374
-					'disp_nextprev_thumbnail'	=> array('lang' => 'DISP_NEXTPREV_THUMB','validate' => 'bool',	'type' => 'radio:yes_no'),
375
-					'disp_image_url'		=> array('lang' => 'VIEW_IMAGE_URL',		'validate' => 'bool',	'type' => 'radio:yes_no'),
366
+					'medium_width'			=> array('lang' => 'RSZ_WIDTH', 'validate' => 'int', 'type' => 'text:7:4', 'append' => 'PIXELS'),
367
+					'medium_height'			=> array('lang' => 'RSZ_HEIGHT', 'validate' => 'int', 'type' => 'text:7:4', 'append' => 'PIXELS'),
368
+					'allow_gif'				=> array('lang' => 'GIF_ALLOWED', 'validate' => 'bool', 'type' => 'radio:yes_no'),
369
+					'allow_jpg'				=> array('lang' => 'JPG_ALLOWED', 'validate' => 'bool', 'type' => 'radio:yes_no'),
370
+					'allow_png'				=> array('lang' => 'PNG_ALLOWED', 'validate' => 'bool', 'type' => 'radio:yes_no'),
371
+					'allow_webp'				=> array('lang' => 'WEBP_ALLOWED', 'validate' => 'bool', 'type' => 'radio:yes_no'),
372
+					'allow_zip'				=> array('lang' => 'ZIP_ALLOWED', 'validate' => 'bool', 'type' => 'radio:yes_no'),
373
+					'description_length'	=> array('lang' => 'IMAGE_DESC_MAX_LENGTH', 'validate' => 'int', 'type' => 'text:7:5', 'append' => 'CHARACTERS'),
374
+					'disp_nextprev_thumbnail'	=> array('lang' => 'DISP_NEXTPREV_THUMB', 'validate' => 'bool', 'type' => 'radio:yes_no'),
375
+					'disp_image_url'		=> array('lang' => 'VIEW_IMAGE_URL', 'validate' => 'bool', 'type' => 'radio:yes_no'),
376 376
 				),
377 377
 
378 378
 				'THUMBNAIL_SETTINGS'	=> array(
379 379
 					//'thumbnail_cache'		=> array('lang' => 'THUMBNAIL_CACHE',		'validate' => 'bool',	'type' => 'radio:yes_no'),
380
-					'gdlib_version'			=> array('lang' => 'GD_VERSION',			'validate' => 'int',	'type' => 'custom',			'method' => 'gd_radio'),
381
-					'thumbnail_width'		=> array('lang' => 'THUMBNAIL_WIDTH',		'validate' => 'int',	'type' => 'text:7:3',		'append' => 'PIXELS'),
382
-					'thumbnail_height'		=> array('lang' => 'THUMBNAIL_HEIGHT',		'validate' => 'int',	'type' => 'text:7:3',		'append' => 'PIXELS'),
383
-					'thumbnail_quality'		=> array('lang' => 'THUMBNAIL_QUALITY',		'validate' => 'int',	'type' => 'text:7:3',		'explain' => true,	'append' => 'PERCENT'),
380
+					'gdlib_version'			=> array('lang' => 'GD_VERSION', 'validate' => 'int', 'type' => 'custom', 'method' => 'gd_radio'),
381
+					'thumbnail_width'		=> array('lang' => 'THUMBNAIL_WIDTH', 'validate' => 'int', 'type' => 'text:7:3', 'append' => 'PIXELS'),
382
+					'thumbnail_height'		=> array('lang' => 'THUMBNAIL_HEIGHT', 'validate' => 'int', 'type' => 'text:7:3', 'append' => 'PIXELS'),
383
+					'thumbnail_quality'		=> array('lang' => 'THUMBNAIL_QUALITY', 'validate' => 'int', 'type' => 'text:7:3', 'explain' => true, 'append' => 'PERCENT'),
384 384
 					//'thumbnail_infoline'	=> array('lang' => 'INFO_LINE',				'validate' => 'bool',	'type' => 'radio:yes_no'),
385 385
 				),
386 386
 
387 387
 				'WATERMARK_OPTIONS'	=> array(
388
-					'watermark_enabled'		=> array('lang' => 'WATERMARK_IMAGES',		'validate' => 'bool',	'type' => 'radio:yes_no'),
389
-					'watermark_source'		=> array('lang' => 'WATERMARK_SOURCE',		'validate' => 'string',	'type' => 'custom',			'explain' => true,	'method' => 'watermark_source'),
390
-					'watermark_height'		=> array('lang' => 'WATERMARK_HEIGHT',		'validate' => 'int',	'type' => 'text:7:4',		'explain' => true,	'append' => 'PIXELS'),
391
-					'watermark_width'		=> array('lang' => 'WATERMARK_WIDTH',		'validate' => 'int',	'type' => 'text:7:4',		'explain' => true,	'append' => 'PIXELS'),
392
-					'watermark_position'	=> array('lang' => 'WATERMARK_POSITION',	'validate' => '',		'type' => 'custom',			'method' => 'watermark_position'),
388
+					'watermark_enabled'		=> array('lang' => 'WATERMARK_IMAGES', 'validate' => 'bool', 'type' => 'radio:yes_no'),
389
+					'watermark_source'		=> array('lang' => 'WATERMARK_SOURCE', 'validate' => 'string', 'type' => 'custom', 'explain' => true, 'method' => 'watermark_source'),
390
+					'watermark_height'		=> array('lang' => 'WATERMARK_HEIGHT', 'validate' => 'int', 'type' => 'text:7:4', 'explain' => true, 'append' => 'PIXELS'),
391
+					'watermark_width'		=> array('lang' => 'WATERMARK_WIDTH', 'validate' => 'int', 'type' => 'text:7:4', 'explain' => true, 'append' => 'PIXELS'),
392
+					'watermark_position'	=> array('lang' => 'WATERMARK_POSITION', 'validate' => '', 'type' => 'custom', 'method' => 'watermark_position'),
393 393
 				),
394 394
 
395 395
 				'UC_LINK_CONFIG'	=> array(
396
-					'link_thumbnail'		=> array('lang' => 'UC_THUMBNAIL',			'validate' => 'string',	'type' => 'custom',			'explain' => true,	'method' => 'uc_select'),
397
-					'link_imagepage'		=> array('lang' => 'UC_IMAGEPAGE',			'validate' => 'string',	'type' => 'custom',			'explain' => true,	'method' => 'uc_select'),
398
-					'link_image_name'		=> array('lang' => 'UC_IMAGE_NAME',			'validate' => 'string',	'type' => 'custom',			'method' => 'uc_select'),
399
-					'link_image_icon'		=> array('lang' => 'UC_IMAGE_ICON',			'validate' => 'string',	'type' => 'custom',			'method' => 'uc_select'),
396
+					'link_thumbnail'		=> array('lang' => 'UC_THUMBNAIL', 'validate' => 'string', 'type' => 'custom', 'explain' => true, 'method' => 'uc_select'),
397
+					'link_imagepage'		=> array('lang' => 'UC_IMAGEPAGE', 'validate' => 'string', 'type' => 'custom', 'explain' => true, 'method' => 'uc_select'),
398
+					'link_image_name'		=> array('lang' => 'UC_IMAGE_NAME', 'validate' => 'string', 'type' => 'custom', 'method' => 'uc_select'),
399
+					'link_image_icon'		=> array('lang' => 'UC_IMAGE_ICON', 'validate' => 'string', 'type' => 'custom', 'method' => 'uc_select'),
400 400
 				),
401 401
 
402 402
 				'RRC_GINDEX'	=> array(
403
-					'rrc_gindex_mode'		=> array('lang' => 'RRC_GINDEX_MODE',		'validate' => 'int',	'type' => 'custom',			'explain' => true,	'method' => 'rrc_modes'),
404
-					'rrc_gindex_comments'	=> array('lang' => 'RRC_GINDEX_COMMENTS',	'validate' => 'bool',	'type' => 'radio:yes_no'),
403
+					'rrc_gindex_mode'		=> array('lang' => 'RRC_GINDEX_MODE', 'validate' => 'int', 'type' => 'custom', 'explain' => true, 'method' => 'rrc_modes'),
404
+					'rrc_gindex_comments'	=> array('lang' => 'RRC_GINDEX_COMMENTS', 'validate' => 'bool', 'type' => 'radio:yes_no'),
405 405
 					//'rrc_gindex_contests'	=> array('lang' => 'RRC_GINDEX_CONTESTS',	'validate' => 'int',	'type' => 'text:7:3'),
406
-					'rrc_gindex_display'	=> array('lang' => 'RRC_DISPLAY_OPTIONS',	'validate' => '',		'type' => 'custom',			'method' => 'rrc_display'),
407
-					'rrc_gindex_pegas'		=> array('lang' => 'RRC_GINDEX_PGALLERIES',	'validate' => 'bool',	'type' => 'radio:yes_no'),
406
+					'rrc_gindex_display'	=> array('lang' => 'RRC_DISPLAY_OPTIONS', 'validate' => '', 'type' => 'custom', 'method' => 'rrc_display'),
407
+					'rrc_gindex_pegas'		=> array('lang' => 'RRC_GINDEX_PGALLERIES', 'validate' => 'bool', 'type' => 'radio:yes_no'),
408 408
 				),
409 409
 
410 410
 				'PHPBB_INTEGRATION'	=> array(
411
-					'disp_gallery_icon'			=> array('lang' => 'DISP_GALLERY_ICON',				'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
412
-					'disp_total_images'			=> array('lang' => 'DISP_TOTAL_IMAGES',				'validate' => 'bool',	'type' => 'radio:yes_no'),
413
-					'profile_user_images'		=> array('lang' => 'DISP_USER_IMAGES_PROFILE',		'validate' => 'bool',	'type' => 'radio:yes_no'),
414
-					'profile_pega'				=> array('lang' => 'DISP_PERSONAL_ALBUM_PROFILE',	'validate' => 'bool',	'type' => 'radio:yes_no'),
415
-					'rrc_profile_mode'			=> array('lang' => 'RRC_PROFILE_MODE',				'validate' => 'int',	'type' => 'custom',			'explain' => true,	'method' => 'rrc_modes'),
416
-					'rrc_profile_items'			=> array('lang' => 'RRC_PROFILE_ITEMS',				'validate' => 'int',	'type' => 'text:7:3'),
417
-					'rrc_profile_display'		=> array('lang' => 'RRC_DISPLAY_OPTIONS',			'validate' => 'int',	'type' => 'custom',			'method' => 'rrc_display'),
411
+					'disp_gallery_icon'			=> array('lang' => 'DISP_GALLERY_ICON', 'validate' => 'bool', 'type' => 'radio:yes_no', 'explain' => true),
412
+					'disp_total_images'			=> array('lang' => 'DISP_TOTAL_IMAGES', 'validate' => 'bool', 'type' => 'radio:yes_no'),
413
+					'profile_user_images'		=> array('lang' => 'DISP_USER_IMAGES_PROFILE', 'validate' => 'bool', 'type' => 'radio:yes_no'),
414
+					'profile_pega'				=> array('lang' => 'DISP_PERSONAL_ALBUM_PROFILE', 'validate' => 'bool', 'type' => 'radio:yes_no'),
415
+					'rrc_profile_mode'			=> array('lang' => 'RRC_PROFILE_MODE', 'validate' => 'int', 'type' => 'custom', 'explain' => true, 'method' => 'rrc_modes'),
416
+					'rrc_profile_items'			=> array('lang' => 'RRC_PROFILE_ITEMS', 'validate' => 'int', 'type' => 'text:7:3'),
417
+					'rrc_profile_display'		=> array('lang' => 'RRC_DISPLAY_OPTIONS', 'validate' => 'int', 'type' => 'custom', 'method' => 'rrc_display'),
418 418
 					//'rrc_profile_pegas'			=> array('lang' => 'RRC_GINDEX_PGALLERIES',			'validate' => 'bool',	'type' => 'radio:yes_no'),
419 419
 					//'viewtopic_icon'			=> array('lang' => 'DISP_VIEWTOPIC_ICON',			'validate' => 'bool',	'type' => 'radio:yes_no'),
420 420
 					//'viewtopic_images'			=> array('lang' => 'DISP_VIEWTOPIC_IMAGES',			'validate' => 'bool',	'type' => 'radio:yes_no'),
@@ -422,15 +422,15 @@  discard block
 block discarded – undo
422 422
 				),
423 423
 
424 424
 				'INDEX_SETTINGS'	=> array(
425
-					'pegas_index_album'		=> array('lang' => 'PERSONAL_ALBUM_INDEX',	'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
425
+					'pegas_index_album'		=> array('lang' => 'PERSONAL_ALBUM_INDEX', 'validate' => 'bool', 'type' => 'radio:yes_no', 'explain' => true),
426 426
 					//'pegas_index_random'	=> array('lang'	=> 'RANDOM_ON_INDEX',		'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
427
-					'pegas_index_rnd_count'	=> array('lang'	=> 'RANDOM_ON_INDEX_COUNT',	'validate' => 'int',	'type' => 'text:7:3'),
427
+					'pegas_index_rnd_count'	=> array('lang'	=> 'RANDOM_ON_INDEX_COUNT', 'validate' => 'int', 'type' => 'text:7:3'),
428 428
 					//'pegas_index_recent'	=> array('lang'	=> 'RECENT_ON_INDEX',		'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
429
-					'pegas_index_rct_count'	=> array('lang'	=> 'RECENT_ON_INDEX_COUNT',	'validate' => 'int',	'type' => 'text:7:3'),
430
-					'disp_login'			=> array('lang' => 'DISP_LOGIN',			'validate' => 'bool',	'type' => 'radio:yes_no',	'explain' => true),
431
-					'disp_whoisonline'		=> array('lang' => 'DISP_WHOISONLINE',		'validate' => 'bool',	'type' => 'radio:yes_no'),
432
-					'disp_birthdays'		=> array('lang' => 'DISP_BIRTHDAYS',		'validate' => 'bool',	'type' => 'radio:yes_no'),
433
-					'disp_statistic'		=> array('lang' => 'DISP_STATISTIC',		'validate' => 'bool',	'type' => 'radio:yes_no'),
429
+					'pegas_index_rct_count'	=> array('lang'	=> 'RECENT_ON_INDEX_COUNT', 'validate' => 'int', 'type' => 'text:7:3'),
430
+					'disp_login'			=> array('lang' => 'DISP_LOGIN', 'validate' => 'bool', 'type' => 'radio:yes_no', 'explain' => true),
431
+					'disp_whoisonline'		=> array('lang' => 'DISP_WHOISONLINE', 'validate' => 'bool', 'type' => 'radio:yes_no'),
432
+					'disp_birthdays'		=> array('lang' => 'DISP_BIRTHDAYS', 'validate' => 'bool', 'type' => 'radio:yes_no'),
433
+					'disp_statistic'		=> array('lang' => 'DISP_STATISTIC', 'validate' => 'bool', 'type' => 'radio:yes_no'),
434 434
 				),
435 435
 			),
436 436
 		),
@@ -573,7 +573,7 @@  discard block
 block discarded – undo
573 573
 		global $phpbb_container;
574 574
 		$this->language = $phpbb_container->get('language');
575 575
 
576
-		$sort_order_options = '';//phpbb_gallery_plugins::uc_select($value, $key);
576
+		$sort_order_options = ''; //phpbb_gallery_plugins::uc_select($value, $key);
577 577
 
578 578
 		if ($key != 'link_imagepage')
579 579
 		{
@@ -587,7 +587,7 @@  discard block
 block discarded – undo
587 587
 		$sort_order_options .= '<option' . (($value == 'none') ? ' selected="selected"' : '') . " value='none'>" . $this->language->lang('UC_LINK_NONE') . '</option>';
588 588
 
589 589
 		return "<select name='config[$key]' id='$key'>$sort_order_options</select>"
590
-			. (($key == 'link_thumbnail') ? '<br /><input class="checkbox" type="checkbox" name="update_bbcode" id="update_bbcode" value="update_bbcode" /><label for="update_bbcode">' .  $this->language->lang('UPDATE_BBCODE') . '</label>' : '');
590
+			. (($key == 'link_thumbnail') ? '<br /><input class="checkbox" type="checkbox" name="update_bbcode" id="update_bbcode" value="update_bbcode" /><label for="update_bbcode">' . $this->language->lang('UPDATE_BBCODE') . '</label>' : '');
591 591
 	}
592 592
 
593 593
 	/**
Please login to merge, or discard this patch.
core/acp/main_module.php 1 patch
Braces   +10 added lines, -20 removed lines patch added patch discarded remove patch
@@ -95,8 +95,7 @@  discard block
 block discarded – undo
95 95
 				'U_SOURCE_DIR_STATE'	=>  $this->language->lang('NO_WRITE_ACCESS'),
96 96
 				'U_SOURCE_DIR_STATE_ERROR'	=> 1,
97 97
 			));
98
-		}
99
-		else
98
+		} else
100 99
 		{
101 100
 			$template->assign_vars(array(
102 101
 				'U_FILE_DIR_STATE'	=>  $this->language->lang('WRITE_ACCESS'),
@@ -109,15 +108,13 @@  discard block
 block discarded – undo
109 108
 					'U_CORE_DIR_STATE'	=>  $this->language->lang('DIR_CREATED'),
110 109
 					'U_CORE_DIR_STATE_ERROR'	=> 0,
111 110
 				));
112
-			}
113
-			else if (is_writable($phpbbgallery_core_file))
111
+			} else if (is_writable($phpbbgallery_core_file))
114 112
 			{
115 113
 				$template->assign_vars(array(
116 114
 					'U_CORE_DIR_STATE'	=>  $this->language->lang('WRITE_ACCESS'),
117 115
 					'U_CORE_DIR_STATE_ERROR'	=> 0,
118 116
 				));
119
-			}
120
-			else
117
+			} else
121 118
 			{
122 119
 				$template->assign_vars(array(
123 120
 					'U_CORE_DIR_STATE'	=>  $this->language->lang('NO_WRITE_ACCESS'),
@@ -131,15 +128,13 @@  discard block
 block discarded – undo
131 128
 					'U_MEDIUM_DIR_STATE'	=>  $this->language->lang('DIR_CREATED'),
132 129
 					'U_MEDIUM_DIR_STATE_ERROR'	=> 0,
133 130
 				));
134
-			}
135
-			else if (is_writable($phpbbgallery_core_file_medium))
131
+			} else if (is_writable($phpbbgallery_core_file_medium))
136 132
 			{
137 133
 				$template->assign_vars(array(
138 134
 					'U_MEDIUM_DIR_STATE'	=>  $this->language->lang('WRITE_ACCESS'),
139 135
 					'U_MEDIUM_DIR_STATE_ERROR'	=> 0,
140 136
 				));
141
-			}
142
-			else
137
+			} else
143 138
 			{
144 139
 				$template->assign_vars(array(
145 140
 					'U_MEDIUM_DIR_STATE'	=>  $this->language->lang('NO_WRITE_ACCESS'),
@@ -153,15 +148,13 @@  discard block
 block discarded – undo
153 148
 					'U_MINI_DIR_STATE'	=>  $this->language->lang('DIR_CREATED'),
154 149
 					'U_MINI_DIR_STATE_ERROR'	=> 0,
155 150
 				));
156
-			}
157
-			else if (is_writable($phpbbgallery_core_file_mini))
151
+			} else if (is_writable($phpbbgallery_core_file_mini))
158 152
 			{
159 153
 				$template->assign_vars(array(
160 154
 					'U_MINI_DIR_STATE'	=>  $this->language->lang('WRITE_ACCESS'),
161 155
 					'U_MINI_DIR_STATE_ERROR'	=> 0,
162 156
 				));
163
-			}
164
-			else
157
+			} else
165 158
 			{
166 159
 				$template->assign_vars(array(
167 160
 					'U_MINI_DIR_STATE'	=>  $this->language->lang('NO_WRITE_ACCESS'),
@@ -175,15 +168,13 @@  discard block
 block discarded – undo
175 168
 					'U_SOURCE_DIR_STATE'	=>  $this->language->lang('DIR_CREATED'),
176 169
 					'U_SOURCE_DIR_STATE_ERROR'	=> 0,
177 170
 				));
178
-			}
179
-			else if (is_writable($phpbbgallery_core_file_source))
171
+			} else if (is_writable($phpbbgallery_core_file_source))
180 172
 			{
181 173
 				$template->assign_vars(array(
182 174
 					'U_SOURCE_DIR_STATE'	=>  $this->language->lang('WRITE_ACCESS'),
183 175
 					'U_SOURCE_DIR_STATE_ERROR'	=> 0,
184 176
 				));
185
-			}
186
-			else
177
+			} else
187 178
 			{
188 179
 				$template->assign_vars(array(
189 180
 					'U_SOURCE_DIR_STATE'	=>  $this->language->lang('NO_WRITE_ACCESS'),
@@ -282,8 +273,7 @@  discard block
 block discarded – undo
282 273
 					'reset_album_id'	=> $album_id,
283 274
 				)));
284 275
 			}
285
-		}
286
-		else
276
+		} else
287 277
 		{
288 278
 			switch ($action)
289 279
 			{
Please login to merge, or discard this patch.
core/acp/permissions_module.php 3 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 			'misc'	=> array('a_list', 'i_count', 'i_unlimited', 'a_count', 'a_unlimited', 'a_restrict'),
71 71
 		);
72 72
 		$permissions->p_masks[$gallery_auth::OWN_ALBUM] = array_merge($permissions->cats[$gallery_auth::OWN_ALBUM]['i'], $permissions->cats[$gallery_auth::OWN_ALBUM]['c'], $permissions->cats[$gallery_auth::OWN_ALBUM]['m'], $permissions->cats[$gallery_auth::OWN_ALBUM]['misc']);
73
-		$permissions->p_masks_anti[$gallery_auth::OWN_ALBUM] = array();// Note: we set i_view to 1 as default, so it's not needed on anti array('i_view');
73
+		$permissions->p_masks_anti[$gallery_auth::OWN_ALBUM] = array(); // Note: we set i_view to 1 as default, so it's not needed on anti array('i_view');
74 74
 
75 75
 		// Permissions for personal albums of other users
76 76
 		// Note: Do !NOT! hide the i_upload. It's used for the moving-permissions
@@ -1244,7 +1244,7 @@  discard block
 block discarded – undo
1244 1244
 	{
1245 1245
 		global $user, $phpbb_container;
1246 1246
 
1247
-		$phpbb_ext_gallery_core_auth =  $phpbb_container->get('phpbbgallery.core.auth');
1247
+		$phpbb_ext_gallery_core_auth = $phpbb_container->get('phpbbgallery.core.auth');
1248 1248
 
1249 1249
 		$disabled = false;
1250 1250
 		// We submit a "wrong" array on the check (to make it more easy) so we convert it here
Please login to merge, or discard this patch.
Braces   +17 added lines, -34 removed lines patch added patch discarded remove patch
@@ -96,8 +96,7 @@  discard block
 block discarded – undo
96 96
 						if (!$submit)
97 97
 						{
98 98
 							$this->permissions_v_mask();
99
-						}
100
-						else
99
+						} else
101 100
 						{
102 101
 							$this->permissions_p_mask();
103 102
 						}
@@ -440,13 +439,11 @@  discard block
 block discarded – undo
440 439
 		if (!sizeof($group_id) && !sizeof($user_id))
441 440
 		{
442 441
 			trigger_error('NO_VICTIM_SELECTED', E_USER_WARNING);
443
-		}
444
-		else if (sizeof($group_id))
442
+		} else if (sizeof($group_id))
445 443
 		{
446 444
 			$victim_mode = 'group';
447 445
 			$victim_id = $group_id;
448
-		}
449
-		else
446
+		} else
450 447
 		{
451 448
 			$victim_mode = 'user';
452 449
 			$victim_id = $user_id;
@@ -478,8 +475,7 @@  discard block
 block discarded – undo
478 475
 				$victim_list[$row['group_id']] = $victim_row;
479 476
 			}
480 477
 			$db->sql_freeresult($result);
481
-		}
482
-		else
478
+		} else
483 479
 		{
484 480
 			// Get the user information
485 481
 			$sql = 'SELECT username, user_id, user_colour
@@ -562,12 +558,10 @@  discard block
 block discarded – undo
562 558
 								if (isset($roles[$role_id][$permission]) && ($roles[$role_id][$permission] == $phpbb_ext_gallery_core_auth::ACL_YES))
563 559
 								{
564 560
 									$acl_s_yes++;
565
-								}
566
-								else if (isset($roles[$role_id][$permission]) && ($roles[$role_id][$permission] == $phpbb_ext_gallery_core_auth::ACL_NEVER))
561
+								} else if (isset($roles[$role_id][$permission]) && ($roles[$role_id][$permission] == $phpbb_ext_gallery_core_auth::ACL_NEVER))
567 562
 								{
568 563
 									$acl_s_never++;
569
-								}
570
-								else if (isset($roles[$role_id][$permission]) && ($roles[$role_id][$permission] == $phpbb_ext_gallery_core_auth::ACL_NO))
564
+								} else if (isset($roles[$role_id][$permission]) && ($roles[$role_id][$permission] == $phpbb_ext_gallery_core_auth::ACL_NO))
571 565
 								{
572 566
 									$acl_s_no++;
573 567
 								}
@@ -596,8 +590,7 @@  discard block
 block discarded – undo
596 590
 					}
597 591
 				}
598 592
 			}
599
-		}
600
-		else
593
+		} else
601 594
 		{
602 595
 			$template->assign_block_vars('c_mask', array(
603 596
 				'C_MASK_ID'				=> $p_system,
@@ -673,13 +666,11 @@  discard block
 block discarded – undo
673 666
 		if (!sizeof($group_id) && !sizeof($user_id))
674 667
 		{
675 668
 			trigger_error('NO_VICTIM_SELECTED', E_USER_WARNING);
676
-		}
677
-		else if (sizeof($group_id))
669
+		} else if (sizeof($group_id))
678 670
 		{
679 671
 			$victim_mode = 'group';
680 672
 			$victim_id = $group_id;
681
-		}
682
-		else
673
+		} else
683 674
 		{
684 675
 			$victim_mode = 'user';
685 676
 			$victim_id = $user_id;
@@ -728,8 +719,7 @@  discard block
 block discarded – undo
728 719
 						if (substr($p_mask, -6, 6) == '_count')
729 720
 						{
730 721
 							$auth_settings[$c_mask][$v_mask][$p_mask] = $value;
731
-						}
732
-						else
722
+						} else
733 723
 						{
734 724
 							$auth_settings[$c_mask][$v_mask][$p_mask] = ($value == ACL_YES) ? $phpbb_ext_gallery_core_auth::ACL_YES : (($value == ACL_NEVER) ? $phpbb_ext_gallery_core_auth::ACL_NEVER : $phpbb_ext_gallery_core_auth::ACL_NO);
735 725
 							// Do we have moderators?
@@ -779,15 +769,13 @@  discard block
 block discarded – undo
779 769
 								}
780 770
 								// We take all permissions of another c_mask, so:
781 771
 								break;
782
-							}
783
-							else
772
+							} else
784 773
 							{
785 774
 								// The choosen option was disabled: Hacking attempt?!
786 775
 								trigger_error('HACKING_ATTEMPT', E_USER_WARNING);
787 776
 							}
788 777
 						}
789
-					}
790
-					else if ($i_mask)
778
+					} else if ($i_mask)
791 779
 					{
792 780
 						// Inherit permissions of one [c_mask][v_mask]
793 781
 						$v_mask = (int) $v_mask;
@@ -808,8 +796,7 @@  discard block
 block discarded – undo
808 796
 								}
809 797
 								$auth_settings[$c_mask][$v_mask] = $auth_settings[$ci_mask][$vi_mask];
810 798
 								$p_mask_storage[$auth_settings[$c_mask][$v_mask]]['usage'][] = array('c_mask' => $c_mask, 'v_mask' => $v_mask);
811
-							}
812
-							else
799
+							} else
813 800
 							{
814 801
 								// The choosen option was disabled: Hacking attempt?!
815 802
 								trigger_error('HACKING_ATTEMPT', E_USER_WARNING);
@@ -882,8 +869,7 @@  discard block
 block discarded – undo
882 869
 						$victim_names[$row['group_id']] = $row['group_name'];
883 870
 					}
884 871
 					$db->sql_freeresult($result);
885
-				}
886
-				else
872
+				} else
887 873
 				{
888 874
 					// Get username's for the GALLERY_MODSCACHE_TABLE
889 875
 					$sql = 'SELECT user_id, username
@@ -949,8 +935,7 @@  discard block
 block discarded – undo
949 935
 									'group_id'		=> $usage['v_mask'],
950 936
 									'group_name'	=> $victim_names[$usage['v_mask']],
951 937
 								);
952
-							}
953
-							else
938
+							} else
954 939
 							{
955 940
 								$sql_moderators[] = array(
956 941
 									'album_id'		=> $usage['c_mask'],
@@ -959,8 +944,7 @@  discard block
 block discarded – undo
959 944
 								);
960 945
 							}
961 946
 						}
962
-					}
963
-					else
947
+					} else
964 948
 					{
965 949
 						$sql_permissions[] = array(
966 950
 							'perm_role_id'					=> $role_id,
@@ -1084,8 +1068,7 @@  discard block
 block discarded – undo
1084 1068
 				$phpbb_ext_gallery_core_auth->set_user_permissions('all', '');
1085 1069
 
1086 1070
 				trigger_error($this->language->lang('COPY_PERMISSIONS_SUCCESSFUL') . adm_back_link($this->u_action));
1087
-			}
1088
-			else
1071
+			} else
1089 1072
 			{
1090 1073
 				$s_hidden_fields = array(
1091 1074
 					'submit'			=> $submit,
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -51,8 +51,8 @@  discard block
 block discarded – undo
51 51
 		$action = $request->variable('action', '');
52 52
 
53 53
 		/**
54
-		* All our beautiful permissions
55
-		*/
54
+		 * All our beautiful permissions
55
+		 */
56 56
 		if (!isset($permissions))
57 57
 		{
58 58
 			$permissions = new \stdClass();
@@ -703,12 +703,12 @@  discard block
 block discarded – undo
703 703
 			$coal = $gallery_cache->get('albums');
704 704
 
705 705
 			/**
706
-			* Grab the permissions
707
-			*
708
-			* includes/acp/acp_permissions.php says:
709
-			* // We obtain and check $_POST['setting'][$ug_id][$forum_id] directly and not using request_var() because request_var()
710
-			* // currently does not support the amount of dimensions required. ;)
711
-			*/
706
+			 * Grab the permissions
707
+			 *
708
+			 * includes/acp/acp_permissions.php says:
709
+			 * // We obtain and check $_POST['setting'][$ug_id][$forum_id] directly and not using request_var() because request_var()
710
+			 * // currently does not support the amount of dimensions required. ;)
711
+			 */
712 712
 			//		$auth_settings = request_var('setting', array(0 => array(0 => array('' => 0))));
713 713
 			$requests = $request->variable('setting', array(0 => array(0 => array('' => 0))));
714 714
 			$p_mask_count = 0;
@@ -762,8 +762,8 @@  discard block
 block discarded – undo
762 762
 				}
763 763
 			}
764 764
 			/**
765
-			* Inherit the permissions
766
-			*/
765
+			 * Inherit the permissions
766
+			 */
767 767
 			$inherit = $request->variable('setting', array(0 => array('' => 0)));
768 768
 			foreach ($inherit as $c_mask => $v_sets)
769 769
 			{
@@ -993,8 +993,8 @@  discard block
 block discarded – undo
993 993
 	}
994 994
 
995 995
 	/**
996
-	* Handles copying permissions from one album to others
997
-	*/
996
+	 * Handles copying permissions from one album to others
997
+	 */
998 998
 	private function copy_album_permissions()
999 999
 	{
1000 1000
 		global $cache, $db, $template, $user, $table_prefix, $phpbb_dispatcher, $table_name, $users_table, $phpbb_container;
Please login to merge, or discard this patch.
core/acp/gallery_logs_module.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -29,11 +29,11 @@  discard block
 block discarded – undo
29 29
 		add_form_key('acp_logs');
30 30
 		$page = $request->variable('page', 0);
31 31
 		$filter_log = $request->variable('lf', 'all');
32
-		$sort_days	= $request->variable('st', 0);
32
+		$sort_days = $request->variable('st', 0);
33 33
 		$sort_key	= $request->variable('sk', 't');
34 34
 		$sort_dir	= $request->variable('sd', 'd');
35 35
 		$deletemark = $request->variable('delmarked', false, false, \phpbb\request\request_interface::POST);
36
-		$marked		= $request->variable('mark', array(0));
36
+		$marked = $request->variable('mark', array(0));
37 37
 		$log = $phpbb_container->get('phpbbgallery.core.log');
38 38
 
39 39
 		// Delete entries if requested and able
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 				{
124 124
 					$additional['sort_dir'] = $sort_dir;
125 125
 				}
126
-				$log->build_list($filter_log, 25, ($page/25) + 1, -1, 0, $additional);
126
+				$log->build_list($filter_log, 25, ($page / 25) + 1, -1, 0, $additional);
127 127
 			break;
128 128
 
129 129
 			default:
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,8 +42,7 @@
 block discarded – undo
42 42
 			if (confirm_box(true))
43 43
 			{
44 44
 				$log->delete_logs($marked);
45
-			}
46
-			else
45
+			} else
47 46
 			{
48 47
 				confirm_box(false, $this->language->lang('CONFIRM_OPERATION'), build_hidden_fields(array(
49 48
 					'page'		=> $page,
Please login to merge, or discard this patch.
core/notification/events/phpbbgallery_new_report.php 1 patch
Indentation   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -11,20 +11,20 @@  discard block
 block discarded – undo
11 11
 class phpbbgallery_new_report extends \phpbb\notification\type\base
12 12
 {
13 13
 	/**
14
-	* Get notification type name
15
-	*
16
-	* @return string
17
-	*/
14
+	 * Get notification type name
15
+	 *
16
+	 * @return string
17
+	 */
18 18
 	public function get_type()
19 19
 	{
20 20
 		return 'phpbbgallery.core.notification.new_report';
21 21
 	}
22 22
 	/**
23
-	* Notification option data (for outputting to the user)
24
-	*
25
-	* @var bool|array False if the service should use it's default data
26
-	* 					Array of data (including keys 'id', 'lang', and 'group')
27
-	*/
23
+	 * Notification option data (for outputting to the user)
24
+	 *
25
+	 * @var bool|array False if the service should use it's default data
26
+	 * 					Array of data (including keys 'id', 'lang', and 'group')
27
+	 */
28 28
 	public static $notification_option = array(
29 29
 		'lang'	=> 'NOTIFICATION_TYPE_PHPBBGALLERY_NEW_REPORT',
30 30
 	);
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
 	}
47 47
 
48 48
 	/**
49
-	* Is this type available to the current user (defines whether or not it will be shown in the UCP Edit notification options)
50
-	*
51
-	* @return bool True/False whether or not this is available to the user
52
-	*/
49
+	 * Is this type available to the current user (defines whether or not it will be shown in the UCP Edit notification options)
50
+	 *
51
+	 * @return bool True/False whether or not this is available to the user
52
+	 */
53 53
 	public function is_available()
54 54
 	{
55 55
 		return true;
@@ -103,10 +103,10 @@  discard block
 block discarded – undo
103 103
 	}
104 104
 
105 105
 	/**
106
-	* Get the HTML formatted title of this notification
107
-	*
108
-	* @return string
109
-	*/
106
+	 * Get the HTML formatted title of this notification
107
+	 *
108
+	 * @return string
109
+	 */
110 110
 	public function get_title()
111 111
 	{
112 112
 		$users = array($this->get_data('reporter'));
@@ -116,19 +116,19 @@  discard block
 block discarded – undo
116 116
 	}
117 117
 
118 118
 	/**
119
-	* Get email template
120
-	*
121
-	* @return string|bool
122
-	*/
119
+	 * Get email template
120
+	 *
121
+	 * @return string|bool
122
+	 */
123 123
 	public function get_email_template()
124 124
 	{
125 125
 		return false;
126 126
 	}
127 127
 	/**
128
-	* Get email template variables
129
-	*
130
-	* @return array
131
-	*/
128
+	 * Get email template variables
129
+	 *
130
+	 * @return array
131
+	 */
132 132
 	public function get_email_template_variables()
133 133
 	{
134 134
 		return array();
@@ -155,14 +155,14 @@  discard block
 block discarded – undo
155 155
 	}
156 156
 
157 157
 	/**
158
-	* Function for preparing the data for insertion in an SQL query
159
-	* (The service handles insertion)
160
-	*
161
-	* @param array $data The data for the updated rules
162
-	* @param array $pre_create_data Data from pre_create_insert_array()
163
-	*
164
-	* @return array Array of data ready to be inserted into the database
165
-	*/
158
+	 * Function for preparing the data for insertion in an SQL query
159
+	 * (The service handles insertion)
160
+	 *
161
+	 * @param array $data The data for the updated rules
162
+	 * @param array $pre_create_data Data from pre_create_insert_array()
163
+	 *
164
+	 * @return array Array of data ready to be inserted into the database
165
+	 */
166 166
 	public function create_insert_array($data, $pre_create_data = array())
167 167
 	{
168 168
 		$this->set_data('item_id', $data['item_id']);
Please login to merge, or discard this patch.
core/notification/events/phpbbgallery_new_comment.php 1 patch
Indentation   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -11,20 +11,20 @@  discard block
 block discarded – undo
11 11
 class phpbbgallery_new_comment extends \phpbb\notification\type\base
12 12
 {
13 13
 	/**
14
-	* Get notification type name
15
-	*
16
-	* @return string
17
-	*/
14
+	 * Get notification type name
15
+	 *
16
+	 * @return string
17
+	 */
18 18
 	public function get_type()
19 19
 	{
20 20
 		return 'phpbbgallery.core.notification.new_comment';
21 21
 	}
22 22
 	/**
23
-	* Notification option data (for outputting to the user)
24
-	*
25
-	* @var bool|array False if the service should use it's default data
26
-	* 					Array of data (including keys 'id', 'lang', and 'group')
27
-	*/
23
+	 * Notification option data (for outputting to the user)
24
+	 *
25
+	 * @var bool|array False if the service should use it's default data
26
+	 * 					Array of data (including keys 'id', 'lang', and 'group')
27
+	 */
28 28
 	public static $notification_option = array(
29 29
 		'lang'	=> 'NOTIFICATION_TYPE_PHPBBGALLERY_NEW_COMMENT',
30 30
 	);
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
 	}
47 47
 
48 48
 	/**
49
-	* Is this type available to the current user (defines whether or not it will be shown in the UCP Edit notification options)
50
-	*
51
-	* @return bool True/False whether or not this is available to the user
52
-	*/
49
+	 * Is this type available to the current user (defines whether or not it will be shown in the UCP Edit notification options)
50
+	 *
51
+	 * @return bool True/False whether or not this is available to the user
52
+	 */
53 53
 	public function is_available()
54 54
 	{
55 55
 		return true;
@@ -156,24 +156,24 @@  discard block
 block discarded – undo
156 156
 	}
157 157
 
158 158
 	/**
159
-	* Users needed to query before this notification can be displayed
160
-	*
161
-	* @return array Array of user_ids
162
-	*/
159
+	 * Users needed to query before this notification can be displayed
160
+	 *
161
+	 * @return array Array of user_ids
162
+	 */
163 163
 	public function users_to_query()
164 164
 	{
165 165
 		return array();
166 166
 	}
167 167
 
168 168
 	/**
169
-	* Function for preparing the data for insertion in an SQL query
170
-	* (The service handles insertion)
171
-	*
172
-	* @param array $data The data for the updated rules
173
-	* @param array $pre_create_data Data from pre_create_insert_array()
174
-	*
175
-	* @return array Array of data ready to be inserted into the database
176
-	*/
169
+	 * Function for preparing the data for insertion in an SQL query
170
+	 * (The service handles insertion)
171
+	 *
172
+	 * @param array $data The data for the updated rules
173
+	 * @param array $pre_create_data Data from pre_create_insert_array()
174
+	 *
175
+	 * @return array Array of data ready to be inserted into the database
176
+	 */
177 177
 	public function create_insert_array($data, $pre_create_data = array())
178 178
 	{
179 179
 		$this->set_data('image_id', $data['image_id']);
Please login to merge, or discard this patch.
core/notification/events/phpbbgallery_new_image.php 1 patch
Indentation   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -11,20 +11,20 @@  discard block
 block discarded – undo
11 11
 class phpbbgallery_new_image extends \phpbb\notification\type\base
12 12
 {
13 13
 	/**
14
-	* Get notification type name
15
-	*
16
-	* @return string
17
-	*/
14
+	 * Get notification type name
15
+	 *
16
+	 * @return string
17
+	 */
18 18
 	public function get_type()
19 19
 	{
20 20
 		return 'phpbbgallery.core.notification.new_image';
21 21
 	}
22 22
 	/**
23
-	* Notification option data (for outputting to the user)
24
-	*
25
-	* @var bool|array False if the service should use it's default data
26
-	* 					Array of data (including keys 'id', 'lang', and 'group')
27
-	*/
23
+	 * Notification option data (for outputting to the user)
24
+	 *
25
+	 * @var bool|array False if the service should use it's default data
26
+	 * 					Array of data (including keys 'id', 'lang', and 'group')
27
+	 */
28 28
 	public static $notification_option = array(
29 29
 		'lang'	=> 'NOTIFICATION_TYPE_PHPBBGALLERY_NEW_IMAGE',
30 30
 	);
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
 	}
47 47
 
48 48
 	/**
49
-	* Is this type available to the current user (defines whether or not it will be shown in the UCP Edit notification options)
50
-	*
51
-	* @return bool True/False whether or not this is available to the user
52
-	*/
49
+	 * Is this type available to the current user (defines whether or not it will be shown in the UCP Edit notification options)
50
+	 *
51
+	 * @return bool True/False whether or not this is available to the user
52
+	 */
53 53
 	public function is_available()
54 54
 	{
55 55
 		return true;
@@ -93,17 +93,17 @@  discard block
 block discarded – undo
93 93
 	}
94 94
 
95 95
 	/**
96
-	* Get the user's avatar
97
-	*/
96
+	 * Get the user's avatar
97
+	 */
98 98
 	public function get_avatar()
99 99
 	{
100 100
 		return 0;
101 101
 	}
102 102
 	/**
103
-	* Get the HTML formatted title of this notification
104
-	*
105
-	* @return string
106
-	*/
103
+	 * Get the HTML formatted title of this notification
104
+	 *
105
+	 * @return string
106
+	 */
107 107
 	public function get_title()
108 108
 	{
109 109
 		return $this->language->lang('NOTIFICATION_PHPBBGALLERY_NEW_IMAGE', $this->get_data('album_name'));
@@ -121,19 +121,19 @@  discard block
 block discarded – undo
121 121
 	}
122 122
 
123 123
 	/**
124
-	* Get email template
125
-	*
126
-	* @return string|bool
127
-	*/
124
+	 * Get email template
125
+	 *
126
+	 * @return string|bool
127
+	 */
128 128
 	public function get_email_template()
129 129
 	{
130 130
 		return false;
131 131
 	}
132 132
 	/**
133
-	* Get email template variables
134
-	*
135
-	* @return array
136
-	*/
133
+	 * Get email template variables
134
+	 *
135
+	 * @return array
136
+	 */
137 137
 	public function get_email_template_variables()
138 138
 	{
139 139
 		return array();
@@ -160,14 +160,14 @@  discard block
 block discarded – undo
160 160
 	}
161 161
 
162 162
 	/**
163
-	* Function for preparing the data for insertion in an SQL query
164
-	* (The service handles insertion)
165
-	*
166
-	* @param array $data The data for the updated rules
167
-	* @param array $pre_create_data Data from pre_create_insert_array()
168
-	*
169
-	* @return array Array of data ready to be inserted into the database
170
-	*/
163
+	 * Function for preparing the data for insertion in an SQL query
164
+	 * (The service handles insertion)
165
+	 *
166
+	 * @param array $data The data for the updated rules
167
+	 * @param array $pre_create_data Data from pre_create_insert_array()
168
+	 *
169
+	 * @return array Array of data ready to be inserted into the database
170
+	 */
171 171
 	public function create_insert_array($data, $pre_create_data = array())
172 172
 	{
173 173
 		$this->set_data('album_name', $data['album_name']);
Please login to merge, or discard this patch.